199092 2019-06-20 17:03:07 -0700 [LFC][IFC] LineBox::Baseline should have a height getter. 2019-06-21 08:31:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1546749 0 zalan 2019-06-20 17:03:07 -0700 that can replace Line::baselineAlignedContentHeight 1546750 1 webkit-bug-importer 2019-06-20 17:03:48 -0700 <rdar://problem/51966958> 1546752 2 372602 zalan 2019-06-20 17:06:43 -0700 Created attachment 372602 Patch 1546877 3 372602 commit-queue 2019-06-21 08:31:08 -0700 Comment on attachment 372602 Patch Clearing flags on attachment: 372602 Committed r246678: <https://trac.webkit.org/changeset/246678> 1546878 4 commit-queue 2019-06-21 08:31:09 -0700 All reviewed patches have been landed. Closing bug. 372602 2019-06-20 17:06:43 -0700 2019-06-21 08:31:08 -0700 Patch bug-199092-20190620170642.patch text/plain 5039 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTYyNDIwY2JkYzkwZWQx YTdmZWQ5YjA5OTk3MGRhOTM5N2IyYTgxYS4uZDY5ZmEwYTVkMDA4YzlhNzA4NDUzZDAzZDEyMWEx NzVkOTZmZjQxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA2LTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lQm94 OjpCYXNlbGluZSBzaG91bGQgaGF2ZSBhIGhlaWdodCBnZXR0ZXIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTkwOTIKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzUxOTY2OTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBiYXNlbGluZSBoZWlnaHQgZG9lcyBub3QgbmVlZCB0byBiZSBhIGdldHRl ciBvbiB0aGUgTGluZSAobm8gb25lIGNhbGxzIGl0KS4KKworICAgICAgICAqIGxheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpM aW5lOjphZGp1c3RCYXNlbGluZUFuZExpbmVIZWlnaHQpOgorICAgICAgICAqIGxheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGlu ZTo6Y29udGVudExvZ2ljYWxXaWR0aCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6 OkxpbmU6OmJhc2VsaW5lQWxpZ25lZENvbnRlbnRIZWlnaHQgY29uc3QpOiBEZWxldGVkLgorICAg ICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guaDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6TGluZUJveDo6QmFzZWxpbmU6OmhlaWdodCBjb25zdCk6CisKIDIw MTktMDYtMjAgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZD XVtJRkNdIE1ha2UgdGhlIGluaXRpYWwgc3RydXQgZXhwbGljaXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKaW5kZXggYzBj ZDVkYTA2MDAzOGU3NjBmNGY2ZmVhY2NiMWI1OGVjYjVkZGIxMi4uMTM4OWMzNDcxZDdlZjMxZDBk MjUyMzFkNTM3MDNhMzNiODkzNzhmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTMxOSw3ICszMTksNyBAQCB2 b2lkIExpbmU6OmFkanVzdEJhc2VsaW5lQW5kTGluZUhlaWdodChjb25zdCBJbmxpbmVJdGVtJiBp bmxpbmVJdGVtLCBMYXlvdXRVbml0CiAgICAgICAgICAgICBtX2Jhc2VsaW5lLmRlc2NlbnQgPSBz dGQ6Om1heChtX2Jhc2VsaW5lLmRlc2NlbnQsIGhhbGZMZWFkaW5nLmRlc2NlbnQpOwogICAgICAg ICBpZiAoaGFsZkxlYWRpbmcuYXNjZW50ID4gMCkKICAgICAgICAgICAgIG1fYmFzZWxpbmUuYXNj ZW50ID0gc3RkOjptYXgobV9iYXNlbGluZS5hc2NlbnQsIGhhbGZMZWFkaW5nLmFzY2VudCk7Ci0g ICAgICAgIG1fY29udGVudExvZ2ljYWxIZWlnaHQgPSBzdGQ6Om1heChtX2NvbnRlbnRMb2dpY2Fs SGVpZ2h0LCBiYXNlbGluZUFsaWduZWRDb250ZW50SGVpZ2h0KCkpOworICAgICAgICBtX2NvbnRl bnRMb2dpY2FsSGVpZ2h0ID0gc3RkOjptYXgobV9jb250ZW50TG9naWNhbEhlaWdodCwgbV9iYXNl bGluZS5oZWlnaHQoKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgLy8gQXBwbHkgaW5p dGlhbCBzdHJ1dCBpZiBuZWVkZWQuCkBAIC0zMjgsNyArMzI4LDcgQEAgdm9pZCBMaW5lOjphZGp1 c3RCYXNlbGluZUFuZExpbmVIZWlnaHQoY29uc3QgSW5saW5lSXRlbSYgaW5saW5lSXRlbSwgTGF5 b3V0VW5pdAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBtX2Jhc2VsaW5lLmFzY2VudCA9 IHN0ZDo6bWF4KG1faW5pdGlhbFN0cnV0LT5hc2NlbnQsIG1fYmFzZWxpbmUuYXNjZW50KTsKICAg ICAgICAgbV9iYXNlbGluZS5kZXNjZW50ID0gc3RkOjptYXgobV9pbml0aWFsU3RydXQtPmRlc2Nl bnQsIG1fYmFzZWxpbmUuZGVzY2VudCk7Ci0gICAgICAgIG1fY29udGVudExvZ2ljYWxIZWlnaHQg PSBzdGQ6Om1heChtX2NvbnRlbnRMb2dpY2FsSGVpZ2h0LCBiYXNlbGluZUFsaWduZWRDb250ZW50 SGVpZ2h0KCkpOworICAgICAgICBtX2NvbnRlbnRMb2dpY2FsSGVpZ2h0ID0gc3RkOjptYXgobV9j b250ZW50TG9naWNhbEhlaWdodCwgbV9iYXNlbGluZS5oZWlnaHQoKSk7CiAgICAgICAgIG1faW5p dGlhbFN0cnV0ID0geyB9OwogICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtMzQzLDEyICszNDMs MTIgQEAgdm9pZCBMaW5lOjphZGp1c3RCYXNlbGluZUFuZExpbmVIZWlnaHQoY29uc3QgSW5saW5l SXRlbSYgaW5saW5lSXRlbSwgTGF5b3V0VW5pdAogICAgICAgICAgICAgYXV0byBpbmxpbmVCbG9j a0Jhc2VsaW5lID0gZm9ybWF0dGluZ1N0YXRlLmxpbmVCb3hlcygpLmxhc3QoKS5iYXNlbGluZSgp OwogICAgICAgICAgICAgbV9iYXNlbGluZS5kZXNjZW50ID0gc3RkOjptYXgoaW5saW5lQmxvY2tC YXNlbGluZS5kZXNjZW50LCBtX2Jhc2VsaW5lLmRlc2NlbnQpOwogICAgICAgICAgICAgbV9iYXNl bGluZS5hc2NlbnQgPSBzdGQ6Om1heChpbmxpbmVCbG9ja0Jhc2VsaW5lLmFzY2VudCwgbV9iYXNl bGluZS5hc2NlbnQpOwotICAgICAgICAgICAgbV9jb250ZW50TG9naWNhbEhlaWdodCA9IHN0ZDo6 bWF4KHN0ZDo6bWF4KG1fY29udGVudExvZ2ljYWxIZWlnaHQsIHJ1bkhlaWdodCksIGJhc2VsaW5l QWxpZ25lZENvbnRlbnRIZWlnaHQoKSk7CisgICAgICAgICAgICBtX2NvbnRlbnRMb2dpY2FsSGVp Z2h0ID0gc3RkOjptYXgoc3RkOjptYXgobV9jb250ZW50TG9naWNhbEhlaWdodCwgcnVuSGVpZ2h0 KSwgbV9iYXNlbGluZS5oZWlnaHQoKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog ICAgICAgICBtX2Jhc2VsaW5lLmRlc2NlbnQgPSBzdGQ6Om1heDxMYXlvdXRVbml0PigwLCBtX2Jh c2VsaW5lLmRlc2NlbnQpOwogICAgICAgICBtX2Jhc2VsaW5lLmFzY2VudCA9IHN0ZDo6bWF4KHJ1 bkhlaWdodCwgbV9iYXNlbGluZS5hc2NlbnQpOwotICAgICAgICBtX2NvbnRlbnRMb2dpY2FsSGVp Z2h0ID0gc3RkOjptYXgobV9jb250ZW50TG9naWNhbEhlaWdodCwgYmFzZWxpbmVBbGlnbmVkQ29u dGVudEhlaWdodCgpKTsKKyAgICAgICAgbV9jb250ZW50TG9naWNhbEhlaWdodCA9IHN0ZDo6bWF4 KG1fY29udGVudExvZ2ljYWxIZWlnaHQsIG1fYmFzZWxpbmUuaGVpZ2h0KCkpOwogICAgICAgICBi cmVhazsKICAgICBjYXNlIFZlcnRpY2FsQWxpZ246OlRvcDoKICAgICAgICAgLy8gVG9wIGFsaWdu IGNvbnRlbnQgbmV2ZXIgY2hhbmdlcyB0aGUgYmFzZWxpbmUgb2Zmc2V0LCBpdCBvbmx5IHB1c2hl cyB0aGUgYm90dG9tIG9mIHRoZSBsaW5lIGZ1cnRoZXIgZG93bi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaAppbmRleCAwOGY5MDhh MjE0NGRiZmU2MDNhZTQ5MjAzZGRmMTg0NWE1NzIzYzU4Li4yYTVlYjBkMzA3OTE5MjM0ZTE3NzQ2 YTZkOGIwZjUzZWI2YmMzMGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5oCkBAIC0xMTgsNyArMTE4LDYgQEAgcHJpdmF0ZToK ICAgICBMYXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnRM b2dpY2FsSGVpZ2h0OyB9CiAKICAgICBMYXlvdXRVbml0IGNvbnRlbnRMb2dpY2FsV2lkdGgoKSBj b25zdCB7IHJldHVybiBtX2NvbnRlbnRMb2dpY2FsV2lkdGg7IH0KLSAgICBMYXlvdXRVbml0IGJh c2VsaW5lQWxpZ25lZENvbnRlbnRIZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2Jhc2VsaW5lLmFz Y2VudCArIG1fYmFzZWxpbmUuZGVzY2VudDsgfQogICAgIExheW91dFVuaXQgYmFzZWxpbmVPZmZz ZXQoKSBjb25zdCB7IHJldHVybiBtX2Jhc2VsaW5lLmFzY2VudCArIG1fYmFzZWxpbmVUb3A7IH0K IAogICAgIHZvaWQgYXBwZW5kTm9uQnJlYWthYmxlU3BhY2UoY29uc3QgSW5saW5lSXRlbSYsIGNv bnN0IERpc3BsYXk6OlJlY3QmIGxvZ2ljYWxSZWN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guaCBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guaAppbmRleCBlYzM0MDMx NDNiMGU2YjIyZDQxZjcwYmJkMjY2YWYxMDhiYzEzYzYzLi45NmE3NGY1M2NjMTY4NTE1NTE4ZTAw MzEzMDQ3YzY2NjBmMGYyNzc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJveC5oCkBAIC0zNSw2ICszNSw4IEBAIG5hbWVz cGFjZSBMYXlvdXQgewogY2xhc3MgTGluZUJveCB7CiBwdWJsaWM6CiAgICAgc3RydWN0IEJhc2Vs aW5lIHsKKyAgICAgICAgTGF5b3V0VW5pdCBoZWlnaHQoKSBjb25zdCB7IHJldHVybiBhc2NlbnQg KyBkZXNjZW50OyB9CisKICAgICAgICAgTGF5b3V0VW5pdCBhc2NlbnQ7CiAgICAgICAgIExheW91 dFVuaXQgZGVzY2VudDsKICAgICB9Owo=