199090 2019-06-20 16:27:02 -0700 Web Inspector: Styles: unbalanced quotes and parenthesis aren't displayed as property closed after editing values 2019-06-22 15:32:56 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1546736 0 nvasilyev 2019-06-20 16:27:02 -0700 I added auto-closing unbalanced quotes and parenthesis in Bug 182523, but I didn't realize there're two code paths to finish value edit. Committing the value by pressing Enter or Tab works as expected, but it doesn't when caused by a blur event (by clicking somewhere else in Web Inspector, for instance). There should be only one code-path. Steps: 1. Open https://webkit.org 2. Inspect <body> 3. Add `font-family: "helv` CSS property to the Style Attribute rule. 4. Click on the white space somewhere in Web Inspector (to trigger blur event on the CSS value field). Actual: font-family: "helv}; ^ Incorrectly shown } character Expected: font-family: "helv" ^ Inserted quote character Notes: After focusing on the value ("helv}) again, it replaces it the correct value ("helv"). 1546739 1 webkit-bug-importer 2019-06-20 16:28:27 -0700 <rdar://problem/51965431> 1547048 2 372663 nvasilyev 2019-06-21 18:19:15 -0700 Created attachment 372663 Patch Here's a one-line fix. I still plan to refactor spreadsheetTextFieldDidCommit and spreadsheetTextFieldDidBlur, but since it's only tangentially related to the bug, I don't plan to do it in this patch. 1547105 3 mattbaker 2019-06-22 10:35:28 -0700 I also noticed that repeating the steps above but with Add `font-family: "Helv` (capitalized) will cause the value to autocomplete to `"Helvetica}`. 1547106 4 372663 mattbaker 2019-06-22 10:35:52 -0700 Comment on attachment 372663 Patch r=me 1547111 5 372663 commit-queue 2019-06-22 11:05:34 -0700 Comment on attachment 372663 Patch Clearing flags on attachment: 372663 Committed r246712: <https://trac.webkit.org/changeset/246712> 1547112 6 commit-queue 2019-06-22 11:05:36 -0700 All reviewed patches have been landed. Closing bug. 1547136 7 nvasilyev 2019-06-22 15:32:56 -0700 (In reply to Matt Baker from comment #3) > I also noticed that repeating the steps above but with Add `font-family: > "Helv` (capitalized) will cause the value to autocomplete to `"Helvetica}`. O_o That's not good. Filled Bug 199130 - Web Inspector: Styles: curly brace incorrectly added after completed value inside unclosed quote 372663 2019-06-21 18:19:15 -0700 2019-06-22 11:05:34 -0700 Patch patch.txt text/plain 1728 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJmNjlkODA5NmRiLi5jYzc1MjkwNjBlMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMjEgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3R5bGVzOiB1bmJhbGFuY2VkIHF1b3RlcyBhbmQgcGFyZW50aGVzaXMgYXJlbid0IGRpc3Bs YXllZCBhcyBwcm9wZXJ0eSBjbG9zZWQgYWZ0ZXIgZWRpdGluZyB2YWx1ZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5OTA5MAorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNTE5NjU0MzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9w ZXJ0eS5qczoKKyAgICAgICAgKFdJLlNwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5wcm90b3R5cGUu c3ByZWFkc2hlZXRUZXh0RmllbGREaWRCbHVyKToKKyAgICAgICAgVW5iYWxhbmNlZCBxdW90ZXMg YW5kIHBhcmVudGhlc2lzIGFyZSBmaXhlZCBpbnNpZGUgb2YgQ1NTUHJvcGVydHkncyByYXdWYWx1 ZSBzZXR0ZXIuCisgICAgICAgIFJlbmRlciB0aGUgdmFsdWUgZnJvbSB0aGUgbW9kZWwsIG5vdCB0 aGUgdmlldy4KKwogMjAxOS0wNi0yMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIHVudXNlZCBEYXRhR3JpZCBzdHlsZSAu Zm9yY2UtZm9jdXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcwppbmRl eCA2Y2JjNjI5YjI2NC4uN2Y1OTMyMzFhMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0U3R5bGVQcm9wZXJ0eS5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVldFN0 eWxlUHJvcGVydHkuanMKQEAgLTQwMiw3ICs0MDIsNyBAQCBXSS5TcHJlYWRzaGVldFN0eWxlUHJv cGVydHkgPSBjbGFzcyBTcHJlYWRzaGVldFN0eWxlUHJvcGVydHkgZXh0ZW5kcyBXSS5PYmplY3QK ICAgICAgICAgfQogCiAgICAgICAgIGlmICh0ZXh0RmllbGQgPT09IHRoaXMuX3ZhbHVlVGV4dEZp ZWxkKQotICAgICAgICAgICAgdGhpcy5fcmVuZGVyVmFsdWUodGhpcy5fdmFsdWVFbGVtZW50LnRl eHRDb250ZW50KTsKKyAgICAgICAgICAgIHRoaXMuX3JlbmRlclZhbHVlKHRoaXMuX3Byb3BlcnR5 LnJhd1ZhbHVlKTsKIAogICAgICAgICBpZiAodHlwZW9mIHRoaXMuX2RlbGVnYXRlLnNwcmVhZHNo ZWV0U3R5bGVQcm9wZXJ0eUZvY3VzTW92ZWQgPT09ICJmdW5jdGlvbiIpCiAgICAgICAgICAgICB0 aGlzLl9kZWxlZ2F0ZS5zcHJlYWRzaGVldFN0eWxlUHJvcGVydHlGb2N1c01vdmVkKHRoaXMsIHtk aXJlY3Rpb246IG51bGx9KTsK