199073 2019-06-20 11:16:33 -0700 [ews-build] Add unit tests for AnalyzeCompileWebKitResults 2019-06-20 13:27:29 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ews-watchlist jbedard webkit-bug-importer oldest_to_newest 1546585 0 aakash_jain 2019-06-20 11:16:33 -0700 We should add unit tests for AnalyzeCompileWebKitResults build step in ews-build. 1546586 1 372573 aakash_jain 2019-06-20 11:18:56 -0700 Created attachment 372573 Patch 1546587 2 ews-watchlist 2019-06-20 11:20:45 -0700 Attachment 372573 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:569: [TestAnalyzeCompileWebKitResults.test_patch_with_build_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:578: [TestAnalyzeCompileWebKitResults.test_patch_with_ToT_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1546634 3 372573 commit-queue 2019-06-20 13:24:36 -0700 Comment on attachment 372573 Patch Clearing flags on attachment: 372573 Committed r246650: <https://trac.webkit.org/changeset/246650> 1546635 4 commit-queue 2019-06-20 13:24:37 -0700 All reviewed patches have been landed. Closing bug. 1546636 5 webkit-bug-importer 2019-06-20 13:27:29 -0700 <rdar://problem/51957288> 372573 2019-06-20 11:18:56 -0700 2019-06-20 13:24:36 -0700 Patch bug-199073-20190620141855.patch text/plain 3350 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjY0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA2LTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdW5pdCB0ZXN0cyBmb3IgQW5hbHl6ZUNvbXBp bGVXZWJLaXRSZXN1bHRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTkwNzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weTog QWRkZWQgdW5pdC10ZXN0cyBmb3IgQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzLgorCiAyMDE5 LTA2LTIwICBBbGV4YW5kZXIgTWlraGF5bGVua28gIDxleGFsbTc2NTlAZ21haWwuY29tPgogCiAg ICAgICAgIFtHVEtdIEVuYWJsZSBuYXZpZ2F0aW9uIHN3aXBlIGxheW91dCB0ZXN0cwpJbmRleDog VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVz dC5weQkocmV2aXNpb24gMjQ2NjQyKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNCw3ICszNCw3IEBAIGZy b20gdHdpc3RlZC5pbnRlcm5ldCBpbXBvcnQgZXJyb3IsIHJlYWMKIGZyb20gdHdpc3RlZC5weXRo b24gaW1wb3J0IGZhaWx1cmUsIGxvZwogZnJvbSB0d2lzdGVkLnRyaWFsIGltcG9ydCB1bml0dGVz dAogCi1mcm9tIHN0ZXBzIGltcG9ydCAoQW5hbHl6ZUFQSVRlc3RzUmVzdWx0cywgQXBwbHlQYXRj aCwgQXJjaGl2ZUJ1aWx0UHJvZHVjdCwgQXJjaGl2ZVRlc3RSZXN1bHRzLAorZnJvbSBzdGVwcyBp bXBvcnQgKEFuYWx5emVBUElUZXN0c1Jlc3VsdHMsIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0 cywgQXBwbHlQYXRjaCwgQXJjaGl2ZUJ1aWx0UHJvZHVjdCwgQXJjaGl2ZVRlc3RSZXN1bHRzLAog ICAgICAgICAgICAgICAgICAgIENoZWNrT3V0U291cmNlLCBDaGVja1BhdGNoUmVsZXZhbmNlLCBD aGVja1N0eWxlLCBDbGVhbkJ1aWxkLCBDbGVhbldvcmtpbmdEaXJlY3RvcnksCiAgICAgICAgICAg ICAgICAgICAgQ29tcGlsZUpTQ09ubHksIENvbXBpbGVKU0NPbmx5VG9ULCBDb21waWxlV2ViS2l0 LCBDb21waWxlV2ViS2l0VG9ULCBDb25maWd1cmVCdWlsZCwKICAgICAgICAgICAgICAgICAgICBE b3dubG9hZEJ1aWx0UHJvZHVjdCwgRXh0cmFjdEJ1aWx0UHJvZHVjdCwgRXh0cmFjdFRlc3RSZXN1 bHRzLCBLaWxsT2xkUHJvY2Vzc2VzLApAQCAtNDgsNiArNDgsMTMgQEAgZnJvbSBidWlsZGJvdC50 ZXN0LmZha2UuZmFrZWJ1aWxkIGltcG9ydAogRmFrZUJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50 U3RlcCA9IGxhbWJkYSBGYWtlQnVpbGQsIHN0ZXBfZmFjdG9yaWVzOiBOb25lCiAKIAorZGVmIG1v Y2tfc3RlcChzdGVwLCBsb2dzPScnLCByZXN1bHRzPVNVQ0NFU1MsIHN0b3BwZWQ9RmFsc2UsIHBy b3BlcnRpZXM9Tm9uZSk6CisgICAgc3RlcC5sb2dzID0gbG9ncworICAgIHN0ZXAucmVzdWx0cyA9 IHJlc3VsdHMKKyAgICBzdGVwLnN0b3BwZWQgPSBzdG9wcGVkCisgICAgcmV0dXJuIHN0ZXAKKwor CiBjbGFzcyBFeHBlY3RNYXN0ZXJTaGVsbENvbW1hbmQob2JqZWN0KToKICAgICBkZWYgX19pbml0 X18oc2VsZiwgY29tbWFuZCwgd29ya2Rpcj1Ob25lLCBlbnY9Tm9uZSwgdXNlUFRZPTApOgogICAg ICAgICBzZWxmLmFyZ3MgPSBjb21tYW5kCkBAIC01NDUsNiArNTUyLDMzIEBAIGNsYXNzIFRlc3RD b21waWxlV2ViS2l0VG9UKEJ1aWxkU3RlcE1peGkKICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3Rl cCgpCiAKIAorY2xhc3MgVGVzdEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cyhCdWlsZFN0ZXBN aXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRlZiBzZXRVcChzZWxmKToK KyAgICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUKKyAgICAgICAgcmV0dXJuIHNlbGYuc2V0 VXBCdWlsZFN0ZXAoKQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgorICAgICAgICByZXR1cm4g c2VsZi50ZWFyRG93bkJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVzdF9wYXRjaF93aXRoX2J1aWxk X2ZhaWx1cmUoc2VsZik6CisgICAgICAgIHByZXZpb3VzX3N0ZXBzID0gWworICAgICAgICAgICAg bW9ja19zdGVwKENvbXBpbGVXZWJLaXQoKSwgcmVzdWx0cz1GQUlMVVJFKSwKKyAgICAgICAgICAg IG1vY2tfc3RlcChDb21waWxlV2ViS2l0VG9UKCksIHJlc3VsdHM9U1VDQ0VTUyksCisgICAgICAg IF0KKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKCks IHByZXZpb3VzX3N0ZXBzPXByZXZpb3VzX3N0ZXBzKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNv bWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nUGF0Y2ggZG9lcyBub3QgYnVpbGQgKGZh aWx1cmUpJykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKyAgICBkZWYgdGVzdF9w YXRjaF93aXRoX1RvVF9mYWlsdXJlKHNlbGYpOgorICAgICAgICBwcmV2aW91c19zdGVwcyA9IFsK KyAgICAgICAgICAgIG1vY2tfc3RlcChDb21waWxlV2ViS2l0KCksIHJlc3VsdHM9RkFJTFVSRSks CisgICAgICAgICAgICBtb2NrX3N0ZXAoQ29tcGlsZVdlYktpdFRvVCgpLCByZXN1bHRzPUZBSUxV UkUpLAorICAgICAgICBdCisgICAgICAgIHNlbGYuc2V0dXBTdGVwKEFuYWx5emVDb21waWxlV2Vi S2l0UmVzdWx0cygpLCBwcmV2aW91c19zdGVwcz1wcmV2aW91c19zdGVwcykKKyAgICAgICAgc2Vs Zi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J1VuYWJsZSB0byBi dWlsZCBXZWJLaXQgd2l0aG91dCBwYXRjaCwgcmV0cnlpbmcgYnVpbGQgKGZhaWx1cmUpJykKKyAg ICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKwogY2xhc3MgVGVzdENvbXBpbGVKU0NPbmx5 KEJ1aWxkU3RlcE1peGluQWRkaXRpb25zLCB1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHNl dFVwKHNlbGYpOgogICAgICAgICBzZWxmLmxvbmdNZXNzYWdlID0gVHJ1ZQo=