198955 2019-06-17 22:26:33 -0700 Web Inspector: Canvas: imported recordings aren't selectable from the overview if there are no canvases in the page 2019-06-18 12:14:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 173807 175485 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1545557 0 hi 2019-06-17 22:26:33 -0700 # STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/demo/WebKit/canvas.html> 2. record any of the <canvas> on the page 3. export the recording 4. navigate to a different page 5. close Web Inspector 6. open Web Inspector 7. import the recording from 3 8. click the "Overview" in the path => the Canvas tab shows "No Canvas Contexts" => there's no way to re-select the imported recording 1545558 1 372327 hi 2019-06-17 22:32:11 -0700 Created attachment 372327 Patch 1545692 2 372327 joepeck 2019-06-18 11:40:13 -0700 Comment on attachment 372327 Patch r=me 1545711 3 372327 commit-queue 2019-06-18 12:09:43 -0700 Comment on attachment 372327 Patch Clearing flags on attachment: 372327 Committed r246555: <https://trac.webkit.org/changeset/246555> 1545712 4 commit-queue 2019-06-18 12:09:44 -0700 All reviewed patches have been landed. Closing bug. 1545720 5 webkit-bug-importer 2019-06-18 12:14:10 -0700 <rdar://problem/51860147> 372327 2019-06-17 22:32:11 -0700 2019-06-18 12:09:43 -0700 Patch bug-198955-20190617223211.patch text/plain 5561 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4YTAwODdiMDkwYjg0YzI3M2MyMTVhNmVkMDE4 ZTM2MGJhMDk5YTcuLjYzOTgyNjQ2YjU0Yzc1MmU5MjE4N2JmNzliNWU3N2E3MjVhNDA1NTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE5LTA2LTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IGltcG9ydGVkIHJlY29yZGluZ3MgYXJlbid0IHNlbGVjdGFibGUgZnJvbSB0aGUgb3Zl cnZpZXcgaWYgdGhlcmUgYXJlIG5vIGNhbnZhc2VzIGluIHRoZSBwYWdlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg5NTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv Q2FudmFzT3ZlcnZpZXdDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkNhbnZhc092ZXJ2aWV3 Q29udGVudFZpZXcucHJvdG90eXBlLl9hZGRTYXZlZFJlY29yZGluZyk6CisgICAgICAgIEhpZGUg dGhlIGNvbnRlbnQgcGxhY2Vob2xkZXIgd2hlbiBhIHJlY29yZGluZyBpcyBpbXBvcnRlZC4gSXQg d29uJ3QgYmUgc2hvd24gYWdhaW4gYmVjYXVzZQorICAgICAgICB0aGUgYHN1YnZpZXdzYCBsaXN0 IHdpbGwgbmV2ZXIgYmUgZW1wdHksIGFzIHRoZXJlJ3Mgbm8gd2F5IHRvIHJlbW92ZSBhbiBpbXBv cnRlZCByZWNvcmRpbmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbGxlY3Rp b25Db250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkNvbGxlY3Rpb25Db250ZW50Vmlldy5wcm90 b3R5cGUuYWRkQ29udGVudFZpZXdGb3JJdGVtKToKKyAgICAgICAgKFdJLkNvbGxlY3Rpb25Db250 ZW50Vmlldy5wcm90b3R5cGUucmVtb3ZlQ29udGVudFZpZXdGb3JJdGVtKToKKyAgICAgICAgKFdJ LkNvbGxlY3Rpb25Db250ZW50Vmlldy5wcm90b3R5cGUuc2hvd0NvbnRlbnRQbGFjZWhvbGRlcik6 IEFkZGVkLgorICAgICAgICAoV0kuQ29sbGVjdGlvbkNvbnRlbnRWaWV3LnByb3RvdHlwZS5oaWRl Q29udGVudFBsYWNlaG9sZGVyKTogQWRkZWQuCisgICAgICAgIChXSS5Db2xsZWN0aW9uQ29udGVu dFZpZXcucHJvdG90eXBlLmluaXRpYWxMYXlvdXQpOgorICAgICAgICAoV0kuQ29sbGVjdGlvbkNv bnRlbnRWaWV3LnByb3RvdHlwZS5fc2VsZWN0SXRlbSk6CisgICAgICAgIChXSS5Db2xsZWN0aW9u Q29udGVudFZpZXcucHJvdG90eXBlLl9zaG93Q29udGVudFBsYWNlaG9sZGVyKTogRGVsZXRlZC4K KyAgICAgICAgKFdJLkNvbGxlY3Rpb25Db250ZW50Vmlldy5wcm90b3R5cGUuX2hpZGVDb250ZW50 UGxhY2Vob2xkZXIpOiBEZWxldGVkLgorICAgICAgICBNYWtlIGBzaG93Q29udGVudFBsYWNlaG9s ZGVyYC9gaGlkZUNvbnRlbnRQbGFjZWhvbGRlcmAgcHJvdGVjdGVkIGZvciBhbnkgc3ViY2xhc3Nl cyB0byBjYWxsLgorCiAyMDE5LTA2LTE3ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBFbGVtZW50czogcmVtb3ZlIGVsbGlwc2VzIGZy b20gIkJyZWFrIG9uIiBjb250ZXh0IG1lbnUgaXRlbSB0aXRsZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzT3ZlcnZpZXdDb250ZW50 Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZh c092ZXJ2aWV3Q29udGVudFZpZXcuanMKaW5kZXggZGVkM2NiOGMxYmUwMGRiYzVlM2U1YmU4M2Q2 YTBkZTFjZTVmMGZkYi4uMmVmNjRmMDM1ZDVlYzg4MWFjMDMzODI5MzcxMDEyN2E1ZTZhNGQ2ZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2Fu dmFzT3ZlcnZpZXdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9DYW52YXNPdmVydmlld0NvbnRlbnRWaWV3LmpzCkBAIC0yOTAsNiAr MjkwLDggQEAgV0kuQ2FudmFzT3ZlcnZpZXdDb250ZW50VmlldyA9IGNsYXNzIENhbnZhc092ZXJ2 aWV3Q29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db2xsZWMKIAogICAgICAgICAgICAgbGV0IGhlYWRl ciA9IHRoaXMuX3NhdmVkUmVjb3JkaW5nc0NvbnRlbnRWaWV3LmVsZW1lbnQuYXBwZW5kQ2hpbGQo ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaGVhZGVyIikpOwogICAgICAgICAgICAgaGVhZGVyLnRl eHRDb250ZW50ID0gV0kuVUlTdHJpbmcoIlNhdmVkIFJlY29yZGluZ3MiKTsKKworICAgICAgICAg ICAgdGhpcy5oaWRlQ29udGVudFBsYWNlaG9sZGVyKCk7CiAgICAgICAgIH0KIAogICAgICAgICBp ZiAoIXRoaXMuX3NhdmVkUmVjb3JkaW5nc1RyZWVPdXRsaW5lKSB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2xsZWN0aW9uQ29udGVudFZp ZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2xsZWN0 aW9uQ29udGVudFZpZXcuanMKaW5kZXggMTEwZGY3MDc0YjE2YjA2OTA2NDA4YzMyMGRiZjQ4MzU2 MjUyYTY2MC4uYjc0NGMxZDhlNjJlNmE4Y2Y5MzI2ZTE5NTk4YzM2OGY4NjdhOTk3ZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29sbGVjdGlv bkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbGxlY3Rpb25Db250ZW50Vmlldy5qcwpAQCAtMTA5LDcgKzEwOSw3IEBAIFdJLkNv bGxlY3Rpb25Db250ZW50VmlldyA9IGNsYXNzIENvbGxlY3Rpb25Db250ZW50VmlldyBleHRlbmRz IFdJLkNvbnRlbnRWaWV3CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAg ICB0aGlzLl9oaWRlQ29udGVudFBsYWNlaG9sZGVyKCk7CisgICAgICAgIHRoaXMuaGlkZUNvbnRl bnRQbGFjZWhvbGRlcigpOwogCiAgICAgICAgIGxldCBjb250ZW50VmlldyA9IG5ldyB0aGlzLl9j b250ZW50Vmlld0NvbnN0cnVjdG9yKGl0ZW0pOwogICAgICAgICBjb25zb2xlLmFzc2VydChjb250 ZW50VmlldyBpbnN0YW5jZW9mIFdJLkNvbnRlbnRWaWV3KTsKQEAgLTE3MSw3ICsxNzEsNyBAQCBX SS5Db2xsZWN0aW9uQ29udGVudFZpZXcgPSBjbGFzcyBDb2xsZWN0aW9uQ29udGVudFZpZXcgZXh0 ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAgICB9CiAKICAgICAgICAgaWYgKCF0aGlzLnN1YnZp ZXdzLmxlbmd0aCkKLSAgICAgICAgICAgIHRoaXMuX3Nob3dDb250ZW50UGxhY2Vob2xkZXIoKTsK KyAgICAgICAgICAgIHRoaXMuc2hvd0NvbnRlbnRQbGFjZWhvbGRlcigpOwogICAgIH0KIAogICAg IGNvbnRlbnRWaWV3QWRkZWQoY29udGVudFZpZXcpCkBAIC0xODQsMTAgKzE4NCwyOSBAQCBXSS5D b2xsZWN0aW9uQ29udGVudFZpZXcgPSBjbGFzcyBDb2xsZWN0aW9uQ29udGVudFZpZXcgZXh0ZW5k cyBXSS5Db250ZW50VmlldwogICAgICAgICAvLyBJbXBsZW1lbnRlZCBieSBzdWJjbGFzc2VzLgog ICAgIH0KIAorICAgIHNob3dDb250ZW50UGxhY2Vob2xkZXIoKQorICAgIHsKKyAgICAgICAgaWYg KCF0aGlzLl9jb250ZW50UGxhY2Vob2xkZXJFbGVtZW50KSB7CisgICAgICAgICAgICBpZiAodHlw ZW9mIHRoaXMuX2NvbnRlbnRQbGFjZWhvbGRlciA9PT0gInN0cmluZyIpCisgICAgICAgICAgICAg ICAgdGhpcy5fY29udGVudFBsYWNlaG9sZGVyRWxlbWVudCA9IFdJLmNyZWF0ZU1lc3NhZ2VUZXh0 Vmlldyh0aGlzLl9jb250ZW50UGxhY2Vob2xkZXIpOworICAgICAgICAgICAgZWxzZSBpZiAodGhp cy5fY29udGVudFBsYWNlaG9sZGVyIGluc3RhbmNlb2YgSFRNTEVsZW1lbnQpCisgICAgICAgICAg ICAgICAgdGhpcy5fY29udGVudFBsYWNlaG9sZGVyRWxlbWVudCA9IHRoaXMuX2NvbnRlbnRQbGFj ZWhvbGRlcjsKKyAgICAgICAgfQorCisgICAgICAgIGlmICghdGhpcy5fY29udGVudFBsYWNlaG9s ZGVyRWxlbWVudC5wYXJlbnROb2RlKQorICAgICAgICAgICAgdGhpcy5lbGVtZW50LmFwcGVuZENo aWxkKHRoaXMuX2NvbnRlbnRQbGFjZWhvbGRlckVsZW1lbnQpOworICAgIH0KKworICAgIGhpZGVD b250ZW50UGxhY2Vob2xkZXIoKQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2NvbnRlbnRQbGFj ZWhvbGRlckVsZW1lbnQpCisgICAgICAgICAgICB0aGlzLl9jb250ZW50UGxhY2Vob2xkZXJFbGVt ZW50LnJlbW92ZSgpOworICAgIH0KKwogICAgIGluaXRpYWxMYXlvdXQoKQogICAgIHsKICAgICAg ICAgaWYgKCF0aGlzLnJlcHJlc2VudGVkT2JqZWN0LnNpemUgfHwgIXRoaXMuX2NvbnRlbnRWaWV3 Q29uc3RydWN0b3IpIHsKLSAgICAgICAgICAgIHRoaXMuX3Nob3dDb250ZW50UGxhY2Vob2xkZXIo KTsKKyAgICAgICAgICAgIHRoaXMuc2hvd0NvbnRlbnRQbGFjZWhvbGRlcigpOwogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfQpAQCAtMjY4LDIzICsyODcsNCBAQCBXSS5Db2xs ZWN0aW9uQ29udGVudFZpZXcgPSBjbGFzcyBDb2xsZWN0aW9uQ29udGVudFZpZXcgZXh0ZW5kcyBX SS5Db250ZW50VmlldwogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJ LkNvbnRlbnRWaWV3LkV2ZW50LlN1cHBsZW1lbnRhbFJlcHJlc2VudGVkT2JqZWN0c0RpZENoYW5n ZSk7CiAgICAgfQotCi0gICAgX3Nob3dDb250ZW50UGxhY2Vob2xkZXIoKQotICAgIHsKLSAgICAg ICAgaWYgKCF0aGlzLl9jb250ZW50UGxhY2Vob2xkZXJFbGVtZW50KSB7Ci0gICAgICAgICAgICBp ZiAodHlwZW9mIHRoaXMuX2NvbnRlbnRQbGFjZWhvbGRlciA9PT0gInN0cmluZyIpCi0gICAgICAg ICAgICAgICAgdGhpcy5fY29udGVudFBsYWNlaG9sZGVyRWxlbWVudCA9IFdJLmNyZWF0ZU1lc3Nh Z2VUZXh0Vmlldyh0aGlzLl9jb250ZW50UGxhY2Vob2xkZXIpOwotICAgICAgICAgICAgZWxzZSBp ZiAodGhpcy5fY29udGVudFBsYWNlaG9sZGVyIGluc3RhbmNlb2YgSFRNTEVsZW1lbnQpCi0gICAg ICAgICAgICAgICAgdGhpcy5fY29udGVudFBsYWNlaG9sZGVyRWxlbWVudCA9IHRoaXMuX2NvbnRl bnRQbGFjZWhvbGRlcjsKLSAgICAgICAgfQotCi0gICAgICAgIGlmICghdGhpcy5fY29udGVudFBs YWNlaG9sZGVyRWxlbWVudC5wYXJlbnROb2RlKQotICAgICAgICAgICAgdGhpcy5lbGVtZW50LmFw cGVuZENoaWxkKHRoaXMuX2NvbnRlbnRQbGFjZWhvbGRlckVsZW1lbnQpOwotICAgIH0KLQotICAg IF9oaWRlQ29udGVudFBsYWNlaG9sZGVyKCkKLSAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9jb250 ZW50UGxhY2Vob2xkZXJFbGVtZW50KQotICAgICAgICAgICAgdGhpcy5fY29udGVudFBsYWNlaG9s ZGVyRWxlbWVudC5yZW1vdmUoKTsKLSAgICB9CiB9Owo=