198953 2019-06-17 22:04:53 -0700 Web Inspector: REGRESSION: Canvas: cannot select saved recordings 2019-06-18 12:14:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 173807 175485 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1545553 0 hi 2019-06-17 22:04:53 -0700 # STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/demo/WebKit/canvas.html> 2. record any of the <canvas> on the page (the larger the recording, the better) 3. collapse the navigation sidebar in the recording/replay view 4. export the recording 5. close Web Inspector 6. open Web Inspector 7. import the recording from 4 8. go to the Overview 9. click on the imported recording from 4 in the "Saved Recordings" card => nothing happens :( 1545554 1 372325 hi 2019-06-17 22:10:30 -0700 Created attachment 372325 Patch 1545695 2 372325 joepeck 2019-06-18 11:42:58 -0700 Comment on attachment 372325 Patch Seems fine. r=me 1545718 3 372325 commit-queue 2019-06-18 12:13:46 -0700 Comment on attachment 372325 Patch Clearing flags on attachment: 372325 Committed r246557: <https://trac.webkit.org/changeset/246557> 1545719 4 commit-queue 2019-06-18 12:13:47 -0700 All reviewed patches have been landed. Closing bug. 1545721 5 webkit-bug-importer 2019-06-18 12:14:16 -0700 <rdar://problem/51860151> 372325 2019-06-17 22:10:30 -0700 2019-06-18 12:13:46 -0700 Patch bug-198953-20190617221030.patch text/plain 2618 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4YTAwODdiMDkwYjg0YzI3M2MyMTVhNmVkMDE4 ZTM2MGJhMDk5YTcuLjI3OGNjMmYxNzIxNTlmMTY1MzU2ODgyYTgwNWI2NDAzZGRhMTE3MWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBDYW52YXM6IGNhbm5vdCBzZWxlY3Qgc2F2ZWQgcmVjb3JkaW5ncworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4OTUzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1RyZWVFbGVtZW50LmpzOgorICAgICAgICAoV0kuVHJlZUVsZW1lbnQudHJlZUVsZW1l bnRUb2dnbGVkKToKKyAgICAgICAgRG9uJ3QgZWFybHkgcmV0dXJuIGlmIHRoZSBgVHJlZUVsZW1l bnRgIGlzbid0IGBzZWxlY3RhYmxlYCBhcyB0aGUgb3duZXIgYFRyZWVPdXRsaW5lYCBtYXkKKyAg ICAgICAgd2FudCB0byBkaXNwYXRjaCBhbiBldmVudCB0aGF0IGl0IHdhcyBjbGlja2VkLgorCiAy MDE5LTA2LTE3ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBFbGVtZW50czogcmVtb3ZlIGVsbGlwc2VzIGZyb20gIkJyZWFrIG9uIiBj b250ZXh0IG1lbnUgaXRlbSB0aXRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcwppbmRleCBmNmFlMDQ2OWRjMGIx OTNkYWE5YjIyY2VlNzVmNWVmYzMzNzc3MTZiLi44NzI0YmQ0YWMzNDc4NDIyYmFiM2ViNDkzYTkx MDI3YTQ5NTExZmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9UcmVlRWxlbWVudC5qcwpAQCAtMzA4LDIyICszMDgsMjAgQEAgV0ku VHJlZUVsZW1lbnQgPSBjbGFzcyBUcmVlRWxlbWVudCBleHRlbmRzIFdJLk9iamVjdAogICAgICAg ICAgICAgcmV0dXJuOwogCiAgICAgICAgIGxldCB0b2dnbGVPbkNsaWNrID0gdHJlZUVsZW1lbnQu dG9nZ2xlT25DbGljayAmJiAhdHJlZUVsZW1lbnQuc2VsZWN0YWJsZTsKLSAgICAgICAgbGV0IGlz SW5UcmlhbmdsZSA9IHRyZWVFbGVtZW50LmlzRXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUo ZXZlbnQpOwotICAgICAgICBpZiAoIXRvZ2dsZU9uQ2xpY2sgJiYgIWlzSW5UcmlhbmdsZSkKLSAg ICAgICAgICAgIHJldHVybjsKLQotICAgICAgICBpZiAodHJlZUVsZW1lbnQuZXhwYW5kZWQpIHsK LSAgICAgICAgICAgIGlmIChldmVudC5hbHRLZXkpCi0gICAgICAgICAgICAgICAgdHJlZUVsZW1l bnQuY29sbGFwc2VSZWN1cnNpdmVseSgpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAg ICAgIHRyZWVFbGVtZW50LmNvbGxhcHNlKCk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAg ICBpZiAoZXZlbnQuYWx0S2V5KQotICAgICAgICAgICAgICAgIHRyZWVFbGVtZW50LmV4cGFuZFJl Y3Vyc2l2ZWx5KCk7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgdHJlZUVsZW1l bnQuZXhwYW5kKCk7CisgICAgICAgIGlmICh0b2dnbGVPbkNsaWNrIHx8IHRyZWVFbGVtZW50Lmlz RXZlbnRXaXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUoZXZlbnQpKSB7CisgICAgICAgICAgICBpZiAo dHJlZUVsZW1lbnQuZXhwYW5kZWQpIHsKKyAgICAgICAgICAgICAgICBpZiAoZXZlbnQuYWx0S2V5 KQorICAgICAgICAgICAgICAgICAgICB0cmVlRWxlbWVudC5jb2xsYXBzZVJlY3Vyc2l2ZWx5KCk7 CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICB0cmVlRWxlbWVudC5j b2xsYXBzZSgpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBpZiAoZXZl bnQuYWx0S2V5KQorICAgICAgICAgICAgICAgICAgICB0cmVlRWxlbWVudC5leHBhbmRSZWN1cnNp dmVseSgpOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgdHJlZUVs ZW1lbnQuZXhwYW5kKCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBldmVudC5zdG9wUHJv cGFnYXRpb24oKTsKICAgICAgICAgfQotICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24oKTsK IAogICAgICAgICBpZiAoIXRyZWVFbGVtZW50LnRyZWVPdXRsaW5lLnNlbGVjdGFibGUpCiAgICAg ICAgICAgICB0cmVlRWxlbWVudC50cmVlT3V0bGluZS5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMo V0kuVHJlZU91dGxpbmUuRXZlbnQuRWxlbWVudENsaWNrZWQsIHt0cmVlRWxlbWVudH0pOwo=