198952 2019-06-17 22:03:24 -0700 Web Inspector: Canvas: the initial state should be selected when processing a new/imported recording if the navigation sidebar is collapsed 2019-06-18 12:14:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 173807 175485 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1545552 0 hi 2019-06-17 22:03:24 -0700 # STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/demo/WebKit/canvas.html> 2. record any of the <canvas> on the page (the larger the recording, the better) 3. collapse the navigation sidebar in the recording/replay view 4. export the recording 5. close Web Inspector 6. open Web Inspector 7. import the recording from 4 => the recording starts processing (the scrubber updates), but no content is selected => expanding the navigation sidebar will cause the first action to become selected, which will make content appear in the recording/replay view 1545556 1 372326 hi 2019-06-17 22:23:09 -0700 Created attachment 372326 Patch 1545693 2 372326 joepeck 2019-06-18 11:41:25 -0700 Comment on attachment 372326 Patch Nice! r=me 1545715 3 372326 commit-queue 2019-06-18 12:13:12 -0700 Comment on attachment 372326 Patch Clearing flags on attachment: 372326 Committed r246556: <https://trac.webkit.org/changeset/246556> 1545716 4 commit-queue 2019-06-18 12:13:14 -0700 All reviewed patches have been landed. Closing bug. 1545722 5 webkit-bug-importer 2019-06-18 12:14:21 -0700 <rdar://problem/51860153> 372326 2019-06-17 22:23:09 -0700 2019-06-18 12:13:12 -0700 Patch bug-198952-20190617222309.patch text/plain 3051 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4YTAwODdiMDkwYjg0YzI3M2MyMTVhNmVkMDE4 ZTM2MGJhMDk5YTcuLjRmZDdkYjRjNmRkZTMxNjM1ZTQ1YmVlNjMxMmEzZTBkZTM5NDUwY2IgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA2LTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW52YXM6IHRoZSBpbml0aWFsIHN0YXRlIHNob3VsZCBiZSBzZWxlY3RlZCB3aGVuIHByb2Nlc3Np bmcgYSBuZXcvaW1wb3J0ZWQgcmVjb3JkaW5nIGlmIHRoZSBuYXZpZ2F0aW9uIHNpZGViYXIgaXMg Y29sbGFwc2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTg5NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQcmV2ZW50IGFueSBjb250ZW50IGZyb20gYmVpbmcgZ2VuZXJhdGVkIHVudGlsIGBpbml0aWFs TGF5b3V0YCBpcyBjYWxsZWQsIGFzIG90aGVyd2lzZSBpdCdzCisgICAgICAgIHBvc3NpYmxlIGZv ciB0aGUgYENhbnZhc05hdmlnYXRpb25TaWRlYmFyYCB0byB1cGRhdGUgdGhlIGN1cnJlbnQgYWN0 aW9uIGluZGV4IGJlZm9yZSB0aGUKKyAgICAgICAgcHJldmlldyBlbGVtZW50IGhhcyBiZWVuIGNy ZWF0ZWQsIHdoaWNoIHdvdWxkIHRocm93IGFuIGVycm9yLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9SZWNvcmRpbmdDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlJlY29yZGlu Z0NvbnRlbnRWaWV3LnByb3RvdHlwZS51cGRhdGVBY3Rpb25JbmRleCk6CisgICAgICAgIChXSS5S ZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuaW5pdGlhbExheW91dCk6CisgICAgICAgIChX SS5SZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZVNsaWRlclZhbHVlKToKKyAg ICAgICAgKFdJLlJlY29yZGluZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5faGFuZGxlUmVjb3JkaW5n UHJvY2Vzc2VkQWN0aW9uKToKKyAgICAgICAgRHJpdmUtYnk6IHVwZGF0ZSB0aGUgc2xpZGVyIG1h eCBlYWNoIHRpbWUgdGhlIHNlbGVjdGVkIGFjdGlvbiBpbmRleCBpcyBjaGFuZ2VkLgorCiAyMDE5 LTA2LTE3ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBFbGVtZW50czogcmVtb3ZlIGVsbGlwc2VzIGZyb20gIkJyZWFrIG9uIiBjb250 ZXh0IG1lbnUgaXRlbSB0aXRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdDb250ZW50Vmlldy5qcwppbmRl eCA0MWU4ODAzYTA5ZDU2ZTk2OTIyYjIwMmE1YzkwNTc0MGRkZTgzMGU5Li4xMGVjZTIwODNiOTM3 ZmZlOTU3NGE2MmUyNjIwYWQxNzA1NjU2OTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdDb250ZW50 Vmlldy5qcwpAQCAtMTExLDcgKzExMSw4IEBAIFdJLlJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xh c3MgUmVjb3JkaW5nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogCiAgICAgICAg IHRoaXMuX3VwZGF0ZVNsaWRlclZhbHVlKCk7CiAKLSAgICAgICAgdGhpcy5fZ2VuZXJhdGVDb250 ZW50VGhyb3R0bGVyLmZpcmUoKTsKKyAgICAgICAgaWYgKHRoaXMuZGlkSW5pdGlhbExheW91dCkK KyAgICAgICAgICAgIHRoaXMuX2dlbmVyYXRlQ29udGVudFRocm90dGxlci5maXJlKCk7CiAKICAg ICAgICAgdGhpcy5fYWN0aW9uID0gdGhpcy5yZXByZXNlbnRlZE9iamVjdC5hY3Rpb25zW3RoaXMu X2luZGV4XTsKIApAQCAtMTc5LDYgKzE4MCw5IEBAIFdJLlJlY29yZGluZ0NvbnRlbnRWaWV3ID0g Y2xhc3MgUmVjb3JkaW5nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAg ICB9CiAKICAgICAgICAgdGhpcy5fdXBkYXRlU2xpZGVyVmFsdWUoKTsKKworICAgICAgICBpZiAo IWlzTmFOKHRoaXMuX2luZGV4KSkKKyAgICAgICAgICAgIHRoaXMuX2dlbmVyYXRlQ29udGVudFRo cm90dGxlci5maXJlKCk7CiAgICAgfQogCiAgICAgLy8gUHJpdmF0ZQpAQCAtNDgzLDYgKzQ4Nyw3 IEBAIFdJLlJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgUmVjb3JkaW5nQ29udGVudFZpZXcg ZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fc2xpZGVy RWxlbWVudC52YWx1ZSA9IHZpc3VhbEFjdGlvbkluZGV4OworICAgICAgICB0aGlzLl9zbGlkZXJF bGVtZW50Lm1heCA9IHZpc3VhbEFjdGlvbkluZGV4ZXMubGVuZ3RoOwogICAgICAgICB0aGlzLl9z bGlkZXJWYWx1ZUVsZW1lbnQudGV4dENvbnRlbnQgPSBXSS5VSVN0cmluZygiJWQgb2YgJWQiKS5m b3JtYXQodmlzdWFsQWN0aW9uSW5kZXgsIHZpc3VhbEFjdGlvbkluZGV4ZXMubGVuZ3RoKTsKICAg ICB9CiAKQEAgLTUyMyw3ICs1MjgsNiBAQCBXSS5SZWNvcmRpbmdDb250ZW50VmlldyA9IGNsYXNz IFJlY29yZGluZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICB7CiAgICAg ICAgIHRoaXMuX3VwZGF0ZUV4cG9ydEJ1dHRvbigpOwogCi0gICAgICAgIHRoaXMuX3NsaWRlckVs ZW1lbnQubWF4ID0gdGhpcy5yZXByZXNlbnRlZE9iamVjdC52aXN1YWxBY3Rpb25JbmRleGVzLmxl bmd0aDsKICAgICAgICAgdGhpcy5fdXBkYXRlU2xpZGVyVmFsdWUoKTsKIAogICAgICAgICBpZiAo dGhpcy5yZXByZXNlbnRlZE9iamVjdC5yZWFkeSkK