198935 2019-06-17 15:21:09 -0700 Crash at com.apple.WebKit: WebKit::WebsiteDataStore::processPools const 2019-06-19 12:44:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen beidson cdumez commit-queue ggaren oldest_to_newest 1545412 0 sihui_liu 2019-06-17 15:21:09 -0700 Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x00007fff4cffeda0 WebKit::WebsiteDataStore::processPools(unsigned long, bool) const + 114 1 com.apple.WebKit 0x00007fff4d0001e9 WebKit::WebsiteDataStore::plugins() const + 53 2 com.apple.WebKit 0x00007fff4d000142 WebKit::WebsiteDataStore::fetchDataAndApply(WTF::OptionSet<WebKit::WebsiteDataType>, WTF::OptionSet<WebKit::WebsiteDataFetchOption>, WTF::RefPtr<WTF::WorkQueue, WTF::DumbPtrTraits<WTF::WorkQueue> >&&, WTF::Function<void (WTF::Vector<WebKit::WebsiteDataRecord, 0ul, WTF::CrashOnOverflow, 16ul>)>&&) + 2874 3 com.apple.WebKit 0x00007fff4d0006f7 WebKit::WebsiteDataStore::fetchDataForRegistrableDomains(WTF::OptionSet<WebKit::WebsiteDataType>, WTF::OptionSet<WebKit::WebsiteDataFetchOption>, WTF::Vector<WebCore::RegistrableDomain, 0ul, WTF::CrashOnOverflow, 16ul> const&, WTF::CompletionHandler<void (WTF::Vector<WebKit::WebsiteDataRecord, 0ul, WTF::CrashOnOverflow, 16ul>&&, WTF::HashSet<WebCore::RegistrableDomain, WebCore::RegistrableDomain::RegistrableDomainHash, WTF::HashTraits<WebCore::RegistrableDomain> >&&)>&&) + 167 4 com.apple.WebKit 0x00007fff4cfb0bf4 WebKit::NetworkProcessProxy::deleteWebsiteDataInUIProcessForRegistrableDomains(PAL::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::OptionSet<WebKit::WebsiteDataFetchOption>, WTF::Vector<WebCore::RegistrableDomain, 0ul, WTF::CrashOnOverflow, 16ul>, WTF::CompletionHandler<void (WTF::HashSet<WebCore::RegistrableDomain, WebCore::RegistrableDomain::RegistrableDomainHash, WTF::HashTraits<WebCore::RegistrableDomain> >&&)>&&) + 130 5 com.apple.WebKit 0x00007fff4cceee38 WebKit::NetworkProcessProxy::didReceiveNetworkProcessProxyMessage(IPC::Connection&, IPC::Decoder&) + 8976 6 com.apple.WebKit 0x00007fff4cca3bca IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 168 1545414 1 sihui_liu 2019-06-17 15:21:45 -0700 <rdar://problem/51549308> 1545423 2 372279 sihui_liu 2019-06-17 15:31:59 -0700 Created attachment 372279 Patch 1545652 3 372279 ggaren 2019-06-18 10:21:05 -0700 Comment on attachment 372279 Patch Separation of concerns <https://en.wikipedia.org/wiki/Separation_of_concerns> is one of our most powerful abstractions for writing maintainable code. It's why we break up code into functions, and why we break up code and data into classes. This patch eliminates some of the separation of concerns between WebsiteDataStore and WebProcessProxy because it requires WebsiteDataStore to know all of the conditions under which WebProcessProxy's processPool() might be null. If someone changes those conditions in WebProcessProxy in the future, they need to know that they should also update the code in WebsiteDataStore -- but they're very unlikely to know that since, by appearance, WebsiteDataStore and WebProcessProxy are separate classes. I'd suggest instead is that you add a function named WebProcessProxy::processPoolIfExists(). (That's not my favorite name, but it's a naming scheme we've agreed upon for WebKit.) WebProcessProxy::processPoolIfExists() should return m_processPool if it is not null, or null otherwise. If you do that, then WebsiteDataStore can call processPoolIfExists() without knowing all the conditions that might make the return value null, retaining most of the separation of concerns. 1545653 4 372279 ggaren 2019-06-18 10:21:22 -0700 Comment on attachment 372279 Patch Oh! Also, can you write an API test for this? 1545673 5 sihui_liu 2019-06-18 10:50:04 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 372279 [details] > Patch > > Separation of concerns > <https://en.wikipedia.org/wiki/Separation_of_concerns> is one of our most > powerful abstractions for writing maintainable code. It's why we break up > code into functions, and why we break up code and data into classes. > > This patch eliminates some of the separation of concerns between > WebsiteDataStore and WebProcessProxy because it requires WebsiteDataStore to > know all of the conditions under which WebProcessProxy's processPool() might > be null. If someone changes those conditions in WebProcessProxy in the > future, they need to know that they should also update the code in > WebsiteDataStore -- but they're very unlikely to know that since, by > appearance, WebsiteDataStore and WebProcessProxy are separate classes. > > I'd suggest instead is that you add a function named > WebProcessProxy::processPoolIfExists(). (That's not my favorite name, but > it's a naming scheme we've agreed upon for WebKit.) > WebProcessProxy::processPoolIfExists() should return m_processPool if it is > not null, or null otherwise. If you do that, then WebsiteDataStore can call > processPoolIfExists() without knowing all the conditions that might make the > return value null, retaining most of the separation of concerns. Okay. Will add processPoolIfExists(). 1545916 6 372413 sihui_liu 2019-06-18 18:03:12 -0700 Created attachment 372413 Patch 1546153 7 372413 ggaren 2019-06-19 11:43:17 -0700 Comment on attachment 372413 Patch r=me 1546193 8 372413 commit-queue 2019-06-19 12:44:16 -0700 Comment on attachment 372413 Patch Clearing flags on attachment: 372413 Committed r246606: <https://trac.webkit.org/changeset/246606> 1546194 9 commit-queue 2019-06-19 12:44:18 -0700 All reviewed patches have been landed. Closing bug. 372279 2019-06-17 15:31:59 -0700 2019-06-18 18:03:10 -0700 Patch bug-198935-20190617153158.patch text/plain 1888 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZlOGM2YTBiMDc5M2IyZjQ2 ZGIwOTk5YmI3MGVmYjAxMzAwY2I3ZTkuLmQ2OTEwMzFmMWMzNTg0ZDRhNDE1MDU2NTNkMGI5ZjRj MGEwNGQ2ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDYtMTcgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggYXQgY29tLmFwcGxlLldl YktpdDogV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpwcm9jZXNzUG9vbHMgY29uc3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODkzNQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTE1NDkzMDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBXZWJQcm9jZXNzUHJveHkgaXMgcHJlLXdhcm1lZCBv ciBpbiBwcm9jZXNzIGNhY2hlLCBpdCBkb2VzIG5vdCBob2xkIHN0cm9uZyByZWZlcmVuY2UgdG8g aXRzIFdlYlByb2Nlc3NQb29sLAorICAgICAgICBzbyBpdCBpcyBub3Qgc2FmZSB0byBkZWZlcmVu Y2UgYXQgdGhhdCB0aW1lLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNp dGVEYXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpwcm9j ZXNzUG9vbHMgY29uc3QpOgorCiAyMDE5LTA2LTE3ICBMdWRvdmljbyBkZSBOaXR0aXMgIDxsdWRv dmljby5kZW5pdHRpc0Bjb2xsYWJvcmEuY29tPgogCiAgICAgICAgIFtHVEtdIFN0b3AgYWNjZXNz aW5nIEdka0V2ZW50IGZpZWxkcyB3aGVuIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4IGMy OGE2NDBmNzc3M2Q0MGUyMDg5MDk0ZGI2OGNhMTNiYTc2ZTNmNTIuLjAzMjhlM2RlMzNmMDkxMTY0 NWVkZWYzMWUzMGFmMzIxNDNjNjhmNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCkBAIC0xNzQ3LDggKzE3 NDcsMTEgQEAgYm9vbCBXZWJzaXRlRGF0YVN0b3JlOjppc0Fzc29jaWF0ZWRQcm9jZXNzUG9vbChX ZWJQcm9jZXNzUG9vbCYgcHJvY2Vzc1Bvb2wpIGNvbnMKIEhhc2hTZXQ8UmVmUHRyPFdlYlByb2Nl c3NQb29sPj4gV2Vic2l0ZURhdGFTdG9yZTo6cHJvY2Vzc1Bvb2xzKHNpemVfdCBjb3VudCwgYm9v bCBlbnN1cmVBUG9vbEV4aXN0cykgY29uc3QKIHsKICAgICBIYXNoU2V0PFJlZlB0cjxXZWJQcm9j ZXNzUG9vbD4+IHByb2Nlc3NQb29sczsKLSAgICBmb3IgKGF1dG8mIHByb2Nlc3MgOiBwcm9jZXNz ZXMoKSkKKyAgICBmb3IgKGF1dG8mIHByb2Nlc3MgOiBwcm9jZXNzZXMoKSkgeworICAgICAgICBp ZiAocHJvY2Vzcy0+aXNJblByb2Nlc3NDYWNoZSgpIHx8IHByb2Nlc3MtPmlzUHJld2FybWVkKCkp CisgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgcHJvY2Vzc1Bvb2xzLmFkZCgmcHJvY2Vz cy0+cHJvY2Vzc1Bvb2woKSk7CisgICAgfQogCiAgICAgaWYgKHByb2Nlc3NQb29scy5pc0VtcHR5 KCkpIHsKICAgICAgICAgLy8gQ2hlY2sgaWYgd2UncmUgb25lIG9mIHRoZSBsZWdhY3kgZGF0YSBz dG9yZXMuCg== 372413 2019-06-18 18:03:12 -0700 2019-06-19 12:44:16 -0700 Patch bug-198935-20190618180311.patch text/plain 4014 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg1YmQ0YWYzZTI5OGNhODEw ZjVhMGU2YmI0OTJiMTZjMjAyNWMxZWYuLjQ5OGJkODg5MGRkYzc1NDAxMzJhMDhlNzA5ZTg2MGMx ZTdiMDU0NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDYtMTggIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggYXQgY29tLmFwcGxlLldl YktpdDogV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpwcm9jZXNzUG9vbHMgY29uc3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODkzNQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNTE1NDkzMDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBXZWJQcm9jZXNzUHJveHkgaXMgaW4gV2ViUHJvY2Vz c0NhY2hlIG9yIGlzIHByZS13YXJtZWQsIGl0IGRvZXMgbm90IGhvbGQgYSBzdHJvbmcgcmVmZXJl bmNlIG9mIAorICAgICAgICBXZWJQcm9jZXNzUG9vbC4gSW4gdGhpcyBjYXNlLCB3ZSBzaG91bGQg bm90IHN0b3JlIHRoZSByYXcgcG9pbnRlciBvZiBXZWJQcm9jZXNzUG9vbCBhbmQgcGVyZm9ybSB3 ZWJzaXRlRGF0YVN0b3JlCisgICAgICAgIG9wZXJhdGlvbnMgd2l0aCBpdC4KKyAgICAgICAgVGhp cyBwYXRjaCBzaG91bGQgZml4IHRoZSBjcmFzaCBhdCBkZXJlZmVyZW5jaW5nIG51bGwgcG9pbnRl ciBvZiBXZWJQcm9jZXNzUG9vbCBpbiAKKyAgICAgICAgV2Vic2l0ZURhdGFTdG9yZTo6cHJvY2Vz c1Bvb2xzLCBidXQgaXQgaXMgdW5jbGVhciB3aHkgd2Vic2l0ZURhdGFTdG9yZSBjb21lcyB0byBv YnNlcnZlIGNhY2hlZCBvciBwcmV3YXJtZWQgd2ViIAorICAgICAgICBwcm9jZXNzIHRoYXQgc2hv dWxkIG5vdCBoYXZlIHdlYiBwYWdlLiBUaGUgcmVsZWFzZSBsb2cgbWF5IGhlbHAgdXMgZmluZCB0 aGUgY2F1c2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5Ojpwcm9jZXNzUG9vbElmRXhpc3RzIGNvbnN0 KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5Lmg6CisgICAgICAgICogVUlQ cm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJzaXRlRGF0YVN0b3JlOjpwcm9jZXNzUG9vbHMgY29uc3QpOgorCiAyMDE5LTA2LTE4ICBZ b3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9yYWdlTWFuYWdl cjo6cmVtb3ZlQWxsb3dlZFNlc3Npb25TdG9yYWdlTmFtZXNwYWNlQ29ubmVjdGlvbiBzaG91bGQg bWFrZSBzdXJlIGl0cyBzdG9yYWdlTmFtZXNwYWNlSUQgaXMgdmFsaWQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IDNhMGMxMmQ3ZTM4MWY3ZDE5ZWVm NmU2NTA4YjI5ZDZiZjBiNzNlMzMuLjczZWQ5OGM0ODJkYjMzYzE4MzFkM2RmMTk4YzU3ZDRjNDIw Y2FlNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcApA QCAtMTUxNiw2ICsxNTE2LDE1IEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpkZWNyZW1lbnRTdXNw ZW5kZWRQYWdlQ291bnQoKQogICAgICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpTZXRI YXNTdXNwZW5kZWRQYWdlUHJveHkoZmFsc2UpLCAwKTsKIH0KIAorV2ViUHJvY2Vzc1Bvb2wqIFdl YlByb2Nlc3NQcm94eTo6cHJvY2Vzc1Bvb2xJZkV4aXN0cygpIGNvbnN0Cit7CisgICAgaWYgKG1f aXNQcmV3YXJtZWQgfHwgbV9pc0luUHJvY2Vzc0NhY2hlKQorICAgICAgICBSRUxFQVNFX0xPR19F UlJPUihQcm9jZXNzLCAiJXAgLSBXZWJQcm9jZXNzUHJveHk6OnByb2Nlc3NQb29sSWZFeGlzdHM6 IHRyeWluZyB0byBnZXQgV2ViUHJvY2Vzc1Bvb2wgZnJvbSBhbiBpbmFjdGl2ZSBXZWJQcm9jZXNz UHJveHkgJWkiLCB0aGlzLCBwcm9jZXNzSWRlbnRpZmllcigpKTsKKyAgICBlbHNlCisgICAgICAg IEFTU0VSVChtX3Byb2Nlc3NQb29sKTsKKyAgICByZXR1cm4gbV9wcm9jZXNzUG9vbC5nZXQoKTsK K30KKwogV2ViUHJvY2Vzc1Bvb2wmIFdlYlByb2Nlc3NQcm94eTo6cHJvY2Vzc1Bvb2woKSBjb25z dAogewogICAgIEFTU0VSVChtX3Byb2Nlc3NQb29sKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Byb3h5LmgKaW5kZXggZTc5MGJjNmIyYjRiYjVmMTI5YWQ1ODAyMzE0N2VjOTgx NGU0NDcwYS4uZWNiYzVkOGZjNGM5ZDQyNzlmZTZhNDFkYmIwMTQ0MTQxNGRlYWI5ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmgKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmgKQEAgLTExOSw2ICsxMTksNyBA QCBwdWJsaWM6CiAgICAgdm9pZCBpbmNyZW1lbnRTdXNwZW5kZWRQYWdlQ291bnQoKTsKICAgICB2 b2lkIGRlY3JlbWVudFN1c3BlbmRlZFBhZ2VDb3VudCgpOwogCisgICAgV2ViUHJvY2Vzc1Bvb2wq IHByb2Nlc3NQb29sSWZFeGlzdHMoKSBjb25zdDsKICAgICBXZWJQcm9jZXNzUG9vbCYgcHJvY2Vz c1Bvb2woKSBjb25zdDsKIAogICAgIFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWluIHJlZ2lzdHJh YmxlRG9tYWluKCkgY29uc3QgeyByZXR1cm4gbV9yZWdpc3RyYWJsZURvbWFpbi52YWx1ZU9yKFdl YkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWluIHsgfSk7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKaW5kZXggM2Ri ODkzYzk3Njc1MGQ0ZDU1NGZjOTEzODBmMjVlYzhhN2ZjZWNlNC4uNGM2MzdlNWFiZGNlYzkxMzI5 MzQ1OTZiODA0NmEyYmE1MWY1NGE1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTE3MTcsOCArMTcx NywxMCBAQCBib29sIFdlYnNpdGVEYXRhU3RvcmU6OmlzQXNzb2NpYXRlZFByb2Nlc3NQb29sKFdl YlByb2Nlc3NQb29sJiBwcm9jZXNzUG9vbCkgY29ucwogSGFzaFNldDxSZWZQdHI8V2ViUHJvY2Vz c1Bvb2w+PiBXZWJzaXRlRGF0YVN0b3JlOjpwcm9jZXNzUG9vbHMoc2l6ZV90IGNvdW50LCBib29s IGVuc3VyZUFQb29sRXhpc3RzKSBjb25zdAogewogICAgIEhhc2hTZXQ8UmVmUHRyPFdlYlByb2Nl c3NQb29sPj4gcHJvY2Vzc1Bvb2xzOwotICAgIGZvciAoYXV0byYgcHJvY2VzcyA6IHByb2Nlc3Nl cygpKQotICAgICAgICBwcm9jZXNzUG9vbHMuYWRkKCZwcm9jZXNzLT5wcm9jZXNzUG9vbCgpKTsK KyAgICBmb3IgKGF1dG8mIHByb2Nlc3MgOiBwcm9jZXNzZXMoKSkgeworICAgICAgICBpZiAoYXV0 byogcHJvY2Vzc1Bvb2wgPSBwcm9jZXNzLT5wcm9jZXNzUG9vbElmRXhpc3RzKCkpCisgICAgICAg ICAgICBwcm9jZXNzUG9vbHMuYWRkKHByb2Nlc3NQb29sKTsKKyAgICB9CiAKICAgICBpZiAocHJv Y2Vzc1Bvb2xzLmlzRW1wdHkoKSkgewogICAgICAgICAvLyBDaGVjayBpZiB3ZSdyZSBvbmUgb2Yg dGhlIGxlZ2FjeSBkYXRhIHN0b3Jlcy4K