198925 2019-06-17 11:13:39 -0700 [iOS] Pressing key while holding Command should not insert character 2019-06-18 13:59:39 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 190571 1 dbates dbates bfulgham webkit-bug-importer wenson_hsieh oldest_to_newest 1545314 0 dbates 2019-06-17 11:13:39 -0700 Seen on iOS. Steps to reproduce: 1. Visit <data:text/html,<input%20type="text">> 2. Focus the input. 3. Press Command + Shift + v. Then nothing should be inserted. But a v is inserted. 1545315 1 dbates 2019-06-17 11:14:14 -0700 <rdar://problem/51778811> 1545326 2 372259 dbates 2019-06-17 11:30:30 -0700 Created attachment 372259 Patch and test If I have a moment, I will look to write a more comprehensive test. Maybe I could modify the fast/events/ios/key-event-comprehensive tests. I didn't want to now since these tests already run longish and I did not want to tempt fate with a modification that could make them run even longer ... and timeout. Maybe I could duplicate these tests as an alternative. 1545620 3 372259 bfulgham 2019-06-18 08:36:37 -0700 Comment on attachment 372259 Patch and test View in context: https://bugs.webkit.org/attachment.cgi?id=372259&action=review Looks reasonable. r=me. > Source/WebKit/ChangeLog:11 > + time of writing) should not insert v. This matches iOS and Mac platform conventions. Yes! 1545793 4 372259 dbates 2019-06-18 13:59:38 -0700 Comment on attachment 372259 Patch and test Clearing flags on attachment: 372259 Committed r246564: <https://trac.webkit.org/changeset/246564> 1545794 5 dbates 2019-06-18 13:59:39 -0700 All reviewed patches have been landed. Closing bug. 372259 2019-06-17 11:30:30 -0700 2019-06-18 13:59:38 -0700 Patch and test bug-198925-20190617113030.patch text/plain 5331 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM5YzE4ZTcwMmQ3NTgwOGIz MWU2Y2M0YmNiMWYzNGY1YTcyNzIyZTkuLmQ1YjI3YjQ0YjI3Nzk3ZjI4ZWYyOWFjMDIzMDMzNzdi NjAzMGRjNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDYtMTcgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFByZXNzaW5nIGtleSB3 aGlsZSBob2xkaW5nIENvbW1hbmQgc2hvdWxkIG5vdCBpbnNlcnQgY2hhcmFjdGVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg5MjUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzUxNzc4ODExPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERvIG5vdCBpbnNlcnQgYSBjaGFyYWN0ZXIgZm9yIGFuIHVuaGFu ZGxlZCBrZXkgY29tbWFuZCB0aGF0IGhhcyBhIENvbW1hbmQgbW9kaWZpZXIuCisgICAgICAgIEZv ciBleGFtcGxlLCBwcmVzc2luZyBDb21tYW5kICsgU2hpZnQgKyB2LCB3aGljaCBpcyBhbiB1bmhh bmRsZWQga2V5IGNvbW1hbmQgKGF0IHRoZQorICAgICAgICB0aW1lIG9mIHdyaXRpbmcpIHNob3Vs ZCBub3QgaW5zZXJ0IHYuIFRoaXMgbWF0Y2hlcyBpT1MgYW5kIE1hYyBwbGF0Zm9ybSBjb252ZW50 aW9ucy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnRlcnByZXRLZXlFdmVudDppc0NoYXJF dmVudDpdKToKKwogMjAxOS0wNS0xNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPU10gU2VsZWN0IGFsbCB3aXRoIGV4aXN0aW5nIHJhbmdlIHNlbGVjdGlv biByZXBsYWNlcyByYW5nZSBpbnN0ZWFkIG9mIHNlbGVjdGluZyBhbGwgdGV4dApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KaW5kZXggOTFmNjI1YzBlMjg3MDU3NmM5NWE3Mzk5YWM4NDczYWFkOGE2YjcwOS4uMWQ2OGEw MzBkNWI3YmMzODZjNjVlMTYxMzczZWU2N2ZmZjQ1ZTk3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC00 NjYzLDYgKzQ2NjMsMTAgQEAgLSAoQk9PTClfaW50ZXJwcmV0S2V5RXZlbnQ6KDo6V2ViRXZlbnQg KilldmVudCBpc0NoYXJFdmVudDooQk9PTClpc0NoYXJFdmVudAogICAgICAgICByZXR1cm4gWUVT OwogI2VuZGlmCiAKKyAgICAvLyBEb24ndCBpbnNlcnQgY2hhcmFjdGVyIGZvciBhbiB1bmhhbmRs ZWQgQ29tbWFuZC1rZXkga2V5IGNvbW1hbmQuIFRoaXMgbWF0Y2hlcyBpT1MgYW5kIE1hYyBwbGF0 Zm9ybSBjb252ZW50aW9ucy4KKyAgICBpZiAoZXZlbnQubW9kaWZpZXJGbGFncyAmIFdlYkV2ZW50 RmxhZ01hc2tDb21tYW5kS2V5KQorICAgICAgICByZXR1cm4gTk87CisKICAgICBOU1N0cmluZyAq Y2hhcmFjdGVycyA9IGV2ZW50LmNoYXJhY3RlcnM7CiAgICAgaWYgKCFjaGFyYWN0ZXJzLmxlbmd0 aCkKICAgICAgICAgcmV0dXJuIE5POwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGExZTdhMTQzYTI4NGQ4NjJmMDI2NDlhNTYx MjAzNDJhYzNmNTYxMDguLjJjNjYzZTI4MTVkOGI3N2I0NWI2NzUzZTNjNDMzOTA5NjhjYWZmOTkg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOS0wNi0xNyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRl c0BhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUHJlc3Npbmcga2V5IHdoaWxlIGhvbGRpbmcg Q29tbWFuZCBzaG91bGQgbm90IGluc2VydCBjaGFyYWN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODkyNQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTE3Nzg4MTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgdGVzdCB0aGF0IENvbW1hbmQgKyBTaGlmdCArIHYgZG9lcyBub3QgaW5zZXJ0 IGEgdiBhcyB3ZSBkb24ndCBleHBlY3QgaXQKKyAgICAgICAgdG8gYXMgb2YgdGhlIHRpbWUgb2Yg d3JpdGluZy4gQSBtb3JlIGNvbXByZWhlbnNpdmUgdGVzdCB3b3VsZCBiZSBuZWVkZWQgdG8KKyAg ICAgICAgZW5zdXJlIHRoYXQgYWxsIHVuaGFuZGxlZCBrZXkgY29tbWFuZHMgd2l0aCBDb21tYW5k IG1vZGlmaWVycyBkbyBub3QgaW5zZXJ0CisgICAgICAgIGEgY2hhcmFjdGVyLiBGb3Igbm93LCB0 aGUgYWRkZWQgdGVzdCBzZWVtcyBnb29kIGVub3VnaC4KKworICAgICAgICAqIGZhc3QvZXZlbnRz L2lvcy9jb21tYW5kK3NoaWZ0K3Ytc2hvdWxkLW5vdC1pbnNlcnQtdi1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL2lvcy9jb21tYW5kK3NoaWZ0K3Ytc2hvdWxkLW5v dC1pbnNlcnQtdi5odG1sOiBBZGRlZC4KKwogMjAxOS0wNi0xMyAgRGFuaWVsIEJhdGVzICA8ZGFi YXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gTm9ybWFsaXplIHRlc3QgcmVzdWx0IG9m IGZhc3QvZXZlbnRzL2lvcy9rZXlib2FyZC1ldmVudC1rZXktYXR0cmlidXRlLmh0bWwgdG8gaGFu ZGxlIHBvc3NpYmxlIG1vZGlmaWVyIGRpc3BhdGNoCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9pb3MvY29tbWFuZCtzaGlmdCt2LXNob3VsZC1ub3QtaW5zZXJ0LXYtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NvbW1hbmQrc2hpZnQrdi1zaG91 bGQtbm90LWluc2VydC12LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42YzE0NDc0MTBmNWU4ZTg1 ZWUwMTU5NzNkYmZmZjc1MTliOGZkOGEyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvaW9zL2NvbW1hbmQrc2hpZnQrdi1zaG91bGQtbm90LWluc2VydC12LWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitUZXN0cyB0aGF0IENvbW1hbmQgKyBTaGlmdCArIHYg ZG9lcyBub3QgaW5zZXJ0IHYgYW5kIHRoYXQgcHJlc3NpbmcgYSBkb2VzIGluc2VydCBhbiBhLgor CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyB3aW5kb3cuZXZlbnQuZGF0YSBp cyAiYSIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvY29tbWFuZCtzaGlmdCt2 LXNob3VsZC1ub3QtaW5zZXJ0LXYuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9j b21tYW5kK3NoaWZ0K3Ytc2hvdWxkLW5vdC1pbnNlcnQtdi5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZhYjY0 NjhiMWQ4MGNhYzhkZWJjZmU1ZTNhZGE5NWYzNmQxNDZmNTYKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvY29tbWFuZCtzaGlmdCt2LXNob3VsZC1ub3QtaW5z ZXJ0LXYuaHRtbApAQCAtMCwwICsxLDQ2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhl YWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy91aS1oZWxwZXIuanMiPjwvc2NyaXB0 PgorPHNjcmlwdD4KK3dpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKworbGV0IHRlc3RFbGVt ZW50OworCitmdW5jdGlvbiBjaGVja1RleHRJbnB1dChldmVudCkKK3sKKyAgICBzaG91bGRCZUVx dWFsVG9TdHJpbmcoIndpbmRvdy5ldmVudC5kYXRhIiwgImEiKTsKKyAgICBkb2N1bWVudC5ib2R5 LnJlbW92ZUNoaWxkKHRlc3RFbGVtZW50KTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KKworZnVu Y3Rpb24gaGFuZGxlRm9jdXMoKQoreworICAgIHRlc3RFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIo ImlucHV0IiwgY2hlY2tUZXh0SW5wdXQsIHsgb25jZTogdHJ1ZSB9KTsKKyAgICBpZiAod2luZG93 LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgVUlIZWxwZXIua2V5RG93bigidiIsIFsibWV0YUtleSIs ICJzaGlmdEtleSJdKTsgLy8gU2hvdWxkIGVtaXQgbm8gVGV4dElucHV0IGV2ZW50LgorICAgICAg ICBVSUhlbHBlci5rZXlEb3duKCJhIik7IC8vIFRvIGVuZCB0aGUgdGVzdC4KKyAgICB9Cit9CisK K2Z1bmN0aW9uIHJ1blRlc3QoKQoreworICAgIHRlc3RFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoInRlc3QiKTsKKworICAgIGRlc2NyaXB0aW9uKCJUZXN0cyB0aGF0IDxrYmQ+Q29t bWFuZDwva2JkPiArIDxrYmQ+U2hpZnQ8L2tiZD4gKyA8a2JkPnY8L2tiZD4gZG9lcyBub3QgaW5z ZXJ0IHYgYW5kIHRoYXQgcHJlc3NpbmcgPGtiZD5hPC9rYmQ+IGRvZXMgaW5zZXJ0IGFuIGEuIik7 CisKKyAgICB0ZXN0RWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJmb2N1cyIsIGhhbmRsZUZvY3Vz LCB7IG9uY2U6IHRydWUgfSk7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICBV SUhlbHBlci5hY3RpdmF0ZUZvcm1Db250cm9sKHRlc3RFbGVtZW50KTsKKyAgICBlbHNlCisgICAg ICAgIHRlc3RFbGVtZW50LmZvY3VzKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9u bG9hZD0icnVuVGVzdCgpIj4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29u c29sZSI+PC9kaXY+Cis8aW5wdXQgdHlwZT0idGV4dCIgaWQ9InRlc3QiIHBsYWNlaG9sZGVyPSJQ cmVzcyBDb21tYW5kICsgU2hpZnQgKyB2LiBUaGVuIHByZXNzIGEuIiBzdHlsZT0id2lkdGg6IDMw MHB4Ij48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K