198905 2019-06-16 13:05:13 -0700 Experiment with simple structured bindings use 2019-06-26 16:46:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198914 1 sam sam benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist simon.fraser webkit-bug-importer oldest_to_newest 1545159 0 sam 2019-06-16 13:05:13 -0700 Experiment with simple structured bindings use 1545160 1 372227 sam 2019-06-16 13:06:48 -0700 Created attachment 372227 Patch 1545161 2 ews-watchlist 2019-06-16 13:09:53 -0700 Attachment 372227 did not pass style-queue: ERROR: Source/WTF/wtf/URLHelpers.cpp:732: Extra space before [. [whitespace/brackets] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1545164 3 sam 2019-06-16 13:16:28 -0700 (In reply to Build Bot from comment #2) > Attachment 372227 [details] did not pass style-queue: > > > ERROR: Source/WTF/wtf/URLHelpers.cpp:732: Extra space before [. > [whitespace/brackets] [5] > Total errors found: 1 in 2 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Filed https://bugs.webkit.org/show_bug.cgi?id=198906 for this. 1545286 4 372227 darin 2019-06-17 10:24:11 -0700 Comment on attachment 372227 Patch Looks like this is going to work once we upgrade those last two EWS bots. 1547905 5 372882 sam 2019-06-25 17:15:37 -0700 Created attachment 372882 Try again 1547907 6 ews-watchlist 2019-06-25 17:18:52 -0700 Attachment 372882 did not pass style-queue: ERROR: Source/WTF/wtf/URLHelpers.cpp:732: Extra space before [. [whitespace/brackets] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1547942 7 372882 commit-queue 2019-06-25 19:00:53 -0700 Comment on attachment 372882 Try again Clearing flags on attachment: 372882 Committed r246826: <https://trac.webkit.org/changeset/246826> 1547944 8 commit-queue 2019-06-25 19:00:55 -0700 All reviewed patches have been landed. Closing bug. 1548210 9 webkit-bug-importer 2019-06-26 16:46:03 -0700 <rdar://problem/52218743> 1548211 10 webkit-bug-importer 2019-06-26 16:46:05 -0700 <rdar://problem/52218744> 372227 2019-06-16 13:06:48 -0700 2019-06-25 17:15:37 -0700 Patch bug-198905-20190616130647.patch text/plain 1435 sam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDY0ODEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTE2ICBTYW0gV2VpbmlnICA8d2Vpbmln QGFwcGxlLmNvbT4KKworICAgICAgICBFeHBlcmltZW50IHdpdGggc2ltcGxlIHN0cnVjdHVyZWQg YmluZGluZ3MgdXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTg5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9VUkxIZWxwZXJzLmNwcDoKKyAgICAgICAgKFdURjo6VVJMSGVscGVyczo6bWFw SG9zdE5hbWVzKToKKyAgICAgICAgU2ltcGxpZnkgY29kZSB1c2luZyBjKysgc3RydWN0dXJlZCBi aW5kaW5ncyAoaHR0cHM6Ly9lbi5jcHByZWZlcmVuY2UuY29tL3cvY3BwL2xhbmd1YWdlL3N0cnVj dHVyZWRfYmluZGluZykKKyAgICAgICAgdG8gc2VlIGlmIGFsbCB0aGUgcGxhdGZvcm1zIHdpbGwg d29yayB3aXRoIGl0LgorCiAyMDE5LTA2LTEyICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBs ZS5jb20+CiAKICAgICAgICAgU2hvdyB0aGUgd2ViIHBhZ2UgVVJMIHdoZW4gc2hhcmluZyBhbiBB UiBtb2RlbApJbmRleDogU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAJKHJldmlzaW9uIDI0NjQ2OCkKKysrIFNv dXJjZS9XVEYvd3RmL1VSTEhlbHBlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MjksOSArNzI5 LDcgQEAgU3RyaW5nIG1hcEhvc3ROYW1lcyhjb25zdCBTdHJpbmcmIHN0cmluZwogICAgIC8vIERv IHRoZSBtYXBwaW5nLgogICAgIFN0cmluZyByZXN1bHQgPSBzdHJpbmc7CiAgICAgd2hpbGUgKCFo b3N0TmFtZVJhbmdlcy0+aXNFbXB0eSgpKSB7Ci0gICAgICAgIHVuc2lnbmVkIGxvY2F0aW9uLCBs ZW5ndGg7Ci0gICAgICAgIFN0cmluZyBtYXBwZWRIb3N0TmFtZTsKLSAgICAgICAgc3RkOjp0aWUo bG9jYXRpb24sIGxlbmd0aCwgbWFwcGVkSG9zdE5hbWUpID0gaG9zdE5hbWVSYW5nZXMtPnRha2VM YXN0KCk7CisgICAgICAgIGF1dG8gW2xvY2F0aW9uLCBsZW5ndGgsIG1hcHBlZEhvc3ROYW1lXSA9 IGhvc3ROYW1lUmFuZ2VzLT50YWtlTGFzdCgpOwogICAgICAgICByZXN1bHQgPSByZXN1bHQucmVw bGFjZShsb2NhdGlvbiwgbGVuZ3RoLCBtYXBwZWRIb3N0TmFtZSk7CiAgICAgfQogICAgIHJldHVy biByZXN1bHQ7Cg== 372882 2019-06-25 17:15:37 -0700 2019-06-25 19:00:53 -0700 Try again bug-198905-20190616130647.patch text/plain 1435 sam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNDY0ODEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTE2ICBTYW0gV2VpbmlnICA8d2Vpbmln QGFwcGxlLmNvbT4KKworICAgICAgICBFeHBlcmltZW50IHdpdGggc2ltcGxlIHN0cnVjdHVyZWQg YmluZGluZ3MgdXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTg5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9VUkxIZWxwZXJzLmNwcDoKKyAgICAgICAgKFdURjo6VVJMSGVscGVyczo6bWFw SG9zdE5hbWVzKToKKyAgICAgICAgU2ltcGxpZnkgY29kZSB1c2luZyBjKysgc3RydWN0dXJlZCBi aW5kaW5ncyAoaHR0cHM6Ly9lbi5jcHByZWZlcmVuY2UuY29tL3cvY3BwL2xhbmd1YWdlL3N0cnVj dHVyZWRfYmluZGluZykKKyAgICAgICAgdG8gc2VlIGlmIGFsbCB0aGUgcGxhdGZvcm1zIHdpbGwg d29yayB3aXRoIGl0LgorCiAyMDE5LTA2LTEyICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBs ZS5jb20+CiAKICAgICAgICAgU2hvdyB0aGUgd2ViIHBhZ2UgVVJMIHdoZW4gc2hhcmluZyBhbiBB UiBtb2RlbApJbmRleDogU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dURi93dGYvVVJMSGVscGVycy5jcHAJKHJldmlzaW9uIDI0NjQ2OCkKKysrIFNv dXJjZS9XVEYvd3RmL1VSTEhlbHBlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MjksOSArNzI5 LDcgQEAgU3RyaW5nIG1hcEhvc3ROYW1lcyhjb25zdCBTdHJpbmcmIHN0cmluZwogICAgIC8vIERv IHRoZSBtYXBwaW5nLgogICAgIFN0cmluZyByZXN1bHQgPSBzdHJpbmc7CiAgICAgd2hpbGUgKCFo b3N0TmFtZVJhbmdlcy0+aXNFbXB0eSgpKSB7Ci0gICAgICAgIHVuc2lnbmVkIGxvY2F0aW9uLCBs ZW5ndGg7Ci0gICAgICAgIFN0cmluZyBtYXBwZWRIb3N0TmFtZTsKLSAgICAgICAgc3RkOjp0aWUo bG9jYXRpb24sIGxlbmd0aCwgbWFwcGVkSG9zdE5hbWUpID0gaG9zdE5hbWVSYW5nZXMtPnRha2VM YXN0KCk7CisgICAgICAgIGF1dG8gW2xvY2F0aW9uLCBsZW5ndGgsIG1hcHBlZEhvc3ROYW1lXSA9 IGhvc3ROYW1lUmFuZ2VzLT50YWtlTGFzdCgpOwogICAgICAgICByZXN1bHQgPSByZXN1bHQucmVw bGFjZShsb2NhdGlvbiwgbGVuZ3RoLCBtYXBwZWRIb3N0TmFtZSk7CiAgICAgfQogICAgIHJldHVy biByZXN1bHQ7Cg==