198843 2019-06-13 14:32:24 -0700 Disable AppSSO for web processes and plugin processes 2019-06-14 14:39:14 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham commit-queue jiewen_tan sam webkit-bug-importer oldest_to_newest 1544607 0 jiewen_tan 2019-06-13 14:32:24 -0700 Disable AppSSO for web processes and plugin processes. 1544608 1 jiewen_tan 2019-06-13 14:32:45 -0700 <rdar://problem/51642920> 1544609 2 372079 jiewen_tan 2019-06-13 14:38:54 -0700 Created attachment 372079 Patch 1544784 3 372079 sam 2019-06-14 11:25:13 -0700 Comment on attachment 372079 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372079&action=review > Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:408 > +#if HAVE(LOAD_OPTIMIZER) Why is the conditional called HAVE(LOAD_OPTIMIZER)? 1544794 4 jiewen_tan 2019-06-14 11:56:40 -0700 (In reply to Sam Weinig from comment #3) > Comment on attachment 372079 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=372079&action=review > > > Source/WebKit/PluginProcess/mac/PluginProcessMac.mm:408 > > +#if HAVE(LOAD_OPTIMIZER) > > Why is the conditional called HAVE(LOAD_OPTIMIZER)? Cause we are hiding some secrets in WKA. Since we are post WWDC now, my next patch after this will move the whole AppSSO thing to OpenSource. 1544836 5 372079 jiewen_tan 2019-06-14 14:08:17 -0700 Comment on attachment 372079 Patch Thanks Sam for r+ this patch. 1544848 6 372079 commit-queue 2019-06-14 14:39:13 -0700 Comment on attachment 372079 Patch Clearing flags on attachment: 372079 Committed r246446: <https://trac.webkit.org/changeset/246446> 1544849 7 commit-queue 2019-06-14 14:39:14 -0700 All reviewed patches have been landed. Closing bug. 372079 2019-06-13 14:38:54 -0700 2019-06-14 14:39:13 -0700 Patch bug-198843-20190613143853.patch text/plain 6551 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA5NjY5MWIy OGZjYTRjMjI4ZDA0MjA1NWI2N2Y5NGE1MTE0OGJmYTI0Li43OWVjNTdmYzBiYzljZTY4ODYyMTI5 MjQzMmUwZTNjMzk5MGM1YzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxOS0wNi0xMyAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgorCisgICAgICAg IERpc2FibGUgQXBwU1NPIGZvciB3ZWIgcHJvY2Vzc2VzIGFuZCBwbHVnaW4gcHJvY2Vzc2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg4NDMKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxNjQyOTIwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaDoKKyAg ICAgICAgQWRkcyBhIFNQSSB0byBkaXNhYmxlIEFwcFNTTyBmb3IgQ0ZOZXR3b3JrLgorCiAyMDE5 LTA2LTEwICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg RGFzaGJvYXJkIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggOGFhNzIyNDhjYjY5YmUwZjAyYzdjNDliZjM5 OTE0NWEzOGQ4NjIyYS4uNzJkZDQzNjE1MGUzMTE3ZTgxYWIwOWVmZWE0NWE4NzIyOTg4MzE0ZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxOS0wNi0xMyAgSmlld2VuIFRhbiAgPGppZXdl bl90YW5AYXBwbGUuY29tPgorCisgICAgICAgIERpc2FibGUgQXBwU1NPIGZvciB3ZWIgcHJvY2Vz c2VzIGFuZCBwbHVnaW4gcHJvY2Vzc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTg4NDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxNjQyOTIw PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg cGF0Y2ggbW92ZXMgdGhlIGRpc2FibGluZyBvZiBBcHBTU08gZnJvbSBBdXhpbGlhcnlQcm9jZXNz IHRvIFBsdWdpblByb2Nlc3MKKyAgICAgICAgYW5kIFdlYlByb2Nlc3Mgc3VjaCB0aGF0IE5ldHdv cmtpbmdQcm9jZXNzIHdpbGwgbm90IGJlIGFmZmVjdGVkLgorCisgICAgICAgICogUGx1Z2luUHJv Y2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJv Y2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplUGx1Z2luUHJvY2Vzcyk6CisgICAgICAgICogU2hhcmVk L2lvcy9BdXhpbGlhcnlQcm9jZXNzSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpBdXhpbGlhcnlQ cm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemUpOgorICAgICAgICAqIFNoYXJlZC9tYWMvQXV4aWxp YXJ5UHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktpdDo6QXV4aWxpYXJ5UHJvY2Vzczo6cGxh dGZvcm1Jbml0aWFsaXplKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3ND b2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXpl UHJvY2Vzcyk6CisKIDIwMTktMDYtMTEgIFBhdHJpY2sgR3JpZmZpcyAgPHBncmlmZmlzQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gRml4IGExMXkgc3VwcG9ydCBpbiBidWJibGV3cmFwIHNh bmRib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29y a1NQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgKaW5k ZXggODk3YWYwNGY2ODVjNThlYTNmNjRmYjg2MzFmNzcwZWI3YjZiMDc0Zi4uMTgyZmY4YmU2NTFh OGQyNjJjYzY4NjQzZjJkYWRkZDI2NjU5NGI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv UEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3Bh bC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgKQEAgLTIzMiwxMSArMjMyLDE0IEBAIHR5cGVkZWYgTlNf RU5VTShOU0ludGVnZXIsIE5TVVJMU2Vzc2lvbkNvbXBhbmlvblByb3h5UHJlZmVyZW5jZSkgewog QGVuZAogI2VuZGlmCiAKLSNpZiBIQVZFKENGTkVUV09SS19OU1VSTFNFU1NJT05fU1RSSUNUUlVT VEVWQUxVQVRFKQogQGludGVyZmFjZSBOU1VSTFNlc3Npb24gKFNQSSkKKyNpZiBIQVZFKENGTkVU V09SS19OU1VSTFNFU1NJT05fU1RSSUNUUlVTVEVWQUxVQVRFKQogKyAodm9pZClfc3RyaWN0VHJ1 c3RFdmFsdWF0ZTooTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAqKWNoYWxsZW5nZSBxdWV1 ZTooZGlzcGF0Y2hfcXVldWVfdClxdWV1ZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNV UkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSAqY2hhbGxlbmdlLCBPU1N0YXR1cyB0cnVzdFJlc3Vs dCkpY2I7Ci1AZW5kCiAjZW5kaWYKKyNpZiBIQVZFKExPQURfT1BUSU1JWkVSKQorKyAodm9pZClf ZGlzYWJsZUFwcFNTTzsKKyNlbmRpZgorQGVuZAogCiBleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBO U1VSTEF1dGhlbnRpY2F0aW9uTWV0aG9kT0F1dGg7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvUGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQv UGx1Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbQppbmRleCBiZDNhYjA4MGJjYzdi NTMwM2Y3MzIxZjBlYTBlYjJkNDIxZjk4M2ZmLi43ODdiY2JhZTQxMDU1YzU3YjRmNTlhYWU2ZDVm OTgyMmQzMTYwNWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFj L1BsdWdpblByb2Nlc3NNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21h Yy9QbHVnaW5Qcm9jZXNzTWFjLm1tCkBAIC00Nyw2ICs0Nyw3IEBACiAjaW1wb3J0IDxtYWNoL21h Y2hfdm0uaD4KICNpbXBvcnQgPG1hY2gvdm1fc3RhdGlzdGljcy5oPgogI2ltcG9ydCA8b2JqYy9y dW50aW1lLmg+CisjaW1wb3J0IDxwYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oPgogI2ltcG9ydCA8 cGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaD4KICNpbXBvcnQgPHBhbC9zcGkvY29jb2EvTGF1 bmNoU2VydmljZXNTUEkuaD4KICNpbXBvcnQgPHBhbC9zcGkvbWFjL0hJVG9vbGJveFNQSS5oPgpA QCAtNDA0LDYgKzQwNSw5IEBAIHZvaWQgUGx1Z2luUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXpl UGx1Z2luUHJvY2VzcyhQbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0CiAgICAgLy8gRGlzYWJs ZSBEYXJrIE1vZGUgaW4gdGhlIHBsdWdpbiBwcm9jZXNzIHRvIGF2b2lkIHJlbmRlcmluZyBpc3N1 ZXMuCiAgICAgW05TQXBwIHNldEFwcGVhcmFuY2U6W05TQXBwZWFyYW5jZSBhcHBlYXJhbmNlTmFt ZWQ6TlNBcHBlYXJhbmNlTmFtZUFxdWFdXTsKICNlbmRpZgorI2lmIEhBVkUoTE9BRF9PUFRJTUla RVIpCisgICAgW05TVVJMU2Vzc2lvbiBfZGlzYWJsZUFwcFNTT107CisjZW5kaWYKIH0KIAogdm9p ZCBQbHVnaW5Qcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcm9jZXNzKGNvbnN0IEF1eGlsaWFy eVByb2Nlc3NJbml0aWFsaXphdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRlcnMpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvQXV4aWxpYXJ5UHJvY2Vzc0lPUy5tbSBiL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL2lvcy9BdXhpbGlhcnlQcm9jZXNzSU9TLm1tCmluZGV4IDAwZTI0M2Nm ZDk3YWQyYzI5MzRiNmUyYzUwMjFkZDA0ODk5NjY4ZTIuLmU1ZTk0NmY5NzMzOWFhN2FhZTA3OWRk ODNlNWRlMTI4MTNmOTc1ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9B dXhpbGlhcnlQcm9jZXNzSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lvcy9BdXhp bGlhcnlQcm9jZXNzSU9TLm1tCkBAIC00MywxMCArNDMsNiBAQAogI2ltcG9ydCA8d3RmL3NwaS9k YXJ3aW4vU2FuZGJveFNQSS5oPgogI2VuZGlmCiAKLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RL KQotI2luY2x1ZGUgPFdlYktpdEFkZGl0aW9ucy9BdXhpbGlhcnlQcm9jZXNzQWRkaXRpb25zLmg+ Ci0jZW5kaWYKLQogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHZvaWQgQXV4aWxpYXJ5UHJvY2Vzczo6 cGxhdGZvcm1Jbml0aWFsaXplKCkKQEAgLTU1LDkgKzUxLDYgQEAgdm9pZCBBdXhpbGlhcnlQcm9j ZXNzOjpwbGF0Zm9ybUluaXRpYWxpemUoKQogICAgIGZsb2F0aW5nUG9pbnRFbnZpcm9ubWVudC5l bmFibGVEZW5vcm1hbFN1cHBvcnQoKTsgCiAgICAgZmxvYXRpbmdQb2ludEVudmlyb25tZW50LnNh dmVNYWluVGhyZWFkRW52aXJvbm1lbnQoKTsgCiAgICAgW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRN YW5hZ2VyXSBjaGFuZ2VDdXJyZW50RGlyZWN0b3J5UGF0aDpbW05TQnVuZGxlIG1haW5CdW5kbGVd IGJ1bmRsZVBhdGhdXTsKLSNpZiBIQVZFKExPQURfT1BUSU1JWkVSKQotQVVYSUxJQVJZUFJPQ0VT U19MT0FET1BUSU1JWkVSX0FERElUSU9OUwotI2VuZGlmCiB9CiAKIHZvaWQgQXV4aWxpYXJ5UHJv Y2Vzczo6aW5pdGlhbGl6ZVNhbmRib3goY29uc3QgQXV4aWxpYXJ5UHJvY2Vzc0luaXRpYWxpemF0 aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycywgU2FuZGJveEluaXRpYWxpemF0aW9uUGFyYW1ldGVy cyYgc2FuZGJveFBhcmFtZXRlcnMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9t YWMvQXV4aWxpYXJ5UHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhp bGlhcnlQcm9jZXNzTWFjLm1tCmluZGV4IGFjMGYyZDg3YTJiYTM5ZmU2M2FjNmQwMzQyNjY1ZmUz NDczODY3YzguLmIxNTdmY2JjYzdkYTNkZmJmNWU3M2M5ZjA3ZjBmODc2NzdlZGY4MDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tCkBAIC01 Nyw3ICs1Nyw2IEBACiAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogI2ltcG9ydCA8QXBw bGljYXRpb25TZXJ2aWNlcy9BcHBsaWNhdGlvblNlcnZpY2VzUHJpdi5oPgotI2ltcG9ydCA8V2Vi S2l0QWRkaXRpb25zL0F1eGlsaWFyeVByb2Nlc3NBZGRpdGlvbnMuaD4KICNpbXBvcnQgPHJvb3Rs ZXNzLmg+CiAjZW5kaWYKIApAQCAtMTYwLDkgKzE1OSw2IEBAIHZvaWQgQXV4aWxpYXJ5UHJvY2Vz czo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIHsKICAgICBpbml0aWFsaXplVGltZXJDb2FsZXNjaW5n UG9saWN5KCk7CiAgICAgW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2VyXSBjaGFuZ2VDdXJy ZW50RGlyZWN0b3J5UGF0aDpbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1bmRsZVBhdGhdXTsKLSNp ZiBIQVZFKExPQURfT1BUSU1JWkVSKQotQVVYSUxJQVJZUFJPQ0VTU19MT0FET1BUSU1JWkVSX0FE RElUSU9OUwotI2VuZGlmCiB9CiAKIHN0YXRpYyBPU1N0YXR1cyBlbmFibGVTYW5kYm94U3R5bGVG aWxlUXVhcmFudGluZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29j b2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbQppbmRleCBiOWNlNzlkMjc0YzQxMjdiYTc4ZjU0YTUyZjYzN2U5NWU4 NTFmNmFjLi5iODVjNzE0YzJmMGU4NjU3ZDI1ZmUzYWJjYjM4NWE3NDgzNmMxOWU5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAg LTY3LDYgKzY3LDcgQEAKICNpbXBvcnQgPGFsZ29yaXRobT4KICNpbXBvcnQgPGRpc3BhdGNoL2Rp c3BhdGNoLmg+CiAjaW1wb3J0IDxvYmpjL3J1bnRpbWUuaD4KKyNpbXBvcnQgPHBhbC9zcGkvY2Yv Q0ZOZXR3b3JrU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NmL0NGVXRpbGl0aWVzU1BJLmg+CiAj aW1wb3J0IDxwYWwvc3BpL2NnL0NvcmVHcmFwaGljc1NQSS5oPgogI2ltcG9ydCA8cGFsL3NwaS9j b2NvYS9MYXVuY2hTZXJ2aWNlc1NQSS5oPgpAQCAtNDYxLDYgKzQ2MiwxMCBAQCB2b2lkIFdlYlBy b2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MoY29uc3QgQXV4aWxpYXJ5UHJvY2Vzc0lu aXRpYWxpemF0aW9uUAogI2lmIFVTRShPU19TVEFURSkKICAgICByZWdpc3RlcldpdGhTdGF0ZUR1 bXBlcigpOwogI2VuZGlmCisKKyNpZiBIQVZFKExPQURfT1BUSU1JWkVSKQorICAgIFtOU1VSTFNl c3Npb24gX2Rpc2FibGVBcHBTU09dOworI2VuZGlmCiB9CiAKICNpZiBVU0UoQVBQS0lUKQo=