198832 2019-06-13 08:43:54 -0700 twitch.tv: embedded video hovers down the screen when scrolling on iPad 2019-06-13 11:36:10 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue ggaren simon.fraser oldest_to_newest 1544487 0 koivisto 2019-06-13 08:43:54 -0700 It does. 1544488 1 koivisto 2019-06-13 08:44:22 -0700 <rdar://problem/51541439> 1544490 2 372056 koivisto 2019-06-13 08:55:23 -0700 Created attachment 372056 patch 1544522 3 372056 ggaren 2019-06-13 10:50:41 -0700 Comment on attachment 372056 patch View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review > Source/WebCore/rendering/RenderLayer.cpp:2522 > + if (auto* paintParent = paintOrderParent()) > + paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves? auto* layer = paintOrderParent() ? paintOrderParent() : this; layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); 1544524 4 koivisto 2019-06-13 10:55:02 -0700 I believe that case is impossible and that if() is just being overly defensive. 1544525 5 372056 simon.fraser 2019-06-13 10:58:14 -0700 Comment on attachment 372056 patch View in context: https://bugs.webkit.org/attachment.cgi?id=372056&action=review >> Source/WebCore/rendering/RenderLayer.cpp:2522 >> + paintParent->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); > > This might be a stupid question, but... In the case where paintParent is null, shouldn't we still setDescendantsNeedUpdateBackingAndHierarchyTraversal() on ourselves? > > auto* layer = paintOrderParent() ? paintOrderParent() : this; > layer->setDescendantsNeedUpdateBackingAndHierarchyTraversal(); paintOrderParent() is only null for RenderView, so that should never hit this code. 1544541 6 372056 commit-queue 2019-06-13 11:36:09 -0700 Comment on attachment 372056 patch Clearing flags on attachment: 372056 Committed r246407: <https://trac.webkit.org/changeset/246407> 1544542 7 commit-queue 2019-06-13 11:36:10 -0700 All reviewed patches have been landed. Closing bug. 372056 2019-06-13 08:55:23 -0700 2019-06-13 11:36:09 -0700 patch twitch-scrolling.patch text/plain 5039 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NjQwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE5LTA2LTEzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICB0d2l0Y2gudHY6IGVtYmVkZGVk IHZpZGVvIGhvdmVycyBkb3duIHRoZSBzY3JlZW4gd2hlbiBzY3JvbGxpbmcgb24gaVBhZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4ODMyCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81MTU0MTQzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBjb21wb3NpdGluZy9zY3JvbGxpbmcvYXN5bmMt b3ZlcmZsb3ctc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9sbC1wYWludC1vcmRlci1zaWJsaW5nLmh0 bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJMYXllcjo6c2Nyb2xsVG8pOgorCisgICAgICAgIE92ZXJmbG93IHNjcm9sbCBs YXllciBtYXkgaGF2ZSBjb21wb3NpdGVkIGRlc2NlbmRhbnRzIHRoYXQgYXJlIGl0cyBwYWludCBv cmRlciBzaWJsaW5ncy4gV2UgbmVlZCB0byBpbnZhbGlkYXRlCisgICAgICAgIHRoZSB0cmVlIG9m IHRoZSBwYWludCBvcmRlciBwYXJlbnQgZm9yIGNvbXBvc2l0aW5nIHVwZGF0ZSAoaW5zdGVhZCBv ZiBqdXN0IHRoZSB0cmVlIG9mIHRoZSBvdmVyZmxvdyBzY3JvbGwgbGF5ZXIpLgorCisgICAgICAg IFRoaXMgbWF0Y2hlcyB3aGF0IFJlbmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uKCkgZG9l cy4KKwogMjAxOS0wNi0xMyAgVGFrYXNoaSBLb21vcmkgIDxUYWthc2hpLktvbW9yaUBzb255LmNv bT4KIAogICAgICAgICBbY3VybF0gUmVtb3ZlIG1lbWJlciBvYmplY3RzIG9mIEN1cmxSZXF1ZXN0 IG5vdCB0byBzaGFyZSBieSBkaWZmZXJlbnQgdGhyZWFkcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24gMjQ2MzkxKQorKysgU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUxNSw3 ICsyNTE1LDExIEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnNjcm9sbFRvKGNvbnN0IFNjcm9sbFAKICAg ICAgICAgICAgIC8vIHdoZW4gdGhhdCBjb21wbGV0ZXMuCiAgICAgICAgICAgICBpZiAodXNlc0Nv bXBvc2l0ZWRTY3JvbGxpbmcoKSkgewogICAgICAgICAgICAgICAgIHNldE5lZWRzQ29tcG9zaXRp bmdHZW9tZXRyeVVwZGF0ZSgpOwotICAgICAgICAgICAgICAgIHNldERlc2NlbmRhbnRzTmVlZFVw ZGF0ZUJhY2tpbmdBbmRIaWVyYXJjaHlUcmF2ZXJzYWwoKTsKKworICAgICAgICAgICAgICAgIC8v IFNjcm9sbCBwb3NpdGlvbiBjYW4gYWZmZWN0IHRoZSBsb2NhdGlvbiBvZiBhIGNvbXBvc2l0ZWQg ZGVzY2VuZGFudCAod2hpY2ggbWF5IGJlIGEgc2libGluZyBpbiB6LW9yZGVyKSwKKyAgICAgICAg ICAgICAgICAvLyBzbyB0cmlnZ2VyIGEgZGVzY2VuZGFudCB3YWxrIGZyb20gdGhlIHBhaW50LW9y ZGVyIHBhcmVudC4KKyAgICAgICAgICAgICAgICBpZiAoYXV0byogcGFpbnRQYXJlbnQgPSBwYWlu dE9yZGVyUGFyZW50KCkpCisgICAgICAgICAgICAgICAgICAgIHBhaW50UGFyZW50LT5zZXREZXNj ZW5kYW50c05lZWRVcGRhdGVCYWNraW5nQW5kSGllcmFyY2h5VHJhdmVyc2FsKCk7CiAgICAgICAg ICAgICB9CiAKICAgICAgICAgICAgIHVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzQWZ0ZXJTY3JvbGwo KTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NjM5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA2LTEzICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICB0d2l0Y2gudHY6IGVtYmVkZGVkIHZpZGVv IGhvdmVycyBkb3duIHRoZSBzY3JlZW4gd2hlbiBzY3JvbGxpbmcgb24gaVBhZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4ODMyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MTU0MTQzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL3Njcm9sbGluZy9hc3luYy1vdmVyZmxvdy1z Y3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xsLXBhaW50LW9yZGVyLXNpYmxpbmctZXhwZWN0ZWQuaHRt bDogQWRkZWQuCisgICAgICAgICogY29tcG9zaXRpbmcvc2Nyb2xsaW5nL2FzeW5jLW92ZXJmbG93 LXNjcm9sbGluZy9vdmVyZmxvdy1zY3JvbGwtcGFpbnQtb3JkZXItc2libGluZy5odG1sOiBBZGRl ZC4KKwogMjAxOS0wNi0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW2NhaXJvXVtTVkddIElmIGNsaXBQYXRoIGhhcyBtdWx0aXBsZSBlbGVt ZW50cywgY2xpcC1wYXRoIGRvZXNuJ3Qgd29yayB3aXRoIHRyYW5zZm9ybQpJbmRleDogTGF5b3V0 VGVzdHMvY29tcG9zaXRpbmcvc2Nyb2xsaW5nL2FzeW5jLW92ZXJmbG93LXNjcm9sbGluZy9vdmVy Zmxvdy1zY3JvbGwtcGFpbnQtb3JkZXItc2libGluZy1leHBlY3RlZC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2NvbXBvc2l0aW5nL3Njcm9sbGluZy9hc3luYy1vdmVyZmxvdy1zY3Jv bGxpbmcvb3ZlcmZsb3ctc2Nyb2xsLXBhaW50LW9yZGVyLXNpYmxpbmctZXhwZWN0ZWQuaHRtbAko bm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy9zY3JvbGxpbmcvYXN5bmMt b3ZlcmZsb3ctc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9sbC1wYWludC1vcmRlci1zaWJsaW5nLWV4 cGVjdGVkLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBFIGh0 bWw+IDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgaW50ZXJuYWw6QXN5bmNPdmVyZmxvd1Njcm9s bGluZ0VuYWJsZWQ9dHJ1ZSBdIC0tPgorPHN0eWxlPgorLnNjcm9sbCB7CisgICAgb3ZlcmZsb3c6 c2Nyb2xsOworICAgIHdpZHRoOiA1MDBweDsKKyAgICBoZWlnaHQ6IDUwMHB4OworICAgIGJvcmRl cjogMnB4IHNvbGlkIHllbGxvdzsKK30KKy5jb250ZW50IHsKKyAgICBvdmVyZmxvdzpoaWRkZW47 CisgICAgd2lkdGg6IDUwMHB4OworICAgIGhlaWdodDogMTUwMHB4OworICAgIGJvcmRlcjogMTBw eCBzb2xpZCBncmVlbjsKK30KKy5zdHVmZiB7CisgICAgcG9zaXRpb246cmVsYXRpdmU7CisgICAg dG9wOiAyMDBweDsKKyAgICB3aWR0aDogNTBweDsKKyAgICBoZWlnaHQ6IDUwcHg7CisgICAgYmFj a2dyb3VuZDogcmVkOworfQorPC9zdHlsZT4KKzxkaXYgY2xhc3M9InNjcm9sbCIgaWQ9InNjcm9s bGVyIj4KKyAgICA8ZGl2IGNsYXNzPSJjb250ZW50Ij4KKyAgICAgICAgPGRpdiBjbGFzcz0ic3R1 ZmYiPgorICAgICAgICA8L2Rpdj4KKyAgICA8L2Rpdj4KKzwvZGl2PgorPHNjcmlwdD4KK3Njcm9s bGVyLnNjcm9sbFRvKDAsIDEwMCk7Cis8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL2NvbXBv c2l0aW5nL3Njcm9sbGluZy9hc3luYy1vdmVyZmxvdy1zY3JvbGxpbmcvb3ZlcmZsb3ctc2Nyb2xs LXBhaW50LW9yZGVyLXNpYmxpbmcuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9jb21w b3NpdGluZy9zY3JvbGxpbmcvYXN5bmMtb3ZlcmZsb3ctc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9s bC1wYWludC1vcmRlci1zaWJsaW5nLmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMv Y29tcG9zaXRpbmcvc2Nyb2xsaW5nL2FzeW5jLW92ZXJmbG93LXNjcm9sbGluZy9vdmVyZmxvdy1z Y3JvbGwtcGFpbnQtb3JkZXItc2libGluZy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MzIgQEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGludGVybmFs OkFzeW5jT3ZlcmZsb3dTY3JvbGxpbmdFbmFibGVkPXRydWUgXSAtLT4KKzxzdHlsZT4KKy5zY3Jv bGwgeworICAgIG92ZXJmbG93OnNjcm9sbDsKKyAgICB3aWR0aDogNTAwcHg7CisgICAgaGVpZ2h0 OiA1MDBweDsKKyAgICBib3JkZXI6IDJweCBzb2xpZCB5ZWxsb3c7Cit9CisuY29udGVudCB7Cisg ICAgb3ZlcmZsb3c6aGlkZGVuOworICAgIHdpZHRoOiA1MDBweDsKKyAgICBoZWlnaHQ6IDE1MDBw eDsKKyAgICBib3JkZXI6IDEwcHggc29saWQgZ3JlZW47Cit9Cisuc3R1ZmYgeworICAgIHBvc2l0 aW9uOnJlbGF0aXZlOworICAgIHRvcDogMjAwcHg7CisgICAgd2lkdGg6IDUwcHg7CisgICAgaGVp Z2h0OiA1MHB4OworICAgIGJhY2tncm91bmQ6IHJlZDsKKyAgICB3aWxsLWNoYW5nZTp0cmFuc2Zv cm07Cit9Cis8L3N0eWxlPgorPGRpdiBjbGFzcz0ic2Nyb2xsIiBpZD0ic2Nyb2xsZXIiPgorICAg IDxkaXYgY2xhc3M9ImNvbnRlbnQiPgorICAgICAgICA8ZGl2IGNsYXNzPSJzdHVmZiI+CisgICAg ICAgIDwvZGl2PgorICAgIDwvZGl2PgorPC9kaXY+Cis8c2NyaXB0Pgorc2Nyb2xsZXIuc2Nyb2xs VG8oMCwgMTAwKTsKKzwvc2NyaXB0Pgo=