198799 2019-06-12 13:06:23 -0700 [iOS] Adjust tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html following r243808 2019-06-12 16:08:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 dbates dbates bfulgham megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1544201 0 dbates 2019-06-12 13:06:23 -0700 Following r243808 (bug #196272) we no longer defocus a <select> on iPad when its popover is dismissed as a result of picking a value for it. This is to make behavior of <select> on iPad like the Mac. We need to update the tests platform/ipad/fast/forms/{select-form-run-twice, unfocus-inside-fixed-hittest}.html to not expect the defocusing of the <select>, which they observe by way of registering for a uiController.didEndFormControlInteractionCallback callback. 1544202 1 dbates 2019-06-12 13:06:48 -0700 <rdar://problem/50181023> 1544204 2 371982 dbates 2019-06-12 13:09:16 -0700 Created attachment 371982 Patch 1544215 3 371982 bfulgham 2019-06-12 13:38:37 -0700 Comment on attachment 371982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371982&action=review > LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html:56 > + uiController.uiScriptComplete() Nit: Semicolon at end of statement. 1544276 4 dbates 2019-06-12 16:06:05 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 371982 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371982&action=review > > > LayoutTests/platform/ipad/fast/forms/select-form-run-twice.html:56 > > + uiController.uiScriptComplete() > > Nit: Semicolon at end of statement. It's JavaScript. Automatic semicolon insertion applies 😀 <-- seriously, this is language feature. I'll add the semicolon just because I like the aesthetics. 1544277 5 371996 dbates 2019-06-12 16:07:05 -0700 Created attachment 371996 To land 1544278 6 dbates 2019-06-12 16:08:02 -0700 Committed r246386: <https://trac.webkit.org/changeset/246386> 371982 2019-06-12 13:09:16 -0700 2019-06-12 16:07:04 -0700 Patch bug-198799-20190612130915.patch text/plain 3044 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWQ5YmM2Zjk2YjhmZTI4MWVlZGEx YTNjMjM4YmVkMTcwZDcxM2RkOC4uMTQzZjc3YTU2MzY5OGRkM2I3MmE0OWZlN2ZjNjY1MGMxNjBl MTdiNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTEyICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBZGp1c3QgdGVzdHMgcGxhdGZvcm0v aXBhZC9mYXN0L2Zvcm1zL3tzZWxlY3QtZm9ybS1ydW4tdHdpY2UsIHVuZm9jdXMtaW5zaWRlLWZp eGVkLWhpdHRlc3R9Lmh0bWwgZm9sbG93aW5nIHIyNDM4MDgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODc5OQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTAxODEwMjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRm9sbG93aW5nIHIyNDM4MDggd2Ugbm8gbG9uZ2VyIGRlZm9jdXMgYSA8c2VsZWN0PiBv biBpUGFkIHdoZW4gaXRzIHBvcG92ZXIgaXMgZGlzbWlzc2VkIGFzIGEKKyAgICAgICAgcmVzdWx0 IG9mIHBpY2tpbmcgYSB2YWx1ZSBmb3IgaXQuIFRoaXMgaXMgdG8gbWFrZSB0aGUgYmVoYXZpb3Ig b2YgPHNlbGVjdD4gb24gaVBhZCBsaWtlIHRoZSBNYWMuIAorICAgICAgICBIb3dldmVyIHRoZSB0 ZXN0cyBwbGF0Zm9ybS9pcGFkL2Zhc3QvZm9ybXMve3NlbGVjdC1mb3JtLXJ1bi10d2ljZSwgdW5m b2N1cy1pbnNpZGUtZml4ZWQtaGl0dGVzdH0uaHRtbAorICAgICAgICBkZXBlbmQgb24gdGhlIG9s ZCBiZWhhdmlvci4gU28sIHdlIG5lZWQgdG8gdXBkYXRlIHRoZW0gdG8gbm8gbG9uZ2VyIGV4cGVj dCBhIGRlZm9jdXNpbmcgb2YgdGhlCisgICAgICAgIDxzZWxlY3Q+L3RoZSBlbmQgb2YgZm9ybSBj b250cm9sIGludGVyYWN0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vaXBhZC9mYXN0L2Zvcm1z L3NlbGVjdC1mb3JtLXJ1bi10d2ljZS5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2lwYWQvZmFz dC9mb3Jtcy91bmZvY3VzLWluc2lkZS1maXhlZC1oaXR0ZXN0Lmh0bWw6CisKIDIwMTktMDYtMTEg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFkanVz dCB0ZXN0IGZhc3QvZXZlbnRzL2lvcy9rZXl1cC5odG1sIHRvIGlnbm9yZSBTaGlmdCBrZXl1cHMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lwYWQvZmFzdC9mb3Jtcy9zZWxlY3Qt Zm9ybS1ydW4tdHdpY2UuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lwYWQvZmFzdC9mb3Jt cy9zZWxlY3QtZm9ybS1ydW4tdHdpY2UuaHRtbAppbmRleCAzZDg1NGZkOTlkZmRiYWJhYjIwY2Yw MTk2ZTViYjhmMGI2Yzg3MzAwLi40ZDY5MjNlZmZhZDE3MWMxOGE1ZmFmNjUxOWQ0YjNlNjQ4NzJm MzQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pcGFkL2Zhc3QvZm9ybXMvc2Vs ZWN0LWZvcm0tcnVuLXR3aWNlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaXBhZC9m YXN0L2Zvcm1zL3NlbGVjdC1mb3JtLXJ1bi10d2ljZS5odG1sCkBAIC01MywxMCArNTMsNyBAQAog ICAgICAgICAgICAgICAgIChmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICAgICAgdWlDb250 cm9sbGVyLmRpZFN0YXJ0Rm9ybUNvbnRyb2xJbnRlcmFjdGlvbkNhbGxiYWNrID0gZnVuY3Rpb24o KSB7CiAgICAgICAgICAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIuc2VsZWN0Rm9ybUFjY2Vz c29yeVBpY2tlclJvdygke3Jvd30pOwotICAgICAgICAgICAgICAgICAgICB9OwotCi0gICAgICAg ICAgICAgICAgICAgIHVpQ29udHJvbGxlci5kaWRFbmRGb3JtQ29udHJvbEludGVyYWN0aW9uQ2Fs bGJhY2sgPSBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIHVpQ29udHJvbGxl ci51aVNjcmlwdENvbXBsZXRlKCk7CisgICAgICAgICAgICAgICAgICAgICAgICB1aUNvbnRyb2xs ZXIudWlTY3JpcHRDb21wbGV0ZSgpCiAgICAgICAgICAgICAgICAgICAgIH07CiAKICAgICAgICAg ICAgICAgICAgICAgdWlDb250cm9sbGVyLnNpbmdsZVRhcEF0UG9pbnQoJHt4fSwgJHt5fSwgZnVu Y3Rpb24oKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pcGFkL2Zhc3QvZm9y bXMvdW5mb2N1cy1pbnNpZGUtZml4ZWQtaGl0dGVzdC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vaXBhZC9mYXN0L2Zvcm1zL3VuZm9jdXMtaW5zaWRlLWZpeGVkLWhpdHRlc3QuaHRtbAppbmRl eCBiYmM4ZTMzZjFiYTJlMmIzODg3YzA0YTIxMDNlYmUxZWIwNjgyMzFmLi5mOWJlYjI0ZTI2ZDZh ZjA3NmMyYjYyNTdiODQ4YjBjMDYxYzI2MmIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9pcGFkL2Zhc3QvZm9ybXMvdW5mb2N1cy1pbnNpZGUtZml4ZWQtaGl0dGVzdC5odG1sCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lwYWQvZmFzdC9mb3Jtcy91bmZvY3VzLWluc2lkZS1m aXhlZC1oaXR0ZXN0Lmh0bWwKQEAgLTUzLDkgKzUzLDYgQEAKICAgICAgICAgICAgICAgICAoZnVu Y3Rpb24oKSB7CiAgICAgICAgICAgICAgICAgICAgIHVpQ29udHJvbGxlci5kaWRTdGFydEZvcm1D b250cm9sSW50ZXJhY3Rpb25DYWxsYmFjayA9IGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgICAg ICAgICAgICAgdWlDb250cm9sbGVyLnNlbGVjdEZvcm1BY2Nlc3NvcnlQaWNrZXJSb3coNSk7Ci0g ICAgICAgICAgICAgICAgICAgIH07Ci0KLSAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVy LmRpZEVuZEZvcm1Db250cm9sSW50ZXJhY3Rpb25DYWxsYmFjayA9IGZ1bmN0aW9uKCkgewogICAg ICAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKICAg ICAgICAgICAgICAgICAgICAgfTsKIAo= 371996 2019-06-12 16:07:05 -0700 2019-06-12 16:07:05 -0700 To land bug-198799-20190612160704.patch text/plain 2909 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2Mzg1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjg5N2NiY2Q0MmQ4NmUxZTUxMzJi M2QxNThkM2UzNjU3ZTg4MGE5Ni4uNzYxMDBlYWE0Mjc5ZjBhMTRkYTAzMTc2ZGQyOTZlMzQ3NGEz OWM3NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTEyICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBZGp1c3QgdGVzdHMgcGxhdGZvcm0v aXBhZC9mYXN0L2Zvcm1zL3tzZWxlY3QtZm9ybS1ydW4tdHdpY2UsIHVuZm9jdXMtaW5zaWRlLWZp eGVkLWhpdHRlc3R9Lmh0bWwgZm9sbG93aW5nIHIyNDM4MDgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODc5OQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTAxODEwMjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAg ICAgICBGb2xsb3dpbmcgcjI0MzgwOCB3ZSBubyBsb25nZXIgZGVmb2N1cyBhIDxzZWxlY3Q+IG9u IGlQYWQgd2hlbiBpdHMgcG9wb3ZlciBpcyBkaXNtaXNzZWQgYXMgYQorICAgICAgICByZXN1bHQg b2YgcGlja2luZyBhIHZhbHVlIGZvciBpdC4gVGhpcyBpcyB0byBtYWtlIHRoZSBiZWhhdmlvciBv ZiA8c2VsZWN0PiBvbiBpUGFkIGxpa2UgdGhlIE1hYy4gCisgICAgICAgIEhvd2V2ZXIgdGhlIHRl c3RzIHBsYXRmb3JtL2lwYWQvZmFzdC9mb3Jtcy97c2VsZWN0LWZvcm0tcnVuLXR3aWNlLCB1bmZv Y3VzLWluc2lkZS1maXhlZC1oaXR0ZXN0fS5odG1sCisgICAgICAgIGRlcGVuZCBvbiB0aGUgb2xk IGJlaGF2aW9yLiBTbywgd2UgbmVlZCB0byB1cGRhdGUgdGhlbSB0byBubyBsb25nZXIgZXhwZWN0 IGEgZGVmb2N1c2luZyBvZiB0aGUKKyAgICAgICAgPHNlbGVjdD4vdGhlIGVuZCBvZiBmb3JtIGNv bnRyb2wgaW50ZXJhY3Rpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pcGFkL2Zhc3QvZm9ybXMv c2VsZWN0LWZvcm0tcnVuLXR3aWNlLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vaXBhZC9mYXN0 L2Zvcm1zL3VuZm9jdXMtaW5zaWRlLWZpeGVkLWhpdHRlc3QuaHRtbDoKKwogMjAxOS0wNi0xMiAg TXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXSExT TF0gRWR1Y2F0ZSB0aGUgcHJvcGVydHkgcmVzb2x2ZXIgYWJvdXQgSW5kZXhFeHByZXNzaW9ucwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaXBhZC9mYXN0L2Zvcm1zL3NlbGVjdC1m b3JtLXJ1bi10d2ljZS5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaXBhZC9mYXN0L2Zvcm1z L3NlbGVjdC1mb3JtLXJ1bi10d2ljZS5odG1sCmluZGV4IDNkODU0ZmQ5OWRmZGJhYmFiMjBjZjAx OTZlNWJiOGYwYjZjODczMDAuLmYzMzBhMmM4NDQ3YmJhZjJiNTYzMDhmMjcxY2Y0ZDI1M2NiNmVk MjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lwYWQvZmFzdC9mb3Jtcy9zZWxl Y3QtZm9ybS1ydW4tdHdpY2UuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pcGFkL2Zh c3QvZm9ybXMvc2VsZWN0LWZvcm0tcnVuLXR3aWNlLmh0bWwKQEAgLTUzLDkgKzUzLDYgQEAKICAg ICAgICAgICAgICAgICAoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICAgICAgIHVpQ29udHJv bGxlci5kaWRTdGFydEZvcm1Db250cm9sSW50ZXJhY3Rpb25DYWxsYmFjayA9IGZ1bmN0aW9uKCkg ewogICAgICAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnNlbGVjdEZvcm1BY2Nlc3Nv cnlQaWNrZXJSb3coJHtyb3d9KTsKLSAgICAgICAgICAgICAgICAgICAgfTsKLQotICAgICAgICAg ICAgICAgICAgICB1aUNvbnRyb2xsZXIuZGlkRW5kRm9ybUNvbnRyb2xJbnRlcmFjdGlvbkNhbGxi YWNrID0gZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIu dWlTY3JpcHRDb21wbGV0ZSgpOwogICAgICAgICAgICAgICAgICAgICB9OwogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pcGFkL2Zhc3QvZm9ybXMvdW5mb2N1cy1pbnNpZGUtZml4 ZWQtaGl0dGVzdC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaXBhZC9mYXN0L2Zvcm1zL3Vu Zm9jdXMtaW5zaWRlLWZpeGVkLWhpdHRlc3QuaHRtbAppbmRleCBiYmM4ZTMzZjFiYTJlMmIzODg3 YzA0YTIxMDNlYmUxZWIwNjgyMzFmLi5mOWJlYjI0ZTI2ZDZhZjA3NmMyYjYyNTdiODQ4YjBjMDYx YzI2MmIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pcGFkL2Zhc3QvZm9ybXMv dW5mb2N1cy1pbnNpZGUtZml4ZWQtaGl0dGVzdC5odG1sCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2lwYWQvZmFzdC9mb3Jtcy91bmZvY3VzLWluc2lkZS1maXhlZC1oaXR0ZXN0Lmh0bWwKQEAg LTUzLDkgKzUzLDYgQEAKICAgICAgICAgICAgICAgICAoZnVuY3Rpb24oKSB7CiAgICAgICAgICAg ICAgICAgICAgIHVpQ29udHJvbGxlci5kaWRTdGFydEZvcm1Db250cm9sSW50ZXJhY3Rpb25DYWxs YmFjayA9IGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVy LnNlbGVjdEZvcm1BY2Nlc3NvcnlQaWNrZXJSb3coNSk7Ci0gICAgICAgICAgICAgICAgICAgIH07 Ci0KLSAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLmRpZEVuZEZvcm1Db250cm9sSW50 ZXJhY3Rpb25DYWxsYmFjayA9IGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgICAgICAgICAgICAg dWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKICAgICAgICAgICAgICAgICAgICAgfTsK IAo=