198768 2019-06-11 15:11:47 -0700 [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups 2019-06-11 16:01:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All iOS 12 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates bfulgham webkit-bug-importer webkit.review.bot oldest_to_newest 1543848 0 dbates 2019-06-11 15:11:47 -0700 In the future WebKit will receive flag changes (e.g. the Shift key was pressed). When this happens the test fast/events/ios/keyup.html will fail due to additional Shift keyup events. Fix up the test to ignore Shift keyups. We have other tests that cover the Shift keyups that will be enabled in the future. 1543849 1 dbates 2019-06-11 15:12:01 -0700 <rdar://problem/46082743> 1543850 2 371885 dbates 2019-06-11 15:13:47 -0700 Created attachment 371885 Patch 1543855 3 371885 bfulgham 2019-06-11 15:56:13 -0700 Comment on attachment 371885 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371885&action=review > LayoutTests/ChangeLog:10 > + currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. Is there a radar we can reference for the UIKit update? 1543856 4 dbates 2019-06-11 15:59:31 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 371885 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371885&action=review > > > LayoutTests/ChangeLog:10 > > + currently skipped in OpenSource that will be unskipped in the future once UIKit support is available. > > Is there a radar we can reference for the UIKit update? It would take me time to track them down and there is likely more than one. Short answer once we start building with ENABLE(FULL_KEYBOARD_ACCESS) in OpenSource then the time will be right to unkip many tests. Will update ChangeLog before landing. 1543859 5 371888 dbates 2019-06-11 16:00:35 -0700 Created attachment 371888 To land 1543860 6 dbates 2019-06-11 16:01:04 -0700 Committed r246338: <https://trac.webkit.org/changeset/246338> 371885 2019-06-11 15:13:47 -0700 2019-06-11 16:00:34 -0700 Patch bug-198768-20190611151347.patch text/plain 2069 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDVhYjNkMjRlNDA4OGRhMjhhNWZl MTQyZjJkYzI1MjM1NDFlOGFjMy4uYWQ5YmM2Zjk2YjhmZTI4MWVlZGExYTNjMjM4YmVkMTcwZDcx M2RkOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA2LTExICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBZGp1c3QgdGVzdCBmYXN0L2V2ZW50 cy9pb3Mva2V5dXAuaHRtbCB0byBpZ25vcmUgU2hpZnQga2V5dXBzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg3NjgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ2MDgyNzQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIElnbm9yZSBTaGlmdCBrZXl1cHMgYXMgaW4gdGhlIGZ1dHVyZSB0aGV5IHdpbGwg YmUgZW1pdHRlZC4gV2UgaGF2ZSBleGlzdGluZyB0ZXN0IGNvdmVyYWdlIGZvciB0aGVtCisgICAg ICAgIGN1cnJlbnRseSBza2lwcGVkIGluIE9wZW5Tb3VyY2UgdGhhdCB3aWxsIGJlIHVuc2tpcHBl ZCBpbiB0aGUgZnV0dXJlIG9uY2UgVUlLaXQgc3VwcG9ydCBpcyBhdmFpbGFibGUuIAorCisgICAg ICAgICogZmFzdC9ldmVudHMvaW9zL2tleXVwLmh0bWw6CisKIDIwMTktMDYtMTEgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEltcG9ydCBDb250ZW50IFNlY3Vy aXR5IFBvbGljeSBXZWIgUGxhdGZvcm0gVGVzdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2lvcy9rZXl1cC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2tl eXVwLmh0bWwKaW5kZXggNWYwYTliOWE4MmZkNTYyNzYyZmJiNzgxOGUzZDBhNDhkZjM3M2I4Ni4u M2FlODcxNThjZDBiZjU5OTYzZjdlZTk0MDRkNjdjMzllN2FhYzg0ZSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2tleXVwLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvaW9zL2tleXVwLmh0bWwKQEAgLTI2LDEwICsyNiwxNSBAQCBmdW5jdGlvbiBsb2co bWVzc2FnZSkKIAogZnVuY3Rpb24gbG9nS2V5RXZlbnQoZXZlbnQpCiB7Ci0gICAgbGV0IHBpZWNl cyA9IFtdOwotICAgIGZvciAobGV0IHByb3BlcnR5TmFtZSBvZiBbInR5cGUiLCAia2V5IiwgImNv ZGUiLCAia2V5SWRlbnRpZmllciIsICJrZXlDb2RlIiwgImNoYXJDb2RlIiwgImtleUNvZGUiLCAi d2hpY2giXSkKLSAgICAgICAgcGllY2VzLnB1c2goYCR7cHJvcGVydHlOYW1lfTogJHtldmVudFtw cm9wZXJ0eU5hbWVdfWApOwotICAgIGxvZyhwaWVjZXMuam9pbigiLCAiKSk7CisgICAgLy8gSWdu b3JlIFNoaWZ0IGtleXVwcywgaWYgdGhleSBhcmUgZGlzcGF0Y2hlZCwgYXMgbm90IGFsbCB2ZXJz aW9ucyBvZiBpT1MgZGlzcGF0Y2ggdGhlbS4KKyAgICBpZiAoZXZlbnQua2V5ID09ICJTaGlmdCIp CisgICAgICAgICsrbnVtYmVyT2ZGaXJlZEtleUV2ZW50c0ZvclRlc3RDb21wbGV0ZTsKKyAgICBp ZiAoZXZlbnQua2V5ICE9PSAiU2hpZnQiKSB7CisgICAgICAgIGxldCBwaWVjZXMgPSBbXTsKKyAg ICAgICAgZm9yIChsZXQgcHJvcGVydHlOYW1lIG9mIFsidHlwZSIsICJrZXkiLCAiY29kZSIsICJr ZXlJZGVudGlmaWVyIiwgImtleUNvZGUiLCAiY2hhckNvZGUiLCAia2V5Q29kZSIsICJ3aGljaCJd KQorICAgICAgICAgICAgcGllY2VzLnB1c2goYCR7cHJvcGVydHlOYW1lfTogJHtldmVudFtwcm9w ZXJ0eU5hbWVdfWApOworICAgICAgICBsb2cocGllY2VzLmpvaW4oIiwgIikpOworICAgIH0KICAg ICBpZiAoKytudW1iZXJPZkZpcmVkS2V5RXZlbnRzID49IG51bWJlck9mRmlyZWRLZXlFdmVudHNG b3JUZXN0Q29tcGxldGUgJiYgd2luZG93LnRlc3RSdW5uZXIpCiAgICAgICAgIHRlc3RSdW5uZXIu bm90aWZ5RG9uZSgpOwogfQo= 371888 2019-06-11 16:00:35 -0700 2019-06-11 16:00:35 -0700 To land bug-198768-20190611160034.patch text/plain 2067 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDAzYmMwZmNiNjRlODZmYjVkM2I5 NDdjNDdkZDgwZTM5ZTg1ZmIxNC4uNjZmYzIyYjk4NTZlYTllZDNiNTViN2E1Y2I4NzVlMDY5ZTZh Y2U3ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA2LTExICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBZGp1c3QgdGVzdCBmYXN0L2V2ZW50 cy9pb3Mva2V5dXAuaHRtbCB0byBpZ25vcmUgU2hpZnQga2V5dXBzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg3NjgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ2MDgyNzQzPgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisK KyAgICAgICAgSWdub3JlIFNoaWZ0IGtleXVwcyBhcyBpbiB0aGUgZnV0dXJlIHRoZXkgd2lsbCBi ZSBlbWl0dGVkLiBXZSBoYXZlIGV4aXN0aW5nIHRlc3QgY292ZXJhZ2UgZm9yIHRoZW0KKyAgICAg ICAgY3VycmVudGx5IHNraXBwZWQgaW4gT3BlblNvdXJjZSB0aGF0IHdpbGwgYmUgdW5za2lwcGVk IGluIHRoZSBmdXR1cmUgb25jZSB3ZSBlbmFibGUgRU5BQkxFKEZVTExfS0VZQk9BUkRfQUNDRVNT KS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2lvcy9rZXl1cC5odG1sOgorCiAyMDE5LTA2LTEx ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdXAgdGVz dCByZXN1bHQgZm9sbG93aW5nIHIyNDUxNjEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy9pb3Mva2V5dXAuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9rZXl1 cC5odG1sCmluZGV4IDVmMGE5YjlhODJmZDU2Mjc2MmZiYjc4MThlM2QwYTQ4ZGYzNzNiODYuLjNh ZTg3MTU4Y2QwYmY1OTk2M2Y3ZWU5NDA0ZDY3YzM5ZTdhYWM4NGUgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9rZXl1cC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2lvcy9rZXl1cC5odG1sCkBAIC0yNiwxMCArMjYsMTUgQEAgZnVuY3Rpb24gbG9nKG1l c3NhZ2UpCiAKIGZ1bmN0aW9uIGxvZ0tleUV2ZW50KGV2ZW50KQogewotICAgIGxldCBwaWVjZXMg PSBbXTsKLSAgICBmb3IgKGxldCBwcm9wZXJ0eU5hbWUgb2YgWyJ0eXBlIiwgImtleSIsICJjb2Rl IiwgImtleUlkZW50aWZpZXIiLCAia2V5Q29kZSIsICJjaGFyQ29kZSIsICJrZXlDb2RlIiwgIndo aWNoIl0pCi0gICAgICAgIHBpZWNlcy5wdXNoKGAke3Byb3BlcnR5TmFtZX06ICR7ZXZlbnRbcHJv cGVydHlOYW1lXX1gKTsKLSAgICBsb2cocGllY2VzLmpvaW4oIiwgIikpOworICAgIC8vIElnbm9y ZSBTaGlmdCBrZXl1cHMsIGlmIHRoZXkgYXJlIGRpc3BhdGNoZWQsIGFzIG5vdCBhbGwgdmVyc2lv bnMgb2YgaU9TIGRpc3BhdGNoIHRoZW0uCisgICAgaWYgKGV2ZW50LmtleSA9PSAiU2hpZnQiKQor ICAgICAgICArK251bWJlck9mRmlyZWRLZXlFdmVudHNGb3JUZXN0Q29tcGxldGU7CisgICAgaWYg KGV2ZW50LmtleSAhPT0gIlNoaWZ0IikgeworICAgICAgICBsZXQgcGllY2VzID0gW107CisgICAg ICAgIGZvciAobGV0IHByb3BlcnR5TmFtZSBvZiBbInR5cGUiLCAia2V5IiwgImNvZGUiLCAia2V5 SWRlbnRpZmllciIsICJrZXlDb2RlIiwgImNoYXJDb2RlIiwgImtleUNvZGUiLCAid2hpY2giXSkK KyAgICAgICAgICAgIHBpZWNlcy5wdXNoKGAke3Byb3BlcnR5TmFtZX06ICR7ZXZlbnRbcHJvcGVy dHlOYW1lXX1gKTsKKyAgICAgICAgbG9nKHBpZWNlcy5qb2luKCIsICIpKTsKKyAgICB9CiAgICAg aWYgKCsrbnVtYmVyT2ZGaXJlZEtleUV2ZW50cyA+PSBudW1iZXJPZkZpcmVkS2V5RXZlbnRzRm9y VGVzdENvbXBsZXRlICYmIHdpbmRvdy50ZXN0UnVubmVyKQogICAgICAgICB0ZXN0UnVubmVyLm5v dGlmeURvbmUoKTsKIH0K