198707 2019-06-09 23:40:00 -0700 [GTK] The Previous/Next gesture should handle RTL 2019-06-20 08:56:00 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Linux RESOLVED FIXED P2 Normal --- 1 kekun.plazas webkit-unassigned alicem berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo kekun.plazas mcatanzaro oldest_to_newest 1543263 0 kekun.plazas 2019-06-09 23:40:00 -0700 The Previous/Next gesture (two-fingers horizontal drag) should be inversed on RTL languages, as the newer page should move to/come from the left instead of the right. This affects GNOME Web: https://gitlab.gnome.org/GNOME/epiphany/issues/820. 1546479 1 alicem 2019-06-20 02:28:14 -0700 Hm, it looks like WebKit in general doesn't support at least GtkInspector's text direction override. Scrollbars are still on the right, for example. 1546484 2 alicem 2019-06-20 02:47:40 -0700 Nevermind, it seems to be flipped for RTL pages only. However, `m_webPageProxy.userInterfaceLayoutDirection()` seems to always return LTR direction, which is why it doesn't work. I wonder if it would work with an actual RTL locale. Other than that, I need to adjust `ViewGestureController::PendingSwipeTracker::scrollEventGetScrollingDeltas()` and drawing. The pages comes from the correct side, but the order is reversed: the current page is on the bottom when you're going back, and on the top if you're going forward. It should be the other way. 1546503 3 372552 alicem 2019-06-20 07:18:26 -0700 Created attachment 372552 Patch 1546505 4 ews-watchlist 2019-06-20 07:22:04 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1546509 5 mcatanzaro 2019-06-20 07:32:50 -0700 (In reply to Alexander Mikhaylenko from comment #2) > Nevermind, it seems to be flipped for RTL pages only. > > However, `m_webPageProxy.userInterfaceLayoutDirection()` seems to always > return LTR direction, which is why it doesn't work. > > I wonder if it would work with an actual RTL locale. Currently we have this in our PageClientImpl.h: WebCore::UserInterfaceLayoutDirection userInterfaceLayoutDirection() override { return WebCore::UserInterfaceLayoutDirection::LTR; } Something like this in our PageClientImpl.cpp would probably suffice: WebCore::UserInterfaceLayoutDirection PageClientImpl::userInterfaceLayoutDirection() { return gtk_widget_get_direction(m_viewWidget) == GTK_TEXT_DIR_RTL ? WebCore::UserInterfaceLayoutDirection::RTL : WebCore::UserInterfaceLayoutDirection::LTR; } 1546510 6 mcatanzaro 2019-06-20 07:33:23 -0700 Next time, I should read your patch *before* wasting time investigating the problem you've already solved. :) 1546511 7 372552 mcatanzaro 2019-06-20 07:34:50 -0700 Comment on attachment 372552 Patch This could improve a bunch of layout test results. I suppose we'll find out. 1546534 8 372552 commit-queue 2019-06-20 08:55:58 -0700 Comment on attachment 372552 Patch Clearing flags on attachment: 372552 Committed r246635: <https://trac.webkit.org/changeset/246635> 1546535 9 commit-queue 2019-06-20 08:56:00 -0700 All reviewed patches have been landed. Closing bug. 372552 2019-06-20 07:18:26 -0700 2019-06-20 08:55:58 -0700 Patch bug-198707-20190620191824.patch text/plain 6507 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNhMjQ1YmViMzk2OWMxNTll NjdlNTE4YzU1MWI3OGMyNGE4YWU0OGEuLjIzOGFjOTljNGExMGI3NGI5NjYwNzdjYTkwZjYzN2Zl MWQ0NDM3MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDYtMjAgIEFsZXhhbmRl ciBNaWtoYXlsZW5rbyAgPGV4YWxtNzY1OUBnbWFpbC5jb20+CisKKyAgICAgICAgW0dUS10gVGhl IFByZXZpb3VzL05leHQgZ2VzdHVyZSBzaG91bGQgaGFuZGxlIFJUTAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NzA3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGdlc3R1cmUgdXNlcyBQYWdlQ2xp ZW50SW1wbDo6dXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbigpIHRvIGRldGVybWluZSB0aGUg dGV4dAorICAgICAgICBkaXJlY3Rpb24uIEltcGxlbWVudCB0aGF0IG1ldGhvZCwgdGhlbiBhZGp1 c3QgZHJhd2luZyBzbyB0aGF0IHRoZSBwYWdlcyBtb3ZlIGZyb20vdG8KKyAgICAgICAgdGhlIGxl ZnQgaW5zdGVhZCBvZiByaWdodCBzaWRlIGZvciBSVEwgbG9jYWxlcy4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6KTog SW1wbGVtZW50ZWQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwu aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1ZpZXdHZXN0dXJlQ29udHJvbGxlckd0ay5jcHA6 CisgICAgICAgIChXZWJLaXQ6OlZpZXdHZXN0dXJlQ29udHJvbGxlcjo6ZHJhdyk6CisKIDIwMTkt MDYtMTkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBVcGRhdGUgcHJldmlldyBBUEkgZGVwcmVjYXRpb24gbWVzc2FnZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggZDdm OWY5OWU0NTIwYTgyYWVhMGMzYTk1ZWY5OTFmNjBkNjk0YTQyNy4uNjQ4MjI5OGYzN2IxMzk2MTcz ZGU4M2IwZWMyYzk1NWMxNDJjODUyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKQEAgLTUzOCw2ICs1MzgsMTUgQEAgdm9pZCBQ YWdlQ2xpZW50SW1wbDo6cmVxdWVzdERPTVBhc3RlQWNjZXNzKGNvbnN0IEludFJlY3QmLCBjb25z dCBTdHJpbmcmLCBDb21wbGUKICAgICBjb21wbGV0aW9uSGFuZGxlcihXZWJDb3JlOjpET01QYXN0 ZUFjY2Vzc1Jlc3BvbnNlOjpEZW5pZWRGb3JHZXN0dXJlKTsKIH0KIAorVXNlckludGVyZmFjZUxh eW91dERpcmVjdGlvbiBQYWdlQ2xpZW50SW1wbDo6dXNlckludGVyZmFjZUxheW91dERpcmVjdGlv bigpCit7CisgICAgR3RrVGV4dERpcmVjdGlvbiBkaXJlY3Rpb24gPSBndGtfd2lkZ2V0X2dldF9k aXJlY3Rpb24obV92aWV3V2lkZ2V0KTsKKyAgICBpZiAoZGlyZWN0aW9uID09IEdUS19URVhUX0RJ Ul9SVEwpCisgICAgICAgIHJldHVybiBVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uOjpSVEw7 CisKKyAgICByZXR1cm4gVXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbjo6TFRSOworfQorCiBi b29sIFBhZ2VDbGllbnRJbXBsOjplZmZlY3RpdmVBcHBlYXJhbmNlSXNEYXJrKCkgY29uc3QKIHsK ICAgICBhdXRvKiBzZXR0aW5ncyA9IGd0a193aWRnZXRfZ2V0X3NldHRpbmdzKG1fdmlld1dpZGdl dCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGll bnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBs LmgKaW5kZXggOWFmMWU4NDgwOTg0MGE3YjJhZmE3Y2E0MWJmZTFkN2YzNDNhOWZiOS4uNTU4Mjgx MTE2YzU1NmQyOGZmMjhlNzBjZGMzMDY0ZDYyNDdlNDNjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaApAQCAtMTYxLDcgKzE2MSw3IEBA IHByaXZhdGU6CiAgICAgYm9vbCBkZWNpZGVQb2xpY3lGb3JJbnN0YWxsTWlzc2luZ01lZGlhUGx1 Z2luc1Blcm1pc3Npb25SZXF1ZXN0KEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lv blJlcXVlc3QmKSBvdmVycmlkZTsKICNlbmRpZgogCi0gICAgV2ViQ29yZTo6VXNlckludGVyZmFj ZUxheW91dERpcmVjdGlvbiB1c2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uKCkgb3ZlcnJpZGUg eyByZXR1cm4gV2ViQ29yZTo6VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbjo6TFRSOyB9Cisg ICAgV2ViQ29yZTo6VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbiB1c2VySW50ZXJmYWNlTGF5 b3V0RGlyZWN0aW9uKCkgb3ZlcnJpZGU7CiAKICAgICBib29sIGVmZmVjdGl2ZUFwcGVhcmFuY2VJ c0RhcmsoKSBjb25zdCBvdmVycmlkZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvZ3RrL1ZpZXdHZXN0dXJlQ29udHJvbGxlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9ndGsvVmlld0dlc3R1cmVDb250cm9sbGVyR3RrLmNwcAppbmRleCA5ZDBiYTIyMDVj NzA0ZmQ0MmEzOWQ3YjRjZTk3NGU4OGNkOWE1NmM5Li41OTdjZWExOTE3OTM4ZmRmN2NkY2E3NDlm ZDA2MDFkNDg3YTAxYTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsv Vmlld0dlc3R1cmVDb250cm9sbGVyR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9ndGsvVmlld0dlc3R1cmVDb250cm9sbGVyR3RrLmNwcApAQCAtMzI4LDYgKzMyOCw4IEBAIHZv aWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpoYW5kbGVTd2lwZUdlc3R1cmUoV2ViQmFja0Zvcndh cmRMaXN0SXRlbSosIGRvdWJsZSwKIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpkcmF3KGNh aXJvX3QqIGNyLCBjYWlyb19wYXR0ZXJuX3QqIHBhZ2VHcm91cCkKIHsKICAgICBib29sIHN3aXBp bmdMZWZ0ID0gaXNQaHlzaWNhbGx5U3dpcGluZ0xlZnQobV9zd2lwZVByb2dyZXNzVHJhY2tlci5k aXJlY3Rpb24oKSk7CisgICAgYm9vbCBzd2lwaW5nQmFjayA9IG1fc3dpcGVQcm9ncmVzc1RyYWNr ZXIuZGlyZWN0aW9uKCkgPT0gU3dpcGVEaXJlY3Rpb246OkJhY2s7CisgICAgYm9vbCBpc1JUTCA9 IG1fd2ViUGFnZVByb3h5LnVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb24oKSA9PSBXZWJDb3Jl OjpVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uOjpSVEw7CiAgICAgZmxvYXQgcHJvZ3Jlc3Mg PSBtX3N3aXBlUHJvZ3Jlc3NUcmFja2VyLnByb2dyZXNzKCk7CiAKICAgICBkb3VibGUgd2lkdGgg PSBtX3dlYlBhZ2VQcm94eS5kcmF3aW5nQXJlYSgpLT5zaXplKCkud2lkdGgoKTsKQEAgLTMzNiw2 ICszMzgsOCBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6ZHJhdyhjYWlyb190KiBjciwg Y2Fpcm9fcGF0dGVybl90KiBwYWdlR3JvdXApCiAgICAgZG91YmxlIHN3aXBpbmdMYXllck9mZnNl dCA9IChzd2lwaW5nTGVmdCA/IDAgOiB3aWR0aCkgKyBmbG9vcih3aWR0aCAqIHByb2dyZXNzKTsK IAogICAgIGRvdWJsZSBkaW1taW5nUHJvZ3Jlc3MgPSBzd2lwaW5nTGVmdCA/IDEgLSBwcm9ncmVz cyA6IC1wcm9ncmVzczsKKyAgICBpZiAoaXNSVEwpCisgICAgICAgIGRpbW1pbmdQcm9ncmVzcyA9 IDEgLSBkaW1taW5nUHJvZ3Jlc3M7CiAKICAgICBkb3VibGUgcmVtYWluaW5nU3dpcGVEaXN0YW5j ZSA9IGRpbW1pbmdQcm9ncmVzcyAqIHdpZHRoOwogICAgIGRvdWJsZSBzaGFkb3dGYWRlRGlzdGFu Y2UgPSBzd2lwZU92ZXJsYXlTaGFkb3dXaWR0aDsKQEAgLTM0NCw3ICszNDgsNyBAQCB2b2lkIFZp ZXdHZXN0dXJlQ29udHJvbGxlcjo6ZHJhdyhjYWlyb190KiBjciwgY2Fpcm9fcGF0dGVybl90KiBw YWdlR3JvdXApCiAgICAgaWYgKHJlbWFpbmluZ1N3aXBlRGlzdGFuY2UgPCBzaGFkb3dGYWRlRGlz dGFuY2UpCiAgICAgICAgIHNoYWRvd09wYWNpdHkgPSAocmVtYWluaW5nU3dpcGVEaXN0YW5jZSAv IHNoYWRvd0ZhZGVEaXN0YW5jZSkgKiBzd2lwZU92ZXJsYXlTaGFkb3dPcGFjaXR5OwogCi0gICAg UmVmUHRyPGNhaXJvX3BhdHRlcm5fdD4gc2hhZG93UGF0dGVybiA9IGFkb3B0UmVmKGNhaXJvX3Bh dHRlcm5fY3JlYXRlX2xpbmVhcigwLCAwLCAtc3dpcGVPdmVybGF5U2hhZG93V2lkdGgsIDApKTsK KyAgICBSZWZQdHI8Y2Fpcm9fcGF0dGVybl90PiBzaGFkb3dQYXR0ZXJuID0gYWRvcHRSZWYoY2Fp cm9fcGF0dGVybl9jcmVhdGVfbGluZWFyKDAsIDAsIHN3aXBlT3ZlcmxheVNoYWRvd1dpZHRoLCAw KSk7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCAxNjsgaSsrKSB7CiAgICAgICAgIGRvdWJsZSBv ZmZzZXQgPSBzd2lwZU92ZXJsYXlTaGFkb3dHcmFkaWVudE9mZnNldHNbaV07CiAgICAgICAgIGRv dWJsZSBhbHBoYSA9IHN3aXBlT3ZlcmxheVNoYWRvd0dyYWRpZW50QWxwaGFbaV0gKiBzaGFkb3dP cGFjaXR5OwpAQCAtMzUzLDggKzM1NywxMSBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6 ZHJhdyhjYWlyb190KiBjciwgY2Fpcm9fcGF0dGVybl90KiBwYWdlR3JvdXApCiAKICAgICBjYWly b19zYXZlKGNyKTsKIAotICAgIGNhaXJvX3JlY3RhbmdsZShjciwgMCwgMCwgc3dpcGluZ0xheWVy T2Zmc2V0LCBoZWlnaHQpOwotICAgIGNhaXJvX3NldF9zb3VyY2UoY3IsIHN3aXBpbmdMZWZ0ID8g bV9jdXJyZW50U3dpcGVTbmFwc2hvdFBhdHRlcm4uZ2V0KCkgOiBwYWdlR3JvdXApOworICAgIGlm IChpc1JUTCkKKyAgICAgICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCBzd2lwaW5nTGF5ZXJPZmZzZXQs IDAsIHdpZHRoIC0gc3dpcGluZ0xheWVyT2Zmc2V0LCBoZWlnaHQpOworICAgIGVsc2UKKyAgICAg ICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCAwLCAwLCBzd2lwaW5nTGF5ZXJPZmZzZXQsIGhlaWdodCk7 CisgICAgY2Fpcm9fc2V0X3NvdXJjZShjciwgc3dpcGluZ0JhY2sgPyBtX2N1cnJlbnRTd2lwZVNu YXBzaG90UGF0dGVybi5nZXQoKSA6IHBhZ2VHcm91cCk7CiAgICAgY2Fpcm9fZmlsbF9wcmVzZXJ2 ZShjcik7CiAKICAgICBjYWlyb19zZXRfc291cmNlX3JnYmEoY3IsIDAsIDAsIDAsIGRpbW1pbmdQ cm9ncmVzcyAqIHN3aXBlT3ZlcmxheURpbW1pbmdPcGFjaXR5KTsKQEAgLTM2MywxMyArMzcwLDIx IEBAIHZvaWQgVmlld0dlc3R1cmVDb250cm9sbGVyOjpkcmF3KGNhaXJvX3QqIGNyLCBjYWlyb19w YXR0ZXJuX3QqIHBhZ2VHcm91cCkKICAgICBjYWlyb190cmFuc2xhdGUoY3IsIHN3aXBpbmdMYXll ck9mZnNldCwgMCk7CiAKICAgICBpZiAocHJvZ3Jlc3MpIHsKLSAgICAgICAgY2Fpcm9fcmVjdGFu Z2xlKGNyLCAtc3dpcGVPdmVybGF5U2hhZG93V2lkdGgsIDAsIHN3aXBlT3ZlcmxheVNoYWRvd1dp ZHRoLCBoZWlnaHQpOworICAgICAgICBjYWlyb19zYXZlKGNyKTsKKyAgICAgICAgaWYgKCFpc1JU TCkKKyAgICAgICAgICAgIGNhaXJvX3NjYWxlKGNyLCAtMSwgMSk7CisgICAgICAgIGNhaXJvX3Jl Y3RhbmdsZShjciwgMCwgMCwgc3dpcGVPdmVybGF5U2hhZG93V2lkdGgsIGhlaWdodCk7CiAgICAg ICAgIGNhaXJvX3NldF9zb3VyY2UoY3IsIHNoYWRvd1BhdHRlcm4uZ2V0KCkpOwogICAgICAgICBj YWlyb19maWxsKGNyKTsKKyAgICAgICAgY2Fpcm9fcmVzdG9yZShjcik7CiAgICAgfQogCi0gICAg Y2Fpcm9fcmVjdGFuZ2xlKGNyLCAwLCAwLCB3aWR0aCAtIHN3aXBpbmdMYXllck9mZnNldCwgaGVp Z2h0KTsKLSAgICBjYWlyb19zZXRfc291cmNlKGNyLCBzd2lwaW5nTGVmdCA/IHBhZ2VHcm91cCA6 IG1fY3VycmVudFN3aXBlU25hcHNob3RQYXR0ZXJuLmdldCgpKTsKKyAgICBpZiAoaXNSVEwpIHsK KyAgICAgICAgY2Fpcm9fdHJhbnNsYXRlKGNyLCAtd2lkdGgsIDApOworICAgICAgICBjYWlyb19y ZWN0YW5nbGUoY3IsIHdpZHRoIC0gc3dpcGluZ0xheWVyT2Zmc2V0LCAwLCBzd2lwaW5nTGF5ZXJP ZmZzZXQsIGhlaWdodCk7CisgICAgfSBlbHNlCisgICAgICAgIGNhaXJvX3JlY3RhbmdsZShjciwg MCwgMCwgd2lkdGggLSBzd2lwaW5nTGF5ZXJPZmZzZXQsIGhlaWdodCk7CisgICAgY2Fpcm9fc2V0 X3NvdXJjZShjciwgc3dpcGluZ0JhY2sgPyBwYWdlR3JvdXAgOiBtX2N1cnJlbnRTd2lwZVNuYXBz aG90UGF0dGVybi5nZXQoKSk7CiAgICAgY2Fpcm9fZmlsbChjcik7CiAKICAgICBjYWlyb19yZXN0 b3JlKGNyKTsK