198631 2019-06-06 16:54:12 -0700 Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods 2019-06-07 18:37:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue megan_gardner thorton webkit-bug-importer oldest_to_newest 1542622 0 wenson_hsieh 2019-06-06 16:54:12 -0700 SSIA 1542623 1 webkit-bug-importer 2019-06-06 16:54:39 -0700 <rdar://problem/51505431> 1543016 2 371633 wenson_hsieh 2019-06-07 17:15:59 -0700 Created attachment 371633 Patch 1543041 3 371633 commit-queue 2019-06-07 18:37:43 -0700 Comment on attachment 371633 Patch Clearing flags on attachment: 371633 Committed r246229: <https://trac.webkit.org/changeset/246229> 1543042 4 commit-queue 2019-06-07 18:37:44 -0700 All reviewed patches have been landed. Closing bug. 371633 2019-06-07 17:15:59 -0700 2019-06-07 18:37:43 -0700 Patch bug-198631-20190607171558.patch text/plain 7243 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwMGJiYTBmNGIwYjc3ZWFk NGExYWUzMmI2ZGE5MjFhYTUxNWFiMzIuLjhkMjdhMzQ1NWU1ZjY3MzE5OTY3Yzg5YWVmYzFkNWM5 MjIyMjgwM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDYtMDcgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgQWxsb3cgY2xpZW50cyB0 byB2ZW5kIGN1c3RvbSAtaW5wdXRWaWV3IGFuZCAtaW5wdXRBY2Nlc3NvcnlWaWV3IGJ5IG92ZXJy aWRpbmcgV0tXZWJWaWV3IG1ldGhvZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5ODYzMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1MDU0MzE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cg V0tXZWJWaWV3IEFQSSBjbGllbnRzIHRvIG92ZXJyaWRlIFdLQ29udGVudFZpZXcncyBkZWZhdWx0 IGlucHV0IHZpZXcgYW5kL29yIGlucHV0IGFjY2Vzc29yeSB2aWV3IGJ5CisgICAgICAgIHN1YmNs YXNzaW5nIFdLV2ViVmlldyBhbmQgaW1wbGVtZW50aW5nIC1pbnB1dFZpZXcgb3IgLWlucHV0QWNj ZXNzb3J5Vmlldy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t OgorICAgICAgICAoLVtXS1dlYlZpZXcgaW5wdXRBY2Nlc3NvcnlWaWV3XSk6CisgICAgICAgICgt W1dLV2ViVmlldyBpbnB1dFZpZXddKToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGlucHV0Vmlld10pOgor ICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGlucHV0Vmlld0ZvcldlYlZpZXddKToKKyAgICAgICAg KC1bV0tDb250ZW50VmlldyBpbnB1dEFjY2Vzc29yeVZpZXddKToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBpbnB1dEFjY2Vzc29yeVZpZXdGb3JXZWJWaWV3XSk6CisKIDIwMTktMDYtMDYgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBhbiBlbnVtZXJh dGlvbiBpbiBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eTo6Z2V0VXNlck1l ZGlhUGVybWlzc2lvbkluZm8gY2FsbGJhY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGZlOGVkODg5MjcyYTJkZWI1NDM4Y2M1YTFlYTAw YmIyOTg5OWI0MWYuLmZhMjIxYmEyMTY4MGUzZTk3YWM0Yzk0OTdkNmFmMmFmODkwOTMxOTEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAt NDU4NSw2ICs0NTg1LDE2IEBAIC0gKHZvaWQpX3NldFRleHRDb2xvcjooVUlDb2xvciAqKWNvbG9y IHNlbmRlcjooaWQpc2VuZGVyCiAgICAgICAgIFtfY29udGVudFZpZXcgX3NldFRleHRDb2xvckZv cldlYlZpZXc6Y29sb3Igc2VuZGVyOnNlbmRlcl07CiB9CiAKKy0gKFVJVmlldyAqKWlucHV0QWNj ZXNzb3J5VmlldworeworICAgIHJldHVybiBbX2NvbnRlbnRWaWV3IGlucHV0QWNjZXNzb3J5Vmll d0ZvcldlYlZpZXddOworfQorCistIChVSVZpZXcgKilpbnB1dFZpZXcKK3sKKyAgICByZXR1cm4g W19jb250ZW50VmlldyBpbnB1dFZpZXdGb3JXZWJWaWV3XTsKK30KKwogI2VuZGlmIC8vIFBMQVRG T1JNKElPU19GQU1JTFkpCiAKIC0gKEJPT0wpX2lzRWRpdGFibGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAppbmRleCBl NGJjNDY5ZDI4ZmY1NjBiMjM3NmM2Y2I2MDYzODBhYmMyNDc1NTZhLi42NjkwY2QxOThiZGFmNDU4 MjcxZDRhYmI5OGRhNjU0YTE4MGYwNTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCkBAIC0zODMsNiArMzgzLDgg QEAgc3RydWN0IFdLQXV0b0NvcnJlY3Rpb25EYXRhIHsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBy ZWFkb25seSkgY29uc3QgV2ViS2l0OjpGb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uJiBmb2N1c2Vk RWxlbWVudEluZm9ybWF0aW9uOwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBVSVdl YkZvcm1BY2Nlc3NvcnkgKmZvcm1BY2Nlc3NvcnlWaWV3OwogQHByb3BlcnR5IChub25hdG9taWMs IHJlYWRvbmx5KSBVSVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKmlucHV0QXNzaXN0YW50SXRlbUZv cldlYlZpZXc7CitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFVJVmlldyAqaW5wdXRW aWV3Rm9yV2ViVmlldzsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgVUlWaWV3ICpp bnB1dEFjY2Vzc29yeVZpZXdGb3JXZWJWaWV3OwogI2lmIEVOQUJMRShQT0lOVEVSX0VWRU5UUykK IEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgQk9PTCBwcmV2ZW50c1Bhbm5pbmdJblhB eGlzOwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBCT09MIHByZXZlbnRzUGFubmlu Z0luWUF4aXM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA5YTZkMjE0ZTRiYzk4ZWFmMmFkM2MzMGRkYThk OGM5MmE3ZmU1NTVjLi4xNzI2NTg1NTdkZWVhODVkMzVlN2Y1NTRiZmZmZTU3MjllOTU0MTQ5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0KQEAgLTE3MTMsNiArMTcxMywxMSBAQCAtICh2b2lkKV96b29tVG9SZXZl YWxGb2N1c2VkRWxlbWVudAogfQogCiAtIChVSVZpZXcgKilpbnB1dFZpZXcKK3sKKyAgICByZXR1 cm4gW193ZWJWaWV3IGlucHV0Vmlld107Cit9CisKKy0gKFVJVmlldyAqKWlucHV0Vmlld0Zvcldl YlZpZXcKIHsKICAgICBpZiAoIWhhc0ZvY3VzZWRFbGVtZW50KF9mb2N1c2VkRWxlbWVudEluZm9y bWF0aW9uKSkKICAgICAgICAgcmV0dXJuIG5pbDsKQEAgLTI1NzEsNiArMjU3NiwxMSBAQCAtIChV SVRleHRJbnB1dEFzc2lzdGFudEl0ZW0gKilpbnB1dEFzc2lzdGFudEl0ZW1Gb3JXZWJWaWV3CiB9 CiAKIC0gKFVJVmlldyAqKWlucHV0QWNjZXNzb3J5VmlldworeworICAgIHJldHVybiBbX3dlYlZp ZXcgaW5wdXRBY2Nlc3NvcnlWaWV3XTsKK30KKworLSAoVUlWaWV3ICopaW5wdXRBY2Nlc3NvcnlW aWV3Rm9yV2ViVmlldwogewogICAgIGlmICghW3NlbGYgcmVxdWlyZXNBY2Nlc3NvcnlWaWV3XSkK ICAgICAgICAgcmV0dXJuIG5pbDsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCBiNzE1NmMyZTQzMGQzNTg5Y2U2YTRhZjhlNzA5YWExYWE5OGU5Yjll Li44ODI2ZTU4YTQ1NzEzYjQwNjJiYTgwOGYzZWJmYjg4ZTVkZDM2ODIxIDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTktMDYtMDcgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAg ICAgQWxsb3cgY2xpZW50cyB0byB2ZW5kIGN1c3RvbSAtaW5wdXRWaWV3IGFuZCAtaW5wdXRBY2Nl c3NvcnlWaWV3IGJ5IG92ZXJyaWRpbmcgV0tXZWJWaWV3IG1ldGhvZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODYzMQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTE1MDU0MzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGFuIEFQSSB0ZXN0IHRoYXQgb3ZlcnJpZGVzIC1bV0tXZWJWaWV3IGlu cHV0Vmlld10gYW5kIC1bV0tXZWJWaWV3IGlucHV0QWNjZXNzb3J5Vmlld10uCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVzdHNJT1MubW06CisgICAg ICAgICgtW0N1c3RvbUlucHV0V2ViVmlldyBpbml0V2l0aEZyYW1lOmNvbmZpZ3VyYXRpb246aW5w dXRWaWV3OmlucHV0QWNjZXNzb3J5VmlldzpdKToKKyAgICAgICAgKC1bQ3VzdG9tSW5wdXRXZWJW aWV3IGlucHV0Vmlld10pOgorICAgICAgICAoLVtDdXN0b21JbnB1dFdlYlZpZXcgaW5wdXRBY2Nl c3NvcnlWaWV3XSk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxOS0wNi0w NiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9T XSBBdCBsZWFzdCA2IEFQSSB0ZXN0cyBhcmUgZmFpbGluZyBkdWUgdG8gYW4gZXhjZXB0aW9uIHdo ZW4gd3JpdGluZyBOU0F0dHJpYnV0ZWRTdHJpbmcgdG8gdGhlIHBhc3RlYm9hcmQKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5wdXRUZXN0c0lPUy5t bSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvaW9zL0tleWJvYXJkSW5wdXRUZXN0c0lPUy5t bQppbmRleCBmZTNiMDFkNTdlMGEyZDRmM2RmNWNjMDRmMGE1Y2E5YzM3ZGZkZDA0Li42Y2JhMmFh NWUzMjZlNWNhZWU4YjFiMzUwZGY0YzhiZmM1MmU3MTI4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL2lvcy9LZXlib2FyZElucHV0VGVzdHNJT1MubW0KKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvS2V5Ym9hcmRJbnB1dFRlc3RzSU9TLm1tCkBAIC0xNDgs NiArMTQ4LDM2IEBAIC0gKFVJQmFyQnV0dG9uSXRlbUdyb3VwICopbGFzdFRyYWlsaW5nQmFyQnV0 dG9uR3JvdXAKIAogQGVuZAogCitAaW50ZXJmYWNlIEN1c3RvbUlucHV0V2ViVmlldyA6IFRlc3RX S1dlYlZpZXcKKy0gKGluc3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihDR1JlY3QpZnJhbWUgY29u ZmlndXJhdGlvbjooV0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24gaW5wdXRW aWV3OihVSVZpZXcgKilpbnB1dFZpZXcgaW5wdXRBY2Nlc3NvcnlWaWV3OihVSVZpZXcgKilpbnB1 dEFjY2Vzc29yeVZpZXc7CitAZW5kCisKK0BpbXBsZW1lbnRhdGlvbiBDdXN0b21JbnB1dFdlYlZp ZXcgeworICAgIFJldGFpblB0cjxVSVZpZXc+IF9jdXN0b21JbnB1dFZpZXc7CisgICAgUmV0YWlu UHRyPFVJVmlldz4gX2N1c3RvbUlucHV0QWNjZXNzb3J5VmlldzsKK30KKworLSAoaW5zdGFuY2V0 eXBlKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb25maWd1cmF0aW9uOihXS1dlYlZpZXdD b25maWd1cmF0aW9uICopY29uZmlndXJhdGlvbiBpbnB1dFZpZXc6KFVJVmlldyAqKWlucHV0Vmll dyBpbnB1dEFjY2Vzc29yeVZpZXc6KFVJVmlldyAqKWlucHV0QWNjZXNzb3J5VmlldworeworICAg IGlmIChzZWxmID0gW3N1cGVyIGluaXRXaXRoRnJhbWU6ZnJhbWUgY29uZmlndXJhdGlvbjpjb25m aWd1cmF0aW9uXSkgeworICAgICAgICBfY3VzdG9tSW5wdXRWaWV3ID0gaW5wdXRWaWV3OworICAg ICAgICBfY3VzdG9tSW5wdXRBY2Nlc3NvcnlWaWV3ID0gaW5wdXRBY2Nlc3NvcnlWaWV3OworICAg IH0KKyAgICByZXR1cm4gc2VsZjsKK30KKworLSAoVUlWaWV3ICopaW5wdXRWaWV3Cit7CisgICAg cmV0dXJuIF9jdXN0b21JbnB1dFZpZXcuZ2V0KCk7Cit9CisKKy0gKFVJVmlldyAqKWlucHV0QWNj ZXNzb3J5VmlldworeworICAgIHJldHVybiBfY3VzdG9tSW5wdXRBY2Nlc3NvcnlWaWV3LmdldCgp OworfQorCitAZW5kCisKIHN0YXRpYyBSZXRhaW5QdHI8VGVzdFdLV2ViVmlldz4gd2ViVmlld1dp dGhBdXRvZm9jdXNlZElucHV0KGNvbnN0IFJldGFpblB0cjxUZXN0SW5wdXREZWxlZ2F0ZT4mIGlu cHV0RGVsZWdhdGUpCiB7CiAgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZp ZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgwLCAwLCAzMjAsIDUwMCldKTsKQEAg LTQzMSw2ICs0NjEsMTggQEAgVEVTVChLZXlib2FyZElucHV0VGVzdHMsIEtleWJvYXJkVHlwZUZv cklucHV0KQogICAgIH0KIH0KIAorVEVTVChLZXlib2FyZElucHV0VGVzdHMsIE92ZXJyaWRlSW5w dXRWaWV3QW5kSW5wdXRBY2Nlc3NvcnlWaWV3KQoreworICAgIGF1dG8gaW5wdXRWaWV3ID0gYWRv cHROUyhbW1VJVmlldyBhbGxvY10gaW5pdF0pOworICAgIGF1dG8gaW5wdXRBY2Nlc3NvcnlWaWV3 ID0gYWRvcHROUyhbW1VJVmlldyBhbGxvY10gaW5pdF0pOworICAgIGF1dG8gY29uZmlndXJhdGlv biA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7CisgICAg YXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW0N1c3RvbUlucHV0V2ViVmlldyBhbGxvY10gaW5pdFdp dGhGcmFtZTpDR1JlY3RNYWtlKDAsIDAsIDMyMCwgNTY4KSBjb25maWd1cmF0aW9uOmNvbmZpZ3Vy YXRpb24uZ2V0KCkgaW5wdXRWaWV3OmlucHV0Vmlldy5nZXQoKSBpbnB1dEFjY2Vzc29yeVZpZXc6 aW5wdXRBY2Nlc3NvcnlWaWV3LmdldCgpXSk7CisgICAgYXV0byBjb250ZW50VmlldyA9IFt3ZWJW aWV3IHRleHRJbnB1dENvbnRlbnRWaWV3XTsKKworICAgIEVYUEVDVF9FUShpbnB1dEFjY2Vzc29y eVZpZXcuZ2V0KCksIFtjb250ZW50VmlldyBpbnB1dEFjY2Vzc29yeVZpZXddKTsKKyAgICBFWFBF Q1RfRVEoaW5wdXRWaWV3LmdldCgpLCBbY29udGVudFZpZXcgaW5wdXRWaWV3XSk7Cit9CisKIH0g Ly8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkKIAogI2VuZGlmIC8vIFBMQVRGT1JNKElPU19GQU1J TFkpCg==