198622 2019-06-06 13:43:20 -0700 Crash using WKHTTPCookieStore when you use WKWebView and UIWebView in the same app 2019-06-06 17:29:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren cdumez commit-queue darin ggaren sihui_liu thorton webkit-bug-importer oldest_to_newest 1542544 0 ggaren 2019-06-06 13:43:20 -0700 Crash using WKHTTPCookieStore when you use WKWebView and UIWebView in the same app 1542545 1 371524 ggaren 2019-06-06 13:48:16 -0700 Created attachment 371524 Patch 1542581 2 371524 thorton 2019-06-06 15:50:57 -0700 Comment on attachment 371524 Patch Nice! 1542588 3 371524 commit-queue 2019-06-06 16:00:12 -0700 Comment on attachment 371524 Patch Clearing flags on attachment: 371524 Committed r246174: <https://trac.webkit.org/changeset/246174> 1542589 4 commit-queue 2019-06-06 16:00:13 -0700 All reviewed patches have been landed. Closing bug. 1542590 5 webkit-bug-importer 2019-06-06 16:01:51 -0700 <rdar://problem/51503523> 1542620 6 371524 darin 2019-06-06 16:52:18 -0700 Comment on attachment 371524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371524&action=review > Source/WebKit/ChangeLog:20 > + (API::HTTPCookieStore::deleteCookie): Avoid using callOnMainThread > + becuase it is prohibited in the UI process. Basic question: Does callOnMainThread already assert if it is called in the UI process? Expert question: Is there a way to catch such problems at compile time instead of runtime? 1542630 7 thorton 2019-06-06 17:01:00 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 371524 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371524&action=review > > > Source/WebKit/ChangeLog:20 > > + (API::HTTPCookieStore::deleteCookie): Avoid using callOnMainThread > > + becuase it is prohibited in the UI process. > > Basic question: Does callOnMainThread already assert if it is called in the > UI process? I don't think it does. We have the same problem with WebCore::Timer and I think the process to getting an assertion has been ... fraught. Mostly because it's OK (and necessary) for *legacy* WebKit to use it in the UI process, and telling the difference is hard. Dave Kilzer was working on this a while back. > Expert question: Is there a way to catch such problems at compile time > instead of runtime? 1542640 8 371524 darin 2019-06-06 17:14:09 -0700 Comment on attachment 371524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371524&action=review >>> Source/WebKit/ChangeLog:20 >>> + becuase it is prohibited in the UI process. >> >> Basic question: Does callOnMainThread already assert if it is called in the UI process? >> Expert question: Is there a way to catch such problems at compile time instead of runtime? > > I don't think it does. We have the same problem with WebCore::Timer and I think the process to getting an assertion has been ... fraught. Mostly because it's OK (and necessary) for *legacy* WebKit to use it in the UI process, and telling the difference is hard. Dave Kilzer was working on this a while back. Well, maybe some kind of compile time (or I guess style checker time?) checking would be easier for at least obvious cases like these, since WebKit and LegacyWebKit are in different source directories. 1542644 9 371524 darin 2019-06-06 17:16:03 -0700 Comment on attachment 371524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371524&action=review >>>> Source/WebKit/ChangeLog:20 >>>> + becuase it is prohibited in the UI process. >>> >>> Basic question: Does callOnMainThread already assert if it is called in the UI process? >>> Expert question: Is there a way to catch such problems at compile time instead of runtime? >> >> I don't think it does. We have the same problem with WebCore::Timer and I think the process to getting an assertion has been ... fraught. Mostly because it's OK (and necessary) for *legacy* WebKit to use it in the UI process, and telling the difference is hard. Dave Kilzer was working on this a while back. > > Well, maybe some kind of compile time (or I guess style checker time?) checking would be easier for at least obvious cases like these, since WebKit and LegacyWebKit are in different source directories. Another idea: Add a runtime check that only works in processes that haven’t yet invoked Legacy WebKit at all. Bonus round: Make processes that aren’t apps explicitly using UIWebView not invoke Legacy WebKit at all. 1542658 10 thorton 2019-06-06 17:29:35 -0700 (In reply to Darin Adler from comment #9) > Comment on attachment 371524 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371524&action=review > > >>>> Source/WebKit/ChangeLog:20 > >>>> + becuase it is prohibited in the UI process. > >>> > >>> Basic question: Does callOnMainThread already assert if it is called in the UI process? > >>> Expert question: Is there a way to catch such problems at compile time instead of runtime? > >> > >> I don't think it does. We have the same problem with WebCore::Timer and I think the process to getting an assertion has been ... fraught. Mostly because it's OK (and necessary) for *legacy* WebKit to use it in the UI process, and telling the difference is hard. Dave Kilzer was working on this a while back. > > > > Well, maybe some kind of compile time (or I guess style checker time?) checking would be easier for at least obvious cases like these, since WebKit and LegacyWebKit are in different source directories. That is true! > Another idea: Add a runtime check that only works in processes that haven’t > yet invoked Legacy WebKit at all. > Bonus round: Make processes that aren’t apps explicitly using UIWebView not > invoke Legacy WebKit at all. See https://bugs.webkit.org/show_bug.cgi?id=185330 for some of the previous fun, but yes, I vaguely think Dave was doing some of these things. Just haven't gotten there yet. 371524 2019-06-06 13:48:16 -0700 2019-06-06 16:00:12 -0700 Patch bug-198622-20190606134815.patch text/plain 2689 ggaren SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDYxNjkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE5LTA2LTA2ICBHZW9mZnJleSBH YXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggdXNpbmcgV0tIVFRQQ29v a2llU3RvcmUgd2hlbiB5b3UgdXNlIFdLV2ViVmlldyBhbmQgVUlXZWJWaWV3IGluIHRoZSBzYW1l IGFwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4 NjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG9k YXkgaW4gYSBXV0RDIGxhYiwgSSBzYXcgc29tZSBjcmFzaCByZXBvcnRzIGZyb20gYW4gYXBwIHRo YXQgbWl4ZWQKKyAgICAgICAgV0tXZWJWaWV3IGFuZCBVSVdlYlZpZXcuIFRoZSBwcm94aW1hdGUg Y2F1c2Ugb2YgdGhlIGNyYXNoIGlzIHRoYXQKKyAgICAgICAgV0tIVFRQQ29va2llU3RvcmUgcXVl dWVzIGEgY2FsbE9uTWFpblRocmVhZCBmdW5jdGlvbiwgYW5kIHRoZW4KKyAgICAgICAgVUlXZWJW aWV3IGRlcXVldWVzIGl0IG9uIHRoZSBXZWJUaHJlYWQuCisKKyAgICAgICAgTm8gdGVzdCBiZWNh dXNlIHRoaXMgY3Jhc2ggZGVwZW5kcyBvbiBtaXhpbmcgV0tXZWJWaWV3IGFuZCBVSVdlYlZpZXcg YW5kCisgICAgICAgIGdldHRpbmcgKHVuKWx1Y2t5IG9uIHRoZSB0aW1pbmcuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL0FQSUhUVFBDb29raWVTdG9yZS5jcHA6CisgICAgICAgIChBUEk6OkhU VFBDb29raWVTdG9yZTo6Y29va2llcyk6CisgICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6 c2V0Q29va2llcyk6CisgICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6ZGVsZXRlQ29va2ll KTogQXZvaWQgdXNpbmcgY2FsbE9uTWFpblRocmVhZAorICAgICAgICBiZWN1YXNlIGl0IGlzIHBy b2hpYml0ZWQgaW4gdGhlIFVJIHByb2Nlc3MuCisKIDIwMTktMDYtMDYgIEFudG9pbmUgUXVpbnQg IDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZHVwbGljYXRlZCB3ZWJzaXRl RGF0YVN0b3JlUGFyYW1ldGVycyBjb2RlIGZyb20gV2Vic2l0ZVBvbGljaWVzRGF0YTo6YXBwbHlU b0RvY3VtZW50TG9hZGVyKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElI VFRQQ29va2llU3RvcmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9BUElIVFRQQ29va2llU3RvcmUuY3BwCShyZXZpc2lvbiAyNDYwOTUpCisrKyBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSFRUUENvb2tpZVN0b3JlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjIsNyArNjIsNyBAQCB2b2lkIEhUVFBDb29raWVTdG9yZTo6Y29va2llcyhDb21wbGV0 aW9uCiAgICAgICAgICAgICBhbGxDb29raWVzID0gZ2V0QWxsRGVmYXVsdFVJUHJvY2Vzc0Nvb2tp ZVN0b3JlQ29va2llcygpOwogICAgICAgICBhbGxDb29raWVzLmFwcGVuZFZlY3RvcihtX293bmlu Z0RhdGFTdG9yZS0+cGVuZGluZ0Nvb2tpZXMoKSk7CiAKLSAgICAgICAgY2FsbE9uTWFpblRocmVh ZChbY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgYWxsQ29v a2llc10gKCkgbXV0YWJsZSB7CisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbY29t cGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSwgYWxsQ29va2llc10g KCkgbXV0YWJsZSB7CiAgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihhbGxDb29raWVzKTsK ICAgICAgICAgfSk7CiAgICAgICAgIHJldHVybjsKQEAgLTg2LDcgKzg2LDcgQEAgdm9pZCBIVFRQ Q29va2llU3RvcmU6OnNldENvb2tpZXMoY29uc3QgVgogICAgICAgICAgICAgICAgIG1fb3duaW5n RGF0YVN0b3JlLT5hZGRQZW5kaW5nQ29va2llKGNvb2tpZSk7CiAgICAgICAgIH0KIAotICAgICAg ICBjYWxsT25NYWluVGhyZWFkKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKKyAgICAgICAg UnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAg ICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtMTA1LDcgKzEwNSw3IEBAIHZvaWQgSFRUUENvb2tp ZVN0b3JlOjpkZWxldGVDb29raWUoY29uc3QKICAgICAgICAgZWxzZQogICAgICAgICAgICAgbV9v d25pbmdEYXRhU3RvcmUtPnJlbW92ZVBlbmRpbmdDb29raWUoY29va2llKTsKIAotICAgICAgICBj YWxsT25NYWluVGhyZWFkKFtjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhh bmRsZXIpXSAoKSBtdXRhYmxlIHsKKyAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtj b21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoKSBtdXRhYmxl IHsKICAgICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKCk7CiAgICAgICAgIH0pOwogICAgICAg ICByZXR1cm47Cg==