198620 2019-06-06 12:18:40 -0700 [lldb-webkit] Pretty-print all kinds of Documents 2019-06-07 15:58:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates bfulgham dino jer.noble simon.fraser webkit-bug-importer oldest_to_newest 1542521 0 dbates 2019-06-06 12:18:40 -0700 We need to add a formatter for each Document derived class in order for LLDB to pretty-print it. Otherwise, you have to manually drill down in Xcode- or cast- to Document* in order for LLDB to emit a pretty-printed summary. Let's make things just work™ and add formatting for all the derived classes. 1542522 1 371519 dbates 2019-06-06 12:23:33 -0700 Created attachment 371519 Patch 1542986 2 371519 dbates 2019-06-07 15:52:37 -0700 Comment on attachment 371519 Patch Clearing flags on attachment: 371519 Committed r246222: <https://trac.webkit.org/changeset/246222> 1542987 3 dbates 2019-06-07 15:52:38 -0700 All reviewed patches have been landed. Closing bug. 1542989 4 webkit-bug-importer 2019-06-07 15:58:26 -0700 <rdar://problem/51539208> 371519 2019-06-06 12:23:33 -0700 2019-06-07 15:52:37 -0700 Patch bug-198620-20190606122332.patch text/plain 2613 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmU5YWFkZTU0YzBkNTAzN2NiMzk1NzQ4ZjcwYzQzN2Ni MWYxMjJhZC4uNmNjMzc5MjcwYTlmYmIyZjkwZjVlYTNkZDU5NGE5OTA3NDcyOGQzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDE5LTA2LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIFByZXR0eS1wcmludCBhbGwga2luZHMgb2YgRG9jdW1lbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg2MjAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWdpc3RlciBm b3JtYXR0ZXJzIGZvciBhbGwgY2xhc3NlcyBkZXJpdmVkIGZyb20gV2ViQ29yZTo6RG9jdW1lbnQg c28gd2UgZ2V0IG5pY2Ugc3VtbWFyaWVzCisgICAgICAgIHdpdGhvdXQgaGF2aW5nIHRvIGRyaWxs IGRvd24gaW4gWGNvZGUtIG9yIGNhc3RpbmctIHRvIHRoZSBiYXNlIGNsYXNzLCBEb2N1bWVudC4K KworICAgICAgICBPbGRlciBMTERCIHZlcnNpb25zIHVzZSB0byBkbyB0aGlzIGF1dG9tYXRpY2Fs bHksIGJ1dCB0aGlzIGZ1bmN0aW9uYWxpdHkgd2FzIHJlbW92ZWQgaW4gbmV3ZXIKKyAgICAgICAg dmVyc2lvbnM6CisgICAgICAgICAgICBbWworICAgICAgICAgICAgICAgIFdhcm5pbmc6IHByZXZp b3VzIHZlcnNpb25zIG9mIExMREIgZGVmaW5lZCBjYXNjYWRpbmcgdG8gbWVhbiBub3Qgb25seSBn b2luZyB0aHJvdWdoIHR5cGVkZWYKKyAgICAgICAgICAgICAgICBjaGFpbnMsIGJ1dCBhbHNvIHRo cm91Z2ggaW5oZXJpdGFuY2UgY2hhaW5zLiBUaGlzIGZlYXR1cmUgaGFzIGJlZW4gcmVtb3ZlZCBz aW5jZSBpdAorICAgICAgICAgICAgICAgIHNpZ25pZmljYW50bHkgZGVncmFkZXMgcGVyZm9ybWFu Y2UuIFlvdSBuZWVkIHRvIHNldCB1cCB5b3VyIGZvcm1hdHRlcnMgZm9yIGV2ZXJ5IHR5cGUgaW4K KyAgICAgICAgICAgICAgICBpbmhlcml0YW5jZSBjaGFpbnMgdG8gd2hpY2ggeW91IHdhbnQgdGhl IGZvcm1hdHRlciB0byBhcHBseS4KKyAgICAgICAgICAgIF1dCisgICAgICAgICAgICA8aHR0cHM6 Ly9sbGRiLmxsdm0ub3JnL3VzZS92YXJpYWJsZS5odG1sPiAoYXMgb2YgMDYvMDYvMjAxOSkKKwor ICAgICAgICAqIGxsZGIvbGxkYl93ZWJraXQucHk6CisgICAgICAgIChfX2xsZGJfaW5pdF9tb2R1 bGUpOgorCiAyMDE5LTA2LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBbbGxkYi13ZWJraXRdIFR5cGVFcnJvcjogY2Fubm90IGNvbmNhdGVuYXRlICdzdHIn IGFuZCAnaW50JyBvYmplY3RzIHdoZW4gcHJldHRpZnkgVVJMIHdpdGggcG9ydCBudW1iZXIKZGlm ZiAtLWdpdCBhL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkgYi9Ub29scy9sbGRiL2xsZGJfd2Vi a2l0LnB5CmluZGV4IDVlYjJkODhhYWIzNmE3NDU4YTg2ZmNjNDdiYjJiMzRjMmZkMGYzYjMuLjhh NmM5ZTQ3ZTIxMzBkNTdiNDJkY2I1Nzg0ZmJjYzJhYTk4OWU0YmIgMTAwNjQ0Ci0tLSBhL1Rvb2xz L2xsZGIvbGxkYl93ZWJraXQucHkKKysrIGIvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQpAQCAt ODUsNyArODUsOSBAQCBkZWYgX19sbGRiX2luaXRfbW9kdWxlKGRlYnVnZ2VyLCBkaWN0KToKIAog ICAgIGRlYnVnZ2VyLkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3VtbWFyeSBhZGQgLUYgbGxkYl93ZWJr aXQuV2ViQ29yZVNlY3VyaXR5T3JpZ2luX1N1bW1hcnlQcm92aWRlciBXZWJDb3JlOjpTZWN1cml0 eU9yaWdpbicpCiAgICAgZGVidWdnZXIuSGFuZGxlQ29tbWFuZCgndHlwZSBzdW1tYXJ5IGFkZCAt RiBsbGRiX3dlYmtpdC5XZWJDb3JlRnJhbWVfU3VtbWFyeVByb3ZpZGVyIFdlYkNvcmU6OkZyYW1l JykKLSAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0eXBlIHN1bW1hcnkgYWRkIC1GIGxsZGJf d2Via2l0LldlYkNvcmVEb2N1bWVudF9TdW1tYXJ5UHJvdmlkZXIgV2ViQ29yZTo6RG9jdW1lbnQn KQorCisgICAgZm9yIGNsYXNzTmFtZSBpbiBbJ0RvY3VtZW50JywgJ0ZUUERpcmVjdG9yeURvY3Vt ZW50JywgJ0hUTUxEb2N1bWVudCcsICdJbWFnZURvY3VtZW50JywgJ01lZGlhRG9jdW1lbnQnLCAn UGx1Z2luRG9jdW1lbnQnLCAnU1ZHRG9jdW1lbnQnLCAnU2lua0RvY3VtZW50JywgJ1RleHREb2N1 bWVudCcsICdYTUxEb2N1bWVudCddOgorICAgICAgICBkZWJ1Z2dlci5IYW5kbGVDb21tYW5kKCd0 eXBlIHN1bW1hcnkgYWRkIC1GIGxsZGJfd2Via2l0LldlYkNvcmVEb2N1bWVudF9TdW1tYXJ5UHJv dmlkZXIgV2ViQ29yZTo6JyArIGNsYXNzTmFtZSkKIAogICAgICMgc3ludGhldGljIHR5cGVzIChz ZWUgPGh0dHBzOi8vbGxkYi5sbHZtLm9yZy92YXJmb3JtYXRzLmh0bWw+KQogICAgIGRlYnVnZ2Vy LkhhbmRsZUNvbW1hbmQoJ3R5cGUgc3ludGhldGljIGFkZCAteCAiXldURjo6VmVjdG9yPC4rPiQi IC0tcHl0aG9uLWNsYXNzIGxsZGJfd2Via2l0LldURlZlY3RvclByb3ZpZGVyJykK