198613 2019-06-06 10:09:42 -0700 Remove obsolete TOOLCHAINS overrides from asan.xcconfig 2019-06-06 11:55:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198589 https://bugs.webkit.org/show_bug.cgi?id=198586 InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue krollin webkit-bug-importer oldest_to_newest 1542460 0 jbedard 2019-06-06 10:09:42 -0700 We already removed the changes in https://trac.webkit.org/changeset/177746/webkit for every thing except for ASan. 1542466 1 371507 jbedard 2019-06-06 10:20:00 -0700 Created attachment 371507 Patch 1542468 2 jbedard 2019-06-06 10:20:52 -0700 Probably more accurate to say we're removing <https://trac.webkit.org/changeset/177703/webkit>. 1542477 3 371507 ap 2019-06-06 10:38:27 -0700 Comment on attachment 371507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371507&action=review > Tools/ChangeLog:3 > + Use default toolchain in ASan xcconfig I would call this "remove obsolete TOOLCHAINS overrides from asan.xcconfig". Unfortunately, "default" has two distinct meanings in this context - one is "default", and another what Xcode defaults to. As you can see, older OSes required changing the default to "default". 1542487 4 371511 jbedard 2019-06-06 11:12:20 -0700 Created attachment 371511 Patch for landing 1542505 5 371511 commit-queue 2019-06-06 11:54:50 -0700 Comment on attachment 371511 Patch for landing Clearing flags on attachment: 371511 Committed r246161: <https://trac.webkit.org/changeset/246161> 1542506 6 commit-queue 2019-06-06 11:54:52 -0700 All reviewed patches have been landed. Closing bug. 1542507 7 webkit-bug-importer 2019-06-06 11:55:16 -0700 <rdar://problem/51493464> 371507 2019-06-06 10:20:00 -0700 2019-06-06 11:12:18 -0700 Patch bug-198613-20190606101958.patch text/plain 1233 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjE1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA2LTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBVc2UgZGVmYXVsdCB0b29sY2hhaW4gaW4gQVNhbiB4Y2NvbmZpZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NjEzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc2FuL2FzYW4u eGNjb25maWc6IFhDQnVpbGQgZG9lc24ndCBzdXBwb3J0IG92ZXJyaWRpbmcgdG9vbGNoYWlucy4K KwogMjAxOS0wNi0wNiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAg ICAgICBibG9jay1zcGFtbWVycyB0b29sIGRvZXNuJ3QgYmxvY2sgZS1tYWlsCkluZGV4OiBUb29s cy9hc2FuL2FzYW4ueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvYXNhbi9hc2FuLnhjY29u ZmlnCShyZXZpc2lvbiAyNDYxMzMpCisrKyBUb29scy9hc2FuL2FzYW4ueGNjb25maWcJKHdvcmtp bmcgY29weSkKQEAgLTEsMTEgKzEsMyBAQAotVE9PTENIQUlOU1tzZGs9bWFjb3N4Kl0gPSAkKFRP T0xDSEFJTlNfbWFjb3N4KTsKLVRPT0xDSEFJTlNfbWFjb3N4ID0gJChUT09MQ0hBSU5TX21hY29z eF8kKE1BQ19PU19YX1ZFUlNJT05fTUFKT1IpKTsKLVRPT0xDSEFJTlNfbWFjb3N4XzEwOTAgPSBk ZWZhdWx0OwotVE9PTENIQUlOU19tYWNvc3hfMTAxMDAwID0gZGVmYXVsdDsKLVRPT0xDSEFJTlNf bWFjb3N4XzEwMTEwMCA9ICQoVE9PTENIQUlOUyk7Ci1UT09MQ0hBSU5TX21hY29zeF8xMDEyMDAg PSAkKFRPT0xDSEFJTlMpOwotVE9PTENIQUlOU19tYWNvc3hfMTAxMzAwID0gJChUT09MQ0hBSU5T KTsKLQogR0NDX09QVElNSVpBVElPTl9MRVZFTCA9ICQoR0NDX09QVElNSVpBVElPTl9MRVZFTF8k KENPTkZJR1VSQVRJT04pKTsKIEdDQ19PUFRJTUlaQVRJT05fTEVWRUxfRGVidWcgPSAwOwogR0ND X09QVElNSVpBVElPTl9MRVZFTF9Qcm9kdWN0aW9uID0gMTsK 371511 2019-06-06 11:12:20 -0700 2019-06-06 11:54:50 -0700 Patch for landing bug-198613-20190606111219.patch text/plain 1258 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjE1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA2LTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgb2Jzb2xldGUgVE9PTENIQUlOUyBvdmVycmlkZXMgZnJvbSBh cyBhc2FuLnhjY29uZmlnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTg2MTMKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292 LgorCisgICAgICAgICogYXNhbi9hc2FuLnhjY29uZmlnOiBYQ0J1aWxkIGRvZXNuJ3Qgc3VwcG9y dCBvdmVycmlkaW5nIHRvb2xjaGFpbnMuCisKIDIwMTktMDYtMDYgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgYmxvY2stc3BhbW1lcnMgdG9vbCBkb2Vzbid0 IGJsb2NrIGUtbWFpbApJbmRleDogVG9vbHMvYXNhbi9hc2FuLnhjY29uZmlnCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL2FzYW4vYXNhbi54Y2NvbmZpZwkocmV2aXNpb24gMjQ2MTU4KQorKysgVG9vbHMv YXNhbi9hc2FuLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0xLDExICsxLDMgQEAKLVRPT0xD SEFJTlNbc2RrPW1hY29zeCpdID0gJChUT09MQ0hBSU5TX21hY29zeCk7Ci1UT09MQ0hBSU5TX21h Y29zeCA9ICQoVE9PTENIQUlOU19tYWNvc3hfJChNQUNfT1NfWF9WRVJTSU9OX01BSk9SKSk7Ci1U T09MQ0hBSU5TX21hY29zeF8xMDkwID0gZGVmYXVsdDsKLVRPT0xDSEFJTlNfbWFjb3N4XzEwMTAw MCA9IGRlZmF1bHQ7Ci1UT09MQ0hBSU5TX21hY29zeF8xMDExMDAgPSAkKFRPT0xDSEFJTlMpOwot VE9PTENIQUlOU19tYWNvc3hfMTAxMjAwID0gJChUT09MQ0hBSU5TKTsKLVRPT0xDSEFJTlNfbWFj b3N4XzEwMTMwMCA9ICQoVE9PTENIQUlOUyk7Ci0KIEdDQ19PUFRJTUlaQVRJT05fTEVWRUwgPSAk KEdDQ19PUFRJTUlaQVRJT05fTEVWRUxfJChDT05GSUdVUkFUSU9OKSk7CiBHQ0NfT1BUSU1JWkFU SU9OX0xFVkVMX0RlYnVnID0gMDsKIEdDQ19PUFRJTUlaQVRJT05fTEVWRUxfUHJvZHVjdGlvbiA9 IDE7Cg==