198561 2019-06-05 05:08:21 -0700 REGRESSION(r243094): [GTK][WPE] Stale content after restoring the web view session 2020-02-18 13:17:32 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195758 https://bugs.webkit.org/show_bug.cgi?id=153230 Gtk, Regression P2 Normal --- 207908 1 cgarcia webkit-unassigned berto bugs-noreply cdumez ews-watchlist gustavo mcatanzaro oldest_to_newest 1541944 0 cgarcia 2019-06-05 05:08:21 -0700 This is another regression of delaying the web process launch until the first load. If the session is restored before anything has been loaded, which is the normal way, the RestoreSession message is just ignored and the state is sent to the WebPage on creation via creation parameters. The WebPage considers that restoring a session from creation parameters only happens when re-launching a process after a crash or in case of process swap. In those cases, the history item is not marked as restored from session. We need to ensure the session is restored in the web process from the IPC message handler, by launching the initial process before the session is restored. 1541945 1 371389 cgarcia 2019-06-05 05:10:11 -0700 Created attachment 371389 Patch 1541946 2 ews-watchlist 2019-06-05 05:11:00 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1541996 3 371389 cdumez 2019-06-05 08:46:35 -0700 Comment on attachment 371389 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371389&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4129 > + getPage(webView).launchInitialProcessIfNecessary(); Can you please add this call at the beginning of WebPageProxy::restoreFromSessionState() instead? It seems like a useful thing to do for all ports. 1542309 4 cgarcia 2019-06-05 22:43:28 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 371389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371389&action=review > > > Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4129 > > + getPage(webView).launchInitialProcessIfNecessary(); > > Can you please add this call at the beginning of > WebPageProxy::restoreFromSessionState() instead? It seems like a useful > thing to do for all ports. Sure, I thought you wanted the opposite, because cocoa based ports always want stale contents after session restore. 1542312 5 371476 cgarcia 2019-06-05 23:05:38 -0700 Created attachment 371476 Patch 1542733 6 cgarcia 2019-06-06 22:46:09 -0700 Committed r246188: <https://trac.webkit.org/changeset/246188> 371389 2019-06-05 05:10:11 -0700 2019-06-05 23:05:38 -0700 Patch wk2-state-session.diff text/plain 2010 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDU0NjkyNjI1ZjQuLjk3NTExM2VkYjk4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIxIEBACisyMDE5LTA2LTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNDMwOTQpOiBbR1RLXVtXUEVdIFN0YWxlIGNv bnRlbnQgYWZ0ZXIgcmVzdG9yaW5nIHRoZSB3ZWIgdmlldyBzZXNzaW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg1NjEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFub3RoZXIgcmVncmVz c2lvbiBvZiBkZWxheWluZyB0aGUgd2ViIHByb2Nlc3MgbGF1bmNoIHVudGlsIHRoZSBmaXJzdCBs b2FkLiBJZiB0aGUgc2Vzc2lvbiBpcyByZXN0b3JlZAorICAgICAgICBiZWZvcmUgYW55dGhpbmcg aGFzIGJlZW4gbG9hZGVkLCB3aGljaCBpcyB0aGUgbm9ybWFsIHdheSwgdGhlIFJlc3RvcmVTZXNz aW9uIG1lc3NhZ2UgaXMganVzdCBpZ25vcmVkIGFuZCB0aGUKKyAgICAgICAgc3RhdGUgaXMgc2Vu dCB0byB0aGUgV2ViUGFnZSBvbiBjcmVhdGlvbiB2aWEgY3JlYXRpb24gcGFyYW1ldGVycy4gVGhl IFdlYlBhZ2UgY29uc2lkZXJzIHRoYXQgcmVzdG9yaW5nIGEgc2Vzc2lvbgorICAgICAgICBmcm9t IGNyZWF0aW9uIHBhcmFtZXRlcnMgb25seSBoYXBwZW5zIHdoZW4gcmUtbGF1bmNoaW5nIGEgcHJv Y2VzcyBhZnRlciBhIGNyYXNoIG9yIGluIGNhc2Ugb2YgcHJvY2VzcyBzd2FwLiBJbgorICAgICAg ICB0aG9zZSBjYXNlcywgdGhlIGhpc3RvcnkgaXRlbSBpcyBub3QgbWFya2VkIGFzIHJlc3RvcmVk IGZyb20gc2Vzc2lvbi4gV2UgbmVlZCB0byBlbnN1cmUgdGhlIHNlc3Npb24gaXMgcmVzdG9yZWQK KyAgICAgICAgaW4gdGhlIHdlYiBwcm9jZXNzIGZyb20gdGhlIElQQyBtZXNzYWdlIGhhbmRsZXIs IGJ5IGxhdW5jaGluZyB0aGUgaW5pdGlhbCBwcm9jZXNzIGJlZm9yZSB0aGUgc2Vzc2lvbiBpcwor ICAgICAgICByZXN0b3JlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRX ZWJWaWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19yZXN0b3JlX3Nlc3Npb25fc3Rh dGUpOgorCiAyMDE5LTA2LTA1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlh LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNDU3OTYpOiBbV1BFXVtHVEtdIFdlYiBwcm9j ZXNzIGNyYXNoIG9uIHN0YXJ0dXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggY2ViOTBkNzNkODMuLjZlMGRlZmNiY2U4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3 LmNwcApAQCAtNDEyNiw2ICs0MTI2LDcgQEAgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfcmVzdG9yZV9z ZXNzaW9uX3N0YXRlKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdFdlYlZpZXcKICAgICBn X3JldHVybl9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSk7CiAgICAgZ19yZXR1 cm5faWZfZmFpbChzdGF0ZSk7CiAKKyAgICBnZXRQYWdlKHdlYlZpZXcpLmxhdW5jaEluaXRpYWxQ cm9jZXNzSWZOZWNlc3NhcnkoKTsKICAgICBnZXRQYWdlKHdlYlZpZXcpLnJlc3RvcmVGcm9tU2Vz c2lvblN0YXRlKHdlYmtpdFdlYlZpZXdTZXNzaW9uU3RhdGVHZXRTZXNzaW9uU3RhdGUoc3RhdGUp LCBmYWxzZSk7CiB9CiAK 371476 2019-06-05 23:05:38 -0700 2019-06-06 06:53:17 -0700 Patch wk2-stale-session.diff text/plain 2582 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZDU0NjkyNjI1ZjQuLmMyNzNlMjdiZTY0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIxIEBACisyMDE5LTA2LTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNDMwOTQpOiBbR1RLXVtXUEVdIFN0YWxlIGNv bnRlbnQgYWZ0ZXIgcmVzdG9yaW5nIHRoZSB3ZWIgdmlldyBzZXNzaW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg1NjEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGFub3RoZXIgcmVncmVz c2lvbiBvZiBkZWxheWluZyB0aGUgd2ViIHByb2Nlc3MgbGF1bmNoIHVudGlsIHRoZSBmaXJzdCBs b2FkLiBJZiB0aGUgc2Vzc2lvbiBpcyByZXN0b3JlZAorICAgICAgICBiZWZvcmUgYW55dGhpbmcg aGFzIGJlZW4gbG9hZGVkLCB3aGljaCBpcyB0aGUgbm9ybWFsIHdheSwgdGhlIFJlc3RvcmVTZXNz aW9uIG1lc3NhZ2UgaXMganVzdCBpZ25vcmVkIGFuZCB0aGUKKyAgICAgICAgc3RhdGUgaXMgc2Vu dCB0byB0aGUgV2ViUGFnZSBvbiBjcmVhdGlvbiB2aWEgY3JlYXRpb24gcGFyYW1ldGVycy4gVGhl IFdlYlBhZ2UgY29uc2lkZXJzIHRoYXQgcmVzdG9yaW5nIGEgc2Vzc2lvbgorICAgICAgICBmcm9t IGNyZWF0aW9uIHBhcmFtZXRlcnMgb25seSBoYXBwZW5zIHdoZW4gcmUtbGF1bmNoaW5nIGEgcHJv Y2VzcyBhZnRlciBhIGNyYXNoIG9yIGluIGNhc2Ugb2YgcHJvY2VzcyBzd2FwLiBJbgorICAgICAg ICB0aG9zZSBjYXNlcywgdGhlIGhpc3RvcnkgaXRlbSBpcyBub3QgbWFya2VkIGFzIHJlc3RvcmVk IGZyb20gc2Vzc2lvbi4gV2UgbmVlZCB0byBlbnN1cmUgdGhlIHNlc3Npb24gaXMgcmVzdG9yZWQK KyAgICAgICAgaW4gdGhlIHdlYiBwcm9jZXNzIGZyb20gdGhlIElQQyBtZXNzYWdlIGhhbmRsZXIs IGJ5IGxhdW5jaGluZyB0aGUgaW5pdGlhbCBwcm9jZXNzIGJlZm9yZSB0aGUgc2Vzc2lvbiBpcwor ICAgICAgICByZXN0b3JlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnJlc3RvcmVGcm9tU2Vzc2lvblN0YXRl KToKKwogMjAxOS0wNi0wNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjQ1Nzk2KTogW1dQRV1bR1RLXSBXZWIgcHJvY2Vz cyBjcmFzaCBvbiBzdGFydHVwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cAppbmRleCBiNmMwNWYxNGFjYy4uOTkzN2JjNDVlNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMzA4Myw2ICszMDgzLDEzIEBAIFJlZlB0cjxBUEk6Ok5h dmlnYXRpb24+IFdlYlBhZ2VQcm94eTo6cmVzdG9yZUZyb21TZXNzaW9uU3RhdGUoU2Vzc2lvblN0 YXRlIHNlc3NpCiAgICAgYm9vbCBoYXNCYWNrRm9yd2FyZExpc3QgPSAhIXNlc3Npb25TdGF0ZS5i YWNrRm9yd2FyZExpc3RTdGF0ZS5jdXJyZW50SW5kZXg7CiAKICAgICBpZiAoaGFzQmFja0Zvcndh cmRMaXN0KSB7CisgICAgICAgIC8vIElmIHRoZXJlIGlzbid0IGEgcnVubmluZyBwcm9jZXNzIHll dCB0aGUgUmVzdG9yZVNlc3Npb24gbWVzc2FnZSBiZWxvdyBpcyBqdXN0IGlnbm9yZWQsIGFuZAor ICAgICAgICAvLyBzZXNzaW9uIGlzIHJlc3RvcmVkIHdoZW4gdGhlIHdlYiBwcm9jZXNzIGlzIGNy ZWF0ZWQgdmlhIGNyZWF0aW9uIHBhcmFtZXRlcnMgd2hpY2ggaXMgbm90CisgICAgICAgIC8vIGNv bnNpZGVyZWQgYW4gQVBJIHJlcXVlc3QuIFNvLCB3ZSBsYXVuY2ggdGhlIGluaXRpYWwgcHJvY2Vz cyBoZXJlIGJlZm9yZSByZXN0b3JpbmcgdGhlCisgICAgICAgIC8vIHNlc3Npb24gdG8gZW5zdXJl IHRoZSBzZXNzaW9uIGlzIHJlc3RvcmVkIGluIHRoZSB3ZWIgcHJvY2VzcyB2aWEgUmVzdG9yZVNl c3Npb24gSVBDIG1lc3NhZ2UKKyAgICAgICAgLy8gd2hpY2ggaXMgY29uc2lkZXJlZCBhbiBBUEkg cmVxdWVzdC4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg1 NjEuCisgICAgICAgIGxhdW5jaEluaXRpYWxQcm9jZXNzSWZOZWNlc3NhcnkoKTsKKwogICAgICAg ICBtX2JhY2tGb3J3YXJkTGlzdC0+cmVzdG9yZUZyb21TdGF0ZShXVEZNb3ZlKHNlc3Npb25TdGF0 ZS5iYWNrRm9yd2FyZExpc3RTdGF0ZSkpOwogICAgICAgICBwcm9jZXNzKCkuc2VuZChNZXNzYWdl czo6V2ViUGFnZTo6UmVzdG9yZVNlc3Npb24obV9iYWNrRm9yd2FyZExpc3QtPml0ZW1TdGF0ZXMo KSksIG1fcGFnZUlEKTsKIAo=