198559 2019-06-05 04:14:03 -0700 "display: contents" Content click does not trigger 2022-07-03 13:30:45 -0700 1 1 1 Unclassified WebKit CSS Safari 12 iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218923 InRadar P2 Normal --- 1 709922234 graouts cdumez cmarcelo commit-queue dbates esprehn+autocc ews-watchlist graouts kangil.han koivisto rniwa webkit-bug-importer zalan oldest_to_newest 1541938 0 709922234 2019-06-05 04:14:03 -0700 https://codepen.io/mantou132/pen/gJyBoz Click on the text in the page, sometimes without triggering the click event 1542463 1 ap 2019-06-06 10:18:41 -0700 I can reproduce on an iPhone with shipping iOS, taps indeed are recognized inconsistently. Moreover, on an iPad Pro with iOS 13 beta, they are not recognized as clicks at all. 1542464 2 webkit-bug-importer 2019-06-06 10:18:51 -0700 <rdar://problem/51488524> 1544447 3 graouts 2019-06-13 06:38:41 -0700 In WebPage::commitPotentialTap() we bail early because m_potentialTapNode->renderer() is false. It might be that we need to also check whether renderOrDisplayContentsStyle() returns something. 1544467 4 372052 graouts 2019-06-13 07:21:50 -0700 Created attachment 372052 Patch 1544492 5 372052 commit-queue 2019-06-13 09:05:34 -0700 Comment on attachment 372052 Patch Clearing flags on attachment: 372052 Committed r246404: <https://trac.webkit.org/changeset/246404> 1544493 6 commit-queue 2019-06-13 09:05:35 -0700 All reviewed patches have been landed. Closing bug. 372052 2019-06-13 07:21:50 -0700 2019-06-13 09:05:34 -0700 Patch bug-198559-20190613162149.patch text/plain 5910 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2Mzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGE4ZWExNDBiMTA2NmY4 ZDM0NjU1NGU0ODQxMDcyZmZlMzRlODk5Zi4uYTZiMjRkMWM5ZjU0MjNiMWVkMDlkMjhjNjY3NTBl Y2YzMzQ1MGMwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTEzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgImRpc3BsYXk6IGNvbnRl bnRzIiBDb250ZW50IGNsaWNrIGRvZXMgbm90IHRyaWdnZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODU1OQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTE0ODg1MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGVzdDogZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LWFuZC1kaXNwbGF5LWNvbnRl bnRzLmh0bWwKKworICAgICAgICAqIGRvbS9FbGVtZW50Lmg6CisKIDIwMTktMDYtMTIgIEFudG9p bmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIEhvb2sgdXAg Y29tcHV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZwppbmRleCAwZDk5MDA5ZjQ2NDQ0Y2UwOTQ1Y2Q4MDNiNzE2ZDZhYTFiMTE1 NjM5Li43NWJiMWFjOTQ3NjI4YzZiODI5YmM1N2M2NTdiNDAzNzFiMzE4ZWZkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDE5LTA2LTEzICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBs ZS5jb20+CisKKyAgICAgICAgImRpc3BsYXk6IGNvbnRlbnRzIiBDb250ZW50IGNsaWNrIGRvZXMg bm90IHRyaWdnZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5ODU1OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE0ODg1MjQ+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmNvbW1pdFBv dGVudGlhbFRhcCk6CisKIDIwMTktMDYtMTIgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxl LmNvbT4KIAogICAgICAgICBTaG93IHRoZSB3ZWIgcGFnZSBVUkwgd2hlbiBzaGFyaW5nIGFuIEFS IG1vZGVsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCA4ZGVkNTQ1MDI3ZmQ1ZTg4ZmUxZjBmYTNmMzI3 MGIwNDY5MTI3YmY1Li43ODRlM2NkYjVhYjY3M2YwNjY3ZWZmZTAxOThjMWI0YzUwYWRjNTA1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmgKQEAgLTU0MCw3ICs1NDAsNyBAQCBwdWJsaWM6CiAgICAgTGF5b3V0 UmVjdCBhYnNvbHV0ZUV2ZW50SGFuZGxlckJvdW5kcyhib29sJiBpbmNsdWRlc0ZpeGVkUG9zaXRp b25FbGVtZW50cykgb3ZlcnJpZGU7CiAKICAgICBjb25zdCBSZW5kZXJTdHlsZSogZXhpc3RpbmdD b21wdXRlZFN0eWxlKCkgY29uc3Q7Ci0gICAgY29uc3QgUmVuZGVyU3R5bGUqIHJlbmRlck9yRGlz cGxheUNvbnRlbnRzU3R5bGUoKSBjb25zdDsKKyAgICBXRUJDT1JFX0VYUE9SVCBjb25zdCBSZW5k ZXJTdHlsZSogcmVuZGVyT3JEaXNwbGF5Q29udGVudHNTdHlsZSgpIGNvbnN0OwogCiAgICAgdm9p ZCBzZXRCZWZvcmVQc2V1ZG9FbGVtZW50KFJlZjxQc2V1ZG9FbGVtZW50PiYmKTsKICAgICB2b2lk IHNldEFmdGVyUHNldWRvRWxlbWVudChSZWY8UHNldWRvRWxlbWVudD4mJik7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDA4 ODcwMjc0MTBjNmZmZDQ1MzRmYmJkYTdkZGM5NjMxNTE1MGVjZDcuLjA3NWE4NmFhNjhlNzUxOTVj MDMyOTAxMWMwNzlkYzU5NmNhNTNhNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0xMDU4LDcgKzEwNTgsMTMgQEAgdm9p ZCBXZWJQYWdlOjpjb21taXRQb3RlbnRpYWxUYXAoT3B0aW9uU2V0PFdlYkV2ZW50OjpNb2RpZmll cj4gbW9kaWZpZXJzLCB1aW50NjQKICAgICAgICAgbV9sYXN0Q29tbWl0dGVkVGFwTG9jYXRpb24g PSBjdXJyZW50UG90ZW50aWFsVGFwTG9jYXRpb247CiAgICAgfTsKIAotICAgIGF1dG8gaW52YWxp ZFRhcmdldEZvclNpbmdsZUNsaWNrID0gIW1fcG90ZW50aWFsVGFwTm9kZSB8fCAoIW1fcG90ZW50 aWFsVGFwTm9kZS0+cmVuZGVyZXIoKSAmJiAhaXM8SFRNTEFyZWFFbGVtZW50PihtX3BvdGVudGlh bFRhcE5vZGUuZ2V0KCkpKTsKKyAgICBhdXRvIGludmFsaWRUYXJnZXRGb3JTaW5nbGVDbGljayA9 ICFtX3BvdGVudGlhbFRhcE5vZGU7CisgICAgaWYgKCFpbnZhbGlkVGFyZ2V0Rm9yU2luZ2xlQ2xp Y2spIHsKKyAgICAgICAgYm9vbCB0YXJnZXRSZW5kZXJzID0gbV9wb3RlbnRpYWxUYXBOb2RlLT5y ZW5kZXJlcigpOworICAgICAgICBpZiAoIXRhcmdldFJlbmRlcnMgJiYgaXM8RWxlbWVudD4obV9w b3RlbnRpYWxUYXBOb2RlLmdldCgpKSkKKyAgICAgICAgICAgIHRhcmdldFJlbmRlcnMgPSBkb3du Y2FzdDxFbGVtZW50PigqbV9wb3RlbnRpYWxUYXBOb2RlKS5yZW5kZXJPckRpc3BsYXlDb250ZW50 c1N0eWxlKCk7CisgICAgICAgIGludmFsaWRUYXJnZXRGb3JTaW5nbGVDbGljayA9ICF0YXJnZXRS ZW5kZXJzICYmICFpczxIVE1MQXJlYUVsZW1lbnQ+KG1fcG90ZW50aWFsVGFwTm9kZS5nZXQoKSk7 CisgICAgfQogICAgIGlmIChpbnZhbGlkVGFyZ2V0Rm9yU2luZ2xlQ2xpY2spIHsKICAgICAgICAg Ly8gV2hlbiB0aGUgbm9kZSBoYXMgbm8gY2xpY2sgZXZlbnRsaXN0ZW5lciwgYnV0IGl0IG1heSBo YXZlIGEgZGJsY2xpY2sgb25lLgogICAgICAgICBoYW5kbGVQb3RlbnRpYWxEb3VibGVUYXBGb3JE b3VibGVDbGlja0F0UG9pbnQobW9kaWZpZXJzLCBsYXN0TGF5ZXJUcmVlVHJhbnNhY3Rpb25JZCk7 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggN2FiZWI3MDdhN2FlYzcyMTQ2Y2QzNjdjNjczODNiNTU5OGJiYjkzNC4uNmU0Mjli MGYxMWRkYWI2ZDk0MTM3MGM5OGJkOGZkN2M3NjQwNWMyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDE5LTA2LTEzICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAg ICAgImRpc3BsYXk6IGNvbnRlbnRzIiBDb250ZW50IGNsaWNrIGRvZXMgbm90IHRyaWdnZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODU1OQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNTE0ODg1MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IHRlc3QgdGhhdCBjaGVja3MgdGhhdCB0 YXBwaW5nIG9uIGFuIGVsZW1lbnQgd2l0aCAiZGlzcGxheTogY29udGVudHMiIGNvcnJlY3RseSBn ZXRzIGEgImNsaWNrIiBldmVudC4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2lvcy9jbGljay1l dmVudC1hbmQtZGlzcGxheS1jb250ZW50cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC1hbmQtZGlzcGxheS1jb250ZW50cy5odG1sOiBB ZGRlZC4KKwogMjAxOS0wNi0xMiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUu Y29tPgogCiAgICAgICAgIFtXSExTTF0gSG9vayB1cCBjb21wdXRlCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvY2xpY2stZXZlbnQtYW5kLWRpc3BsYXktY29udGVudHMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LWFu ZC1kaXNwbGF5LWNvbnRlbnRzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42OWNmYzVhOThkYjc0 ZmJlMzJhYzliNjc4YTYxMzRhZjk3MzZkZDU5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LWFuZC1kaXNwbGF5LWNvbnRlbnRzLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1BBU1MKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LWFuZC1kaXNwbGF5LWNvbnRlbnRzLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvY2xpY2stZXZlbnQtYW5kLWRpc3BsYXktY29udGVu dHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi43M2JkMmRkMzZiZGM2MTBlOGQxMzJiNGZhZTg1ZjIyNmZjZDhj ZDg3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNr LWV2ZW50LWFuZC1kaXNwbGF5LWNvbnRlbnRzLmh0bWwKQEAgLTAsMCArMSw0MSBAQAorPCFET0NU WVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPlRoaXMgdGVzdHMgdGhhdCBhIHRhcCBv biBhbiBlbGVtZW50IHdpdGggZGlzcGxheTogY29udGVudHMgZGlzcGF0Y2hlcyBhICJjbGljayIg ZXZlbnQuPC90aXRsZT4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvYmFzaWMtZ2Vz dHVyZXMuanMiPjwvc2NyaXB0PgorPHN0eWxlPgorI3RhcmdldCB7CisgICAgd2lkdGg6IDEwMHB4 OworICAgIGhlaWdodDogMTAwcHg7CisgICAgYmFja2dyb3VuZC1jb2xvcjogYmxhY2s7CisgICAg ZGlzcGxheTogY29udGVudHM7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGlk PSJ0YXJnZXQiPkZBSUw8L2Rpdj4KKzxzY3JpcHQ+CisKKyhmdW5jdGlvbigpIHsKKyAgICBpZiAo IXdpbmRvdy50ZXN0UnVubmVyIHx8ICF0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KQorICAgICAgICBy ZXR1cm47CisKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB0ZXN0UnVubmVy LmR1bXBBc1RleHQoKTsKKworICAgIGNvbnN0IHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0YXJnZXQiKTsKKworICAgIHRhcmdldC5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGV2 ZW50ID0+IHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpLmlubmVy VGV4dCA9ICJQQVNTIjsKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgfSk7 CisKKyAgICBjb25zdCBib3VuZHMgPSB0YXJnZXQuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7Cisg ICAgY29uc3QgeCA9IGJvdW5kcy5sZWZ0ICsgYm91bmRzLndpZHRoIC8gMjsKKyAgICBjb25zdCB5 ID0gYm91bmRzLnRvcCArIGJvdW5kcy5oZWlnaHQgLyAyOworICAgIHRhcEF0UG9pbnQoeCwgeSk7 Cit9KSgpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K