198540 2019-06-04 13:08:22 -0700 Fix 64-bit vs 32-bit mismatch in TileController.cpp 2019-06-04 17:26:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin bfulgham commit-queue simon.fraser thorton webkit-bug-importer oldest_to_newest 1541711 0 krollin 2019-06-04 13:08:22 -0700 TileController::blankPixelCountForTiles calculates its result as a uint64_t, but returns it as an unsigned. The former is a 64-bit value, while the latter can be a 32-bit value on some platforms. This mismatch can lead to a compile-time error. Fix this by explicitly casting the 64-bit value to a "signed". 1541712 1 webkit-bug-importer 2019-06-04 13:08:50 -0700 <rdar://problem/51410851> 1541713 2 371323 krollin 2019-06-04 13:11:36 -0700 Created attachment 371323 Patch 1541789 3 371323 bfulgham 2019-06-04 16:45:44 -0700 Comment on attachment 371323 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371323&action=review > Source/WebCore/ChangeLog:13 > + casting the 64-bit value to a "signed". signed -> unsigned? 1541795 4 371352 krollin 2019-06-04 17:08:41 -0700 Created attachment 371352 Patch 1541796 5 krollin 2019-06-04 17:09:22 -0700 Thanks. Fixed the think-o. 1541797 6 371353 krollin 2019-06-04 17:10:21 -0700 Created attachment 371353 Patch 1541808 7 371353 commit-queue 2019-06-04 17:26:16 -0700 Comment on attachment 371353 Patch Clearing flags on attachment: 371353 Committed r246091: <https://trac.webkit.org/changeset/246091> 1541809 8 commit-queue 2019-06-04 17:26:18 -0700 All reviewed patches have been landed. Closing bug. 371323 2019-06-04 13:11:36 -0700 2019-06-04 17:08:40 -0700 Patch bug-198540-20190604131136.patch text/plain 1867 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMxYzUzOTAzODg2ODEx YWJkMWRkMWQ5NmJjZTc4NTg3YWEzM2Q2Zi4uOWU3ZTdlMTBjYmYyMDBhOWQ4OWE4NmE4NWFiYmI2 ZGFmMTA0ZmRiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTA0ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggNjQtYml0IHZzIDMy LWJpdCBtaXNtYXRjaCBpbiBUaWxlQ29udHJvbGxlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODU0MAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTE0MTA4NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGlsZUNvbnRyb2xsZXI6OmJsYW5rUGl4ZWxDb3VudEZvclRpbGVzIGNhbGN1bGF0ZXMg aXRzIHJlc3VsdCBhcyBhCisgICAgICAgIHVpbnQ2NF90LCBidXQgcmV0dXJucyBpdCBhcyBhbiB1 bnNpZ25lZC4gVGhlIGZvcm1lciBpcyBhIDY0LWJpdCB2YWx1ZSwKKyAgICAgICAgd2hpbGUgdGhl IGxhdHRlciBjYW4gYmUgYSAzMi1iaXQgdmFsdWUgb24gc29tZSBwbGF0Zm9ybXMuIFRoaXMKKyAg ICAgICAgbWlzbWF0Y2ggY2FuIGxlYWQgdG8gYSBjb21waWxlLXRpbWUgZXJyb3IuIEZpeCB0aGlz IGJ5IGV4cGxpY2l0bHkKKyAgICAgICAgY2FzdGluZyB0aGUgNjQtYml0IHZhbHVlIHRvIGEgInNp Z25lZCIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0tIG5vIG5ldyBmdW5jdGlvbmFsaXR5Lgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VGlsZUNvbnRyb2xsZXI6OmJsYW5rUGl4ZWxDb3VudEZvclRpbGVzKToK KwogMjAxOS0wNi0wNCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRml4IDY0LWJpdCB2cyAzMi1iaXQgbWlzbWF0Y2ggaW4gSVNPRmFpclBsYXlTdHJlYW1pbmdQ c3NoQm94LmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvVGlsZUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2EvVGlsZUNvbnRyb2xsZXIuY3BwCmluZGV4IDc1ZmU3NTlhOGVlZDMyYWMzYWNlODdmYmY4NjBl MTIyMjQwNzE4NTUuLjI2MmRlOGI0MjQ4ZDg0NTUzOGJhZTM5YTM0OTA3ZjZmMjYzOGRiYjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVDb250cm9s bGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxlQ29u dHJvbGxlci5jcHAKQEAgLTY1MCw3ICs2NTAsNyBAQCB1bnNpZ25lZCBUaWxlQ29udHJvbGxlcjo6 YmxhbmtQaXhlbENvdW50Rm9yVGlsZXMoY29uc3QgUGxhdGZvcm1MYXllckxpc3QmIHRpbGVzLAog ICAgIFJlZ2lvbiB1bmNvdmVyZWRSZWdpb24oZW5jbG9zaW5nSW50UmVjdCh2aXNpYmxlUmVjdCkp OwogICAgIHVuY292ZXJlZFJlZ2lvbi5zdWJ0cmFjdChwYWludGVkVmlzaWJsZVRpbGVzKTsKIAot ICAgIHJldHVybiB1bmNvdmVyZWRSZWdpb24udG90YWxBcmVhKCk7CisgICAgcmV0dXJuIHN0YXRp Y19jYXN0PHVuc2lnbmVkPih1bmNvdmVyZWRSZWdpb24udG90YWxBcmVhKCkpOwogfQogCiB2b2lk IFRpbGVDb250cm9sbGVyOjpzZXROZWVkc1JldmFsaWRhdGVUaWxlcygpCg== 371352 2019-06-04 17:08:41 -0700 2019-06-04 17:10:20 -0700 Patch bug-198540-20190604170841.patch text/plain 1870 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMxYzUzOTAzODg2ODEx YWJkMWRkMWQ5NmJjZTc4NTg3YWEzM2Q2Zi4uNzI2MmFhM2ViMjhlOWE3MDMyNGU2ZDA5NWExZGY1 NjNiMGJlNjQyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTA0ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggNjQtYml0IHZzIDMy LWJpdCBtaXNtYXRjaCBpbiBUaWxlQ29udHJvbGxlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODU0MAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTE0MTA4NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGlsZUNvbnRyb2xsZXI6OmJsYW5rUGl4ZWxDb3VudEZvclRpbGVzIGNhbGN1bGF0ZXMg aXRzIHJlc3VsdCBhcyBhCisgICAgICAgIHVpbnQ2NF90LCBidXQgcmV0dXJucyBpdCBhcyBhbiB1 bnNpZ25lZC4gVGhlIGZvcm1lciBpcyBhIDY0LWJpdCB2YWx1ZSwKKyAgICAgICAgd2hpbGUgdGhl IGxhdHRlciBjYW4gYmUgYSAzMi1iaXQgdmFsdWUgb24gc29tZSBwbGF0Zm9ybXMuIFRoaXMKKyAg ICAgICAgbWlzbWF0Y2ggY2FuIGxlYWQgdG8gYSBjb21waWxlLXRpbWUgZXJyb3IuIEZpeCB0aGlz IGJ5IGV4cGxpY2l0bHkKKyAgICAgICAgY2FzdGluZyB0aGUgNjQtYml0IHZhbHVlIHRvIGFuICJ1 bnNpZ25lZCIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0tIG5vIG5ldyBmdW5jdGlvbmFsaXR5 LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNvbnRyb2xsZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VGlsZUNvbnRyb2xsZXI6OmJsYW5rUGl4ZWxDb3VudEZvclRpbGVz KToKKwogMjAxOS0wNi0wNCAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgRml4IDY0LWJpdCB2cyAzMi1iaXQgbWlzbWF0Y2ggaW4gSVNPRmFpclBsYXlTdHJlYW1p bmdQc3NoQm94LmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvVGlsZUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvVGlsZUNvbnRyb2xsZXIuY3BwCmluZGV4IDc1ZmU3NTlhOGVlZDMyYWMzYWNlODdmYmY4 NjBlMTIyMjQwNzE4NTUuLjI2MmRlOGI0MjQ4ZDg0NTUzOGJhZTM5YTM0OTA3ZjZmMjYzOGRiYjgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVDb250 cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxl Q29udHJvbGxlci5jcHAKQEAgLTY1MCw3ICs2NTAsNyBAQCB1bnNpZ25lZCBUaWxlQ29udHJvbGxl cjo6YmxhbmtQaXhlbENvdW50Rm9yVGlsZXMoY29uc3QgUGxhdGZvcm1MYXllckxpc3QmIHRpbGVz LAogICAgIFJlZ2lvbiB1bmNvdmVyZWRSZWdpb24oZW5jbG9zaW5nSW50UmVjdCh2aXNpYmxlUmVj dCkpOwogICAgIHVuY292ZXJlZFJlZ2lvbi5zdWJ0cmFjdChwYWludGVkVmlzaWJsZVRpbGVzKTsK IAotICAgIHJldHVybiB1bmNvdmVyZWRSZWdpb24udG90YWxBcmVhKCk7CisgICAgcmV0dXJuIHN0 YXRpY19jYXN0PHVuc2lnbmVkPih1bmNvdmVyZWRSZWdpb24udG90YWxBcmVhKCkpOwogfQogCiB2 b2lkIFRpbGVDb250cm9sbGVyOjpzZXROZWVkc1JldmFsaWRhdGVUaWxlcygpCg== 371353 2019-06-04 17:10:21 -0700 2019-06-04 17:26:16 -0700 Patch bug-198540-20190604171020.patch text/plain 1872 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGMxYzUzOTAzODg2ODEx YWJkMWRkMWQ5NmJjZTc4NTg3YWEzM2Q2Zi4uMDYwMTEwNjc3NDYzYTNkYzhhODczOTg4ZTlhOGM5 MThiNWM0ZDRkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTA0ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggNjQtYml0IHZzIDMy LWJpdCBtaXNtYXRjaCBpbiBUaWxlQ29udHJvbGxlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODU0MAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTE0MTA4NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KKwor ICAgICAgICBUaWxlQ29udHJvbGxlcjo6YmxhbmtQaXhlbENvdW50Rm9yVGlsZXMgY2FsY3VsYXRl cyBpdHMgcmVzdWx0IGFzIGEKKyAgICAgICAgdWludDY0X3QsIGJ1dCByZXR1cm5zIGl0IGFzIGFu IHVuc2lnbmVkLiBUaGUgZm9ybWVyIGlzIGEgNjQtYml0IHZhbHVlLAorICAgICAgICB3aGlsZSB0 aGUgbGF0dGVyIGNhbiBiZSBhIDMyLWJpdCB2YWx1ZSBvbiBzb21lIHBsYXRmb3Jtcy4gVGhpcwor ICAgICAgICBtaXNtYXRjaCBjYW4gbGVhZCB0byBhIGNvbXBpbGUtdGltZSBlcnJvci4gRml4IHRo aXMgYnkgZXhwbGljaXRseQorICAgICAgICBjYXN0aW5nIHRoZSA2NC1iaXQgdmFsdWUgdG8gYW4g InVuc2lnbmVkIi4KKworICAgICAgICBObyBuZXcgdGVzdHMgLS0gbm8gbmV3IGZ1bmN0aW9uYWxp dHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxlQ29udHJvbGxlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpUaWxlQ29udHJvbGxlcjo6YmxhbmtQaXhlbENvdW50Rm9yVGls ZXMpOgorCiAyMDE5LTA2LTA0ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAog ICAgICAgICBGaXggNjQtYml0IHZzIDMyLWJpdCBtaXNtYXRjaCBpbiBJU09GYWlyUGxheVN0cmVh bWluZ1Bzc2hCb3guY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYS9UaWxlQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYS9UaWxlQ29udHJvbGxlci5jcHAKaW5kZXggNzVmZTc1OWE4ZWVkMzJhYzNhY2U4N2Zi Zjg2MGUxMjIyNDA3MTg1NS4uMjYyZGU4YjQyNDhkODQ1NTM4YmFlMzlhMzQ5MDdmNmYyNjM4ZGJi OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNv bnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1Rp bGVDb250cm9sbGVyLmNwcApAQCAtNjUwLDcgKzY1MCw3IEBAIHVuc2lnbmVkIFRpbGVDb250cm9s bGVyOjpibGFua1BpeGVsQ291bnRGb3JUaWxlcyhjb25zdCBQbGF0Zm9ybUxheWVyTGlzdCYgdGls ZXMsCiAgICAgUmVnaW9uIHVuY292ZXJlZFJlZ2lvbihlbmNsb3NpbmdJbnRSZWN0KHZpc2libGVS ZWN0KSk7CiAgICAgdW5jb3ZlcmVkUmVnaW9uLnN1YnRyYWN0KHBhaW50ZWRWaXNpYmxlVGlsZXMp OwogCi0gICAgcmV0dXJuIHVuY292ZXJlZFJlZ2lvbi50b3RhbEFyZWEoKTsKKyAgICByZXR1cm4g c3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHVuY292ZXJlZFJlZ2lvbi50b3RhbEFyZWEoKSk7CiB9CiAK IHZvaWQgVGlsZUNvbnRyb2xsZXI6OnNldE5lZWRzUmV2YWxpZGF0ZVRpbGVzKCkK