198526 2019-06-04 06:00:11 -0700 [GTK][WPE] Re-enable process warming 2019-06-05 00:43:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196208 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply cdumez mcatanzaro webkit-bug-importer oldest_to_newest 1541530 0 cgarcia 2019-06-04 06:00:11 -0700 It was disabled in r243490 because bubblewrap sandbox needs a valid WebsiteDataStore before launching the web process. We can use the default WebsiteDataStore from the WebProcessPool and only use the prewarmed process later if the given WebsiteDataStore is the same as the WebProcessPool one. 1541531 1 371271 cgarcia 2019-06-04 06:05:13 -0700 Created attachment 371271 Patch 1541540 2 371271 mcatanzaro 2019-06-04 06:50:18 -0700 Comment on attachment 371271 Patch Excellent! I had hoped something like this might work.... 1541913 3 cgarcia 2019-06-05 00:42:16 -0700 Committed r246101: <https://trac.webkit.org/changeset/246101> 1541914 4 webkit-bug-importer 2019-06-05 00:43:18 -0700 <rdar://problem/51431462> 371271 2019-06-04 06:05:13 -0700 2019-06-04 06:50:18 -0700 Patch wk-glib-prewarm.diff text/plain 5385 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMDlmNGIzYmIxZTcuLjIyODhjNzZiMDdhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIzIEBACisyMDE5LTA2LTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFJlLWVuYWJsZSBwcm9jZXNzIHdhcm1pbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODUyNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IHdhcyBkaXNh YmxlZCBpbiByMjQzNDkwIGJlY2F1c2UgYnViYmxld3JhcCBzYW5kYm94IG5lZWRzIGEgdmFsaWQg V2Vic2l0ZURhdGFTdG9yZSBiZWZvcmUgbGF1bmNoaW5nIHRoZSB3ZWIKKyAgICAgICAgcHJvY2Vz cy4gV2UgY2FuIHVzZSB0aGUgZGVmYXVsdCBXZWJzaXRlRGF0YVN0b3JlIGZyb20gdGhlIFdlYlBy b2Nlc3NQb29sIGFuZCBvbmx5IHVzZSB0aGUgcHJld2FybWVkIHByb2Nlc3MKKyAgICAgICAgbGF0 ZXIgaWYgdGhlIGdpdmVuIFdlYnNpdGVEYXRhU3RvcmUgaXMgdGhlIHNhbWUgYXMgdGhlIFdlYlBy b2Nlc3NQb29sIG9uZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjp0cnlUYWtlUHJld2FybWVkUHJvY2Vz cyk6IERvIG5vdCB1c2UgdGhlIHByZXdhcm1lZCBwcm9jZXNzIGlmIFdlYnNpdGVEYXRhU3RvcmUg aXMKKyAgICAgICAgZGlmZmVyZW50IHRoYW4gdGhlIG9uZSB1c2VkIHRvIGxhdW5jaCB0aGUgcHJv Y2VzcyB3aGVuIHNhbmRib3hpbmcgaXMgZW5hYmxlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvZ2xp Yi9XZWJQcm9jZXNzUG9vbEdMaWIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9v bDo6cGxhdGZvcm1Jbml0aWFsaXplKTogRG8gbm90IGRpc2FibGUgcHJvY2VzcyB3YXJtaW5nLgor ICAgICAgICAqIFVJUHJvY2Vzcy9nbGliL1dlYlByb2Nlc3NQcm94eUdMaWIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6OnBsYXRmb3JtR2V0TGF1bmNoT3B0aW9ucyk6IFVz ZSB0aGUgV2Vic2l0ZURhdGFTdG9yZSBmcm9tIHRoZSBXZWJQcm9jZXNzUG9vbCBpZiBwcm9jZXNz CisgICAgICAgIGlzIHByZXdhcm1lZCBhbmQgc2FuZGJveGluZyBpcyBlbmFibGVkLgorCiAyMDE5 LTA2LTA0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBDcmFzaCB3aGVuIHJlLWVudGVyaW5nIEFDIG1vZGUgYWZ0ZXIgcjI0NTk1Nwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IDNlMDQ5NGY1 NjI2Li4zNGJmYzAzOGI5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQ b29sLmNwcApAQCAtODIwLDYgKzgyMCwxMyBAQCBSZWZQdHI8V2ViUHJvY2Vzc1Byb3h5PiBXZWJQ cm9jZXNzUG9vbDo6dHJ5VGFrZVByZXdhcm1lZFByb2Nlc3MoV2Vic2l0ZURhdGFTdG9yZQogICAg IGlmICghbV9wcmV3YXJtZWRQcm9jZXNzKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAorI2lm IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQorICAgIC8vIEluIHBsYXRmb3JtcyB1c2lu ZyBCdWJibGV3cmFwIGZvciBzYW5kYm94aW5nLCBwcmV3YXJtZWQgcHJvY2VzcyBpcyBsYXVuY2hl ZCB1c2luZyB0aGUgV2ViUHJvY2Vzc1Bvb2wgcHJpbWFyeSBXZWJzaXRlRGF0YVN0b3JlLAorICAg IC8vIHNvIHdlIGRvbid0IHVzZSBpdCBpbiBjYXNlIG9mIHVzaW5nIGEgZGlmZmVyZW50IFdlYnNp dGVEYXRhU3RvcmUuCisgICAgaWYgKG1fc2FuZGJveEVuYWJsZWQgJiYgbV93ZWJzaXRlRGF0YVN0 b3JlICYmICZtX3dlYnNpdGVEYXRhU3RvcmUtPndlYnNpdGVEYXRhU3RvcmUoKSAhPSAmd2Vic2l0 ZURhdGFTdG9yZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisjZW5kaWYKKwogICAgIEFTU0VS VChtX3ByZXdhcm1lZFByb2Nlc3MtPmlzUHJld2FybWVkKCkpOwogICAgIG1fcHJld2FybWVkUHJv Y2Vzcy0+bWFya0lzTm9Mb25nZXJJblByZXdhcm1lZFBvb2woKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvZ2xpYi9XZWJQcm9jZXNzUG9vbEdMaWIuY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvZ2xpYi9XZWJQcm9jZXNzUG9vbEdMaWIuY3BwCmluZGV4IDFjYjRm YzE4MzBkLi45OTJmMzMxOWEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Z2xpYi9XZWJQcm9jZXNzUG9vbEdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2dsaWIvV2ViUHJvY2Vzc1Bvb2xHTGliLmNwcApAQCAtOTgsMTMgKzk4LDYgQEAgdm9pZCBXZWJQ cm9jZXNzUG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIAogICAgIGlmICghbWVtb3J5UHJlc3N1 cmVNb25pdG9yRGlzYWJsZWQoKSkKICAgICAgICAgaW5zdGFsbE1lbW9yeVByZXNzdXJlSGFuZGxl cigpOwotCi0gICAgLy8gUHJvY2VzcyB3YXJtaW5nIGlzIGluY29tcGF0aWJsZSB3aXRoIHRoZSBm YWN0IG91ciBXZWJQcm9jZXNzUHJveHk6OnBsYXRmb3JtR2V0TGF1bmNoT3B0aW9ucygpCi0gICAg Ly8gcmVxdWlyZXMgYSB2YWxpZCBXZWJzaXRlRGF0YVN0b3JlIGF0IGluaXRpYWxpemF0aW9uIHRp bWUgZm9yIG91ciBzYW5kYm94IHBlcm1pc3Npb25zLgotICAgIC8vIEZJWE1FOiBXaXRoIHByb2Nl c3Mgd2FybWluZyBkaXNhYmxlZCwgdGhlIHBlcmZvcm1hbmNlIG9mCi0gICAgLy8gcHJvY2Vzcy1z d2FwLW9uLW5hdmlnYXRpb24gaXMgbm90IGdvaW5nIHRvIGJlIGdyZWF0LiBTbyB0aGlzIG5lZWRz IHRvIGJlCi0gICAgLy8gcmUtZW5hYmxlZCB3aGVuIHdlIGVuYWJsZSBQU09OLgotICAgIGNvbmZp Z3VyYXRpb24oKS5zZXRJc0F1dG9tYXRpY1Byb2Nlc3NXYXJtaW5nRW5hYmxlZChmYWxzZSk7CiB9 CiAKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoV2Vi UHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2dsaWIvV2ViUHJvY2Vzc1Byb3h5R0xpYi5jcHAgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9nbGliL1dlYlByb2Nlc3NQcm94eUdMaWIuY3BwCmluZGV4IDNjNDJi YWViZTU2Li5lZWY4ODI2ZDI2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Z2xpYi9XZWJQcm9jZXNzUHJveHlHTGliLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9nbGliL1dlYlByb2Nlc3NQcm94eUdMaWIuY3BwCkBAIC0zOCwxMiArMzgsMjMgQEAgdm9pZCBX ZWJQcm9jZXNzUHJveHk6OnBsYXRmb3JtR2V0TGF1bmNoT3B0aW9ucyhQcm9jZXNzTGF1bmNoZXI6 OkxhdW5jaE9wdGlvbnMmIGwKIHsKICAgICBsYXVuY2hPcHRpb25zLmV4dHJhSW5pdGlhbGl6YXRp b25EYXRhLnNldCgiZW5hYmxlLXNhbmRib3giLCBtX3Byb2Nlc3NQb29sLT5zYW5kYm94RW5hYmxl ZCgpID8gInRydWUiIDogImZhbHNlIik7CiAKLSAgICB3ZWJzaXRlRGF0YVN0b3JlKCkucmVzb2x2 ZURpcmVjdG9yaWVzSWZOZWNlc3NhcnkoKTsKLSAgICBsYXVuY2hPcHRpb25zLmV4dHJhSW5pdGlh bGl6YXRpb25EYXRhLnNldCgid2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkiLCB3ZWJzaXRlRGF0YVN0 b3JlKCkucmVzb2x2ZWREYXRhYmFzZURpcmVjdG9yeSgpKTsKLSAgICBsYXVuY2hPcHRpb25zLmV4 dHJhSW5pdGlhbGl6YXRpb25EYXRhLnNldCgibWVkaWFLZXlzRGlyZWN0b3J5Iiwgd2Vic2l0ZURh dGFTdG9yZSgpLnJlc29sdmVkTWVkaWFLZXlzRGlyZWN0b3J5KCkpOwotICAgIGxhdW5jaE9wdGlv bnMuZXh0cmFJbml0aWFsaXphdGlvbkRhdGEuc2V0KCJhcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5 Iiwgd2Vic2l0ZURhdGFTdG9yZSgpLnJlc29sdmVkQXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgp KTsKKyAgICBpZiAobV9wcm9jZXNzUG9vbC0+c2FuZGJveEVuYWJsZWQoKSkgeworICAgICAgICBX ZWJzaXRlRGF0YVN0b3JlKiBkYXRhU3RvcmUgPSBtX3dlYnNpdGVEYXRhU3RvcmUuZ2V0KCk7Cisg ICAgICAgIGlmICghZGF0YVN0b3JlKSB7CisgICAgICAgICAgICAvLyBQcmV3YXJtZWQgcHJvY2Vz c2VzIGRvbid0IGhhdmUgYSBXZWJzaXRlRGF0YVN0b3JlIHlldCwgc28gdXNlIHRoZSBwcmltYXJ5 IFdlYnNpdGVEYXRhU3RvcmUgZnJvbSB0aGUgV2ViUHJvY2Vzc1Bvb2wuCisgICAgICAgICAgICAv LyBUaGUgcHJvY2VzcyB3b24ndCBiZSB1c2VkIGlmIGN1cnJlbnQgV2Vic2l0ZURhdGFTdG9yZSBp cyBkaWZmZXJlbnQgdGhhbiB0aGUgV2ViUHJvY2Vzc1Bvb2wgcHJpbWFyeSBvbmUuCisgICAgICAg ICAgICBpZiAoYXV0byogYXBpRGF0YVN0b3JlID0gbV9wcm9jZXNzUG9vbC0+d2Vic2l0ZURhdGFT dG9yZSgpKQorICAgICAgICAgICAgICAgIGRhdGFTdG9yZSA9ICZhcGlEYXRhU3RvcmUtPndlYnNp dGVEYXRhU3RvcmUoKTsKKyAgICAgICAgfQogCi0gICAgbGF1bmNoT3B0aW9ucy5leHRyYVdlYlBy b2Nlc3NTYW5kYm94UGF0aHMgPSBtX3Byb2Nlc3NQb29sLT5zYW5kYm94UGF0aHMoKTsKKyAgICAg ICAgQVNTRVJUKGRhdGFTdG9yZSk7CisgICAgICAgIGRhdGFTdG9yZS0+cmVzb2x2ZURpcmVjdG9y aWVzSWZOZWNlc3NhcnkoKTsKKyAgICAgICAgbGF1bmNoT3B0aW9ucy5leHRyYUluaXRpYWxpemF0 aW9uRGF0YS5zZXQoIndlYlNRTERhdGFiYXNlRGlyZWN0b3J5IiwgZGF0YVN0b3JlLT5yZXNvbHZl ZERhdGFiYXNlRGlyZWN0b3J5KCkpOworICAgICAgICBsYXVuY2hPcHRpb25zLmV4dHJhSW5pdGlh bGl6YXRpb25EYXRhLnNldCgibWVkaWFLZXlzRGlyZWN0b3J5IiwgZGF0YVN0b3JlLT5yZXNvbHZl ZE1lZGlhS2V5c0RpcmVjdG9yeSgpKTsKKyAgICAgICAgbGF1bmNoT3B0aW9ucy5leHRyYUluaXRp YWxpemF0aW9uRGF0YS5zZXQoImFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkiLCBkYXRhU3RvcmUt PnJlc29sdmVkQXBwbGljYXRpb25DYWNoZURpcmVjdG9yeSgpKTsKKworICAgICAgICBsYXVuY2hP cHRpb25zLmV4dHJhV2ViUHJvY2Vzc1NhbmRib3hQYXRocyA9IG1fcHJvY2Vzc1Bvb2wtPnNhbmRi b3hQYXRocygpOworICAgIH0KIH0KIAogfTsK