198508 2019-06-03 17:22:20 -0700 REGRESSION(r244268): Web Inspector: Styles: navigating from Computed to Styles doesn't work 2019-06-10 14:14:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1541405 0 nvasilyev 2019-06-03 17:22:20 -0700 Steps: 1. Open https://webkit.org 2. Inspect <body> 3. Open Computed panel in the right sidebar 4. Hover "background-color: rgb(0, 37, 61)" 5. Click on the arrow icon on the right. Expected: Styles panel open with "background-color" property selected. Actual: Styles panel open but no properties are selected. Notes: This must have regressed in the last 2 months. 1541406 1 webkit-bug-importer 2019-06-03 17:22:38 -0700 <rdar://problem/51375503> 1541410 2 nvasilyev 2019-06-03 17:34:57 -0700 Broken in r244268 Web Inspector: sidebar panels shouldn't be added as subviews unless visible 1541411 3 nvasilyev 2019-06-03 17:41:54 -0700 After clicking the arrow icon: [Error] TypeError: null is not an object (evaluating 'this.parentSidebar.sidebarPanels') computedStyleDetailsPanelShowProperty (GeneralStyleDetailsSidebarPanel.js:75) spreadsheetCSSStyleDeclarationEditorShowProperty (ComputedStyleDetailsPanel.js:78) spreadsheetStylePropertyShowProperty (ComputedStyleSection.js:207) (anonymous function) (SpreadsheetStyleProperty.js:227) 1543153 4 371687 nvasilyev 2019-06-08 17:31:58 -0700 Created attachment 371687 Patch 1543422 5 371687 mattbaker 2019-06-10 12:37:26 -0700 Comment on attachment 371687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371687&action=review > Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:72 > + let parentSidebar = this.parentSidebar; Instead of saving a reference, why not reorder the operations in the function body? computedStyleDetailsPanelShowProperty(property) { let styleRulesPanel = this.parentSidebar.sidebarPanels.find((panel) => panel instanceof WI.RulesStyleDetailsSidebarPanel); console.assert(styleRulesPanel, "Styles panel is missing."); if (!styleRulesPanel) return; this.parentSidebar.selectedSidebarPanel = styleRulesPanel; styleRulesPanel.panel.scrollToSectionAndHighlightProperty(property); } Also, this delegate method seems like it belongs in ComputedStyleDetailsPanel, not in a generic base class. 1543432 6 nvasilyev 2019-06-10 13:00:55 -0700 (In reply to Matt Baker from comment #5) > Comment on attachment 371687 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371687&action=review > > > Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:72 > > + let parentSidebar = this.parentSidebar; > > Instead of saving a reference, why not reorder the operations in the > function body? Makes sense. Also, I like how you didn't use a string identifier. 1543434 7 371772 nvasilyev 2019-06-10 13:07:31 -0700 Created attachment 371772 Patch 1543445 8 371772 mattbaker 2019-06-10 13:28:12 -0700 Comment on attachment 371772 Patch r=me 1543457 9 371772 commit-queue 2019-06-10 14:14:01 -0700 Comment on attachment 371772 Patch Clearing flags on attachment: 371772 Committed r246279: <https://trac.webkit.org/changeset/246279> 1543458 10 commit-queue 2019-06-10 14:14:03 -0700 All reviewed patches have been landed. Closing bug. 371687 2019-06-08 17:31:58 -0700 2019-06-10 13:07:31 -0700 Patch patch.txt text/plain 2038 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc4OGQzMGEwNzBmLi44NzFmYmExNGZkNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMDggIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjQ0MjY4KTogV2ViIEluc3BlY3RvcjogU3R5bGVzOiBuYXZpZ2F0aW5nIGZyb20gQ29tcHV0ZWQg dG8gU3R5bGVzIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk4NTA4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTM3NTUwMz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTYXZlIGEg cmVmZXJlbmNlIHRvIHRoZSBwYXJlbnQgdmlldyAoaS5lLiBwYXJlbnRTaWRlYmFyKSBiZWZvcmUg dGhlIHBhbmVsIHZpZXcgZ2V0cyBkZXRhY2hlZC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdJLkdl bmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmNvbXB1dGVkU3R5bGVEZXRh aWxzUGFuZWxTaG93UHJvcGVydHkpOgorCiAyMDE5LTA1LTI0ICBEZXZpbiBSb3Vzc28gIDxkcm91 c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBPdmVybGF5OiBkb24ndCBz aG93IHNldHRpbmcgZm9yIHNob3dpbmcgcnVsZXJzL2d1aWRlcyBkdXJpbmcgZWxlbWVudCBzZWxl Y3Rpb24gaWYgaXQncyBub3Qgc3VwcG9ydGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVs LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0 eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwppbmRleCBhMTAwMDQ1MTJhOS4uZWEyZDQzMmIwOTkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dl bmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5q cwpAQCAtNjksMTAgKzY5LDEzIEBAIFdJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwg PSBjbGFzcyBHZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsIGV4dGVuCiAKICAgICBjb21w dXRlZFN0eWxlRGV0YWlsc1BhbmVsU2hvd1Byb3BlcnR5KHByb3BlcnR5KQogICAgIHsKLSAgICAg ICAgdGhpcy5wYXJlbnRTaWRlYmFyLnNlbGVjdGVkU2lkZWJhclBhbmVsID0gInN0eWxlLXJ1bGVz IjsKKyAgICAgICAgbGV0IHBhcmVudFNpZGViYXIgPSB0aGlzLnBhcmVudFNpZGViYXI7CisKKyAg ICAgICAgLy8gVGhpcyBzZXRzIHRoaXMucGFyZW50U2lkZWJhciB0byBudWxsIGJlY2F1c2UgQ29t cHV0ZWRTdHlsZURldGFpbHNQYW5lbCB2aWV3IGdldHMgZGV0YWNoZWQuCisgICAgICAgIHBhcmVu dFNpZGViYXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWwgPSAic3R5bGUtcnVsZXMiOwogCiAgICAgICAg IGxldCBzdHlsZVJ1bGVzUGFuZWwgPSBudWxsOwotICAgICAgICBmb3IgKGxldCBzaWRlYmFyUGFu ZWwgb2YgdGhpcy5wYXJlbnRTaWRlYmFyLnNpZGViYXJQYW5lbHMpIHsKKyAgICAgICAgZm9yIChs ZXQgc2lkZWJhclBhbmVsIG9mIHBhcmVudFNpZGViYXIuc2lkZWJhclBhbmVscykgewogICAgICAg ICAgICAgaWYgKCEoc2lkZWJhclBhbmVsIGluc3RhbmNlb2YgV0kuUnVsZXNTdHlsZURldGFpbHNT aWRlYmFyUGFuZWwpKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCg== 371772 2019-06-10 13:07:31 -0700 2019-06-10 14:14:01 -0700 Patch patch.txt text/plain 3641 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc4OGQzMGEwNzBmLi5mNmU2MDEwNTc2NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDYtMTAgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjQ0MjY4KTogV2ViIEluc3BlY3RvcjogU3R5bGVzOiBuYXZpZ2F0aW5nIGZyb20gQ29tcHV0ZWQg dG8gU3R5bGVzIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk4NTA4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTM3NTUwMz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBkaWRu J3Qgd29yayBiZWNhdXNlIHRoZSBkZXRhY2hlZCBzaWRlYmFyIHBhbmVsIHRyaWVkIHRvIGFjY2Vz cyBpdHMgcGFyZW50IHZpZXcgKHRoaXMucGFyZW50U2lkZWJhcikuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbXB1dGVkU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAg ICAgICAoV0kuQ29tcHV0ZWRTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLmNvbXB1 dGVkU3R5bGVEZXRhaWxzUGFuZWxTaG93UHJvcGVydHkpOiBBZGRlZC4KKyAgICAgICAgKFdJLkNv bXB1dGVkU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXSS5H ZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5jb21wdXRlZFN0eWxlRGV0 YWlsc1BhbmVsU2hvd1Byb3BlcnR5KTogRGVsZXRlZC4KKyAgICAgICAgTW92ZSBjb21wdXRlZFN0 eWxlRGV0YWlsc1BhbmVsU2hvd1Byb3BlcnR5IHRvIENvbXB1dGVkU3R5bGVEZXRhaWxzU2lkZWJh clBhbmVsIHNpbmNlIGl0J3MgdGhlIG9ubHkKKyAgICAgICAgcGFuZWwgd2hlcmUgaXQncyBuZWVk ZWQuCisKIDIwMTktMDUtMjQgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IE92ZXJsYXk6IGRvbid0IHNob3cgc2V0dGluZyBmb3Igc2hv d2luZyBydWxlcnMvZ3VpZGVzIGR1cmluZyBlbGVtZW50IHNlbGVjdGlvbiBpZiBpdCdzIG5vdCBz dXBwb3J0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbXB1dGVkU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURldGFpbHNTaWRlYmFy UGFuZWwuanMKaW5kZXggZjUzYTE2OTBlY2UuLmMzNDMwMDZlY2VhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21wdXRlZFN0eWxlRGV0YWls c1NpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db21wdXRlZFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtMjksNCArMjks MTcgQEAgV0kuQ29tcHV0ZWRTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBDb21wdXRl ZFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbCBleHQKICAgICB7CiAgICAgICAgIHN1cGVyKCJzdHls ZS1jb21wdXRlZCIsIFdJLlVJU3RyaW5nKCJDb21wdXRlZCIpLCBXSS5Db21wdXRlZFN0eWxlRGV0 YWlsc1BhbmVsKTsKICAgICB9CisKKyAgICAvLyBDb21wdXRlZFN0eWxlRGV0YWlsc1BhbmVsIGRl bGVnYXRlCisKKyAgICBjb21wdXRlZFN0eWxlRGV0YWlsc1BhbmVsU2hvd1Byb3BlcnR5KHByb3Bl cnR5KQorICAgIHsKKyAgICAgICAgbGV0IHN0eWxlUnVsZXNQYW5lbCA9IHRoaXMucGFyZW50U2lk ZWJhci5zaWRlYmFyUGFuZWxzLmZpbmQoKHBhbmVsKSA9PiBwYW5lbCBpbnN0YW5jZW9mIFdJLlJ1 bGVzU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsKTsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoc3R5 bGVSdWxlc1BhbmVsLCAiU3R5bGVzIHBhbmVsIGlzIG1pc3NpbmcuIik7CisgICAgICAgIGlmICgh c3R5bGVSdWxlc1BhbmVsKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMucGFy ZW50U2lkZWJhci5zZWxlY3RlZFNpZGViYXJQYW5lbCA9IHN0eWxlUnVsZXNQYW5lbDsKKyAgICAg ICAgc3R5bGVSdWxlc1BhbmVsLnBhbmVsLnNjcm9sbFRvU2VjdGlvbkFuZEhpZ2hsaWdodFByb3Bl cnR5KHByb3BlcnR5KTsKKyAgICB9CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHls ZURldGFpbHNTaWRlYmFyUGFuZWwuanMKaW5kZXggYTEwMDA0NTEyYTkuLmMwMmEzZTMyMjlhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5l cmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanMK QEAgLTY3LDIzICs2Nyw2IEBAIFdJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwgPSBj bGFzcyBHZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsIGV4dGVuCiAgICAgICAgIHRoaXMu X3BhbmVsLm1hcmtBc05lZWRzUmVmcmVzaCh0aGlzLmRvbU5vZGUpOwogICAgIH0KIAotICAgIGNv bXB1dGVkU3R5bGVEZXRhaWxzUGFuZWxTaG93UHJvcGVydHkocHJvcGVydHkpCi0gICAgewotICAg ICAgICB0aGlzLnBhcmVudFNpZGViYXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWwgPSAic3R5bGUtcnVs ZXMiOwotCi0gICAgICAgIGxldCBzdHlsZVJ1bGVzUGFuZWwgPSBudWxsOwotICAgICAgICBmb3Ig KGxldCBzaWRlYmFyUGFuZWwgb2YgdGhpcy5wYXJlbnRTaWRlYmFyLnNpZGViYXJQYW5lbHMpIHsK LSAgICAgICAgICAgIGlmICghKHNpZGViYXJQYW5lbCBpbnN0YW5jZW9mIFdJLlJ1bGVzU3R5bGVE ZXRhaWxzU2lkZWJhclBhbmVsKSkKLSAgICAgICAgICAgICAgICBjb250aW51ZTsKLQotICAgICAg ICAgICAgc3R5bGVSdWxlc1BhbmVsID0gc2lkZWJhclBhbmVsOwotICAgICAgICAgICAgYnJlYWs7 Ci0gICAgICAgIH0KLQotICAgICAgICBjb25zb2xlLmFzc2VydChzdHlsZVJ1bGVzUGFuZWwsICJT dHlsZXMgcGFuZWwgaXMgbWlzc2luZy4iKTsKLSAgICAgICAgc3R5bGVSdWxlc1BhbmVsLnBhbmVs LnNjcm9sbFRvU2VjdGlvbkFuZEhpZ2hsaWdodFByb3BlcnR5KHByb3BlcnR5KTsKLSAgICB9Ci0K ICAgICAvLyBTdHlsZURldGFpbHNQYW5lbCBkZWxlZ2F0ZQogCiAgICAgc3R5bGVEZXRhaWxzUGFu ZWxGb2N1c0xhc3RQc2V1ZG9DbGFzc0NoZWNrYm94KHN0eWxlRGV0YWlsc1BhbmVsKQo=