198501 2019-06-03 15:25:13 -0700 Fix 32-bit/64-bit mismatch in PointerCaptureController::elementWasRemoved 2019-06-05 00:37:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin cdumez commit-queue graouts webkit-bug-importer oldest_to_newest 1541358 0 krollin 2019-06-03 15:25:13 -0700 keyAndValue.key is a uint64_t, whereas pointerId is a size_t, which is 32-bits on some platforms. This mismatch is normally just a warning, but breaks builds where warnings are treated as errors. Address this mismatch by explicitly casting keyAndValue.key to a size_t. 1541359 1 webkit-bug-importer 2019-06-03 15:25:29 -0700 <rdar://problem/51370464> 1541364 2 krollin 2019-06-03 15:39:06 -0700 The bit about size_t appears to be incorrect. It looks like PointerID is just an int32_t. I'm now curious as to why this conversion issue doesn't hit all platforms. 1541388 3 krollin 2019-06-03 16:44:14 -0700 64-to-32 bit conversion warnings are disabled for arm64. That's why most builds succeed. However, some products build for armv7k, which does not disable this conversion. It's the build for this architecture that's failing. Source/WebCore/Configurations/Base.xcconfig 78:GCC_WARN_64_TO_32_BIT_CONVERSION = YES; 79:GCC_WARN_64_TO_32_BIT_CONVERSION[arch=arm64*] = NO; 80:GCC_WARN_64_TO_32_BIT_CONVERSION[arch=x86_64] = NO; 1541397 4 krollin 2019-06-03 17:09:03 -0700 See also Bug 107093. 1541412 5 371233 krollin 2019-06-03 17:58:50 -0700 Created attachment 371233 Patch 1541420 6 371233 cdumez 2019-06-03 18:26:26 -0700 Comment on attachment 371233 Patch r=me 1541652 7 371233 commit-queue 2019-06-04 10:59:58 -0700 Comment on attachment 371233 Patch Clearing flags on attachment: 371233 Committed r246072: <https://trac.webkit.org/changeset/246072> 1541653 8 commit-queue 2019-06-04 10:59:59 -0700 All reviewed patches have been landed. Closing bug. 1541911 9 graouts 2019-06-05 00:37:31 -0700 Thanks for catching that Keith. 371233 2019-06-03 17:58:50 -0700 2019-06-04 10:59:58 -0700 Patch bug-198501-20190603175849.patch text/plain 2845 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM5MjgxZWUyNTMzZmVm ZGRjZDI5MTIzYTdjNjM4OTBhOTA4NjhmZC4uNWFmMzZhM2Q0MGZhMTUxMjNmNjNiMTk0NDQ5YjU2 ZTAyYTM4NDg2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE5LTA2LTAzICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggMzItYml0LzY0LWJp dCBtaXNtYXRjaCBpbiBQb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXI6OmVsZW1lbnRXYXNSZW1vdmVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg1MDEK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxMzcwNDY0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGtleUFuZFZhbHVlLmtleSBpcyBhc3NpZ25lZCB0 byBwb2ludGVySWQuIEtleUFuZFZhbHVlLmtleSBpcyBhCisgICAgICAgIGludDY0X3QsIHdoZXJl YXMgcG9pbnRlcklkIGlzIGEgUG9pbnRlcklELCBha2EgaW50MzJfdC4gVGhpcyBtaXNtYXRjaAor ICAgICAgICBpcyBub3JtYWxseSBqdXN0IGEgd2FybmluZywgYnV0IGJyZWFrcyBidWlsZHMgd2hl cmUgd2FybmluZ3MgYXJlCisgICAgICAgIHRyZWF0ZWQgYXMgZXJyb3JzLgorCisgICAgICAgIFRo aXMgaXNzdWUgaXMgbm90IGVuY291bnRlcmVkIGluIG1vc3QgYnVpbGRzIGJlY2F1c2UgdGhlIHdh cm5pbmcgaXMKKyAgICAgICAgZGlzYWJsZWQgaW4gdGhlIG1ham9yaXR5IG9mIGJ1aWxkIGNvbmZp Z3VyYXRpb25zLiBCdXQgdGhlcmUgYXJlIHNvbWUKKyAgICAgICAgd2hlcmUgdGhlIHdhcm5pbmcg aXMgbm90IGRpc2FibGVkLCBhbmQgc28gdGhvc2UgYnVpbGRzIGJyZWFrLgorCisgICAgICAgIEFk ZHJlc3MgdGhpcyBjb252ZXJzaW9uIGVycm9yL3dhcm5pbmcgYnkgZXhwbGljaXRseSBjYXN0aW5n CisgICAgICAgIGtleUFuZFZhbHVlLmtleSB0byBhIFBvaW50ZXJJRCAoYW5kIGFkZGluZyBhIGRl YnVnIGNoZWNrIHRvIG1ha2Ugc3VyZQorICAgICAgICB0aGUgY2FzdCBpcyBPSykuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIC0tIG5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFn ZS9Qb2ludGVyQ2FwdHVyZUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9pbnRl ckNhcHR1cmVDb250cm9sbGVyOjplbGVtZW50V2FzUmVtb3ZlZCk6CisKIDIwMTktMDYtMDMgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IHJlc2l6aW5n IG9mIGNhbWVyYSB2aWRlbyBmZWVkcyB0byB2ZXJ5IHNtYWxsIHJlc29sdXRpb25zCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJDYXB0dXJlQ29udHJvbGxlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1BvaW50ZXJDYXB0dXJlQ29udHJvbGxlci5jcHAKaW5kZXggZmRm MmVjNDljMWI1ZTk4NzhmMzAzMTZjZjc2ZjJiZGM1M2NiOGYyMi4uYjkxNzg0MDM2ZjQ2ZmUwYzgz Y2Y3YjM5MTUxYjA1YWI2YzkxMTgwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Q b2ludGVyQ2FwdHVyZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUG9p bnRlckNhcHR1cmVDb250cm9sbGVyLmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIkV2 ZW50VGFyZ2V0LmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBvaW50ZXJFdmVudC5o IgorI2luY2x1ZGUgPHd0Zi9DaGVja2VkQXJpdGhtZXRpYy5oPgogCiAjaWYgRU5BQkxFKFBPSU5U RVJfTE9DSykKICNpbmNsdWRlICJQb2ludGVyTG9ja0NvbnRyb2xsZXIuaCIKQEAgLTEzMyw3ICsx MzQsOCBAQCB2b2lkIFBvaW50ZXJDYXB0dXJlQ29udHJvbGxlcjo6ZWxlbWVudFdhc1JlbW92ZWQo RWxlbWVudCYgZWxlbWVudCkKICAgICAgICAgICAgIC8vIFdoZW4gdGhlIHBvaW50ZXIgY2FwdHVy ZSB0YXJnZXQgb3ZlcnJpZGUgaXMgbm8gbG9uZ2VyIGNvbm5lY3RlZCwgdGhlIHBlbmRpbmcgcG9p bnRlciBjYXB0dXJlIHRhcmdldCBvdmVycmlkZSBhbmQgcG9pbnRlciBjYXB0dXJlIHRhcmdldAog ICAgICAgICAgICAgLy8gb3ZlcnJpZGUgbm9kZXMgU0hPVUxEIGJlIGNsZWFyZWQgYW5kIGFsc28g YSBQb2ludGVyRXZlbnQgbmFtZWQgbG9zdHBvaW50ZXJjYXB0dXJlIGNvcnJlc3BvbmRpbmcgdG8g dGhlIGNhcHR1cmVkIHBvaW50ZXIgU0hPVUxEIGJlIGZpcmVkCiAgICAgICAgICAgICAvLyBhdCB0 aGUgZG9jdW1lbnQuCi0gICAgICAgICAgICBhdXRvIHBvaW50ZXJJZCA9IGtleUFuZFZhbHVlLmtl eTsKKyAgICAgICAgICAgIEFTU0VSVChXVEY6OmlzSW5Cb3VuZHM8UG9pbnRlcklEPihrZXlBbmRW YWx1ZS5rZXkpKTsKKyAgICAgICAgICAgIGF1dG8gcG9pbnRlcklkID0gc3RhdGljX2Nhc3Q8UG9p bnRlcklEPihrZXlBbmRWYWx1ZS5rZXkpOwogICAgICAgICAgICAgYXV0byBwb2ludGVyVHlwZSA9 IGNhcHR1cmluZ0RhdGEucG9pbnRlclR5cGU7CiAgICAgICAgICAgICByZWxlYXNlUG9pbnRlckNh cHR1cmUoJmVsZW1lbnQsIHBvaW50ZXJJZCk7CiAgICAgICAgICAgICBlbGVtZW50LmRvY3VtZW50 KCkuZW5xdWV1ZURvY3VtZW50RXZlbnQoUG9pbnRlckV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygp Lmxvc3Rwb2ludGVyY2FwdHVyZUV2ZW50LCBwb2ludGVySWQsIHBvaW50ZXJUeXBlKSk7Cg==