198490 2019-06-03 11:45:51 -0700 [CMake] Use WEBKIT_EXECUTABLE in ImageDiff 2019-06-03 13:12:26 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead webkit-unassigned achristensen annulen commit-queue fujii mcatanzaro oldest_to_newest 1541280 0 don.olmstead 2019-06-03 11:45:51 -0700 Use WEBKIT_EXECUTABLE in ImageDiff 1541281 1 371200 don.olmstead 2019-06-03 11:48:44 -0700 Created attachment 371200 Patch 1541295 2 371200 commit-queue 2019-06-03 13:12:24 -0700 Comment on attachment 371200 Patch Clearing flags on attachment: 371200 Committed r246044: <https://trac.webkit.org/changeset/246044> 1541296 3 commit-queue 2019-06-03 13:12:26 -0700 All reviewed patches have been landed. Closing bug. 371200 2019-06-03 11:48:44 -0700 2019-06-03 13:12:24 -0700 Patch bug-198490.diff text/plain 4543 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMjg1 NGE2Nzc2Mi4uYTA1MjFlZjY1ZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxOS0wNi0wMyAgRG9uIE9sbXN0ZWFk ICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0gVXNlIFdFQktJVF9F WEVDVVRBQkxFIGluIEltYWdlRGlmZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk4NDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXNlIFdFQktJVF9FWEVDVVRBQkxFIGluIEltYWdlRGlmZi4gQ2hhbmdl IENNYWtlIHZhcmlhYmxlcyB0byB1c2UgdGhlIHByb3BlcgorICAgICAgICBjb252ZW50aW9uLiBB ZGQgYSBzaGFyZWQgQ29yZUdyYXBoaWNzLmNtYWtlIGluc3RlYWQgb2YganVzdCBpbmNsdWRpbmcg UGxhdGZvcm1NYWMKKyAgICAgICAgZm9yIEFwcGxlV2luIGJ1aWxkcy4KKworICAgICAgICAqIElt YWdlRGlmZi9DTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBJbWFnZURpZmYvQ2Fpcm8uY21ha2U6 CisgICAgICAgICogSW1hZ2VEaWZmL0NvcmVHcmFwaGljcy5jbWFrZTogQWRkZWQuCisgICAgICAg ICogSW1hZ2VEaWZmL1BsYXRmb3JtR1RLLmNtYWtlOgorICAgICAgICAqIEltYWdlRGlmZi9QbGF0 Zm9ybU1hYy5jbWFrZToKKyAgICAgICAgKiBJbWFnZURpZmYvUGxhdGZvcm1XaW4uY21ha2U6CisK IDIwMTktMDYtMDMgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAg ICAgICBbQ01ha2VdIEFkZCBXZWJLaXQ6OkphdmFTY3JpcHRDb3JlIHRhcmdldApkaWZmIC0tZ2l0 IGEvVG9vbHMvSW1hZ2VEaWZmL0NNYWtlTGlzdHMudHh0IGIvVG9vbHMvSW1hZ2VEaWZmL0NNYWtl TGlzdHMudHh0CmluZGV4IDljNThjYzU1NTEzLi45MzgzMWNkNmQ0NyAxMDA2NDQKLS0tIGEvVG9v bHMvSW1hZ2VEaWZmL0NNYWtlTGlzdHMudHh0CisrKyBiL1Rvb2xzL0ltYWdlRGlmZi9DTWFrZUxp c3RzLnR4dApAQCAtMSwyMyArMSwxNCBAQAogc2V0KElNQUdFX0RJRkZfRElSICIke1RPT0xTX0RJ Un0vSW1hZ2VEaWZmIikKIAotc2V0KElNQUdFX0RJRkZfU1lTVEVNX0lOQ0xVREVfRElSRUNUT1JJ RVMgIiIpCi0KLXNldChJTUFHRV9ESUZGX1NPVVJDRVMKLSAgICAke0lNQUdFX0RJRkZfRElSfS9J bWFnZURpZmYuY3BwCi0gICAgJHtJTUFHRV9ESUZGX0RJUn0vUGxhdGZvcm1JbWFnZS5jcHAKK3Nl dChJbWFnZURpZmZfU09VUkNFUworICAgIEltYWdlRGlmZi5jcHAKKyAgICBQbGF0Zm9ybUltYWdl LmNwcAogKQogCi1zZXQoSU1BR0VfRElGRl9JTkNMVURFX0RJUkVDVE9SSUVTCitzZXQoSW1hZ2VE aWZmX1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICR7SU1BR0VfRElGRl9ESVJ9CiAp CiAKK1dFQktJVF9FWEVDVVRBQkxFX0RFQ0xBUkUoSW1hZ2VEaWZmKQogV0VCS0lUX0lOQ0xVREVf Q09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCi0KLWluY2x1ZGVfZGlyZWN0b3JpZXMoJHtJTUFHRV9E SUZGX0lOQ0xVREVfRElSRUNUT1JJRVN9KQotaW5jbHVkZV9kaXJlY3RvcmllcyhTWVNURU0gJHtJ TUFHRV9ESUZGX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKLWFkZF9leGVjdXRhYmxlKElt YWdlRGlmZiAke0lNQUdFX0RJRkZfU09VUkNFU30pCi10YXJnZXRfbGlua19saWJyYXJpZXMoSW1h Z2VEaWZmICR7SU1BR0VfRElGRl9MSUJSQVJJRVN9KQotCi1pZiAoV0lOMzIpCi0gICAgYWRkX2Rl cGVuZGVuY2llcyhJbWFnZURpZmYgSW1hZ2VEaWZmTGliKQotZW5kaWYgKCkKK1dFQktJVF9FWEVD VVRBQkxFKEltYWdlRGlmZikKZGlmZiAtLWdpdCBhL1Rvb2xzL0ltYWdlRGlmZi9DYWlyby5jbWFr ZSBiL1Rvb2xzL0ltYWdlRGlmZi9DYWlyby5jbWFrZQppbmRleCBmZGU4YzA5MzA4ZS4uNjZjMzRk NmNmNWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0ltYWdlRGlmZi9DYWlyby5jbWFrZQorKysgYi9Ub29s cy9JbWFnZURpZmYvQ2Fpcm8uY21ha2UKQEAgLTEsMTMgKzEsMTMgQEAKLWxpc3QoQVBQRU5EIElN QUdFX0RJRkZfU09VUkNFUwotICAgICR7SU1BR0VfRElGRl9ESVJ9L2NhaXJvL1BsYXRmb3JtSW1h Z2VDYWlyby5jcHAKK2xpc3QoQVBQRU5EIEltYWdlRGlmZl9TT1VSQ0VTCisgICAgY2Fpcm8vUGxh dGZvcm1JbWFnZUNhaXJvLmNwcAogKQogCi1saXN0KEFQUEVORCBJTUFHRV9ESUZGX1NZU1RFTV9J TkNMVURFX0RJUkVDVE9SSUVTCitsaXN0KEFQUEVORCBJbWFnZURpZmZfU1lTVEVNX0lOQ0xVREVf RElSRUNUT1JJRVMKICAgICAke0NBSVJPX0lOQ0xVREVfRElSU30KICkKIAotbGlzdChBUFBFTkQg SU1BR0VfRElGRl9MSUJSQVJJRVMKK2xpc3QoQVBQRU5EIEltYWdlRGlmZl9MSUJSQVJJRVMKICAg ICAke0NBSVJPX0xJQlJBUklFU30KICkKIAotYWRkX2RlZmluaXRpb25zKC1EVVNFX0NBSVJPPTEp CitsaXN0KEFQUEVORCBJbWFnZURpZmZfUFJJVkFURV9ERUZJTklUSU9OUyBVU0VfQ0FJUk89MSkK ZGlmZiAtLWdpdCBhL1Rvb2xzL0ltYWdlRGlmZi9Db3JlR3JhcGhpY3MuY21ha2UgYi9Ub29scy9J bWFnZURpZmYvQ29yZUdyYXBoaWNzLmNtYWtlCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwLi5hOGQ1ZTA3YzgxOAotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL0ltYWdlRGlm Zi9Db3JlR3JhcGhpY3MuY21ha2UKQEAgLTAsMCArMSw5IEBACitsaXN0KEFQUEVORCBJbWFnZURp ZmZfU09VUkNFUworICAgIGNnL1BsYXRmb3JtSW1hZ2VDRy5jcHAKKykKKworbGlzdChBUFBFTkQg SW1hZ2VEaWZmX0xJQlJBUklFUworICAgIENvcmVGb3VuZGF0aW9uCisgICAgQ29yZUdyYXBoaWNz CisgICAgQ29yZVRleHQKKykKZGlmZiAtLWdpdCBhL1Rvb2xzL0ltYWdlRGlmZi9QbGF0Zm9ybUdU Sy5jbWFrZSBiL1Rvb2xzL0ltYWdlRGlmZi9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCBjNGRjZTAw NzJmZi4uNGIwZWU1MzI4YmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0ltYWdlRGlmZi9QbGF0Zm9ybUdU Sy5jbWFrZQorKysgYi9Ub29scy9JbWFnZURpZmYvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTEsMiAr MSBAQAogaW5jbHVkZShDYWlyby5jbWFrZSkKLQpkaWZmIC0tZ2l0IGEvVG9vbHMvSW1hZ2VEaWZm L1BsYXRmb3JtTWFjLmNtYWtlIGIvVG9vbHMvSW1hZ2VEaWZmL1BsYXRmb3JtTWFjLmNtYWtlCmlu ZGV4IGJkNmMwMDAzNWY0Li5hYTNkNjU3MzQ0MiAxMDA2NDQKLS0tIGEvVG9vbHMvSW1hZ2VEaWZm L1BsYXRmb3JtTWFjLmNtYWtlCisrKyBiL1Rvb2xzL0ltYWdlRGlmZi9QbGF0Zm9ybU1hYy5jbWFr ZQpAQCAtMSw4ICsxIEBACi1saXN0KEFQUEVORCBJTUFHRV9ESUZGX1NPVVJDRVMKLSAgICAke0lN QUdFX0RJRkZfRElSfS9jZy9QbGF0Zm9ybUltYWdlQ0cuY3BwCi0pCi1saXN0KEFQUEVORCBJTUFH RV9ESUZGX0xJQlJBUklFUwotICAgIENvcmVGb3VuZGF0aW9uCi0gICAgQ29yZUdyYXBoaWNzCi0g ICAgQ29yZVRleHQKLSkKK2luY2x1ZGUoQ29yZUdyYXBoaWNzLmNtYWtlKQpkaWZmIC0tZ2l0IGEv VG9vbHMvSW1hZ2VEaWZmL1BsYXRmb3JtV2luLmNtYWtlIGIvVG9vbHMvSW1hZ2VEaWZmL1BsYXRm b3JtV2luLmNtYWtlCmluZGV4IDA4ZDQ5Zjc1OTZhLi5kN2I3ZDM0MzVkZSAxMDA2NDQKLS0tIGEv VG9vbHMvSW1hZ2VEaWZmL1BsYXRmb3JtV2luLmNtYWtlCisrKyBiL1Rvb2xzL0ltYWdlRGlmZi9Q bGF0Zm9ybVdpbi5jbWFrZQpAQCAtMSwxNSArMSwxNSBAQAorc2V0KHdyYXBwZXJfREVGSU5JVElP TlMgVVNFX0NPTlNPTEVfRU5UUllfUE9JTlQpCisKIGlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJ Uk99KQotICAgIGFkZF9kZWZpbml0aW9ucygtRFdJTl9DQUlSTykKKyAgICBsaXN0KEFQUEVORCB3 cmFwcGVyX0RFRklOSVRJT05TIFdJTl9DQUlSTykKIAogICAgIGluY2x1ZGUoQ2Fpcm8uY21ha2Up CiBlbHNlICgpCi0gICAgaW5jbHVkZShQbGF0Zm9ybU1hYy5jbWFrZSkKKyAgICBpbmNsdWRlKENv cmVHcmFwaGljcy5jbWFrZSkKIGVuZGlmICgpCiAKLWFkZF9saWJyYXJ5KEltYWdlRGlmZkxpYiBT SEFSRUQgJHtJTUFHRV9ESUZGX1NPVVJDRVN9KQotdGFyZ2V0X2xpbmtfbGlicmFyaWVzKEltYWdl RGlmZkxpYiAke0lNQUdFX0RJRkZfTElCUkFSSUVTfSkKLQotYWRkX2RlZmluaXRpb25zKC1EVVNF X0NPTlNPTEVfRU5UUllfUE9JTlQpCi0KLXNldChJTUFHRV9ESUZGX1NPVVJDRVMgJHtUT09MU19E SVJ9L3dpbi9ETExMYXVuY2hlci9ETExMYXVuY2hlck1haW4uY3BwKQotc2V0KElNQUdFX0RJRkZf TElCUkFSSUVTIHNobHdhcGkpCitXRUJLSVRfV1JBUF9FWEVDVVRBQkxFKEltYWdlRGlmZgorICAg IFNPVVJDRVMgJHtUT09MU19ESVJ9L3dpbi9ETExMYXVuY2hlci9ETExMYXVuY2hlck1haW4uY3Bw CisgICAgTElCUkFSSUVTIHNobHdhcGkKKykKK3RhcmdldF9jb21waWxlX2RlZmluaXRpb25zKElt YWdlRGlmZiBQUklWQVRFICR7d3JhcHBlcl9ERUZJTklUSU9OU30pCg==