198473 2019-06-02 20:22:46 -0700 [Win] Implement NetworkCacheBlobStorage.cpp without stat and unlink 2019-06-02 20:40:36 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 fujii webkit-unassigned annulen oldest_to_newest 1541168 0 fujii 2019-06-02 20:22:46 -0700 [Win] Implement NetworkCacheBlobStorage.cpp without stat and unlink unlink is deprecated https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/unlink?view=vs-2019 _unlink https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/unlink-wunlink?view=vs-2019 _stat、_stat32、_stat64、_stati64、_stat32i64、_stat64i32、_wstat、_wstat32、_wstat64、_wstati64、_wstat32i64、_wstat64i32 | Microsoft Docs https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=vs-2019 1541170 1 annulen 2019-06-02 20:34:19 -0700 Proper direction would be to convert as much as possible of NetworkCache code to be cross-platform by using our FileSystem abstractions, e.g. FileSystem::deleteFile instead of unlink In future we may want to use std::filesystem to implement some of operations 1541171 2 annulen 2019-06-02 20:40:36 -0700 And where are substantial differences which require code to be #ifdef'ed, it would be better to avoid increasing of #ifdef's and instead separate parts of code to respective *POSIX.cpp and *Win.cpp files