198457 2019-06-01 11:23:23 -0700 Web Inspector: Canvas: in tests don't manually stop recording if a frame count is specified 2019-06-01 13:19:26 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1540977 0 hi 2019-06-01 11:23:23 -0700 If a `frameCount` is specified, the recording will stop by itself, so if we hit the `LastFrame`, there's no need to manually stop the recording at that point. 1540978 1 hi 2019-06-01 11:23:49 -0700 <rdar://problem/48248697> 1540979 2 371116 hi 2019-06-01 11:30:51 -0700 Created attachment 371116 Patch 1540980 3 371116 joepeck 2019-06-01 11:35:05 -0700 Comment on attachment 371116 Patch r=me 1540996 4 371116 commit-queue 2019-06-01 13:19:24 -0700 Comment on attachment 371116 Patch Clearing flags on attachment: 371116 Committed r246015: <https://trac.webkit.org/changeset/246015> 1540997 5 commit-queue 2019-06-01 13:19:26 -0700 All reviewed patches have been landed. Closing bug. 371116 2019-06-01 11:30:51 -0700 2019-06-01 13:19:24 -0700 Patch bug-198457-20190601113050.patch text/plain 3755 hi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiMjU4YzVmMWU4MWIxODE2ZDIzNTJlOWVjMjBhMTJkNDMwYjg3NjI4Li41MWIyNTk5 NTczOTQyNTc4ZGM0YmI5NjA2YTU1OThmMTVlMTk0ZmQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTktMDYtMDEgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IENhbnZhczogaW4gdGVzdHMgZG9uJ3QgbWFudWFsbHkgc3RvcCByZWNv cmRpbmcgaWYgYSBmcmFtZSBjb3VudCBpcyBzcGVjaWZpZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODQ1NworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDgyNDg2OTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgYSBgZnJhbWVDb3VudGAgaXMgc3BlY2lmaWVkLCB0aGUgcmVjb3JkaW5nIHdpbGwg c3RvcCBieSBpdHNlbGYsIHNvIGlmIHdlIGhpdCB0aGUKKyAgICAgICAgYExhc3RGcmFtZWAsIHRo ZXJlJ3Mgbm8gbmVlZCB0byBtYW51YWxseSBzdG9wIHRoZSByZWNvcmRpbmcgYXQgdGhhdCBwb2lu dC4gT3RoZXJ3aXNlLAorICAgICAgICBzdG9wcGluZyBpdCBlYXJseSBtYXkgY2F1c2UgdGhlIHJl Y29yZGluZyB0byB0aGluayB0aGF0IHRoZSBsYXN0IGZyYW1lIGlzIGluY29tcGxldGUuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvY2FudmFzL3Jlc291cmNlcy9yZWNvcmRpbmctdXRpbGl0aWVzLmpz OgorICAgICAgICAqIGluc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLXdlYmdsLXNuYXBzaG90cy5o dG1sOgorICAgICAgICAqIGluc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLXdlYmdsMi1zbmFwc2hv dHMuaHRtbDoKKwogMjAxOS0wNS0zMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxl LmNvbT4KIAogICAgICAgICBNYWtlIHRlc3RzIHRoYXQgdXNlIFVJSGVscGVyIG1vcmUgcm9idXN0 IHVuZGVyIGNlcnRhaW4gY29uZmlndXJhdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLXdlYmdsLXNuYXBzaG90cy5odG1sIGIvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctd2ViZ2wtc25hcHNob3RzLmh0bWwKaW5kZXgg M2I1ZjMzZTZkMTJjNjNlZWVhNmIxN2IyZDVjZjgyZTUwYTcwOGE4YS4uYjcwYzdjNTllZTZhMGIw M2Y1YWMxOWVmOGMwMWIxZjY1NjgwMTZiOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2NhbnZhcy9yZWNvcmRpbmctd2ViZ2wtc25hcHNob3RzLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctd2ViZ2wtc25hcHNob3RzLmh0bWwKQEAgLTEw MCw3ICsxMDAsNyBAQCBmdW5jdGlvbiB0ZXN0KCkgewogICAgICAgICBuYW1lOiAiQ2FudmFzLnJl Y29yZGluZ1dlYkdMLnNuYXBzaG90cyIsCiAgICAgICAgIGRlc2NyaXB0aW9uOiAiQ2hlY2sgdGhh dCB0aGUgc25hcHNob3QgdGFrZW4gYWZ0ZXIgZWFjaCB2aXN1YWwgYWN0aW9uIGlzIGRpZmZlcmVu dC4iLAogICAgICAgICB0ZXN0KHJlc29sdmUsIHJlamVjdCkgewotICAgICAgICAgICAgc3RhcnRS ZWNvcmRpbmcoV0kuQ2FudmFzLkNvbnRleHRUeXBlLldlYkdMLCByZXNvbHZlLCByZWplY3QsIHtj aGVja0ZvckNvbnRlbnRDaGFuZ2U6IHRydWV9KTsKKyAgICAgICAgICAgIHN0YXJ0UmVjb3JkaW5n KFdJLkNhbnZhcy5Db250ZXh0VHlwZS5XZWJHTCwgcmVzb2x2ZSwgcmVqZWN0LCB7ZnJhbWVDb3Vu dDogMSwgY2hlY2tGb3JDb250ZW50Q2hhbmdlOiB0cnVlfSk7CiAgICAgICAgIH0sCiAgICAgICAg IHRpbWVvdXQ6IC0xLAogICAgIH0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2NhbnZhcy9yZWNvcmRpbmctd2ViZ2wyLXNuYXBzaG90cy5odG1sIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctd2ViZ2wyLXNuYXBzaG90cy5odG1sCmluZGV4IDAxOTA1 MjA2NjBmZTBiZTJlMTA5OTBjZDlmOTk3NGU3MDIzNzgyMjQuLjgyZjI3YzlkNjRmN2RhMzI4NjU1 OTIxZWUzMDg4ODkzOWY2Y2I1OWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9j YW52YXMvcmVjb3JkaW5nLXdlYmdsMi1zbmFwc2hvdHMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvY2FudmFzL3JlY29yZGluZy13ZWJnbDItc25hcHNob3RzLmh0bWwKQEAgLTEwMiw3 ICsxMDIsNyBAQCBmdW5jdGlvbiB0ZXN0KCkgewogICAgICAgICBuYW1lOiAiQ2FudmFzLnJlY29y ZGluZ1dlYkdMMi5zbmFwc2hvdHMiLAogICAgICAgICBkZXNjcmlwdGlvbjogIkNoZWNrIHRoYXQg dGhlIHNuYXBzaG90IHRha2VuIGFmdGVyIGVhY2ggdmlzdWFsIGFjdGlvbiBpcyBkaWZmZXJlbnQu IiwKICAgICAgICAgdGVzdChyZXNvbHZlLCByZWplY3QpIHsKLSAgICAgICAgICAgIHN0YXJ0UmVj b3JkaW5nKFdJLkNhbnZhcy5Db250ZXh0VHlwZS5XZWJHTDIsIHJlc29sdmUsIHJlamVjdCwge2No ZWNrRm9yQ29udGVudENoYW5nZTogdHJ1ZX0pOworICAgICAgICAgICAgc3RhcnRSZWNvcmRpbmco V0kuQ2FudmFzLkNvbnRleHRUeXBlLldlYkdMMiwgcmVzb2x2ZSwgcmVqZWN0LCB7ZnJhbWVDb3Vu dDogMSwgY2hlY2tGb3JDb250ZW50Q2hhbmdlOiB0cnVlfSk7CiAgICAgICAgIH0sCiAgICAgICAg IHRpbWVvdXQ6IC0xLAogICAgIH0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2NhbnZhcy9yZXNvdXJjZXMvcmVjb3JkaW5nLXV0aWxpdGllcy5qcyBiL0xheW91dFRlc3RzL2lu c3BlY3Rvci9jYW52YXMvcmVzb3VyY2VzL3JlY29yZGluZy11dGlsaXRpZXMuanMKaW5kZXggOGI5 OTU2M2QzMjcwYWMzMmNmYzgwZDI5ODRmNWMzODY5NmM1YmViNC4uNjAxNDZmZjM4NDg3ZmQxOTNl MjNkMzM3NDdkZjMxMDQ2Y2M2ODFmMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2NhbnZhcy9yZXNvdXJjZXMvcmVjb3JkaW5nLXV0aWxpdGllcy5qcworKysgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvY2FudmFzL3Jlc291cmNlcy9yZWNvcmRpbmctdXRpbGl0aWVzLmpzCkBAIC0x MDcsOSArMTA3LDEwIEBAIFRlc3RQYWdlLnJlZ2lzdGVySW5pdGlhbGl6ZXIoKCkgPT4gewogICAg ICAgICAudGhlbigoZXZlbnQpID0+IHsKICAgICAgICAgICAgIGxhc3RGcmFtZSA9IHRydWU7CiAK LSAgICAgICAgICAgIGlmIChjYW52YXMucmVjb3JkaW5nQWN0aXZlKQotICAgICAgICAgICAgICAg IENhbnZhc0FnZW50LnN0b3BSZWNvcmRpbmcoY2FudmFzLmlkZW50aWZpZXIpLmNhdGNoKHJlamVj dCk7Ci0gICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgIGlmIChjYW52YXMucmVjb3JkaW5n QWN0aXZlKSB7CisgICAgICAgICAgICAgICAgaWYgKCFmcmFtZUNvdW50KQorICAgICAgICAgICAg ICAgICAgICBDYW52YXNBZ2VudC5zdG9wUmVjb3JkaW5nKGNhbnZhcy5pZGVudGlmaWVyKS5jYXRj aChyZWplY3QpOworICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBJbnNwZWN0 b3JUZXN0LmV2YWx1YXRlSW5QYWdlKGBjYW5jZWxBY3Rpb25zKClgKQogICAgICAgICAgICAgICAg IC50aGVuKCgpID0+IHsKICAgICAgICAgICAgICAgICAgICAgaWYgKHN3aXp6bGVkKQo=