198423 2019-05-31 10:02:05 -0700 [ Mac WK2 ] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky timeout when run locally. 2019-06-03 14:10:43 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198090 InRadar P2 Normal --- 1 sroberts sihui_liu commit-queue jlewis3 rniwa ryanhaddad sihui_liu tsavell webkit-bug-importer youennf oldest_to_newest 1540752 0 sroberts 2019-05-31 10:02:05 -0700 The following API test is failing when run locally. TestWebKitAPI.WKWebView.LocalStorageProcessCrashes Test originally had originally landed in r244540 and was a flaky failure on the bots and when run locally. Test was fixed in r245649 and we have not seen any failures on the bots since this change. However when using my original repro to close out the bug/radar I noticed I get Timeouts on the test when run locally, using my original repro. Reproduced with: run-api-tests TestWebKitAPI.WKWebView.LocalStorageProcessCrashes --iter 30 Gets about 1 timeout in 10 runs. Test suite failed Timeout TestWebKitAPI.WKWebView.LocalStorageProcessCrashes _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. 1540753 1 webkit-bug-importer 2019-05-31 10:02:48 -0700 <rdar://problem/51305247> 1540850 2 371087 sihui_liu 2019-05-31 14:48:17 -0700 Created attachment 371087 Patch 1540909 3 371087 rniwa 2019-05-31 17:23:15 -0700 Comment on attachment 371087 Patch Looks sane to me. You probably want to explain what you told me in the change log so that others can follow what’s happening here. 1540948 4 371108 sihui_liu 2019-05-31 23:02:46 -0700 Created attachment 371108 Patch 1541332 5 371108 commit-queue 2019-06-03 14:10:42 -0700 Comment on attachment 371108 Patch Clearing flags on attachment: 371108 Committed r246050: <https://trac.webkit.org/changeset/246050> 1541333 6 commit-queue 2019-06-03 14:10:43 -0700 All reviewed patches have been landed. Closing bug. 371087 2019-05-31 14:48:17 -0700 2019-05-31 21:23:05 -0700 Patch bug-198423-20190531144816.patch text/plain 3721 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1OTgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjA1NjAyZjU2MTY1OGY4NzY5NmQ0NWE4MTI5ODlhYTJl MDllNTQ5MC4uYjc3YzYxZDMxZWU3MWYwNjNhYTY5OGQwZDEzNDNlODE5MTY0MjRjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTA1LTMxICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIFsgTWFjIFdLMiBdIFRlc3RXZWJLaXRBUEkuV0tXZWJWaWV3LkxvY2FsU3RvcmFnZVByb2Nl c3NDcmFzaGVzIGlzIGEgZmxha3kgdGltZW91dCB3aGVuIHJ1biBsb2NhbGx5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NDIzCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MTMwNTI0Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgdGVzdCBleHBlY3RlZCB0aGUgbGFzdCBtZXNzYWdlIHNlbnQg YWZ0ZXIgbmV0d29yayBwcm9jZXNzIHdhcyByZXN1bWVkLCBidXQgY2hlY2sgZm9yIGxvY2FsIHN0 b3JhZ2UgaXRlbSBpbgorICAgICAgICBsb2NhbC1zdG9yYWdlLXByb2Nlc3Mtc3VzcGVuZHMtMi5o dG1sIG1heSBmaW5pc2ggZWFybGllciBhbmQgc2VuZCB0aGUgbWVzc2FnZSBlYXJsaWVyLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Mb2NhbFN0b3JhZ2VQZXJz aXN0ZW5jZS5tbToKKyAgICAgICAgKFRFU1QpOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Q29jb2EvbG9jYWwtc3RvcmFnZS1wcm9jZXNzLXN1c3BlbmRzLTIuaHRtbDoKKwog MjAxOS0wNS0zMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAg ICAgICBPcHRpb25hbGx5IHJlc3BlY3QgZGV2aWNlIG1hbmFnZW1lbnQgcmVzdHJpY3Rpb25zIHdo ZW4gbG9hZGluZyBmcm9tIHRoZSBuZXR3b3JrCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL0xvY2FsU3RvcmFnZVBlcnNpc3RlbmNlLm1tIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Mb2NhbFN0b3JhZ2VQZXJzaXN0ZW5jZS5t bQppbmRleCAxYmM3OGQ3MTk0OWJhOTcyNDExNmJjZmQ3MjZlY2EzNWI2NmEzYWUyLi4zZGIxNzNm ODgyYjJhOWNkMzI5NGIzMTY5MDkxNzZjMzFiYjA0Y2M1IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0xvY2FsU3RvcmFnZVBlcnNpc3RlbmNlLm1tCisr KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTG9jYWxTdG9yYWdlUGVy c2lzdGVuY2UubW0KQEAgLTExMSw2ICsxMTEsNyBAQCBURVNUKFdLV2ViVmlldywgTG9jYWxTdG9y YWdlUHJvY2Vzc1N1c3BlbmRzKQogICAgIFtbY29uZmlndXJhdGlvbiB1c2VyQ29udGVudENvbnRy b2xsZXJdIGFkZFNjcmlwdE1lc3NhZ2VIYW5kbGVyOmhhbmRsZXIuZ2V0KCkgbmFtZTpAInRlc3RI YW5kbGVyIl07CiAgICAgUmV0YWluUHRyPFdLUHJvY2Vzc1Bvb2w+IHByb2Nlc3NQb29sID0gYWRv cHROUyhbW1dLUHJvY2Vzc1Bvb2wgYWxsb2NdIGluaXRdKTsKICAgICBbY29uZmlndXJhdGlvbiBz ZXRQcm9jZXNzUG9vbDpwcm9jZXNzUG9vbC5nZXQoKV07CisgICAgW2NvbmZpZ3VyYXRpb24gX3Nl dEFsbG93VW5pdmVyc2FsQWNjZXNzRnJvbUZpbGVVUkxzOllFU107CiAKICAgICBSZXRhaW5QdHI8 V0tXZWJWaWV3PiB3ZWJWaWV3MSA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRo RnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0 aW9uLmdldCgpXSk7CiAgICAgTlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCBy ZXF1ZXN0V2l0aFVSTDpbW05TQnVuZGxlIG1haW5CdW5kbGVdIFVSTEZvclJlc291cmNlOkAibG9j YWwtc3RvcmFnZS1wcm9jZXNzLXN1c3BlbmRzLTEiIHdpdGhFeHRlbnNpb246QCJodG1sIiBzdWJk aXJlY3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdXTsKQEAgLTEzOCw3ICsxMzksNyBA QCBURVNUKFdLV2ViVmlldywgTG9jYWxTdG9yYWdlUHJvY2Vzc1N1c3BlbmRzKQogICAgIAogICAg IHJlYWR5VG9Db250aW51ZSA9IGZhbHNlOwogICAgIFt3ZWJWaWV3MiBldmFsdWF0ZUphdmFTY3Jp cHQ6QCJ3aW5kb3cubG9jYWxTdG9yYWdlLmdldEl0ZW0oJ2tleScpIiBjb21wbGV0aW9uSGFuZGxl cjpeKGlkIHJlc3VsdCwgTlNFcnJvciAqKSB7Ci0gICAgICAgIEVYUEVDVF9UUlVFKFtAInZhbHVl IiBpc0VxdWFsVG9TdHJpbmc6cmVzdWx0XSk7CisgICAgICAgIEVYUEVDVF9XS19TVFJFUShAInZh bHVlIiwgcmVzdWx0KTsKICAgICAgICAgcmVhZHlUb0NvbnRpbnVlID0gdHJ1ZTsKICAgICB9XTsK ICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJnJlYWR5VG9Db250aW51ZSk7CmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL2xvY2FsLXN0b3JhZ2Ut cHJvY2Vzcy1zdXNwZW5kcy0yLmh0bWwgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL2xvY2FsLXN0b3JhZ2UtcHJvY2Vzcy1zdXNwZW5kcy0yLmh0bWwKaW5kZXggZDNhMjc2 NGQ2ZTM0ZjlmYTQ1ZTJkZDE2OWU2OWE0MGNmNTUxODljYi4uNmJhMjVkMTAzZGJlNzExODBhNTlj NjI0NTk4ZmI5MzFiYWQxMWQ1NiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9sb2NhbC1zdG9yYWdlLXByb2Nlc3Mtc3VzcGVuZHMtMi5odG1sCisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvbG9jYWwtc3RvcmFnZS1wcm9j ZXNzLXN1c3BlbmRzLTIuaHRtbApAQCAtMSwxNyArMSwxMSBAQAogPCFET0NUWVBFIGh0bWw+CiA8 c2NyaXB0PgogCi12YXIgc3RhcnRWYWx1ZSA9IHdpbmRvdy5sb2NhbFN0b3JhZ2UuZ2V0SXRlbSgn a2V5Jyk7Ci13aW5kb3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVz c2FnZShzdGFydFZhbHVlKTsKK2Z1bmN0aW9uIGNoZWNrTG9jYWxTdG9yYWdlKGV2ZW50KSB7Cisg ICAgd2luZG93LndlYmtpdC5tZXNzYWdlSGFuZGxlcnMudGVzdEhhbmRsZXIucG9zdE1lc3NhZ2Uo d2luZG93LmxvY2FsU3RvcmFnZS5nZXRJdGVtKCdrZXknKSk7Cit9CiAKLXZhciB0cmllcyA9IDEw OwotdmFyIGludGVydmFsSUQgPSBzZXRJbnRlcnZhbCgoKT0+IHsKLSAgICB2YXIgbmV3VmFsdWUg PSB3aW5kb3cubG9jYWxTdG9yYWdlLmdldEl0ZW0oJ2tleScpOwotICAgIGlmIChuZXdWYWx1ZSAh PSBzdGFydFZhbHVlIHx8IHRyaWVzID09IDApIHsKLSAgICAgICAgd2luZG93LndlYmtpdC5tZXNz YWdlSGFuZGxlcnMudGVzdEhhbmRsZXIucG9zdE1lc3NhZ2UobmV3VmFsdWUpOwotICAgICAgICBj bGVhckludGVydmFsKGludGVydmFsSUQpOwotICAgIH0KLSAgICAtLXRyaWVzOwotfSwgMTAwKTsK K2NoZWNrTG9jYWxTdG9yYWdlKCk7Cit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigic3RvcmFnZSIs IGNoZWNrTG9jYWxTdG9yYWdlKTsKIAotPC9zY3JpcHQ+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2Yg ZmlsZQorPC9zY3JpcHQ+Cg== 371108 2019-05-31 23:02:46 -0700 2019-06-03 14:10:42 -0700 Patch bug-198423-20190531230245.patch text/plain 2237 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2RlNDdiNTI2M2Y2YTI1ZGU0OTFhNzg3ZGQ1MTRjYmM3 Y2I5YmY0MS4uMmRlZTlhNjUyM2QxOWU1ZTQ4YzM5NWNhNzQ0YjY4MDgyYjc5ZTM3OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA1LTMxICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIFsgTWFjIFdLMiBdIFRlc3RXZWJLaXRBUEkuV0tXZWJWaWV3LkxvY2FsU3RvcmFnZVByb2Nl c3NDcmFzaGVzIGlzIGEgZmxha3kgdGltZW91dCB3aGVuIHJ1biBsb2NhbGx5LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NDIzCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MTMwNTI0Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJREJEYXRhYmFzZSByZWNlaXZlcyBlcnJvciBldmVudCBvbiBuZXR3 b3JrIHByb2Nlc3MgY3Jhc2gsIHNvIHdlIGRvbid0IG5lZWQgdG8gY2hlY2sgaXQgcGVyaW9kaWNh bGx5LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9sb2NhbC1z dG9yYWdlLXByb2Nlc3MtY3Jhc2hlcy5odG1sOgorCiAyMDE5LTA1LTMxICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIERyYWdBbmREcm9wVGVzdHMuRHJhZ0ltYWdl TG9jYXRpb25Gb3JMaW5rSW5TdWJmcmFtZSBmYWlscyBvbiBzb21lIGlQYWQKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvbG9jYWwtc3RvcmFnZS1wcm9j ZXNzLWNyYXNoZXMuaHRtbCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev bG9jYWwtc3RvcmFnZS1wcm9jZXNzLWNyYXNoZXMuaHRtbAppbmRleCBlMmRjNGYyM2JkMDZhMTBj NTNiYjhiYmU3ZmZlY2QzNDRmMTJjMGQ1Li4xNmQxN2Y5ODI5ZTE4N2Y0OGVkNTYzOTkxMmQ2MGRl M2Y2YzZkNmVmIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL2xvY2FsLXN0b3JhZ2UtcHJvY2Vzcy1jcmFzaGVzLmh0bWwKKysrIGIvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9sb2NhbC1zdG9yYWdlLXByb2Nlc3MtY3Jhc2hlcy5o dG1sCkBAIC0zLDE3ICszLDYgQEAKIAogdmFyIGRiOwogCi1mdW5jdGlvbiBwdXQoKSB7Ci0gICAg dmFyIG9zID0gZGIudHJhbnNhY3Rpb24oWyJUZXN0T2JqZWN0U3RvcmUiXSwgInJlYWR3cml0ZSIp Lm9iamVjdFN0b3JlKCJUZXN0T2JqZWN0U3RvcmUiKTsKLSAgICB2YXIgcmVxdWVzdCA9IG9zLnB1 dCgndmFsdWUnLCAna2V5Jyk7Ci0gICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSAoZXZlbnQpID0+IHsK LSAgICAgICAgc2V0VGltZW91dChwdXQsIDEwMCk7Ci0gICAgfQotICAgIHJlcXVlc3Qub25lcnJv ciA9IChldmVudCk9PiB7Ci0gICAgICAgIHdpbmRvdy53ZWJraXQubWVzc2FnZUhhbmRsZXJzLnRl c3RIYW5kbGVyLnBvc3RNZXNzYWdlKCJOZXR3b3JrIFByb2Nlc3MgQ3Jhc2hlZCIpOwotICAgIH0K LX0KLQogd2luZG93LmxvY2FsU3RvcmFnZS5zZXRJdGVtKCJsb2NhbCIsICJzdG9yYWdlIik7CiB3 aW5kb3cuc2Vzc2lvblN0b3JhZ2Uuc2V0SXRlbSgic2Vzc2lvbiIsICJzdG9yYWdlIik7CiAKQEAg LTIyLDcgKzExLDcgQEAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBmdW5jdGlvbihldmVudCkgewogICAg IHdpbmRvdy53ZWJraXQubWVzc2FnZUhhbmRsZXJzLnRlc3RIYW5kbGVyLnBvc3RNZXNzYWdlKCJs b2NhbDoiICsgd2luZG93LmxvY2FsU3RvcmFnZS5nZXRJdGVtKCJsb2NhbCIpKTsKICAgICB3aW5k b3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgic2Vzc2lv bjoiKyB3aW5kb3cuc2Vzc2lvblN0b3JhZ2UuZ2V0SXRlbSgic2Vzc2lvbiIpKTsKICAgICBkYiA9 IHJlcXVlc3QucmVzdWx0OwotICAgIHB1dCgpOworICAgIGRiLm9uZXJyb3IgPSAoKSA9PiB3aW5k b3cud2Via2l0Lm1lc3NhZ2VIYW5kbGVycy50ZXN0SGFuZGxlci5wb3N0TWVzc2FnZSgiTmV0d29y ayBQcm9jZXNzIENyYXNoZWQiKTsKIH0KIAogcmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQgPSBmdW5j dGlvbihldmVudCkgewo=