198422 2019-05-31 09:47:10 -0700 WebKitTestRunner sometimes freezes under -[NSWindow release] 2019-05-31 11:56:43 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap beidson commit-queue ryanhaddad sroberts thorton oldest_to_newest 1540746 0 ap 2019-05-31 09:47:10 -0700 rdar://problem/50948871 NSWindow does some interesting things when a window that's being deallocated is still the key window. Our code for key window management that was added for gamepad testing makes it so that the window remains the key one until after dealloc, which results in a deadlock. 1540748 1 371065 ap 2019-05-31 09:51:25 -0700 Created attachment 371065 proposed fix 1540787 2 371065 commit-queue 2019-05-31 11:56:42 -0700 Comment on attachment 371065 proposed fix Clearing flags on attachment: 371065 Committed r245975: <https://trac.webkit.org/changeset/245975> 1540788 3 commit-queue 2019-05-31 11:56:43 -0700 All reviewed patches have been landed. Closing bug. 371065 2019-05-31 09:51:25 -0700 2019-05-31 11:56:42 -0700 proposed fix WebKitTestRunnerWindowAllWindows.txt text/plain 2726 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NTk2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE5LTA1LTMxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgc29tZXRpbWVzIGZyZWV6ZXMgdW5kZXIgLVtO U1dpbmRvdyByZWxlYXNlXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4NDIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIHdpbmRvdyByZW1haW5zIGtleSB1bnRpbCBpdCdzIG91dCBvZiB0aGUgYWxs V2luZG93cyB2ZWN0b3IsIGFuZCBBcHBLaXQgaXMgbm90CisgICAgICAgIGhhcHB5IGFib3V0IGRl YWxsb2NhdGluZyBrZXkgd2luZG93cy4gRml4ZWQgYnkgdXBkYXRpbmcgYWxsV2luZG93cyBpbiAt Y2xvc2UKKyAgICAgICAgaW5zdGVhZCBvZiAtcmVsZWFzZS4KKworICAgICAgICBBZGRlZCBpc01h aW5GcmFtZSBhc3NlcnRpb25zIGluIGNvZGUgdGhhdCBtYW5pcHVsYXRlcyBhbGxXaW5kb3dzIGZv ciBhIGdvb2QgbWVhc3VyZS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1dlYktp dFRlc3RSdW5uZXJXaW5kb3cubW06CisgICAgICAgICgrW1dlYktpdFRlc3RSdW5uZXJXaW5kb3cg X1dUUl9rZXlXaW5kb3ddKToKKyAgICAgICAgKC1bV2ViS2l0VGVzdFJ1bm5lcldpbmRvdyBpbml0 V2l0aENvbnRlbnRSZWN0OnN0eWxlTWFzazpiYWNraW5nOmRlZmVyOl0pOgorICAgICAgICAoLVtX ZWJLaXRUZXN0UnVubmVyV2luZG93IGNsb3NlXSk6CisgICAgICAgICgtW1dlYktpdFRlc3RSdW5u ZXJXaW5kb3cgZGVhbGxvY10pOgorCiAyMDE5LTA1LTMxICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTiAoU2FmYXJpIDEyKTog U2FmYXJpRm9yV2Via2l0RGV2ZWxvcG1lbnQgd29uJ3QgbG9hZCBhbnkgcGFnZXMgb24gTW9qYXZl LCBuaWdodGx5IGJ1aWxkcyBicm9rZW4KSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFj L1dlYktpdFRlc3RSdW5uZXJXaW5kb3cubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9tYWMvV2ViS2l0VGVzdFJ1bm5lcldpbmRvdy5tbQkocmV2aXNpb24gMjQ1Nzg2KQor KysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvV2ViS2l0VGVzdFJ1bm5lcldpbmRvdy5tbQko d29ya2luZyBjb3B5KQpAQCAtMjcsNiArMjcsNyBAQAogI2ltcG9ydCAiV2ViS2l0VGVzdFJ1bm5l cldpbmRvdy5oIgogCiAjaW1wb3J0ICJQbGF0Zm9ybVdlYlZpZXcuaCIKKyNpbXBvcnQgPHd0Zi9N YWluVGhyZWFkLmg+CiAjaW1wb3J0IDx3dGYvVmVjdG9yLmg+CiAKIEBpbXBsZW1lbnRhdGlvbiBX ZWJLaXRUZXN0UnVubmVyV2luZG93CkBAIC0zNyw2ICszOCw3IEBAIHN0YXRpYyBWZWN0b3I8V2Vi S2l0VGVzdFJ1bm5lcldpbmRvdyAqPiAKIAogKyAoV2ViS2l0VGVzdFJ1bm5lcldpbmRvdyAqKV9X VFJfa2V5V2luZG93CiB7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBmb3IgKGF1 dG8gd2luZG93IDogYWxsV2luZG93cykgewogICAgICAgICBpZiAoW3dpbmRvdyBpc0tleVdpbmRv d10pCiAgICAgICAgICAgICByZXR1cm4gd2luZG93OwpAQCAtNDYsMTQgKzQ4LDI0IEBAICsgKFdl YktpdFRlc3RSdW5uZXJXaW5kb3cgKilfV1RSX2tleVdpbmQKIAogLSAoaW5zdGFuY2V0eXBlKWlu aXRXaXRoQ29udGVudFJlY3Q6KE5TUmVjdCljb250ZW50UmVjdCBzdHlsZU1hc2s6KE5TVUludGVn ZXIpd2luZG93U3R5bGUgYmFja2luZzooTlNCYWNraW5nU3RvcmVUeXBlKWJ1ZmZlcmluZ1R5cGUg ZGVmZXI6KEJPT0wpZGVmZXJDcmVhdGlvbgogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7 CiAgICAgYWxsV2luZG93cy5hcHBlbmQoc2VsZik7CiAgICAgcmV0dXJuIFtzdXBlciBpbml0V2l0 aENvbnRlbnRSZWN0OmNvbnRlbnRSZWN0IHN0eWxlTWFzazp3aW5kb3dTdHlsZSBiYWNraW5nOmJ1 ZmZlcmluZ1R5cGUgZGVmZXI6ZGVmZXJDcmVhdGlvbl07CiB9CiAKLS0gKHZvaWQpZGVhbGxvYwor LSAodm9pZCljbG9zZQogeworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisgICAgQVNTRVJU KGFsbFdpbmRvd3MuY29udGFpbnMoc2VsZikpOwogICAgIGFsbFdpbmRvd3MucmVtb3ZlRmlyc3Qo c2VsZik7CiAgICAgQVNTRVJUKCFhbGxXaW5kb3dzLmNvbnRhaW5zKHNlbGYpKTsKKyAgICBbc3Vw ZXIgY2xvc2VdOworfQorCistICh2b2lkKWRlYWxsb2MKK3sKKyAgICBBU1NFUlQoaXNNYWluVGhy ZWFkKCkpOworICAgIEFTU0VSVCghYWxsV2luZG93cy5jb250YWlucyhzZWxmKSk7IC8vIFRoZSB3 aW5kb3cgbmVlZHMgdG8gc3RvcCBiZWluZyBrZXkgYmVmb3JlIGRlYWxsb2NhdGlvbiwgb3RoZXJ3 aXNlIEFwcEtpdCBzcGlucyB3YWl0aW5nIGZvciB0aGlzIHRvIGhhcHBlbiAoc2VlIDxyZGFyOi8v cHJvYmxlbS81MDk0ODg3MT4pLgogICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIAo=