198408 2019-05-30 21:21:40 -0700 [WebAuthn] Support more than two FIDO protocol versions 2019-11-13 15:41:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Major --- 181943 1 geoffrey jiewen_tan alex.gaynor bfulgham cdumez commit-queue jiewen_tan jonathan webkit-bug-importer oldest_to_newest 1540618 0 geoffrey 2019-05-30 21:21:40 -0700 readCTAPGetInfoResponse rejects any list of versions with more than two elements, but this precludes any future FIDO versions from being added to the version list. Now there are several Authenticators which have already supported this FIDO 2.1preview and have 3 protocols (["U2F_V2", "FIDO_2_0", "FIDO_2_1_PRE"]). 1540623 1 geoffrey 2019-05-30 21:27:31 -0700 Chrome has fixed this bug, https://chromium-review.googlesource.com/c/chromium/src/+/1534868 . 1540653 2 webkit-bug-importer 2019-05-30 23:17:10 -0700 <rdar://problem/51292176> 1560369 3 geoffrey 2019-08-12 01:36:46 -0700 Any update of this? 1569714 4 378504 jiewen_tan 2019-09-10 16:06:06 -0700 Created attachment 378504 Patch 1571309 5 jiewen_tan 2019-09-16 15:58:29 -0700 Thanks, Chris. 1571327 6 commit-queue 2019-09-16 16:27:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 378504: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html bug 201849 The commit-queue is continuing to process your patch. 1571328 7 378504 commit-queue 2019-09-16 16:28:17 -0700 Comment on attachment 378504 Patch Clearing flags on attachment: 378504 Committed r249927: <https://trac.webkit.org/changeset/249927> 1571329 8 commit-queue 2019-09-16 16:28:18 -0700 All reviewed patches have been landed. Closing bug. 378504 2019-09-10 16:06:06 -0700 2019-09-16 16:28:17 -0700 Patch bug-198408-20190910160605.patch text/plain 5861 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJhNTIwNjhmNWNkODI3 Y2M4OWYwZmQ5YzE0MmI2MTkyMWJjZmYxZC4uYTg4YzdkMDJkYjVkODkwYTBhNmUwNmVkNjY1NGQy OWFhNDVhYWIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA5LTEwICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1dGhuXSBTdXBw b3J0IG1vcmUgdGhhbiB0d28gRklETyBwcm90b2NvbCB2ZXJzaW9ucworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NDA4CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81MTI5MjE3Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb3ZlcmVkIGJ5IG5ldyBBUEkgdGVzdHMuCisKKyAgICAgICAgKiBNb2R1bGVz L3dlYmF1dGhuL2ZpZG8vRGV2aWNlUmVzcG9uc2VDb252ZXJ0ZXIuY3BwOgorICAgICAgICAoZmlk bzo6cmVhZENUQVBHZXRJbmZvUmVzcG9uc2UpOgorICAgICAgICBSZW1vdmUgdGhlIGNoZWNrIGZv ciB0aGUgYXJyYXkgc2l6ZS4KKwogMjAxOS0wOS0xMCAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IFsgQ2F0YWxpbmEgV0syIF0gaHR0cC93 cHQvd2ViYXV0aG4vcHVibGljLWtleS1jcmVkZW50aWFsLWNyZWF0ZS1zdWNjZXNzLXUyZi5odHRw cy5odG1sIGlzIGZhaWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi YXV0aG4vZmlkby9EZXZpY2VSZXNwb25zZUNvbnZlcnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1dGhuL2ZpZG8vRGV2aWNlUmVzcG9uc2VDb252ZXJ0ZXIuY3BwCmluZGV4IGRh ZmJlZmQ5YzdkYjY4M2IxNDk1MDUyZWJjMmQxOWJiODI0MGU4NGIuLmRhNDYxZmMxMDIyZmNhZDdl OWYyOTQzYzRlZDMzZDdmMzRmMWYzYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXV0aG4vZmlkby9EZXZpY2VSZXNwb25zZUNvbnZlcnRlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdXRobi9maWRvL0RldmljZVJlc3BvbnNlQ29udmVydGVyLmNw cApAQCAtMTk1LDcgKzE5NSw3IEBAIE9wdGlvbmFsPEF1dGhlbnRpY2F0b3JHZXRJbmZvUmVzcG9u c2U+IHJlYWRDVEFQR2V0SW5mb1Jlc3BvbnNlKGNvbnN0IFZlY3Rvcjx1aW50CiAgICAgY29uc3Qg YXV0byYgcmVzcG9uc2VNYXAgPSBkZWNvZGVkUmVzcG9uc2UtPmdldE1hcCgpOwogCiAgICAgYXV0 byBpdCA9IHJlc3BvbnNlTWFwLmZpbmQoQ0JPUigxKSk7Ci0gICAgaWYgKGl0ID09IHJlc3BvbnNl TWFwLmVuZCgpIHx8ICFpdC0+c2Vjb25kLmlzQXJyYXkoKSB8fCBpdC0+c2Vjb25kLmdldEFycmF5 KCkuc2l6ZSgpID4gMikKKyAgICBpZiAoaXQgPT0gcmVzcG9uc2VNYXAuZW5kKCkgfHwgIWl0LT5z ZWNvbmQuaXNBcnJheSgpKQogICAgICAgICByZXR1cm4gV1RGOjpudWxsb3B0OwogICAgIFN0ZFNl dDxQcm90b2NvbFZlcnNpb24+IHByb3RvY29sVmVyc2lvbnM7CiAgICAgZm9yIChjb25zdCBhdXRv JiB2ZXJzaW9uIDogaXQtPnNlY29uZC5nZXRBcnJheSgpKSB7CmRpZmYgLS1naXQgYS9Ub29scy9D aGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDRkODVkMDA4MTIxNDliNGM4OTIwOTll YTk3ODczZTQ2MTFmNTRkNi4uYjg0YjJjNmI0Y2M3YTIyMzllN2M5MGVkYmFiMDk3N2I3MTRjZDJk NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDE5LTA5LTEwICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5j b20+CisKKyAgICAgICAgW1dlYkF1dGhuXSBTdXBwb3J0IG1vcmUgdGhhbiB0d28gRklETyBwcm90 b2NvbCB2ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk4NDA4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTI5MjE3Nj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIGEgbmV3IHRlc3Qg Y2FzZSB0aGF0IGluY2x1ZGVzIGEgRklET18yXzFfUFJFIHZlcnNpb24gc3RyaW5nLgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0N0YXBSZXNwb25zZVRlc3QuY3BwOgor ICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisgICAgICAgICogVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJDb3JlL0ZpZG9UZXN0RGF0YS5oOgorCiAyMDE5LTA5LTEwICBLZWl0aCBSb2xsaW4g IDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgU1NMLWJhc2VkIFRMU0RlcHJl Y2F0aW9uLm1tIGNvbnRlbnRzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYkNvcmUvQ3RhcFJlc3BvbnNlVGVzdC5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYkNvcmUvQ3RhcFJlc3BvbnNlVGVzdC5jcHAKaW5kZXggYTdkY2FiMGI3NmE3MjhmODkyZTdi NDM5MGZjNDg1YWM4ZTcxN2Y4Yi4uY2FjYTU5OGRjZTZhY2MyZWZjZGQ5NmVkODZhZDZmOTU1YzMx MTNkMiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0N0YXBS ZXNwb25zZVRlc3QuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9D dGFwUmVzcG9uc2VUZXN0LmNwcApAQCAtNTcyLDYgKzU3MiwyMSBAQCBURVNUKENUQVBSZXNwb25z ZVRlc3QsIFRlc3RSZWFkR2V0SW5mb1Jlc3BvbnNlKQogICAgIEVYUEVDVF9FUShBdXRoZW50aWNh dG9yU3VwcG9ydGVkT3B0aW9uczo6Q2xpZW50UGluQXZhaWxhYmlsaXR5OjprU3VwcG9ydGVkQnV0 UGluTm90U2V0LCBnZXRJbmZvUmVzcG9uc2UtPm9wdGlvbnMoKS5jbGllbnRQaW5BdmFpbGFiaWxp dHkoKSk7CiB9CiAKK1RFU1QoQ1RBUFJlc3BvbnNlVGVzdCwgVGVzdFJlYWRHZXRJbmZvUmVzcG9u c2UyKQoreworICAgIGF1dG8gZ2V0SW5mb1Jlc3BvbnNlID0gcmVhZENUQVBHZXRJbmZvUmVzcG9u c2UoY29udmVydEJ5dGVzVG9WZWN0b3IoVGVzdERhdGE6OmtUZXN0R2V0SW5mb1Jlc3BvbnNlUGxh dGZvcm1EZXZpY2UyLCBzaXplb2YoVGVzdERhdGE6OmtUZXN0R2V0SW5mb1Jlc3BvbnNlUGxhdGZv cm1EZXZpY2UyKSkpOworICAgIEFTU0VSVF9UUlVFKGdldEluZm9SZXNwb25zZSk7CisgICAgQVNT RVJUX1RSVUUoZ2V0SW5mb1Jlc3BvbnNlLT5tYXhNc2dTaXplKCkpOworICAgIEVYUEVDVF9FUSgq Z2V0SW5mb1Jlc3BvbnNlLT5tYXhNc2dTaXplKCksIDEyMDB1KTsKKyAgICBFWFBFQ1RfTkUoZ2V0 SW5mb1Jlc3BvbnNlLT52ZXJzaW9ucygpLmZpbmQoUHJvdG9jb2xWZXJzaW9uOjprQ3RhcCksIGdl dEluZm9SZXNwb25zZS0+dmVyc2lvbnMoKS5lbmQoKSk7CisgICAgRVhQRUNUX05FKGdldEluZm9S ZXNwb25zZS0+dmVyc2lvbnMoKS5maW5kKFByb3RvY29sVmVyc2lvbjo6a1UyZiksIGdldEluZm9S ZXNwb25zZS0+dmVyc2lvbnMoKS5lbmQoKSk7CisgICAgRVhQRUNUX1RSVUUoZ2V0SW5mb1Jlc3Bv bnNlLT5vcHRpb25zKCkuaXNQbGF0Zm9ybURldmljZSgpKTsKKyAgICBFWFBFQ1RfVFJVRShnZXRJ bmZvUmVzcG9uc2UtPm9wdGlvbnMoKS5zdXBwb3J0c1Jlc2lkZW50S2V5KCkpOworICAgIEVYUEVD VF9UUlVFKGdldEluZm9SZXNwb25zZS0+b3B0aW9ucygpLnVzZXJQcmVzZW5jZVJlcXVpcmVkKCkp OworICAgIEVYUEVDVF9FUShBdXRoZW50aWNhdG9yU3VwcG9ydGVkT3B0aW9uczo6VXNlclZlcmlm aWNhdGlvbkF2YWlsYWJpbGl0eTo6a1N1cHBvcnRlZEFuZENvbmZpZ3VyZWQsIGdldEluZm9SZXNw b25zZS0+b3B0aW9ucygpLnVzZXJWZXJpZmljYXRpb25BdmFpbGFiaWxpdHkoKSk7CisgICAgRVhQ RUNUX0VRKEF1dGhlbnRpY2F0b3JTdXBwb3J0ZWRPcHRpb25zOjpDbGllbnRQaW5BdmFpbGFiaWxp dHk6OmtTdXBwb3J0ZWRCdXRQaW5Ob3RTZXQsIGdldEluZm9SZXNwb25zZS0+b3B0aW9ucygpLmNs aWVudFBpbkF2YWlsYWJpbGl0eSgpKTsKK30KKwogVEVTVChDVEFQUmVzcG9uc2VUZXN0LCBUZXN0 UmVhZEdldEluZm9SZXNwb25zZVdpdGhJbmNvcnJlY3RGb3JtYXQpCiB7CiAgICAgRVhQRUNUX0ZB TFNFKHJlYWRDVEFQR2V0SW5mb1Jlc3BvbnNlKGNvbnZlcnRCeXRlc1RvVmVjdG9yKGtUZXN0QXV0 aGVudGljYXRvckdldEluZm9SZXNwb25zZVdpdGhOb1ZlcnNpb24sIHNpemVvZihrVGVzdEF1dGhl bnRpY2F0b3JHZXRJbmZvUmVzcG9uc2VXaXRoTm9WZXJzaW9uKSkpKTsKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9GaWRvVGVzdERhdGEuaCBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9GaWRvVGVzdERhdGEuaAppbmRleCA5Mjc5MjAxMGIz NDE0YjVjODAwMGQwOWJiZmJlM2I4ZGFjYzhjMGI2Li4wMDg2ZTZlMDU5MzM4MjAxYTRiZGY4NDI3 YzcwNzM1MjYxNTQ2NDg4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YkNvcmUvRmlkb1Rlc3REYXRhLmgKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJD b3JlL0ZpZG9UZXN0RGF0YS5oCkBAIC02MDQsNiArNjA0LDIzIEBAIGNvbnN0ZXhwciB1aW50OF90 IGtUZXN0R2V0SW5mb1Jlc3BvbnNlUGxhdGZvcm1EZXZpY2VbXSA9IHsKICAgICAweDE5LCAweDA0 LCAweEIwLCAweDA2LCAweDgxLCAweDAxLAogfTsKIAorY29uc3RleHByIHVpbnQ4X3Qga1Rlc3RH ZXRJbmZvUmVzcG9uc2VQbGF0Zm9ybURldmljZTJbXSA9IHsKKyAgICAweDAwLCAweEE2LCAweDAx LCAweDgzLCAweDY4LCAweDQ2LCAweDQ5LCAweDQ0LCAweDRGLCAweDVGLCAweDMyLCAweDVGLAor ICAgIDB4MzAsIDB4NjYsIDB4NTUsIDB4MzIsIDB4NDYsIDB4NUYsIDB4NTYsIDB4MzIsIDB4NkMs IDB4NDYsIDB4NDksIDB4NDQsCisgICAgMHg0RiwgMHg1RiwgMHgzMiwgMHg1RiwgMHgzMSwgMHg1 RiwgMHg1MCwgMHg1MiwgMHg0NSwgMHgwMiwgMHg4MiwgMHg2MywKKyAgICAweDc1LCAweDc2LCAw eDZELCAweDZCLCAweDY4LCAweDZELCAweDYxLCAweDYzLCAweDJELCAweDczLCAweDY1LCAweDYz LAorICAgIDB4NzIsIDB4NjUsIDB4NzQsIDB4MDMsIDB4NTAsIDB4RjgsIDB4QTAsIDB4MTEsIDB4 RjMsIDB4OEMsIDB4MEEsIDB4NEQsCisgICAgMHgxNSwgMHg4MCwgMHgwNiwgMHgxNywgMHgxMSwg MHgxRiwgMHg5RSwgMHhEQywgMHg3RCwgMHgwNCwgMHhBNSwgMHg2MiwKKyAgICAweDcyLCAweDZC LCAweEY1LCAweDYyLCAweDc1LCAweDcwLCAweEY1LCAweDYyLCAweDc1LCAweDc2LCAweEY1LCAw eDY0LAorICAgIDB4NzAsCisgICAgLy8gcGxhdGZvcm0gZGV2aWNlIDogdHJ1ZQorICAgIDB4NkMs IDB4NjEsIDB4NzQsIDB4RjUsCisgICAgLy8gRW5kIG9mIHBsYXRmb3JtX2RldmljZSBzZXR0aW5n LgorICAgIDB4NjksIDB4NjMsIDB4NkMsIDB4NjksIDB4NjUsIDB4NkUsIDB4NzQsIDB4NTAsIDB4 NjksIDB4NkUsIDB4RjQsIDB4MDUsCisgICAgMHgxOSwgMHgwNCwgMHhCMCwgMHgwNiwgMHg4MSwg MHgwMSwKK307CisKKwogLy8gQSBTYW1wbGUgd2VsbCBmb3JtZWQgcmVzcG9uc2UgdG8gQ1RBUCBN YWtlQ3JlZGVudGlhbCByZXF1ZXN0LgogY29uc3RleHByIHVpbnQ4X3Qga1Rlc3RNYWtlQ3JlZGVu dGlhbFJlc3BvbnNlW10gPSB7CiAgICAgLy8gU3VjY2VzcyBzdGF0dXMgYnl0ZQo=