198396 2019-05-30 16:01:50 -0700 [CMake] Add WEBKIT_FRAMEWORK_TARGET macro 2019-05-30 17:46:45 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead achristensen annulen commit-queue mcatanzaro oldest_to_newest 1540491 0 don.olmstead 2019-05-30 16:01:50 -0700 Add a macro to create the WebKit::${_target} targets. This will eventually roll into WEBKIT_FRAMEWORK after everything is using WEBKIT_FRAMEWORK_TARGET. 1540509 1 370993 don.olmstead 2019-05-30 16:34:09 -0700 Created attachment 370993 Patch 1540530 2 370993 annulen 2019-05-30 17:08:57 -0700 Comment on attachment 370993 Patch _WEBKIT_TARGET, WEBKIT_FRAMEWORK_TARGET... Targets everywhere! 1540547 3 370993 commit-queue 2019-05-30 17:46:44 -0700 Comment on attachment 370993 Patch Clearing flags on attachment: 370993 Committed r245940: <https://trac.webkit.org/changeset/245940> 1540548 4 commit-queue 2019-05-30 17:46:45 -0700 All reviewed patches have been landed. Closing bug. 370993 2019-05-30 16:34:09 -0700 2019-05-30 17:46:44 -0700 Patch bug-198396.diff text/plain 4454 don.olmstead ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggZTc5ZjQx MjU5ZTQuLjQ1OWVhN2I4MzllIDEwMDY0NAotLS0gYS9DTWFrZUxpc3RzLnR4dAorKysgYi9DTWFr ZUxpc3RzLnR4dApAQCAtMTM5LDYgKzEzOSw3IEBAIGVuZGlmICgpCiAjIEJ5IGRlZmF1bHQsIG9u bHkgdGhlIGhpZ2hlc3QtbGV2ZWwgbGlicmFyaWVzLCBXZWJLaXRMZWdhY3kgYW5kIFdlYktpdCwg YXJlCiAjIHNoYXJlZCwgYmVjYXVzZSBwcm9wZXJseSBidWlsZGluZyBzaGFyZWQgbGlicmFyaWVz IHRoYXQgZGVwZW5kIG9uIGVhY2ggb3RoZXIKICMgY2FuIGJlIHRyaWNreS4gT3ZlcnJpZGUgdGhl c2UgaW4gT3B0aW9ucyouY21ha2UgZm9yIHlvdXIgcG9ydCBhcyBuZWVkZWQuCitzZXQoYm1hbGxv Y19MSUJSQVJZX1RZUEUgU1RBVElDKQogc2V0KFdURl9MSUJSQVJZX1RZUEUgU1RBVElDKQogc2V0 KEphdmFTY3JpcHRDb3JlX0xJQlJBUllfVFlQRSBTVEFUSUMpCiBzZXQoUEFMX0xJQlJBUllfVFlQ RSBTVEFUSUMpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNmQ3ZGM5 NzVjY2QuLmZmNWZhNTk3NDYyIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDUtMzAgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVh ZEBzb255LmNvbT4KKworICAgICAgICBbQ01ha2VdIEFkZCBXRUJLSVRfRlJBTUVXT1JLX1RBUkdF VCBtYWNybworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk4Mzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGEgbWFjcm8gdG8gaGVscCBjcmVhdGUgdGhlIFdlYktpdDo6dGFyZ2V0cyBpbiBDTWFrZS4K KworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJL aXRNYWNyb3MuY21ha2U6CisKIDIwMTktMDUtMjkgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVh ZEBzb255LmNvbT4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFIGRlZmluaXRpb25zIGZyb20gV2Vi S2l0IGNvbmZpZyBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvQ01ha2VMaXN0cy50 eHQgYi9Tb3VyY2UvYm1hbGxvYy9DTWFrZUxpc3RzLnR4dAppbmRleCAyZTA3ZjFhNmEwYS4uYjc4 YmIzODgwM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9ibWFsbG9jL0NNYWtlTGlzdHMudHh0CkBAIC0xNDEsMzAgKzE0MSwyNyBAQCBzZXQo Ym1hbGxvY19MSUJSQVJJRVMKICAgICAke0NNQUtFX0RMX0xJQlN9CiApCiAKLVdFQktJVF9JTkNM VURFX0NPTkZJR19GSUxFU19JRl9FWElTVFMoKQorc2V0KGJtYWxsb2NfSU5URVJGQUNFX0xJQlJB UklFUyBibWFsbG9jKQorc2V0KGJtYWxsb2NfSU5URVJGQUNFX0lOQ0xVREVfRElSRUNUT1JJRVMg JHtibWFsbG9jX0ZSQU1FV09SS19IRUFERVJTX0RJUn0pCitzZXQoYm1hbGxvY19JTlRFUkZBQ0Vf REVQRU5ERU5DSUVTIGJtYWxsb2NfQ29weUhlYWRlcnMpCiAKLVdFQktJVF9XUkFQX1NPVVJDRUxJ U1QoJHtibWFsbG9jX1NPVVJDRVN9KQorc2V0KG1ibWFsbG9jX0xJQlJBUklFUyBibWFsbG9jKQog Ci1hZGRfbGlicmFyeShibWFsbG9jIFNUQVRJQyAke2JtYWxsb2NfU09VUkNFU30pCi10YXJnZXRf aW5jbHVkZV9kaXJlY3RvcmllcyhibWFsbG9jIFBSSVZBVEUgJHtibWFsbG9jX1BSSVZBVEVfSU5D TFVERV9ESVJFQ1RPUklFU30pCi10YXJnZXRfaW5jbHVkZV9kaXJlY3RvcmllcyhibWFsbG9jIElO VEVSRkFDRSAiJDxCVUlMRF9JTlRFUkZBQ0U6JHtibWFsbG9jX0ZSQU1FV09SS19IRUFERVJTX0RJ Un0+IikKLXRhcmdldF9saW5rX2xpYnJhcmllcyhibWFsbG9jICR7Ym1hbGxvY19MSUJSQVJJRVN9 KQotc2V0X3RhcmdldF9wcm9wZXJ0aWVzKGJtYWxsb2MgUFJPUEVSVElFUyBDT01QSUxFX0RFRklO SVRJT05TICJCVUlMRElOR19ibWFsbG9jIikKK1dFQktJVF9GUkFNRVdPUktfREVDTEFSRShibWFs bG9jKQorV0VCS0lUX0lOQ0xVREVfQ09ORklHX0ZJTEVTX0lGX0VYSVNUUygpCiAKIFdFQktJVF9D T1BZX0ZJTEVTKGJtYWxsb2NfQ29weUhlYWRlcnMKICAgICBERVNUSU5BVElPTiAke2JtYWxsb2Nf RlJBTUVXT1JLX0hFQURFUlNfRElSfQogICAgIEZJTEVTICR7Ym1hbGxvY19QVUJMSUNfSEVBREVS U30KICkKIAotYWRkX2xpYnJhcnkoYm1hbGxvY19Qb3N0QnVpbGQgSU5URVJGQUNFKQotdGFyZ2V0 X2xpbmtfbGlicmFyaWVzKGJtYWxsb2NfUG9zdEJ1aWxkIElOVEVSRkFDRSBibWFsbG9jKQotYWRk X2RlcGVuZGVuY2llcyhibWFsbG9jX1Bvc3RCdWlsZCBibWFsbG9jX0NvcHlIZWFkZXJzKQotCi1h ZGRfbGlicmFyeShXZWJLaXQ6OmJtYWxsb2MgQUxJQVMgYm1hbGxvY19Qb3N0QnVpbGQpCitXRUJL SVRfV1JBUF9TT1VSQ0VMSVNUKCR7Ym1hbGxvY19TT1VSQ0VTfSkKK1dFQktJVF9GUkFNRVdPUkso Ym1hbGxvYykKK1dFQktJVF9GUkFNRVdPUktfVEFSR0VUKGJtYWxsb2MpCiAKIGlmIChERVZFTE9Q RVJfTU9ERSkKICAgICBhZGRfbGlicmFyeShtYm1hbGxvYyBTSEFSRUQgYm1hbGxvYy9tYm1hbGxv Yy5jcHApCiAgICAgdGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMobWJtYWxsb2MgUFJJVkFURSAk e2JtYWxsb2NfUFJJVkFURV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKLSAgICB0YXJnZXRfbGlua19s aWJyYXJpZXMobWJtYWxsb2MgYm1hbGxvYyAke0NNQUtFX1RIUkVBRF9MSUJTX0lOSVR9ICR7Ym1h bGxvY19MSUJSQVJJRVN9KQorICAgIHRhcmdldF9saW5rX2xpYnJhcmllcyhtYm1hbGxvYyAke0NN QUtFX1RIUkVBRF9MSUJTX0lOSVR9ICR7bWJtYWxsb2NfTElCUkFSSUVTfSAke2JtYWxsb2NfTElC UkFSSUVTfSkKICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMobWJtYWxsb2MgUFJPUEVSVElFUyBD T01QSUxFX0RFRklOSVRJT05TICJCVUlMRElOR19tYm1hbGxvYyIpCiBlbmRpZiAoKQpkaWZmIC0t Z2l0IGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nIGIvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9n CmluZGV4IGRkZmQ4MDY3Yjk2Li43YWJmYTBlZTliMSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxs b2MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTA1LTMwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisK KyAgICAgICAgW0NNYWtlXSBBZGQgV0VCS0lUX0ZSQU1FV09SS19UQVJHRVQgbWFjcm8KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODM5NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBXRUJLSVRfRlJB TUVXT1JLX1RBUkdFVC4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE5LTA1LTIz ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtl XSBVc2UgdGFyZ2V0IG9yaWVudGVkIGRlc2lnbiBmb3IgYm1hbGxvYwpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3Mu Y21ha2UKaW5kZXggNmQ1N2VlMzQ4NzUuLjlhMDljYjdjNDhkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3Mu Y21ha2UKQEAgLTE5Nyw2ICsxOTcsMTUgQEAgbWFjcm8oV0VCS0lUX0ZSQU1FV09SSyBfdGFyZ2V0 KQogICAgIGVuZGlmICgpCiBlbmRtYWNybygpCiAKKyMgRklYTUUgTW92ZSBpbnRvIFdFQktJVF9G UkFNRVdPUksgYWZ0ZXIgYWxsIGxpYnJhcmllcyBhcmUgdXNpbmcgdGhpcyBtYWNybworbWFjcm8o V0VCS0lUX0ZSQU1FV09SS19UQVJHRVQgX3RhcmdldCkKKyAgICBhZGRfbGlicmFyeSgke190YXJn ZXR9X1Bvc3RCdWlsZCBJTlRFUkZBQ0UpCisgICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKCR7X3Rh cmdldH1fUG9zdEJ1aWxkIElOVEVSRkFDRSAkeyR7X3RhcmdldH1fSU5URVJGQUNFX0xJQlJBUklF U30pCisgICAgdGFyZ2V0X2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtfdGFyZ2V0fV9Qb3N0QnVpbGQg SU5URVJGQUNFICR7JHtfdGFyZ2V0fV9JTlRFUkZBQ0VfSU5DTFVERV9ESVJFQ1RPUklFU30pCisg ICAgYWRkX2RlcGVuZGVuY2llcygke190YXJnZXR9X1Bvc3RCdWlsZCAkeyR7X3RhcmdldH1fSU5U RVJGQUNFX0RFUEVOREVOQ0lFU30pCisgICAgYWRkX2xpYnJhcnkoV2ViS2l0Ojoke190YXJnZXR9 IEFMSUFTICR7X3RhcmdldH1fUG9zdEJ1aWxkKQorZW5kbWFjcm8oKQorCiBtYWNybyhXRUJLSVRf RVhFQ1VUQUJMRSBfdGFyZ2V0KQogICAgIF9XRUJLSVRfVEFSR0VUKCR7X3RhcmdldH0gJHtfdGFy Z2V0fSkKIAo=