198349 2019-05-29 13:23:21 -0700 check-webkit-style reports false-positive build/include_order warning in WTF C++ source files 2019-05-29 15:06:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198346 https://bugs.webkit.org/show_bug.cgi?id=198351 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen bburg cgarcia commit-queue ews-watchlist glenn mcatanzaro thorton timothy webkit-bug-importer oldest_to_newest 1540077 0 ddkilzer 2019-05-29 13:23:21 -0700 check-webkit-style reports false-positive build/include_order warning in WTF C++ source files. For example, see Bug 198346 Comment #3: <https://bugs.webkit.org/show_bug.cgi?id=198346#c3> ERROR: Source/WTF/wtf/CrossThreadTaskHandler.cpp:29: Alphabetical sorting problem. [build/include_order] [4] For this source in Source/WTF/wtf/CrossThreadTaskHandler.cpp: #include "config.h" #include <wtf/CrossThreadTaskHandler.h> #include <wtf/AutodrainedPool.h> For whatever reason, most C++ source files in WTF use <wtf/Header.h> instead of "Header.h". 1540107 1 ddkilzer 2019-05-29 14:16:13 -0700 This fix cuts down on a HUGE amount of false-positives about a missing primary header when running this command: $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WTF 2>&1 | grep -i primary 1540109 2 370883 ddkilzer 2019-05-29 14:17:18 -0700 Created attachment 370883 Patch v1 1540116 3 370883 achristensen 2019-05-29 14:37:52 -0700 Comment on attachment 370883 Patch v1 r=me This is necessary so that #pragma once can work with WTF headers, which would otherwise sometimes be included from the build directory and sometimes from the source causing duplicate declarations from including two copies of the same header. 1540118 4 ddkilzer 2019-05-29 14:39:00 -0700 (In reply to Alex Christensen from comment #3) > Comment on attachment 370883 [details] > Patch v1 > > r=me > This is necessary so that #pragma once can work with WTF headers, which > would otherwise sometimes be included from the build directory and sometimes > from the source causing duplicate declarations from including two copies of > the same header. Thanks for the explanation! 1540131 5 370883 commit-queue 2019-05-29 15:05:06 -0700 Comment on attachment 370883 Patch v1 Clearing flags on attachment: 370883 Committed r245870: <https://trac.webkit.org/changeset/245870> 1540132 6 commit-queue 2019-05-29 15:05:07 -0700 All reviewed patches have been landed. Closing bug. 1540133 7 webkit-bug-importer 2019-05-29 15:06:19 -0700 <rdar://problem/51238831> 370883 2019-05-29 14:17:18 -0700 2019-05-29 15:05:06 -0700 Patch v1 bug-198349-20190529141717.patch text/plain 5069 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDMzYjhhZjdjNjJjYzhjY2YxY2UxZmYyZmQ3NGEzZWNm YTI3ZTVlYS4uMjdjM2I5ZDkxY2Q3MTM4ODMwMjUzZDliZTM0MWIzYTJjNDViNjhlMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTA1LTI5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIHJlcG9ydHMgZmFsc2UtcG9zaXRpdmUgYnVpbGQvaW5j bHVkZV9vcmRlciB3YXJuaW5nIGluIFdURiBDKysgc291cmNlIGZpbGVzCisgICAgICAgIDxodHRw czovL3dlYmtpdC5vcmcvYi8xOTgzNDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eToKKyAgICAgICAgKF9jbGFzc2lmeV9pbmNsdWRlKTogRG9uJ3QgcmV0dXJuIGVhcmx5IGZvciA8 d3RmL0hlYWRlci5oPgorICAgICAgICBpbmNsdWRlcy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKE9yZGVyT2ZJbmNs dWRlc1Rlc3QudGVzdF9wcmltYXJ5X2hlYWRlcik6IEFkZCB0ZXN0cyBmb3IKKyAgICAgICAgPHd0 Zi9IZWFkZXIuaD4gaW5jbHVkZXMuCisKIDIwMTktMDUtMjkgIEFha2FzaCBKYWluICA8YWFrYXNo X2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUgRmxha3kgQVBJIFRlc3QgVGVzdFdl YktpdEFQSS5fV0tEb3dubG9hZC5Eb3dubG9hZE1vbml0b3JDYW5jZWwKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNGFkZGU3YWFmMjZiZDU4NTQ4 NjJlZjdkYWM1Y2QxZmMzNWVjN2I0MS4uNTRiMTM2ODNkZGEzYWIzY2QzZGY2ZjZlMDRiMzY4MWQ4 ZTU2NDZhZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHkKQEAgLTMwMzEsNyArMzAzMSw3IEBAIGRlZiBfY2xhc3NpZnlfaW5jbHVkZShmaWxlbmFtZSwg aW5jbHVkZSwgaXNfc3lzdGVtLCBpbmNsdWRlX3N0YXRlKToKICAgICAiIiIKIAogICAgICMgSWYg aXQgaXMgYSBzeXN0ZW0gaGVhZGVyIHdlIGtub3cgaXQgaXMgY2xhc3NpZmllZCBhcyBfT1RIRVJf SEVBREVSLgotICAgIGlmIGlzX3N5c3RlbSBhbmQgbm90IGluY2x1ZGUuc3RhcnRzd2l0aCgncHVi bGljLycpOgorICAgIGlmIGlzX3N5c3RlbSBhbmQgbm90IGluY2x1ZGUuc3RhcnRzd2l0aCgncHVi bGljLycpIGFuZCBub3QgaW5jbHVkZS5zdGFydHN3aXRoKCd3dGYvJyk6CiAgICAgICAgIHJldHVy biBfT1RIRVJfSEVBREVSCiAKICAgICAjIElmIHRoZSBpbmNsdWRlIGlzIG5hbWVkIGNvbmZpZy5o IHRoZW4gdGhpcyBpcyBXZWJDb3JlL2NvbmZpZy5oLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBmODM5N2U0ZTYy ZTExYjI2N2M3NGEyYTRmZjYxNTM0NDhiZTdlMzg0Li43MzE3OWFiNzQzNDhlNTUwNjFkNWQ1YzQ0 NjE1NGZkZjVmY2I1YTU1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMzEyOSw4ICszMTI5LDEwIEBAIGNsYXNz IE9yZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICdcbicKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJyNpbmNsdWRlICJiYXIuaCJcbicsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICcnKQorCiAgICAgICAgICMgUHJldGVuZCB0aGF0IGhlYWRl ciBmaWxlcyBleGlzdC4KICAgICAgICAgb3MucGF0aC5pc2ZpbGUgPSBsYW1iZGEgZmlsZW5hbWU6 IFRydWUKKwogICAgICAgICAjIE1pc3NpbmcgaW5jbHVkZSBmb3IgZXhpc3RpbmcgcHJpbWFyeSBo ZWFkZXIgLT4gZXJyb3IuCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNr KCdmb28uY3BwJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNp bmNsdWRlICJjb25maWcuaCJcbicKQEAgLTMxMzksMTIgKzMxNDEsMTQgQEAgY2xhc3MgT3JkZXJP ZkluY2x1ZGVzVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJ0ZvdW5kIG90aGVyIGhlYWRlciBiZWZvcmUgYSBoZWFkZXIgdGhp cyBmaWxlIGltcGxlbWVudHMuICcKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgJ1Nob3VsZCBiZTogY29uZmlnLmgsIHByaW1hcnkgaGVhZGVyLCBibGFuayBsaW5lLCBh bmQgdGhlbiAnCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdhbHBo YWJldGljYWxseSBzb3J0ZWQuICBbYnVpbGQvaW5jbHVkZV9vcmRlcl0gWzRdJykKKwogICAgICAg ICAjICpTb2Z0TGluay5jcHAgZmlsZXMgc2hvdWxkIG5vdCBpbmNsdWRlIHRoZWlyIGhlYWRlcnMg LT4gbm8gZXJyb3IuCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdG b29Tb2Z0TGluay5jcHAnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnI2luY2x1ZGUgImNvbmZpZy5oIlxuJwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnXG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICcjaW5jbHVkZSA8d3RmL1NvZnRMaW5raW5nLmg+XG4nLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnJykKKwogICAgICAgICAjIEhhdmluZyBpbmNsdWRlIGZvciBl eGlzdGluZyBwcmltYXJ5IGhlYWRlciAtPiBubyBlcnJvci4KICAgICAgICAgc2VsZi5hc3NlcnRf bGFuZ3VhZ2VfcnVsZXNfY2hlY2soJ2Zvby5jcHAnLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnI2luY2x1ZGUgImNvbmZpZy5oIlxuJwpAQCAtMzE1Myw2ICszMTU3 LDI3IEBAIGNsYXNzIE9yZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiYmFyLmgiXG4n LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnJykKIAorICAgICAg ICAjIEhhdmluZyBpbmNsdWRlIGZvciBleGlzdGluZyBXVEYgcHJpbWFyeSBoZWFkZXIgLT4gbm8g ZXJyb3IuCisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdmb28uY3Bw JywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJj b25maWcuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNp bmNsdWRlIDx3dGYvZm9vLmg+XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNp bmNsdWRlIDx3dGYvYmFyLmg+XG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnJykKKworICAgICAgICAjIFdURiBwcmltYXJ5IGhlYWRlciBpbmNsdWRlZCBvdXQg b2Ygb3JkZXIgLT4gZXJyb3IuCisgICAgICAgIHNlbGYuYXNzZXJ0X2xhbmd1YWdlX3J1bGVzX2No ZWNrKCdmb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JyNpbmNsdWRlICJjb25maWcuaCJcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJyNpbmNsdWRlIDx3dGYvYmFyLmg+XG4nCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJyNpbmNsdWRlIDx3dGYvZm9vLmg+XG4nLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBbJ0ZvdW5kIG90aGVyIGhlYWRlciBiZWZvcmUgYSBoZWFkZXIg dGhpcyBmaWxlIGltcGxlbWVudHMuICcKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdTaG91bGQgYmU6IGNvbmZpZy5oLCBwcmltYXJ5IGhlYWRlciwgYmxhbmsgbGlu ZSwgYW5kIHRoZW4gJworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J2FscGhhYmV0aWNhbGx5IHNvcnRlZC4gIFtidWlsZC9pbmNsdWRlX29yZGVyXSBbNF0nLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ0ZvdW5kIGhlYWRlciB0aGlz IGZpbGUgaW1wbGVtZW50cyBhZnRlciBvdGhlciBoZWFkZXIuICcKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICdTaG91bGQgYmU6IGNvbmZpZy5oLCBwcmltYXJ5IGhl YWRlciwgYmxhbmsgbGluZSwgYW5kIHRoZW4gJworICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJ2FscGhhYmV0aWNhbGx5IHNvcnRlZC4gIFtidWlsZC9pbmNsdWRlX29y ZGVyXSBbNF0nXSkKKwogICAgICAgICBvcy5wYXRoLmlzZmlsZSA9IHNlbGYub3NfcGF0aF9pc2Zp bGVfb3JpZwogCiAgICAgZGVmIHRlc3RfcHVibGljX3ByaW1hcnlfaGVhZGVyKHNlbGYpOgo=