198346 2019-05-29 12:59:49 -0700 IndexedDatabase Server thread in com.apple.WebKit.Networking process leaks objects into an autoreleasePool that's never cleared 2019-05-29 15:07:31 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198349 InRadar P2 Normal --- 1 ddkilzer ddkilzer alecflett beidson benjamin bfulgham cdumez cmarcelo commit-queue dbates ews-watchlist jsbell sihui_liu simon.fraser webkit-bug-importer oldest_to_newest 1540064 0 ddkilzer 2019-05-29 12:59:49 -0700 IndexedDatabase Server thread in com.apple.WebKit.Networking process leaks objects into an autoreleasePool that's never cleared. Running a bunch of IndexedDB tests on a single process shows how these objects build up: $ ./Tools/Scripts/run-webkit-tests --no-build --release --batch-size=1500 --child-processes=1 --leaks --no-retry --no-sample --time-out-ms=60000 --no-show-results LayoutTests/inspector/indexeddb LayoutTests/storage/indexeddb LayoutTests/http/tests/IndexedDB LayoutTests/imported/blink/storage/indexeddb LayoutTests/imported/w3c/IndexedDB-private-browsing LayoutTests/imported/w3c/web-platform-tests/IndexedDB $ leaks -auto com.apple.WebKit.Networking.Development-58655-UNFIXED.memgraph | less […] Thread 5 Thread_17325843: IndexedDatabase Server <@autoreleasepool content 0x7face9815000> [4096] 0: <CFString 0x7face8710870> [192] 1: <NSPathStore2 0x7face87188f0> [368] 2: 2 (304 bytes) <NSURL 0x7face871ae10> [96] 1 (208 bytes) _clients --> <CFString 0x7face87030b0> [208] 3: <NSMutableArray 0x7face8717f40> [48] 4: <NSArray 0x7face8715ac0> [16] […] 9595: <NSMutableArray 0x7face865e0f0> [48] 9596: <NSArray 0x7face865c9d0> [16] Thread 6 Thread_17325989: IndexedDatabase Server no autorelease pool […] 1540066 1 ddkilzer 2019-05-29 13:00:55 -0700 <rdar://problem/50895658> 1540069 2 370877 ddkilzer 2019-05-29 13:12:44 -0700 Created attachment 370877 Patch v1 1540073 3 ews-watchlist 2019-05-29 13:14:32 -0700 Attachment 370877 did not pass style-queue: ERROR: Source/WTF/wtf/CrossThreadTaskHandler.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1540078 4 ddkilzer 2019-05-29 13:23:58 -0700 (In reply to Build Bot from comment #3) > Attachment 370877 [details] did not pass style-queue: > > > ERROR: Source/WTF/wtf/CrossThreadTaskHandler.cpp:29: Alphabetical sorting > problem. [build/include_order] [4] > Total errors found: 1 in 5 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Bug 198349: check-webkit-style reports false-positive build/include_order warning in WTF C++ source files 1540104 5 370877 bfulgham 2019-05-29 14:15:00 -0700 Comment on attachment 370877 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=370877&action=review > Source/WTF/wtf/CrossThreadTaskHandler.h:44 > + WTF_EXPORT_PRIVATE CrossThreadTaskHandler(const char* threadName, AutodrainedPoolForRunLoop = AutodrainedPoolForRunLoop::DoNotUse); Since the only use of CrossThreadTaskHandler is IndexedDB, and IndexedDB needs an auto drained pool, should we just make auto drained the default? 1540110 6 370877 ddkilzer 2019-05-29 14:22:19 -0700 Comment on attachment 370877 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=370877&action=review >> Source/WTF/wtf/CrossThreadTaskHandler.h:44 >> + WTF_EXPORT_PRIVATE CrossThreadTaskHandler(const char* threadName, AutodrainedPoolForRunLoop = AutodrainedPoolForRunLoop::DoNotUse); > > Since the only use of CrossThreadTaskHandler is IndexedDB, and IndexedDB needs an auto drained pool, should we just make auto drained the default? The reason I made AutodrainedPoolForRunLoop::DoNotUse the default is that I think it tends to be unusual to run Objective-C code (on background threads) in WebKit, but maybe I'm wrong? However, I don't have an objection to making AutodrainedPoolForRunLoop::Use the default since CrossThreadTaskHandler is only used by IndexedDB currently. I do think we should keep the AutodrainedPoolForRunLoop enum class argument, though, since it make using the class in other scenarios easier, and hopefully makes future users ask the question whether they need an AutodrainedPool or not for their task runloop. 1540119 7 370877 bfulgham 2019-05-29 14:40:21 -0700 Comment on attachment 370877 Patch v1 Looks good! r=me 1540134 8 370877 commit-queue 2019-05-29 15:07:30 -0700 Comment on attachment 370877 Patch v1 Clearing flags on attachment: 370877 Committed r245871: <https://trac.webkit.org/changeset/245871> 1540135 9 commit-queue 2019-05-29 15:07:31 -0700 All reviewed patches have been landed. Closing bug. 370877 2019-05-29 13:12:44 -0700 2019-05-29 15:07:30 -0700 Patch v1 bug-198346-20190529131242.patch text/plain 6166 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE4NjFmMTg5YTUxZTQ5N2M2MmY1NjVi NzZmZTI2ZTAyYmI4MDVlZWQuLmE0NDlhOWJhMjFiZTY3YmQyZTZlZDAzZDMyOGFjNDc2MWQ3OWMy Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTktMDUtMjkgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBJbmRleGVkRGF0YWJhc2UgU2VydmVyIHRocmVhZCBp biBjb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcgcHJvY2VzcyBsZWFrcyBvYmplY3RzIGludG8g YW4gYXV0b3JlbGVhc2VQb29sIHRoYXQncyBuZXZlciBjbGVhcmVkCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xOTgzNDY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDg5NTY1OD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9D cm9zc1RocmVhZFRhc2tIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdURjo6Q3Jvc3NUaHJlYWRUYXNr SGFuZGxlcjo6Q3Jvc3NUaHJlYWRUYXNrSGFuZGxlcik6CisgICAgICAgIC0gQWRkIG9wdGlvbmFs IHNlY29uZCBhcmd1bWVudCB0byBlbmFibGUgdXNlIG9mIGFuCisgICAgICAgICAgQXV0b2RyYWlu ZWRQb29sIHdoZW4gcnVubmluZyB0aGUgcnVubG9vcC4KKyAgICAgICAgKFdURjo6Q3Jvc3NUaHJl YWRUYXNrSGFuZGxlcjo6dGFza1J1bkxvb3ApOgorICAgICAgICAtIENyZWF0ZSBhbiBBdXRvZHJh aW5lZFBvb2wgaWYgcmVxdWVzdGVkIHdoZW4KKyAgICAgICAgICBDcm9zc1RocmVhZFRhc2tIYW5k bGVyIHdhcyBjcmVhdGVkLgorICAgICAgICAqIHd0Zi9Dcm9zc1RocmVhZFRhc2tIYW5kbGVyLmg6 CisgICAgICAgIChXVEY6OkNyb3NzVGhyZWFkVGFza0hhbmRsZXI6OkF1dG9kcmFpbmVkUG9vbEZv clJ1bkxvb3ApOgorICAgICAgICAtIEFkZCBlbnVtIGNsYXNzIGZvciBlbmFibGluZyBhbiBBdXRv ZHJhaW5lZFBvb2wgZm9yCisgICAgICAgICAgQ3Jvc3NUaHJlYWRUYXNrSGFuZGxlcjo6dGFza1J1 bkxvb3AoKS4KKyAgICAgICAgKFdURjo6Q3Jvc3NUaHJlYWRUYXNrSGFuZGxlcjo6Q3Jvc3NUaHJl YWRUYXNrSGFuZGxlcik6CisgICAgICAgIC0gQWRkIG9wdGlvbmFsIHNlY29uZCBhcmd1bWVudCB0 byBlbmFibGUgdXNlIG9mIGFuCisgICAgICAgICAgQXV0b2RyYWluZWRQb29sIHdoZW4gcnVubmlu ZyB0aGUgcnVubG9vcC4KKwogMjAxOS0wNS0yNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIFVzZSBhIHN0cm9uZ2x5LXR5cGVkIGlkZW50aWZpZXIgZm9yIHBhZ2Vz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggY2FhYThkNzZiOGRjYzlhNTMyMWEyYzRmOGRjZDY0MDExNmRjNTIyMC4u NDkyYWJhNTRiNjk5NTFiZGFhN2U2ODFhMWQ5MmNiMzY1YzljZmMyNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDE5LTA1LTI5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5j b20+CisKKyAgICAgICAgSW5kZXhlZERhdGFiYXNlIFNlcnZlciB0aHJlYWQgaW4gY29tLmFwcGxl LldlYktpdC5OZXR3b3JraW5nIHByb2Nlc3MgbGVha3Mgb2JqZWN0cyBpbnRvIGFuIGF1dG9yZWxl YXNlUG9vbCB0aGF0J3MgbmV2ZXIgY2xlYXJlZAorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn L2IvMTk4MzQ2PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTA4OTU2NTg+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRk Yi9zZXJ2ZXIvSURCU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQlNlcnZlcjo6SURC U2VydmVyOjpJREJTZXJ2ZXIpOgorICAgICAgICAtIFBhc3MgQXV0b2RyYWluZWRQb29sRm9yUnVu TG9vcDo6VXNlIHdoZW4gY3JlYXRpbmcKKyAgICAgICAgICBDcm9zc1RocmVhZFRhc2tIYW5kbGVy IHRvIGZpeCB0aGUgYnVnLgorCiAyMDE5LTA1LTI5ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBTY3JvbGxpbmcgbm9kZSBvcmRlcmluZyB3cm9uZyB3aGVuIGEg bGF5ZXIgaGFzIGJvdGggcG9zaXRpb25pbmcgYW5kIGZpeGVkL3N0aWNreSBub2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9Dcm9zc1RocmVhZFRhc2tIYW5kbGVyLmNwcCBiL1NvdXJjZS9X VEYvd3RmL0Nyb3NzVGhyZWFkVGFza0hhbmRsZXIuY3BwCmluZGV4IDQ1ZWMwNDE3NzljZjgyZjY3 M2JiMmY4OTc3YTYyZDlhZTMzYjAxY2UuLjgzYzIwNzUxZjg1ZjRlNGQyMDE1NjE0NDFjYTgzMTQx Y2I1YzM3ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Nyb3NzVGhyZWFkVGFza0hhbmRs ZXIuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Nyb3NzVGhyZWFkVGFza0hhbmRsZXIuY3BwCkBA IC0yNiw5ICsyNiwxMiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgPHd0Zi9Dcm9z c1RocmVhZFRhc2tIYW5kbGVyLmg+CiAKKyNpbmNsdWRlIDx3dGYvQXV0b2RyYWluZWRQb29sLmg+ CisKIG5hbWVzcGFjZSBXVEYgewogCi1Dcm9zc1RocmVhZFRhc2tIYW5kbGVyOjpDcm9zc1RocmVh ZFRhc2tIYW5kbGVyKGNvbnN0IGNoYXIqIHRocmVhZE5hbWUpCitDcm9zc1RocmVhZFRhc2tIYW5k bGVyOjpDcm9zc1RocmVhZFRhc2tIYW5kbGVyKGNvbnN0IGNoYXIqIHRocmVhZE5hbWUsIEF1dG9k cmFpbmVkUG9vbEZvclJ1bkxvb3AgdXNlQXV0b2RyYWluZWRQb29sKQorICAgIDogbV91c2VBdXRv ZHJhaW5lZFBvb2wodXNlQXV0b2RyYWluZWRQb29sKQogewogICAgIEFTU0VSVChpc01haW5UaHJl YWQoKSk7CiAgICAgTG9ja2VyPExvY2s+IGxvY2tlcihtX3Rhc2tUaHJlYWRDcmVhdGlvbkxvY2sp OwpAQCAtNjksNyArNzIsMTEgQEAgdm9pZCBDcm9zc1RocmVhZFRhc2tIYW5kbGVyOjp0YXNrUnVu TG9vcCgpCiAgICAgfQogCiAgICAgd2hpbGUgKCFtX3Rhc2tRdWV1ZS5pc0tpbGxlZCgpKSB7Ci0g ICAgICAgIG1fdGFza1F1ZXVlLndhaXRGb3JNZXNzYWdlKCkucGVyZm9ybVRhc2soKTsKKyAgICAg ICAgeworICAgICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPEF1dG9kcmFpbmVkUG9vbD4gYXV0b2Ry YWluZWRQb29sID0gKG1fdXNlQXV0b2RyYWluZWRQb29sID09IEF1dG9kcmFpbmVkUG9vbEZvclJ1 bkxvb3A6OlVzZSkgPyBzdGQ6Om1ha2VfdW5pcXVlPEF1dG9kcmFpbmVkUG9vbD4oKSA6IG51bGxw dHI7CisKKyAgICAgICAgICAgIG1fdGFza1F1ZXVlLndhaXRGb3JNZXNzYWdlKCkucGVyZm9ybVRh c2soKTsKKyAgICAgICAgfQogCiAgICAgICAgIExvY2tlcjxMb2NrPiBzaG91bGRTdXNwZW5kTG9j a2VyKG1fc2hvdWxkU3VzcGVuZExvY2spOwogICAgICAgICB3aGlsZSAobV9zaG91bGRTdXNwZW5k KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Dcm9zc1RocmVhZFRhc2tIYW5kbGVyLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9Dcm9zc1RocmVhZFRhc2tIYW5kbGVyLmgKaW5kZXggZjA1NDYwMWMy NDY2MWU0MjljZjhiOThkYjg5MGViYjVkOTIzMzc5Mi4uMTQ2MGFlN2U4YzllMThkZjVlNWI5YzU2 MzdjMzg1Mjc1MmRiNWQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ3Jvc3NUaHJlYWRU YXNrSGFuZGxlci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Nyb3NzVGhyZWFkVGFza0hhbmRsZXIu aApAQCAtMzgsOSArMzgsMTAgQEAgY2xhc3MgU1FMaXRlRGF0YWJhc2U7CiBjbGFzcyBDcm9zc1Ro cmVhZFRhc2tIYW5kbGVyIHsKIHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdmlydHVh bCB+Q3Jvc3NUaHJlYWRUYXNrSGFuZGxlcigpOworICAgIGVudW0gY2xhc3MgQXV0b2RyYWluZWRQ b29sRm9yUnVuTG9vcCB7IERvTm90VXNlLCBVc2UgfTsKIAogcHJvdGVjdGVkOgotICAgIFdURl9F WFBPUlRfUFJJVkFURSBDcm9zc1RocmVhZFRhc2tIYW5kbGVyKGNvbnN0IGNoYXIqIHRocmVhZE5h bWUpOworICAgIFdURl9FWFBPUlRfUFJJVkFURSBDcm9zc1RocmVhZFRhc2tIYW5kbGVyKGNvbnN0 IGNoYXIqIHRocmVhZE5hbWUsIEF1dG9kcmFpbmVkUG9vbEZvclJ1bkxvb3AgPSBBdXRvZHJhaW5l ZFBvb2xGb3JSdW5Mb29wOjpEb05vdFVzZSk7CiAKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9p ZCBwb3N0VGFzayhDcm9zc1RocmVhZFRhc2smJik7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZv aWQgcG9zdFRhc2tSZXBseShDcm9zc1RocmVhZFRhc2smJik7CkBAIC01MSw2ICs1Miw4IEBAIHBy aXZhdGU6CiAgICAgdm9pZCBoYW5kbGVUYXNrUmVwbGllc09uTWFpblRocmVhZCgpOwogICAgIHZv aWQgdGFza1J1bkxvb3AoKTsKIAorICAgIEF1dG9kcmFpbmVkUG9vbEZvclJ1bkxvb3AgbV91c2VB dXRvZHJhaW5lZFBvb2wgeyBBdXRvZHJhaW5lZFBvb2xGb3JSdW5Mb29wOjpEb05vdFVzZSB9Owor CiAgICAgTG9jayBtX3Rhc2tUaHJlYWRDcmVhdGlvbkxvY2s7CiAgICAgTG9jayBtX21haW5UaHJl YWRSZXBseUxvY2s7CiAgICAgYm9vbCBtX21haW5UaHJlYWRSZXBseVNjaGVkdWxlZCB7IGZhbHNl IH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIv SURCU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9J REJTZXJ2ZXIuY3BwCmluZGV4IDA1NGI3ZTJmYWQ4ZmIxNzFkODM3MjAwN2RiOWRhMTZkN2M4NzU2 MjEuLjdmMDcwOWQzOWZjYmQ4YTQ3ZjI0MWU5Y2RiOTA0ODNhMmU3NjBhYWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJ2ZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJ2ZXIuY3Bw CkBAIC01Nyw3ICs1Nyw3IEBAIFJlZjxJREJTZXJ2ZXI+IElEQlNlcnZlcjo6Y3JlYXRlKFBBTDo6 U2Vzc2lvbklEIHNlc3Npb25JRCwgY29uc3QgU3RyaW5nJiBkYXRhYmFzCiB9CiAKIElEQlNlcnZl cjo6SURCU2VydmVyKFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCwgSURCQmFja2luZ1N0b3JlVGVt cG9yYXJ5RmlsZUhhbmRsZXImIGZpbGVIYW5kbGVyLCBRdW90YU1hbmFnZXJHZXR0ZXImJiBxdW90 YU1hbmFnZXJHZXR0ZXIpCi0gICAgOiBDcm9zc1RocmVhZFRhc2tIYW5kbGVyKCJJbmRleGVkRGF0 YWJhc2UgU2VydmVyIikKKyAgICA6IENyb3NzVGhyZWFkVGFza0hhbmRsZXIoIkluZGV4ZWREYXRh YmFzZSBTZXJ2ZXIiLCBBdXRvZHJhaW5lZFBvb2xGb3JSdW5Mb29wOjpVc2UpCiAgICAgLCBtX3Nl c3Npb25JRChzZXNzaW9uSUQpCiAgICAgLCBtX2JhY2tpbmdTdG9yZVRlbXBvcmFyeUZpbGVIYW5k bGVyKGZpbGVIYW5kbGVyKQogICAgICwgbV9xdW90YU1hbmFnZXJHZXR0ZXIoV1RGTW92ZShxdW90 YU1hbmFnZXJHZXR0ZXIpKQpAQCAtNjUsNyArNjUsNyBAQCBJREJTZXJ2ZXI6OklEQlNlcnZlcihQ QUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIElEQkJhY2tpbmdTdG9yZVRlbXBvcmFyeUZpbGVIYW5k bAogfQogCiBJREJTZXJ2ZXI6OklEQlNlcnZlcihQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIGNv bnN0IFN0cmluZyYgZGF0YWJhc2VEaXJlY3RvcnlQYXRoLCBJREJCYWNraW5nU3RvcmVUZW1wb3Jh cnlGaWxlSGFuZGxlciYgZmlsZUhhbmRsZXIsIFF1b3RhTWFuYWdlckdldHRlciYmIHF1b3RhTWFu YWdlckdldHRlcikKLSAgICA6IENyb3NzVGhyZWFkVGFza0hhbmRsZXIoIkluZGV4ZWREYXRhYmFz ZSBTZXJ2ZXIiKQorICAgIDogQ3Jvc3NUaHJlYWRUYXNrSGFuZGxlcigiSW5kZXhlZERhdGFiYXNl IFNlcnZlciIsIEF1dG9kcmFpbmVkUG9vbEZvclJ1bkxvb3A6OlVzZSkKICAgICAsIG1fc2Vzc2lv bklEKHNlc3Npb25JRCkKICAgICAsIG1fZGF0YWJhc2VEaXJlY3RvcnlQYXRoKGRhdGFiYXNlRGly ZWN0b3J5UGF0aCkKICAgICAsIG1fYmFja2luZ1N0b3JlVGVtcG9yYXJ5RmlsZUhhbmRsZXIoZmls ZUhhbmRsZXIpCg==