198342 2019-05-29 11:02:56 -0700 Fix builds that don't use makeWindowFromView 2019-05-29 12:16:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue webkit-bug-importer wenson_hsieh oldest_to_newest 1540019 0 krollin 2019-05-29 11:02:56 -0700 In some configurations, VideoFullscreenInterfaceAVKit.mm declares but does not use makeWindowFromView. Fix by conditionalizing the the declaration on the same symbol as point where it's used. 1540020 1 webkit-bug-importer 2019-05-29 11:03:49 -0700 <rdar://problem/51228563> 1540021 2 370866 krollin 2019-05-29 11:05:05 -0700 Created attachment 370866 Patch 1540055 3 370866 commit-queue 2019-05-29 12:16:42 -0700 Comment on attachment 370866 Patch Clearing flags on attachment: 370866 Committed r245861: <https://trac.webkit.org/changeset/245861> 1540056 4 commit-queue 2019-05-29 12:16:43 -0700 All reviewed patches have been landed. Closing bug. 370866 2019-05-29 11:05:05 -0700 2019-05-29 12:16:42 -0700 Patch bug-198342-20190529110504.patch text/plain 1843 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTViM2NmOWIwOTg5YTg3 OTg3MmVhY2VkY2U3YWQzMjM2MWY0MTM1Zi4uOWI2ZTc0ZmQ3YzIwOGNhM2NmNDhmOWZkM2IzMDk3 ZmRiZGZjODA5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTI5ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnVpbGRzIHRoYXQg ZG9uJ3QgdXNlIG1ha2VXaW5kb3dGcm9tVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MzQyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTIy ODU2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ biBzb21lIGNvbmZpZ3VyYXRpb25zLCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBk ZWNsYXJlcyBidXQKKyAgICAgICAgZG9lcyBub3QgdXNlIG1ha2VXaW5kb3dGcm9tVmlldy4gRml4 IGJ5IGNvbmRpdGlvbmFsaXppbmcgdGhlIHRoZQorICAgICAgICBkZWNsYXJhdGlvbiBvbiB0aGUg c2FtZSBzeW1ib2wgYXMgcG9pbnQgd2hlcmUgaXQncyB1c2VkLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAtLSBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9W aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbToKKwogMjAxOS0wNS0yOCAgWmFsYW4gQnVq dGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW1ZlcmlmaWNhdGlvbl0gQWRk IGFkZGl0aW9uYWwgaW5saW5lIGFuZCBibG9jayBjaGVja3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5t bQppbmRleCBiZmMwODRkMmRmMjhkNGYzNmQyYTVmOGY0ZTM3NzM5MjI1NzFmYTNhLi5jYmEwNDE4 NGFmMDJkMzAyZGQyYTE5ZWM1YjBiMmZlZmI0NDFhMjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 Lm1tCkBAIC0xMTc3LDYgKzExNzcsNyBAQCB2b2lkIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0OjpzZXRJbmxpbmVSZWN0KGNvbnN0IEludFJlY3QmIGlubGluZVJlY3QsIGJvbwogICAgICAg ICBkb0V4aXRGdWxsc2NyZWVuKCk7CiB9CiAKKyNpZiAhUExBVEZPUk0oV0FUQ0hPUykKICNpZiBV U0UoQVBQTEVfSU5URVJOQUxfU0RLKQogI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL1ZpZGVvRnVs bHNjcmVlbkludGVyZmFjZUFWS2l0QWRkaXRpb25zLm1tPgogI2Vsc2UKQEAgLTExODUsNiArMTE4 Niw3IEBAIHN0YXRpYyBSZXRhaW5QdHI8VUlXaW5kb3c+IG1ha2VXaW5kb3dGcm9tVmlldyhVSVZp ZXcgKikKICAgICByZXR1cm4gYWRvcHROUyhbUEFMOjphbGxvY1VJV2luZG93SW5zdGFuY2UoKSBp bml0V2l0aEZyYW1lOltbUEFMOjpnZXRVSVNjcmVlbkNsYXNzKCkgbWFpblNjcmVlbl0gYm91bmRz XV0pOwogfQogI2VuZGlmCisjZW5kaWYKIAogdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdDo6ZG9TZXR1cCgpCiB7Cg==