198337 2019-05-29 09:47:05 -0700 UserMediaCaptureManager should remove a source from its map once the source is ended 2019-05-29 11:51:33 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1539973 0 youennf 2019-05-29 09:47:05 -0700 UserMediaCaptureManager should remove a source from its map once the source is ended 1539981 1 youennf 2019-05-29 10:02:49 -0700 <rdar://problem/49474912> 1539993 2 370859 youennf 2019-05-29 10:19:57 -0700 Created attachment 370859 Patch 1540038 3 370859 commit-queue 2019-05-29 11:51:32 -0700 Comment on attachment 370859 Patch Clearing flags on attachment: 370859 Committed r245859: <https://trac.webkit.org/changeset/245859> 1540039 4 commit-queue 2019-05-29 11:51:33 -0700 All reviewed patches have been landed. Closing bug. 370859 2019-05-29 10:19:57 -0700 2019-05-29 11:51:32 -0700 Patch bug-198337-20190529101956.patch text/plain 6689 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4NTFiOWFmNTMzNzQ5NTVk YTFlNWVhYTJkNGY4ZWNkZWNlMDAyZGMuLjkxMTE5MDIyNGRjNWQ4ZThjYzFkMzY3ODdjNWFhZWVj YmRjZGRmYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTktMDUtMjkgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFVzZXJNZWRpYUNhcHR1cmVNYW5h Z2VyIHNob3VsZCByZW1vdmUgYSBzb3VyY2UgZnJvbSBpdHMgbWFwIG9uY2UgdGhlIHNvdXJjZSBp cyBlbmRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk4MzM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiB0aGUgc291cmNlIGlzIHN0b3BwZWQsIGZvciBpbnN0YW5jZSB1c2luZyBNZWRpYVN0cmVh bVRyYWNrLnN0b3AsCisgICAgICAgIHJlbW92ZSB0aGUgc291cmNlIGZyb20gVXNlck1lZGlhQ2Fw dHVyZU1hbmFnZXIgc291cmNlcyBtYXAuCisgICAgICAgIFRoaXMgbWFrZXMgc3VyZSB0aGUgbWFw IHdpbGwgbm90IGdyb3cgb3ZlciB0aW1lLgorICAgICAgICBBZGQgYW4gaWYgY2hlY2sgdG8gZW5z dXJlIHRoYXQgdGhlIHNvdXJjZSBpcyBzdGlsbCB0aGVyZSBiZWZvcmUgcHJvY2Vzc2luZyBhbiBp bmNvbWluZyBJUEMgY2FsbC4KKworICAgICAgICBXaGVuIFVJUHJvY2VzcyB0ZWxscyB1cyB0aGUg Y2FwdHVyZSBpcyBmaW5pc2hlZCAodHlwaWNhbGx5IGNhcHR1cmUgZmFpbGVkKSwgcmVtb3ZlIHRo ZSBlbnRyeSBvbiBXZWJQcm9jZXNzIHNpZGUgYXMgd2VsbC4KKworICAgICAgICAqIFdlYlByb2Nl c3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpV c2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6Y3JlYXRlQ2FwdHVyZVNvdXJjZSk6CisgICAgICAgIChX ZWJLaXQ6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpzb3VyY2VTdG9wcGVkKToKKyAgICAgICAg KFdlYktpdDo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OmNhcHR1cmVGYWlsZWQpOgorICAgICAg ICAoV2ViS2l0OjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6c291cmNlTXV0ZWRDaGFuZ2VkKToK KyAgICAgICAgKFdlYktpdDo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OnNvdXJjZVNldHRpbmdz Q2hhbmdlZCk6CisgICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpzdG9y YWdlQ2hhbmdlZCk6CisgICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpy aW5nQnVmZmVyRnJhbWVCb3VuZHNDaGFuZ2VkKToKKyAgICAgICAgKFdlYktpdDo6VXNlck1lZGlh Q2FwdHVyZU1hbmFnZXI6OmF1ZGlvU2FtcGxlc0F2YWlsYWJsZSk6CisgICAgICAgIChXZWJLaXQ6 OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpyZW1vdGVWaWRlb1NhbXBsZUF2YWlsYWJsZSk6Cisg ICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpzb3VyY2VFbmRlZCk6Cisg ICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjphcHBseUNvbnN0cmFpbnRz U3VjY2VlZGVkKToKKyAgICAgICAgKFdlYktpdDo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OmFw cGx5Q29uc3RyYWludHNGYWlsZWQpOgorCiAyMDE5LTA1LTI5ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm5pemUgZ2V0dGluZyBwcm94aWVzIG9mIFVz ZXJNZWRpYUNhcHR1cmVNYW5hZ2VyUHJveHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwCmluZGV4IGI0NjVh ZDI1MjM5ZTZiMjc4ZDNmYjQwNzc0N2Q4OWI4NzI5OTg3NTEuLmQxOTQzNmQ5NDA0NDZhOWJjMTIx ZThlMDI1ZjY4NGQ0MDViZGEwNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLmNwcApAQCAtMjU2LDU5ICsy NTYsNjMgQEAgV2ViQ29yZTo6Q2FwdHVyZVNvdXJjZU9yRXJyb3IgVXNlck1lZGlhQ2FwdHVyZU1h bmFnZXI6OmNyZWF0ZUNhcHR1cmVTb3VyY2UoY29uc3QKICAgICBhdXRvIHR5cGUgPSBkZXZpY2Uu dHlwZSgpID09IENhcHR1cmVEZXZpY2U6OkRldmljZVR5cGU6Ok1pY3JvcGhvbmUgPyBXZWJDb3Jl OjpSZWFsdGltZU1lZGlhU291cmNlOjpUeXBlOjpBdWRpbyA6IFdlYkNvcmU6OlJlYWx0aW1lTWVk aWFTb3VyY2U6OlR5cGU6OlZpZGVvOwogICAgIGF1dG8gc291cmNlID0gYWRvcHRSZWYoKm5ldyBT b3VyY2UoU3RyaW5nOjpudW1iZXIoaWQpLCB0eXBlLCBkZXZpY2UudHlwZSgpLCBTdHJpbmcgeyBz ZXR0aW5ncy5sYWJlbCgpIH0sIFdURk1vdmUoaGFzaFNhbHQpLCBpZCwgKnRoaXMpKTsKICAgICBz b3VyY2UtPnNldFNldHRpbmdzKFdURk1vdmUoc2V0dGluZ3MpKTsKLSAgICBtX3NvdXJjZXMuc2V0 KGlkLCBzb3VyY2UuY29weVJlZigpKTsKKyAgICBtX3NvdXJjZXMuYWRkKGlkLCBzb3VyY2UuY29w eVJlZigpKTsKICAgICByZXR1cm4gV2ViQ29yZTo6Q2FwdHVyZVNvdXJjZU9yRXJyb3IoV1RGTW92 ZShzb3VyY2UpKTsKIH0KIAogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6c291cmNlU3Rv cHBlZCh1aW50NjRfdCBpZCkKIHsKLSAgICBBU1NFUlQobV9zb3VyY2VzLmNvbnRhaW5zKGlkKSk7 Ci0gICAgbV9zb3VyY2VzLmdldChpZCktPnN0b3AoKTsKKyAgICBpZiAoYXV0byBzb3VyY2UgPSBt X3NvdXJjZXMuZ2V0KGlkKSkgeworICAgICAgICBzb3VyY2UtPnN0b3AoKTsKKyAgICAgICAgc291 cmNlRW5kZWQoaWQpOworICAgIH0KIH0KIAogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6 Y2FwdHVyZUZhaWxlZCh1aW50NjRfdCBpZCkKIHsKLSAgICBBU1NFUlQobV9zb3VyY2VzLmNvbnRh aW5zKGlkKSk7Ci0gICAgbV9zb3VyY2VzLmdldChpZCktPmNhcHR1cmVGYWlsZWQoKTsKKyAgICBp ZiAoYXV0byBzb3VyY2UgPSBtX3NvdXJjZXMuZ2V0KGlkKSkgeworICAgICAgICBzb3VyY2UtPmNh cHR1cmVGYWlsZWQoKTsKKyAgICAgICAgc291cmNlRW5kZWQoaWQpOworICAgIH0KIH0KIAogdm9p ZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6c291cmNlTXV0ZWRDaGFuZ2VkKHVpbnQ2NF90IGlk LCBib29sIG11dGVkKQogewotICAgIEFTU0VSVChtX3NvdXJjZXMuY29udGFpbnMoaWQpKTsKLSAg ICBtX3NvdXJjZXMuZ2V0KGlkKS0+c2V0TXV0ZWQobXV0ZWQpOworICAgIGlmIChhdXRvIHNvdXJj ZSA9IG1fc291cmNlcy5nZXQoaWQpKQorICAgICAgICBzb3VyY2UtPnNldE11dGVkKG11dGVkKTsK IH0KIAogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6c291cmNlU2V0dGluZ3NDaGFuZ2Vk KHVpbnQ2NF90IGlkLCBjb25zdCBSZWFsdGltZU1lZGlhU291cmNlU2V0dGluZ3MmIHNldHRpbmdz KQogewotICAgIEFTU0VSVChtX3NvdXJjZXMuY29udGFpbnMoaWQpKTsKLSAgICBtX3NvdXJjZXMu Z2V0KGlkKS0+c2V0U2V0dGluZ3MoUmVhbHRpbWVNZWRpYVNvdXJjZVNldHRpbmdzKHNldHRpbmdz KSk7CisgICAgaWYgKGF1dG8gc291cmNlID0gbV9zb3VyY2VzLmdldChpZCkpCisgICAgICAgIHNv dXJjZS0+c2V0U2V0dGluZ3MoUmVhbHRpbWVNZWRpYVNvdXJjZVNldHRpbmdzKHNldHRpbmdzKSk7 CiB9CiAKIHZvaWQgVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OnN0b3JhZ2VDaGFuZ2VkKHVpbnQ2 NF90IGlkLCBjb25zdCBTaGFyZWRNZW1vcnk6OkhhbmRsZSYgaGFuZGxlLCBjb25zdCBXZWJDb3Jl OjpDQUF1ZGlvU3RyZWFtRGVzY3JpcHRpb24mIGRlc2NyaXB0aW9uLCB1aW50NjRfdCBudW1iZXJP ZkZyYW1lcykKIHsKLSAgICBBU1NFUlQobV9zb3VyY2VzLmNvbnRhaW5zKGlkKSk7Ci0gICAgbV9z b3VyY2VzLmdldChpZCktPnNldFN0b3JhZ2UoaGFuZGxlLCBkZXNjcmlwdGlvbiwgbnVtYmVyT2ZG cmFtZXMpOworICAgIGlmIChhdXRvIHNvdXJjZSA9IG1fc291cmNlcy5nZXQoaWQpKQorICAgICAg ICBzb3VyY2UtPnNldFN0b3JhZ2UoaGFuZGxlLCBkZXNjcmlwdGlvbiwgbnVtYmVyT2ZGcmFtZXMp OwogfQogCiB2b2lkIFVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpyaW5nQnVmZmVyRnJhbWVCb3Vu ZHNDaGFuZ2VkKHVpbnQ2NF90IGlkLCB1aW50NjRfdCBzdGFydEZyYW1lLCB1aW50NjRfdCBlbmRG cmFtZSkKIHsKLSAgICBBU1NFUlQobV9zb3VyY2VzLmNvbnRhaW5zKGlkKSk7Ci0gICAgbV9zb3Vy Y2VzLmdldChpZCktPnNldFJpbmdCdWZmZXJGcmFtZUJvdW5kcyhzdGFydEZyYW1lLCBlbmRGcmFt ZSk7CisgICAgaWYgKGF1dG8gc291cmNlID0gbV9zb3VyY2VzLmdldChpZCkpCisgICAgICAgIHNv dXJjZS0+c2V0UmluZ0J1ZmZlckZyYW1lQm91bmRzKHN0YXJ0RnJhbWUsIGVuZEZyYW1lKTsKIH0K IAogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6YXVkaW9TYW1wbGVzQXZhaWxhYmxlKHVp bnQ2NF90IGlkLCBNZWRpYVRpbWUgdGltZSwgdWludDY0X3QgbnVtYmVyT2ZGcmFtZXMsIHVpbnQ2 NF90IHN0YXJ0RnJhbWUsIHVpbnQ2NF90IGVuZEZyYW1lKQogewotICAgIEFTU0VSVChtX3NvdXJj ZXMuY29udGFpbnMoaWQpKTsKLSAgICBhdXRvJiBzb3VyY2UgPSAqbV9zb3VyY2VzLmdldChpZCk7 Ci0gICAgc291cmNlLnNldFJpbmdCdWZmZXJGcmFtZUJvdW5kcyhzdGFydEZyYW1lLCBlbmRGcmFt ZSk7Ci0gICAgc291cmNlLmF1ZGlvU2FtcGxlc0F2YWlsYWJsZSh0aW1lLCBudW1iZXJPZkZyYW1l cyk7CisgICAgaWYgKGF1dG8gc291cmNlID0gbV9zb3VyY2VzLmdldChpZCkpIHsKKyAgICAgICAg c291cmNlLT5zZXRSaW5nQnVmZmVyRnJhbWVCb3VuZHMoc3RhcnRGcmFtZSwgZW5kRnJhbWUpOwor ICAgICAgICBzb3VyY2UtPmF1ZGlvU2FtcGxlc0F2YWlsYWJsZSh0aW1lLCBudW1iZXJPZkZyYW1l cyk7CisgICAgfQogfQogCiAjaWYgSEFWRShJT1NVUkZBQ0UpCiB2b2lkIFVzZXJNZWRpYUNhcHR1 cmVNYW5hZ2VyOjpyZW1vdGVWaWRlb1NhbXBsZUF2YWlsYWJsZSh1aW50NjRfdCBpZCwgUmVtb3Rl VmlkZW9TYW1wbGUmJiBzYW1wbGUpCiB7Ci0gICAgQVNTRVJUKG1fc291cmNlcy5jb250YWlucyhp ZCkpOwotICAgIG1fc291cmNlcy5nZXQoaWQpLT5yZW1vdGVWaWRlb1NhbXBsZUF2YWlsYWJsZShX VEZNb3ZlKHNhbXBsZSkpOworICAgIGlmIChhdXRvIHNvdXJjZSA9IG1fc291cmNlcy5nZXQoaWQp KQorICAgICAgICBzb3VyY2UtPnJlbW90ZVZpZGVvU2FtcGxlQXZhaWxhYmxlKFdURk1vdmUoc2Ft cGxlKSk7CiB9CiAjZWxzZQogTk9fUkVUVVJOX0RVRV9UT19BU1NFUlQgdm9pZCBVc2VyTWVkaWFD YXB0dXJlTWFuYWdlcjo6cmVtb3RlVmlkZW9TYW1wbGVBdmFpbGFibGUodWludDY0X3QsIFJlbW90 ZVZpZGVvU2FtcGxlJiYpCkBAIC0zNDcsMjAgKzM1MSwxOSBAQCB2b2lkIFVzZXJNZWRpYUNhcHR1 cmVNYW5hZ2VyOjphcHBseUNvbnN0cmFpbnRzKHVpbnQ2NF90IGlkLCBjb25zdCBXZWJDb3JlOjpN ZWRpYQogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6c291cmNlRW5kZWQodWludDY0X3Qg aWQpCiB7CiAgICAgbV9wcm9jZXNzLnNlbmQoTWVzc2FnZXM6OlVzZXJNZWRpYUNhcHR1cmVNYW5h Z2VyUHJveHk6OkVuZChpZCksIDApOworICAgIG1fc291cmNlcy5yZW1vdmUoaWQpOwogfQogCiB2 b2lkIFVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjphcHBseUNvbnN0cmFpbnRzU3VjY2VlZGVkKHVp bnQ2NF90IGlkLCBjb25zdCBXZWJDb3JlOjpSZWFsdGltZU1lZGlhU291cmNlU2V0dGluZ3MmIHNl dHRpbmdzKQogewotICAgIEFTU0VSVChtX3NvdXJjZXMuY29udGFpbnMoaWQpKTsKLSAgICBhdXRv JiBzb3VyY2UgPSAqbV9zb3VyY2VzLmdldChpZCk7Ci0gICAgc291cmNlLmFwcGx5Q29uc3RyYWlu dHNTdWNjZWVkZWQoc2V0dGluZ3MpOworICAgIGlmIChhdXRvIHNvdXJjZSA9IG1fc291cmNlcy5n ZXQoaWQpKQorICAgICAgICBzb3VyY2UtPmFwcGx5Q29uc3RyYWludHNTdWNjZWVkZWQoc2V0dGlu Z3MpOwogfQogCiB2b2lkIFVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjphcHBseUNvbnN0cmFpbnRz RmFpbGVkKHVpbnQ2NF90IGlkLCBTdHJpbmcmJiBmYWlsZWRDb25zdHJhaW50LCBTdHJpbmcmJiBt ZXNzYWdlKQogewotICAgIEFTU0VSVChtX3NvdXJjZXMuY29udGFpbnMoaWQpKTsKLSAgICBhdXRv JiBzb3VyY2UgPSAqbV9zb3VyY2VzLmdldChpZCk7Ci0gICAgc291cmNlLmFwcGx5Q29uc3RyYWlu dHNGYWlsZWQoV1RGTW92ZShmYWlsZWRDb25zdHJhaW50KSwgV1RGTW92ZShtZXNzYWdlKSk7Cisg ICAgaWYgKGF1dG8gc291cmNlID0gbV9zb3VyY2VzLmdldChpZCkpCisgICAgICAgIHNvdXJjZS0+ YXBwbHlDb25zdHJhaW50c0ZhaWxlZChXVEZNb3ZlKGZhaWxlZENvbnN0cmFpbnQpLCBXVEZNb3Zl KG1lc3NhZ2UpKTsKIH0KIAogfQo=