198335 2019-05-29 09:19:06 -0700 UserMediaCaptureManagerProxy::SourceProxy should directly have access to its IPC connection 2019-05-29 11:36:14 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1539966 0 youennf 2019-05-29 09:19:06 -0700 UserMediaCaptureManagerProxy::SourceProxy should directly have access to its IPC connection 1539967 1 370854 youennf 2019-05-29 09:21:24 -0700 Created attachment 370854 Patch 1540002 2 webkit-bug-importer 2019-05-29 10:32:17 -0700 <rdar://problem/51226901> 1540032 3 370854 commit-queue 2019-05-29 11:36:12 -0700 Comment on attachment 370854 Patch Clearing flags on attachment: 370854 Committed r245858: <https://trac.webkit.org/changeset/245858> 1540033 4 commit-queue 2019-05-29 11:36:14 -0700 All reviewed patches have been landed. Closing bug. 370854 2019-05-29 09:21:24 -0700 2019-05-29 11:36:12 -0700 Patch bug-198335-20190529092124.patch text/plain 5489 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlMTQ1NTIwMThjMjcwYWQx MmNmZGVjNTJhMGI2NmYwMzhjZDg5YmMuLjFhZTNkZWIxZTFiNzg3YWRkMTVkYjY2YTIxZWYwMzcy Mzc4ZjI3OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDUtMjkgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFVzZXJNZWRpYUNhcHR1cmVNYW5h Z2VyUHJveHk6OlNvdXJjZVByb3h5IHNob3VsZCBkaXJlY3RseSBoYXZlIGFjY2VzcyB0byBpdHMg SVBDIGNvbm5lY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5ODMzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFByZXZpb3VzbHksIFNvdXJjZVByb3h5IHdhcyBnZXR0aW5nIGl0cyBJUEMgY29ubmVj dGlvbiBieSBnb2luZyB0aHJvdWdoIGl0cyBtYW5hZ2VyLCB0aGVuIGl0cyBwcm9jZXNzIHByb3h5 LgorICAgICAgICBBcyBzb21lIGNhbGxzIGNhbiBiZSBkb25lIGZyb20gYSBiYWNrZ3JvdW5kIHRo cmVhZCwgaXQgaXMgc2FmZXIgdG8gZGlyZWN0bHkgbWFrZSBTb3VyY2VQcm94eSBvd24gYSBSZWYg b2YgaXRzIElQQyBjb25uZWN0aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VzZXJN ZWRpYUNhcHR1cmVNYW5hZ2VyUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpVc2VyTWVkaWFD YXB0dXJlTWFuYWdlclByb3h5OjpTb3VyY2VQcm94eTo6U291cmNlUHJveHkpOgorICAgICAgICAo V2ViS2l0OjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlclByb3h5OjpjcmVhdGVNZWRpYVNvdXJjZUZv ckNhcHR1cmVEZXZpY2VXaXRoQ29uc3RyYWludHMpOgorCiAyMDE5LTA1LTI5ICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWVzdGFibGlzaCBXZWJTV0NsaWVu dENvbm5lY3Rpb24gaW4gY2FzZSBvZiBuZXR3b3JrIHByb2Nlc3MgY3Jhc2gKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVXNlck1lZGlhQ2FwdHVyZU1h bmFnZXJQcm94eS5jcHAKaW5kZXggMTJlOTNmZjI4OWU1YTE2MGY3Mzc1NjljYTNmYmNmZWM5ODVj ZThjZi4uNDdmZjRlOTEwZjc2YzcwMTA1YWMyNDQwMTIwMzhiYjcwYjhiZDI0NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXJQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVXNlck1lZGlhQ2Fw dHVyZU1hbmFnZXJQcm94eS5jcHAKQEAgLTQ2LDkgKzQ2LDkgQEAgdXNpbmcgbmFtZXNwYWNlIFdl YkNvcmU7CiAKIGNsYXNzIFVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyUHJveHk6OlNvdXJjZVByb3h5 IDogcHVibGljIFJlYWx0aW1lTWVkaWFTb3VyY2U6Ok9ic2VydmVyLCBwdWJsaWMgU2hhcmVkUmlu Z0J1ZmZlclN0b3JhZ2U6OkNsaWVudCB7CiBwdWJsaWM6Ci0gICAgU291cmNlUHJveHkodWludDY0 X3QgaWQsIFVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyUHJveHkmIG1hbmFnZXIsIFJlZjxSZWFsdGlt ZU1lZGlhU291cmNlPiYmIHNvdXJjZSkKKyAgICBTb3VyY2VQcm94eSh1aW50NjRfdCBpZCwgUmVm PElQQzo6Q29ubmVjdGlvbj4mJiBjb25uZWN0aW9uLCBSZWY8UmVhbHRpbWVNZWRpYVNvdXJjZT4m JiBzb3VyY2UpCiAgICAgICAgIDogbV9pZChpZCkKLSAgICAgICAgLCBtX21hbmFnZXIobWFuYWdl cikKKyAgICAgICAgLCBtX2Nvbm5lY3Rpb24oV1RGTW92ZShjb25uZWN0aW9uKSkKICAgICAgICAg LCBtX3NvdXJjZShXVEZNb3ZlKHNvdXJjZSkpCiAgICAgICAgICwgbV9yaW5nQnVmZmVyKG1ha2VV bmlxdWVSZWY8U2hhcmVkUmluZ0J1ZmZlclN0b3JhZ2U+KG1ha2VVbmlxdWVSZWY8U2hhcmVkUmlu Z0J1ZmZlclN0b3JhZ2U+KHRoaXMpKSkKICAgICB7CkBAIC02OCwxOCArNjgsMTggQEAgcHVibGlj OgogCiAgICAgdm9pZCBzb3VyY2VTdG9wcGVkKCkgZmluYWwgewogICAgICAgICBpZiAobV9zb3Vy Y2UtPmNhcHR1cmVEaWRGYWlsKCkpIHsKLSAgICAgICAgICAgIG1fbWFuYWdlci5wcm9jZXNzKCku c2VuZChNZXNzYWdlczo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OkNhcHR1cmVGYWlsZWQobV9p ZCksIDApOworICAgICAgICAgICAgbV9jb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpVc2VyTWVk aWFDYXB0dXJlTWFuYWdlcjo6Q2FwdHVyZUZhaWxlZChtX2lkKSwgMCk7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0KLSAgICAgICAgbV9tYW5hZ2VyLnByb2Nlc3MoKS5zZW5kKE1lc3Nh Z2VzOjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6U291cmNlU3RvcHBlZChtX2lkKSwgMCk7Cisg ICAgICAgIG1fY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6VXNlck1lZGlhQ2FwdHVyZU1hbmFn ZXI6OlNvdXJjZVN0b3BwZWQobV9pZCksIDApOwogICAgIH0KIAogICAgIHZvaWQgc291cmNlTXV0 ZWRDaGFuZ2VkKCkgZmluYWwgewotICAgICAgICBtX21hbmFnZXIucHJvY2VzcygpLnNlbmQoTWVz c2FnZXM6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpTb3VyY2VNdXRlZENoYW5nZWQobV9pZCwg bV9zb3VyY2UtPm11dGVkKCkpLCAwKTsKKyAgICAgICAgbV9jb25uZWN0aW9uLT5zZW5kKE1lc3Nh Z2VzOjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6U291cmNlTXV0ZWRDaGFuZ2VkKG1faWQsIG1f c291cmNlLT5tdXRlZCgpKSwgMCk7CiAgICAgfQogCiAgICAgdm9pZCBzb3VyY2VTZXR0aW5nc0No YW5nZWQoKSBmaW5hbCB7Ci0gICAgICAgIG1fbWFuYWdlci5wcm9jZXNzKCkuc2VuZChNZXNzYWdl czo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OlNvdXJjZVNldHRpbmdzQ2hhbmdlZChtX2lkLCBt X3NvdXJjZS0+c2V0dGluZ3MoKSksIDApOworICAgICAgICBtX2Nvbm5lY3Rpb24tPnNlbmQoTWVz c2FnZXM6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpTb3VyY2VTZXR0aW5nc0NoYW5nZWQobV9p ZCwgbV9zb3VyY2UtPnNldHRpbmdzKCkpLCAwKTsKICAgICB9CiAKICAgICAvLyBNYXkgZ2V0IGNh bGxlZCBvbiBhIGJhY2tncm91bmQgdGhyZWFkLgpAQCAtOTgsNyArOTgsNyBAQCBwdWJsaWM6CiAg ICAgICAgIHVpbnQ2NF90IHN0YXJ0RnJhbWU7CiAgICAgICAgIHVpbnQ2NF90IGVuZEZyYW1lOwog ICAgICAgICBtX3JpbmdCdWZmZXIuZ2V0Q3VycmVudEZyYW1lQm91bmRzKHN0YXJ0RnJhbWUsIGVu ZEZyYW1lKTsKLSAgICAgICAgbV9tYW5hZ2VyLnByb2Nlc3MoKS5zZW5kKE1lc3NhZ2VzOjpVc2Vy TWVkaWFDYXB0dXJlTWFuYWdlcjo6QXVkaW9TYW1wbGVzQXZhaWxhYmxlKG1faWQsIHRpbWUsIG51 bWJlck9mRnJhbWVzLCBzdGFydEZyYW1lLCBlbmRGcmFtZSksIDApOworICAgICAgICBtX2Nvbm5l Y3Rpb24tPnNlbmQoTWVzc2FnZXM6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpBdWRpb1NhbXBs ZXNBdmFpbGFibGUobV9pZCwgdGltZSwgbnVtYmVyT2ZGcmFtZXMsIHN0YXJ0RnJhbWUsIGVuZEZy YW1lKSwgMCk7CiAgICAgfQogCiAgICAgdm9pZCB2aWRlb1NhbXBsZUF2YWlsYWJsZShNZWRpYVNh bXBsZSYgc2FtcGxlKSBmaW5hbApAQCAtMTA2LDcgKzEwNiw3IEBAIHB1YmxpYzoKICNpZiBIQVZF KElPU1VSRkFDRSkKICAgICAgICAgYXV0byByZW1vdGVTYW1wbGUgPSBSZW1vdGVWaWRlb1NhbXBs ZTo6Y3JlYXRlKFdURk1vdmUoc2FtcGxlKSk7CiAgICAgICAgIGlmIChyZW1vdGVTYW1wbGUpCi0g ICAgICAgICAgICBtX21hbmFnZXIucHJvY2VzcygpLnNlbmQoTWVzc2FnZXM6OlVzZXJNZWRpYUNh cHR1cmVNYW5hZ2VyOjpSZW1vdGVWaWRlb1NhbXBsZUF2YWlsYWJsZShtX2lkLCBXVEZNb3ZlKCpy ZW1vdGVTYW1wbGUpKSwgMCk7CisgICAgICAgICAgICBtX2Nvbm5lY3Rpb24tPnNlbmQoTWVzc2Fn ZXM6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpSZW1vdGVWaWRlb1NhbXBsZUF2YWlsYWJsZSht X2lkLCBXVEZNb3ZlKCpyZW1vdGVTYW1wbGUpKSwgMCk7CiAjZWxzZQogICAgICAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKICNlbmRpZgpAQCAtMTE2LDEyICsxMTYsMTIgQEAgcHVibGljOgogICAg ICAgICBTaGFyZWRNZW1vcnk6OkhhbmRsZSBoYW5kbGU7CiAgICAgICAgIGlmIChzdG9yYWdlKQog ICAgICAgICAgICAgc3RvcmFnZS0+Y3JlYXRlSGFuZGxlKGhhbmRsZSwgU2hhcmVkTWVtb3J5OjpQ cm90ZWN0aW9uOjpSZWFkT25seSk7Ci0gICAgICAgIG1fbWFuYWdlci5wcm9jZXNzKCkuc2VuZChN ZXNzYWdlczo6VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OlN0b3JhZ2VDaGFuZ2VkKG1faWQsIGhh bmRsZSwgbV9kZXNjcmlwdGlvbiwgbV9udW1iZXJPZkZyYW1lcyksIDApOworICAgICAgICBtX2Nv bm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpTdG9yYWdl Q2hhbmdlZChtX2lkLCBoYW5kbGUsIG1fZGVzY3JpcHRpb24sIG1fbnVtYmVyT2ZGcmFtZXMpLCAw KTsKICAgICB9CiAKIHByb3RlY3RlZDoKICAgICB1aW50NjRfdCBtX2lkOwotICAgIFVzZXJNZWRp YUNhcHR1cmVNYW5hZ2VyUHJveHkmIG1fbWFuYWdlcjsKKyAgICBSZWY8SVBDOjpDb25uZWN0aW9u PiBtX2Nvbm5lY3Rpb247CiAgICAgUmVmPFJlYWx0aW1lTWVkaWFTb3VyY2U+IG1fc291cmNlOwog ICAgIENBUmluZ0J1ZmZlciBtX3JpbmdCdWZmZXI7CiAgICAgQ0FBdWRpb1N0cmVhbURlc2NyaXB0 aW9uIG1fZGVzY3JpcHRpb24geyB9OwpAQCAtMTY4LDcgKzE2OCw3IEBAIHZvaWQgVXNlck1lZGlh Q2FwdHVyZU1hbmFnZXJQcm94eTo6Y3JlYXRlTWVkaWFTb3VyY2VGb3JDYXB0dXJlRGV2aWNlV2l0 aENvbnN0cmFpCiAgICAgICAgIHNvdXJjZS0+c2V0SXNSZW1vdGUodHJ1ZSk7CiAgICAgICAgIHNl dHRpbmdzID0gc291cmNlLT5zZXR0aW5ncygpOwogICAgICAgICBBU1NFUlQoIW1fcHJveGllcy5j b250YWlucyhpZCkpOwotICAgICAgICBtX3Byb3hpZXMuYWRkKGlkLCBzdGQ6Om1ha2VfdW5pcXVl PFNvdXJjZVByb3h5PihpZCwgKnRoaXMsIFdURk1vdmUoc291cmNlKSkpOworICAgICAgICBtX3By b3hpZXMuYWRkKGlkLCBzdGQ6Om1ha2VfdW5pcXVlPFNvdXJjZVByb3h5PihpZCwgKm1fcHJvY2Vz cy5jb25uZWN0aW9uKCksIFdURk1vdmUoc291cmNlKSkpOwogICAgIH0gZWxzZQogICAgICAgICBp bnZhbGlkQ29uc3RyYWludHMgPSBXVEZNb3ZlKHNvdXJjZU9yRXJyb3IuZXJyb3JNZXNzYWdlKTsK ICAgICBjb21wbGV0aW9uSGFuZGxlcihzdWNjZWVkZWQsIGludmFsaWRDb25zdHJhaW50cywgV1RG TW92ZShzZXR0aW5ncykpOwo=