198308 2019-05-28 15:58:10 -0700 Correct flaky WebAuthN test cases 2019-05-29 10:05:09 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue ddkilzer jiewen_tan webkit-bug-importer oldest_to_newest 1539767 0 bfulgham 2019-05-28 15:58:10 -0700 A series of flaky WebAuthN crashes were due to a mistake in the implementation of the MockHidConnection test object. This code is not used in production operation, and is not a security risk. After reserving the appropriate size for the payload, and appending the Nonce to the payload, it was grown to the size of the kHidInitResponseSize constant. Unfortunately, this also changes the value the payload Vector returns when asked for its size. Consequently, we always began writing the CtapChannelIdSize value aafter the end of the buffer we had just allocated. I did not find any other instances of this coding issue elsewhere. 1539768 1 bfulgham 2019-05-28 15:58:34 -0700 <rdar://problem/48677219> 1539825 2 370811 bfulgham 2019-05-28 17:26:48 -0700 Created attachment 370811 Patch 1539880 3 370811 ddkilzer 2019-05-28 21:10:45 -0700 Comment on attachment 370811 Patch r=me assuming the test failures aren't caused by this change. 1539896 4 bfulgham 2019-05-28 22:54:30 -0700 Boy it would be hard to imagine this change affecting that Download test. I’ll run locally under ASan and confirm the change doesn’t trigger that failure before landing. 1539969 5 bfulgham 2019-05-29 09:37:50 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 370811 [details] > Patch > > r=me assuming the test failures aren't caused by this change. Yes, that flaky timeout is well known (see Bug 198298). 1539984 6 370811 commit-queue 2019-05-29 10:05:08 -0700 Comment on attachment 370811 Patch Clearing flags on attachment: 370811 Committed r245852: <https://trac.webkit.org/changeset/245852> 1539985 7 commit-queue 2019-05-29 10:05:09 -0700 All reviewed patches have been landed. Closing bug. 370811 2019-05-28 17:26:48 -0700 2019-05-29 10:05:08 -0700 Patch bug-198308-20190528172647.patch text/plain 2144 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzYzUwMjFjYjQ1NWZkYWZm MWUwYjU3YzAyYjQ0NDcyZGY0ZTFmM2IuLjQ1YzdmM2U0MjcxYjE5NzQ1OWQxNGY5YTUxMDI0NzVm ZTNhYmUzZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDUtMjggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQ29ycmVjdCBmbGFreSBXZWJB dXRoTiB0ZXN0IGNhc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTgzMDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ4Njc3MjE5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3Qgb2Zmc2V0 IG1hdGggaW4gdGhlIE1vY2tIaWRDb25uZWN0aW9uIGltcGxlbWVudGF0aW9uLiBUaGUgd3JpdGUg cG9zaXRpb24gb2YKKyAgICAgICAgdGhlIHBheWxvYWQgYnVmZmVyIHdhcyBjb21wdXRlZCB1c2lu ZyB0aGUgdmFsdWUgb2YgJ3NpemUoKScsIHdoaWNoIGlzIHNldCB0byB0aGUgZnVsbAorICAgICAg ICBjYXBhY2l0eSBvZiB0aGUgdmVjdG9yIGFmdGVyIGEgJ2dyb3coKScgb3BlcmF0aW9uLgorCisg ICAgICAgIFRlc3RzOiBodHRwL3dwdC93ZWJhdXRobgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YkF1dGhlbnRpY2F0aW9uL01vY2svTW9ja0hpZENvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2Vi S2l0OjpNb2NrSGlkQ29ubmVjdGlvbjo6ZmVlZFJlcG9ydHMpOiAKKwogMjAxOS0wNS0yOCAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgc2FuZGJv eCBydWxlcyBmb3IgbW9yZSBOZXdzIHVzZSBjYXNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vTW9jay9Nb2NrSGlkQ29ubmVjdGlvbi5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Nb2NrL01vY2tIaWRD b25uZWN0aW9uLmNwcAppbmRleCAzOWRkNzUyODhhOTU3NjQwZDk1ODNhYjAxOGYyMWVmOTMzOTk3 MDIyLi5jOGJhOTE4M2U5YzhhMjUzZWUzMTUyNGQxZTJiYTk5MTcxYTUyOWViIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Nb2NrL01vY2tIaWRD b25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Nb2NrL01vY2tIaWRDb25uZWN0aW9uLmNwcApAQCAtMTk1LDEwICsxOTUsMTEgQEAgdm9p ZCBNb2NrSGlkQ29ubmVjdGlvbjo6ZmVlZFJlcG9ydHMoKQogICAgICAgICBWZWN0b3I8dWludDhf dD4gcGF5bG9hZDsKICAgICAgICAgcGF5bG9hZC5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGtIaWRJ bml0UmVzcG9uc2VTaXplKTsKICAgICAgICAgcGF5bG9hZC5hcHBlbmRWZWN0b3IobV9ub25jZSk7 CisgICAgICAgIHNpemVfdCB3cml0ZVBvc2l0aW9uID0gcGF5bG9hZC5zaXplKCk7CiAgICAgICAg IGlmIChzdGFnZXNNYXRjaCgpICYmIG1fY29uZmlndXJhdGlvbi5oaWQtPmVycm9yID09IE1vY2s6 OkVycm9yOjpXcm9uZ05vbmNlKQogICAgICAgICAgICAgcGF5bG9hZFswXS0tOwogICAgICAgICBw YXlsb2FkLmdyb3coa0hpZEluaXRSZXNwb25zZVNpemUpOwotICAgICAgICBjcnlwdG9ncmFwaGlj YWxseVJhbmRvbVZhbHVlcyhwYXlsb2FkLmRhdGEoKSArIHBheWxvYWQuc2l6ZSgpLCBDdGFwQ2hh bm5lbElkU2l6ZSk7CisgICAgICAgIGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzKHBheWxv YWQuZGF0YSgpICsgd3JpdGVQb3NpdGlvbiwgQ3RhcENoYW5uZWxJZFNpemUpOwogICAgICAgICBh dXRvIGNoYW5uZWwgPSBrSGlkQnJvYWRjYXN0Q2hhbm5lbDsKICAgICAgICAgaWYgKHN0YWdlc01h dGNoKCkgJiYgbV9jb25maWd1cmF0aW9uLmhpZC0+ZXJyb3IgPT0gTW9jazo6RXJyb3I6Oldyb25n Q2hhbm5lbElkKQogICAgICAgICAgICAgY2hhbm5lbC0tOwo=