198285 2019-05-28 01:28:52 -0700 [GTK] Build without WPE renderer in debian and ubuntu bots 2019-05-31 01:49:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply dbates ews-watchlist psaavedra zan oldest_to_newest 1539503 0 cgarcia 2019-05-28 01:28:52 -0700 There aren't wpe packages in those distros, so we need to build with wpe renderer disabled. 1539504 1 370717 cgarcia 2019-05-28 01:30:50 -0700 Created attachment 370717 Patch 1539514 2 cgarcia 2019-05-28 02:38:52 -0700 Pablo told me we have a way to pass cmake args to those bots without having to change any configuration. He already changed it, so closing. 1540673 3 psaavedra 2019-05-31 01:49:21 -0700 For the record, basically we are using the envvar `BUILD_WEBKIT_ARGS` to override specific flags for a particular bot. For example, for the case of Ubuntu: ``` BUILD_WEBKIT_ARGS="--cmakeargs=-DENABLE_WEB_CRYPTO=OFF --cmakeargs=-DUSE_WOFF2=OFF --cmakeargs=-DUSE_GSTREAMER_GL=OFF --cmakeargs=-DENABLE_BUBBLEWRAP_SANDBOX=OFF --cmakeargs=-DUSE_OPENJPEG=OFF --cmakeargs=-DUSE_WPE_RENDERER=OFF" \ ``` As you can , we added -DUSE_WPE_RENDERER=OFF to avoid the WPE renderer in this one. 370717 2019-05-28 01:30:50 -0700 2019-05-28 02:39:01 -0700 Patch wkgtk-no-wpe.diff text/plain 3119 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL2NvbmZpZy5qc29uIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvY29uZmlnLmpzb24KaW5kZXggMjQ3NDliMDkzNDAuLjFmNGE0MWY3NzljIDEwMDY0 NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9j b25maWcuanNvbgorKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9jb25maWcuanNvbgpAQCAtMjcyLDEzICsyNzIsMTMgQEAKICAgICAgICAgICAgICAg ICAgICAgewogICAgICAgICAgICAgICAgICAgICAgICJuYW1lIjogIkdUSyBMaW51eCA2NC1iaXQg UmVsZWFzZSBEZWJpYW4gU3RhYmxlIChCdWlsZCkiLCAidHlwZSI6ICJCdWlsZCIsICJidWlsZGRp ciI6ICJndGstbGludXgtNjQtcmVsZWFzZS1kZWJpYW4iLAogICAgICAgICAgICAgICAgICAgICAg ICJwbGF0Zm9ybSI6ICJndGsiLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVj dHVyZXMiOiBbIng4Nl82NCJdLAotICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJn dW1lbnRzIjogWyItLW5vLWV4cGVyaW1lbnRhbC1mZWF0dXJlcyIsICItLW5vLW1lZGlhLXNvdXJj ZSJdLAorICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsQXJndW1lbnRzIjogWyItLW5v LWV4cGVyaW1lbnRhbC1mZWF0dXJlcyIsICItLW5vLW1lZGlhLXNvdXJjZSIsICItLW5vLXdwZS1y ZW5kZXJlciJdLAogICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJndGstbGlu dXgtc2xhdmUtMTAiXQogICAgICAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAg ICB7CiAgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiR1RLIExpbnV4IDY0LWJpdCBSZWxl YXNlIFVidW50dSBMVFMgKEJ1aWxkKSIsICJ0eXBlIjogIkJ1aWxkIiwgImJ1aWxkZGlyIjogImd0 ay1saW51eC02NC1yZWxlYXNlLXVidW50dSIsCiAgICAgICAgICAgICAgICAgICAgICAgInBsYXRm b3JtIjogImd0ayIsICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0dXJlcyI6 IFsieDg2XzY0Il0sCi0gICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1bWVudHMi OiBbIi0tbm8tZXhwZXJpbWVudGFsLWZlYXR1cmVzIiwgIi0tbm8tbWVkaWEtc291cmNlIl0sCisg ICAgICAgICAgICAgICAgICAgICAgImFkZGl0aW9uYWxBcmd1bWVudHMiOiBbIi0tbm8tZXhwZXJp bWVudGFsLWZlYXR1cmVzIiwgIi0tbm8tbWVkaWEtc291cmNlIiwgIi0tbm8td3BlLXJlbmRlcmVy Il0sCiAgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImd0ay1saW51eC1zbGF2 ZS0xMSJdCiAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgICAgIHsKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlMzA5OTlj MzNiOS4uYWE5MGM4OGMxZmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29s cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wNS0yOCAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQnVpbGQgd2l0aG91 dCBXUEUgcmVuZGVyZXIgaW4gZGViaWFuIGFuZCB1YnVudHUgYm90cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4Mjg1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlbid0IHdwZSBwYWNrYWdl cyBpbiB0aG9zZSBkaXN0cm9zLCBzbyB3ZSBuZWVkIHRvIGJ1aWxkIHdpdGggd3BlIHJlbmRlcmVy IGRpc2FibGVkLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvY29uZmlnLmpzb246IFBhc3MgLS1uby13cGUtcmVuZGVyZXIgdG8gYnVpbGQtd2Vi a2l0IGZvciBkZWJpYW4gYW5kCisgICAgICAgIHVidW50dSBib3RzLgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbTogQWRkIC0tW25vLV13cGUtcmVuZGVyZXIgY29t bWFuZCBsaW5lIG9wdGlvbi4KKwogMjAxOS0wNS0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVXNlIFdQRUJhY2tlbmQtZmRvIGZv ciBhY2NlbGVyYXRpbmcgY29tcG9zaXRpbmcgaW4gV2F5bGFuZCBpbnN0ZWFkIG9mIHRoZSBuZXN0 ZWQgY29tcG9zaXRvcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1 cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4 IDRlMDI3ZWExZjFjLi4yYmVlMDlmYTgzOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRwZXJsL0ZlYXR1cmVMaXN0LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbQpAQCAtMTgwLDYgKzE4MCw3IEBAIG15ICgKICAgICAkd2ViZ2xTdXBwb3J0LAog ICAgICR3ZWJncHVTdXBwb3J0LAogICAgICR3aXJlbGVzc1BsYXliYWNrVGFyZ2V0U3VwcG9ydCwK KyAgICAkd3BlUmVuZGVyZXJTdXBwb3J0LAogICAgICR4c2x0U3VwcG9ydCwKICk7CiAKQEAgLTU3 OCw2ICs1NzksOSBAQCBteSBAZmVhdHVyZXMgPSAoCiAKICAgICB7IG9wdGlvbiA9PiAic3lzdGVt LW1hbGxvYyIsIGRlc2MgPT4gIlRvZ2dsZSBzeXN0ZW0gYWxsb2NhdG9yIGluc3RlYWQgb2YgYm1h bGxvYyIsCiAgICAgICBkZWZpbmUgPT4gIlVTRV9TWVNURU1fTUFMTE9DIiwgdmFsdWUgPT4gXCRz eXN0ZW1NYWxsb2NTdXBwb3J0IH0sCisKKyAgICB7IG9wdGlvbiA9PiAid3BlLXJlbmRlcmVyIiwg ZGVzYyA9PiAiVG9nZ2xlIFdQRSByZW5kZXJlciBzdXBwb3J0IGluIEdUSyBwb3J0IiwKKyAgICAg IGRlZmluZSA9PiAiVVNFX1dQRV9SRU5ERVJFUiIsIHZhbHVlID0+IFwkd3BlUmVuZGVyZXJTdXBw b3J0IH0sCiApOwogCiBzdWIgZ2V0RmVhdHVyZU9wdGlvbkxpc3QoKQo=