198268 2019-05-26 21:32:37 -0700 [LFC[IFC] Ignore the initial strut's height when the line does not have any content. 2019-05-28 07:49:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1539322 0 zalan 2019-05-26 21:32:37 -0700 The initial strut sets the height of the line. However when the line is "empty" this strut height should be ignored. 1539323 1 webkit-bug-importer 2019-05-26 21:32:59 -0700 <rdar://problem/51150057> 1539324 2 370665 zalan 2019-05-26 21:40:23 -0700 Created attachment 370665 Patch 1539560 3 370665 commit-queue 2019-05-28 07:49:03 -0700 Comment on attachment 370665 Patch Clearing flags on attachment: 370665 Committed r245810: <https://trac.webkit.org/changeset/245810> 1539561 4 commit-queue 2019-05-28 07:49:04 -0700 All reviewed patches have been landed. Closing bug. 370665 2019-05-26 21:40:23 -0700 2019-05-28 07:49:03 -0700 Patch bug-198268-20190526214020.patch text/plain 2252 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxYjViOTgzZGEwN2Q4 OWJlZjUwNmEzN2UxM2IwY2Q4YzYwNGRiMy4uZjlkMDU0Y2RiODY4ZDA3YmEzNTg0ZWIyN2NkNGNk MGMwYWVkYzRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA1LTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ1tJRkNdIElnbm9yZSB0 aGUgaW5pdGlhbCBzdHJ1dCdzIGhlaWdodCB3aGVuIHRoZSBsaW5lIGRvZXMgbm90IGhhdmUgYW55 IGNvbnRlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTgyNjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxMTUwMDU3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzdHJ1dCAoaHR0cHM6Ly93 d3cudzMub3JnL1RSL0NTUzIyL3Zpc3VkZXQuaHRtbCNsZWFkaW5nKSBkZWZpbmVzIHRoZSBpbml0 aWFsIGxvZ2ljYWwgaGVpZ2h0CisgICAgICAgIGZvciB0aGUgbGluZS4gVGhpcyBoZWlnaHQgc2hv dWxkIGJlIGlnbm9yZWQgdGhvdWdoIHdoZW4gdGhlIGxpbmUgZG9lcyBub3QgaGF2ZSBhbnkgY29u dGVudC4gCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0 aW5nQ29udGV4dExpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxp bmVGb3JtYXR0aW5nQ29udGV4dDo6TGluZUxheW91dDo6Y2xvc2VMaW5lIGNvbnN0KToKKwogMjAx OS0wNS0yNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNd W0lGQ10gSWdub3JlIGNvbGxhcHNlZCBydW5zIHdoZW4gc2V0dGluZyB0aGUgd2lkdGggb24gdGhl IGFzc29jaWF0ZWQgZGlzcGxheSBib3hlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0 aW5nQ29udGV4dExpbmVMYXlvdXQuY3BwCmluZGV4IDViMDEyNTU1N2I2MTk0ZTM2MTVmMGFmYmI2 NTEwZjFiMTEwZmQ3ZGIuLmFjYjI5YTNjN2UwYzAyNGY1NTgxYTc4MjQzM2YwNzAxM2IyNWM1YzAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGlu ZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNw cApAQCAtNTAxLDcgKzUwMSw5IEBAIHZvaWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVM YXlvdXQ6OmNsb3NlTGluZShMaW5lJiBsaW5lKSBjb25zdAogICAgIE9wdGlvbmFsPHVuc2lnbmVk PiBwcmV2aW91c0xpbmVMYXN0UnVuSW5kZXggPSBpbmxpbmVEaXNwbGF5UnVucy5pc0VtcHR5KCkg PyBPcHRpb25hbDx1bnNpZ25lZD4oKSA6IGlubGluZURpc3BsYXlSdW5zLnNpemUoKSAtIDE7CiAg ICAgLy8gOS40LjIgSW5saW5lIGZvcm1hdHRpbmcgY29udGV4dHMKICAgICAvLyBBIGxpbmUgYm94 IGlzIGFsd2F5cyB0YWxsIGVub3VnaCBmb3IgYWxsIG9mIHRoZSBib3hlcyBpdCBjb250YWlucy4K LSAgICBhdXRvIGxpbmVCb3ggPSBEaXNwbGF5OjpSZWN0IHsgbGluZS5sb2dpY2FsVG9wKCksIGxp bmUubG9naWNhbExlZnQoKSwgMCAsIGxpbmUubG9naWNhbEhlaWdodCgpIH07CisKKyAgICAvLyBJ Z25vcmUgdGhlIGluaXRpYWwgc3RydXQuCisgICAgYXV0byBsaW5lQm94ID0gRGlzcGxheTo6UmVj dCB7IGxpbmUubG9naWNhbFRvcCgpLCBsaW5lLmxvZ2ljYWxMZWZ0KCksIDAgLCBsaW5lLmhhc0Nv bnRlbnQoKSA/IGxpbmUubG9naWNhbEhlaWdodCgpIDogTGF5b3V0VW5pdCB7IH0gfTsKICAgICAv LyBDcmVhdGUgZmluYWwgZGlzcGxheSBydW5zLgogICAgIGZvciAodW5zaWduZWQgaW5kZXggPSAw OyBpbmRleCA8IGxpbmVJdGVtcy5zaXplKCk7ICsraW5kZXgpIHsKICAgICAgICAgYXV0byYgbGlu ZUl0ZW0gPSBsaW5lSXRlbXMuYXQoaW5kZXgpOwo=