198256 2019-05-26 07:24:22 -0700 Fix opensource build of testapi 2019-05-28 02:47:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo aakash_jain ap commit-queue ews-watchlist fpizlo jbedard keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer ysuzuki oldest_to_newest 1539267 0 tzagallo 2019-05-26 07:24:22 -0700 ... 1539268 1 370649 tzagallo 2019-05-26 07:40:53 -0700 Created attachment 370649 Patch 1539317 2 ap 2019-05-26 20:43:59 -0700 Looks like this regresses TestWebKitAPI._WKDownload.DownloadMonitorCancel? 1539319 3 ap 2019-05-26 20:44:54 -0700 Looking at the patch, it appears impossible. Must be a bad case of flakiness. 1539320 4 370649 ap 2019-05-26 20:54:44 -0700 Comment on attachment 370649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370649&action=review > Source/JavaScriptCore/API/JSScript.mm:87 > - createError([NSString stringWithFormat:@"Cache path `%s` does not contain in a valid directory", systemPath.utf8().data()], error); > + createError([NSString stringWithFormat:@"Cache path `%s` does not contain in a valid directory", systemPath.ascii().data()], error); The post-commit comment was that you should use %@ instead of %s. Obviously, you cannot just use %@ as a replacement, because it expects an Objective-C object. But you cannot use ascii() either, because the path may not be all ASCII. In this case, it's probably easiest to convert systemPath to an NSString, and then format with %@. In more performance sensitive cases, we'd probably want to stick with WTF. 1539338 5 370672 tzagallo 2019-05-26 23:02:49 -0700 Created attachment 370672 Patch 1539339 6 370649 tzagallo 2019-05-26 23:08:51 -0700 Comment on attachment 370649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370649&action=review >> Source/JavaScriptCore/API/JSScript.mm:87 >> + createError([NSString stringWithFormat:@"Cache path `%s` does not contain in a valid directory", systemPath.ascii().data()], error); > > The post-commit comment was that you should use %@ instead of %s. Obviously, you cannot just use %@ as a replacement, because it expects an Objective-C object. But you cannot use ascii() either, because the path may not be all ASCII. > > In this case, it's probably easiest to convert systemPath to an NSString, and then format with %@. In more performance sensitive cases, we'd probably want to stick with WTF. Oh, now I see that WTF::String has a conversion operator to NSString. I've updated the patch, thanks! 1539434 7 370672 ap 2019-05-27 13:09:06 -0700 Comment on attachment 370672 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370672&action=review > Source/JavaScriptCore/API/JSScript.mm:80 > + createError([NSString stringWithFormat:@"Cache path `%@` already exists and is not a file", static_cast<NSString*>(systemPath)], error); Please add a space between NSString and the star, since this is an Objective-C class name. > Source/JavaScriptCore/API/JSScript.mm:87 > + createError([NSString stringWithFormat:@"Cache path `%@` does not contain in a valid directory", static_cast<NSString*>(systemPath)], error); Ditto. > Source/JavaScriptCore/API/JSScript.mm:92 > + createError([NSString stringWithFormat:@"Cache directory `%@` is not a directory or does not exist", static_cast<NSString*>(directory)], error); Ditto. 1539446 8 370708 tzagallo 2019-05-27 14:22:08 -0700 Created attachment 370708 Patch for landing 1539450 9 370708 commit-queue 2019-05-27 14:51:46 -0700 Comment on attachment 370708 Patch for landing Clearing flags on attachment: 370708 Committed r245800: <https://trac.webkit.org/changeset/245800> 1539451 10 commit-queue 2019-05-27 14:51:48 -0700 All reviewed patches have been landed. Closing bug. 1539452 11 webkit-bug-importer 2019-05-27 14:52:21 -0700 <rdar://problem/51163764> 1539517 12 aakash_jain 2019-05-28 02:47:44 -0700 (In reply to Alexey Proskuryakov from comment #3) > Looking at the patch, it appears impossible. Must be a bad case of flakiness. https://bugs.webkit.org/show_bug.cgi?id=198288 370649 2019-05-26 07:40:53 -0700 2019-05-26 23:02:45 -0700 Patch bug-198256-20190526164050.patch text/plain 4191 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZjVhZGM0Y2M3MjVmYTQ2MWIyYWM4OTc0Zjc3MjU1OGYxMWE1NDU1Li42NjA1Mzg5MmQzNmU0YmMz MjFkNjU4ODNjMTQ3ODRhZGFkNjRkYjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wNS0yNiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggb3BlbnNvdXJjZSBidWlsZCBvZiB0ZXN0YXBpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgyNTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjQ1NTY0LCB3ZSBhZGRl ZCBjdXN0b20gZW50aXRsZW1lbnRzIHRvIHRlc3RhcGkgdG8gYWxsb3cgY2FjaGluZworICAgICAg ICBieXRlY29kZSBpbiBkYXRhIHZhdWx0cywgYnV0IHdlIHNob3VsZCBvbmx5IHVzZSB0aGUgZW50 aXRsZW1lbnRzIGZvcgorICAgICAgICBpbnRlcm5hbCBidWlsZHMuIE90aGVyd2lzZXMsIHRlc3Rh cGkgZ2V0cyBraWxsZWQgb24gbGF1bmNoLiBBbHNvIGZpeCB0aGUKKyAgICAgICAgZm9ybWF0dGlu ZyBmb3IgdGhlIGVycm9ycyBhZGRlZCBpbiB0aGUgc2FtZSBwYXRjaCwgYWNjb3JkaW5nIHRvIGNv bW1lbnRzCisgICAgICAgIGluIHRoZSBidWcgYWZ0ZXIgdGhlIHBhdGNoIGhhZCBhbHJlYWR5IGxh bmRlZC4KKworICAgICAgICAqIEFQSS9KU1NjcmlwdC5tbToKKyAgICAgICAgKHZhbGlkYXRlQnl0 ZWNvZGVDYWNoZVBhdGgpOgorICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxl LnhjY29uZmlnOgorCiAyMDE5LTA1LTI1ICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUu Y29tPgogCiAgICAgICAgIEpJVE9wZXJhdGlvbnMgZ2V0QnlWYWwgc2hvdWxkIG1hcmsgbmVnYXRp dmUgYXJyYXkgaW5kaWNlcyBhcyBvdXQtb2YtYm91bmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTU2NyaXB0Lm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U1NjcmlwdC5tbQppbmRleCBiM2FkMDM3ZDY4NmE5ZTRhNWNhYjA1YTk5ODRlODdjNDVmYmE3Mjc2 Li5mMjAyZDNkNzNiMzJjYzdhYjM4YWNjNTk0NTA0M2ZlMjQ5ODNlYWMwIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU2NyaXB0Lm1tCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvSlNTY3JpcHQubW0KQEAgLTc3LDI1ICs3NywyNSBAQCBzdGF0aWMgYm9vbCB2 YWxpZGF0ZUJ5dGVjb2RlQ2FjaGVQYXRoKE5TVVJMKiBjYWNoZVBhdGgsIE5TRXJyb3IqKiBlcnJv cikKIAogICAgIGlmIChhdXRvIG1ldGFkYXRhID0gRmlsZVN5c3RlbTo6ZmlsZU1ldGFkYXRhKHN5 c3RlbVBhdGgpKSB7CiAgICAgICAgIGlmIChtZXRhZGF0YS0+dHlwZSAhPSBGaWxlTWV0YWRhdGE6 OlR5cGU6OkZpbGUpIHsKLSAgICAgICAgICAgIGNyZWF0ZUVycm9yKFtOU1N0cmluZyBzdHJpbmdX aXRoRm9ybWF0OkAiQ2FjaGUgcGF0aCBgJXNgIGFscmVhZHkgZXhpc3RzIGFuZCBpcyBub3QgYSBm aWxlIiwgc3lzdGVtUGF0aC51dGY4KCkuZGF0YSgpXSwgZXJyb3IpOworICAgICAgICAgICAgY3Jl YXRlRXJyb3IoW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJDYWNoZSBwYXRoIGAlc2AgYWxy ZWFkeSBleGlzdHMgYW5kIGlzIG5vdCBhIGZpbGUiLCBzeXN0ZW1QYXRoLmFzY2lpKCkuZGF0YSgp XSwgZXJyb3IpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAgICAgfQog CiAgICAgU3RyaW5nIGRpcmVjdG9yeSA9IEZpbGVTeXN0ZW06OmRpcmVjdG9yeU5hbWUoc3lzdGVt UGF0aCk7CiAgICAgaWYgKGRpcmVjdG9yeS5pc051bGwoKSkgewotICAgICAgICBjcmVhdGVFcnJv cihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIHBhdGggYCVzYCBkb2VzIG5vdCBj b250YWluIGluIGEgdmFsaWQgZGlyZWN0b3J5Iiwgc3lzdGVtUGF0aC51dGY4KCkuZGF0YSgpXSwg ZXJyb3IpOworICAgICAgICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpA IkNhY2hlIHBhdGggYCVzYCBkb2VzIG5vdCBjb250YWluIGluIGEgdmFsaWQgZGlyZWN0b3J5Iiwg c3lzdGVtUGF0aC5hc2NpaSgpLmRhdGEoKV0sIGVycm9yKTsKICAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIH0KIAogICAgIGlmICghRmlsZVN5c3RlbTo6ZmlsZUlzRGlyZWN0b3J5KGRpcmVjdG9y eSwgRmlsZVN5c3RlbTo6U2hvdWxkRm9sbG93U3ltYm9saWNMaW5rczo6Tm8pKSB7Ci0gICAgICAg IGNyZWF0ZUVycm9yKFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiQ2FjaGUgZGlyZWN0b3J5 IGAlc2AgaXMgbm90IGEgZGlyZWN0b3J5IG9yIGRvZXMgbm90IGV4aXN0IiwgZGlyZWN0b3J5LnV0 ZjgoKS5kYXRhKCldLCBlcnJvcik7CisgICAgICAgIGNyZWF0ZUVycm9yKFtOU1N0cmluZyBzdHJp bmdXaXRoRm9ybWF0OkAiQ2FjaGUgZGlyZWN0b3J5IGAlc2AgaXMgbm90IGEgZGlyZWN0b3J5IG9y IGRvZXMgbm90IGV4aXN0IiwgZGlyZWN0b3J5LmFzY2lpKCkuZGF0YSgpXSwgZXJyb3IpOwogICAg ICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCiAjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykK ICAgICBpZiAocm9vdGxlc3NfY2hlY2tfZGF0YXZhdWx0X2ZsYWcoRmlsZVN5c3RlbTo6ZmlsZVN5 c3RlbVJlcHJlc2VudGF0aW9uKGRpcmVjdG9yeSkuZGF0YSgpLCBudWxscHRyKSkgewotICAgICAg ICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIGRpcmVjdG9y eSBgJXNgIGlzIG5vdCBhIGRhdGEgdmF1bHQiLCBkaXJlY3RvcnkudXRmOCgpLmRhdGEoKV0sIGVy cm9yKTsKKyAgICAgICAgY3JlYXRlRXJyb3IoW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJD YWNoZSBkaXJlY3RvcnkgYCVzYCBpcyBub3QgYSBkYXRhIHZhdWx0IiwgZGlyZWN0b3J5LmFzY2lp KCkuZGF0YSgpXSwgZXJyb3IpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogI2VuZGlm CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4 ZWN1dGFibGUueGNjb25maWcgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMv VG9vbEV4ZWN1dGFibGUueGNjb25maWcKaW5kZXggMjYzOTQyZDIyNTMxNTRhMDg5ZjJjOGViNzdk MjE2MzAwMmI3ZDIxYy4uYjhhOWIyOGYxMTA2N2U1NmY1ZTAyMzhhYTk0OTk4YWI2NGYyNTFiMyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL1Rvb2xFeGVj dXRhYmxlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9u cy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwpAQCAtNDMsOCArNDMsOCBAQCBDT0RFX1NJR05fSURF TlRJVFlfID0gJChDT0RFX1NJR05fSURFTlRJVFlfTk8pOwogQ09ERV9TSUdOX0lERU5USVRZX05P ID0gLTsKIENPREVfU0lHTl9JREVOVElUWV9ZRVMgPSAkKFdLX0VOR0lORUVSSU5HX0NPREVfU0lH Tl9JREVOVElUWSk7CiAKLUNPREVfU0lHTl9FTlRJVExFTUVOVFNbc2RrPW1hY29zeCpdID0gJChD T0RFX1NJR05fRU5USVRMRU1FTlRTX21hY29zeF8kKFRBUkdFVF9OQU1FKSk7Ci1DT0RFX1NJR05f RU5USVRMRU1FTlRTX21hY29zeF90ZXN0YXBpID0gdGVzdGFwaS5lbnRpdGxlbWVudHM7CitDT0RF X1NJR05fRU5USVRMRU1FTlRTW3Nkaz1tYWNvc3gqXSA9ICQoQ09ERV9TSUdOX0VOVElUTEVNRU5U U19tYWNvc3hfJChUQVJHRVRfTkFNRSlfJChVU0VfSU5URVJOQUxfU0RLKSk7CitDT0RFX1NJR05f RU5USVRMRU1FTlRTX21hY29zeF90ZXN0YXBpX1lFUyA9IHRlc3RhcGkuZW50aXRsZW1lbnRzOwog CiBDT0RFX1NJR05fRU5USVRMRU1FTlRTW3Nkaz1pcGhvbmUqXSA9ICQoQ09ERV9TSUdOX0VOVElU TEVNRU5UU19pb3NfJChUQVJHRVRfTkFNRSkpOwogQ09ERV9TSUdOX0VOVElUTEVNRU5UU19pb3Nf bWluaWRvbSA9IGVudGl0bGVtZW50cy5wbGlzdDsK 370672 2019-05-26 23:02:49 -0700 2019-05-27 14:22:04 -0700 Patch bug-198256-20190527080247.patch text/plain 4227 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZjVhZGM0Y2M3MjVmYTQ2MWIyYWM4OTc0Zjc3MjU1OGYxMWE1NDU1Li42NjA1Mzg5MmQzNmU0YmMz MjFkNjU4ODNjMTQ3ODRhZGFkNjRkYjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wNS0yNiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggb3BlbnNvdXJjZSBidWlsZCBvZiB0ZXN0YXBpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgyNTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjQ1NTY0LCB3ZSBhZGRl ZCBjdXN0b20gZW50aXRsZW1lbnRzIHRvIHRlc3RhcGkgdG8gYWxsb3cgY2FjaGluZworICAgICAg ICBieXRlY29kZSBpbiBkYXRhIHZhdWx0cywgYnV0IHdlIHNob3VsZCBvbmx5IHVzZSB0aGUgZW50 aXRsZW1lbnRzIGZvcgorICAgICAgICBpbnRlcm5hbCBidWlsZHMuIE90aGVyd2lzZXMsIHRlc3Rh cGkgZ2V0cyBraWxsZWQgb24gbGF1bmNoLiBBbHNvIGZpeCB0aGUKKyAgICAgICAgZm9ybWF0dGlu ZyBmb3IgdGhlIGVycm9ycyBhZGRlZCBpbiB0aGUgc2FtZSBwYXRjaCwgYWNjb3JkaW5nIHRvIGNv bW1lbnRzCisgICAgICAgIGluIHRoZSBidWcgYWZ0ZXIgdGhlIHBhdGNoIGhhZCBhbHJlYWR5IGxh bmRlZC4KKworICAgICAgICAqIEFQSS9KU1NjcmlwdC5tbToKKyAgICAgICAgKHZhbGlkYXRlQnl0 ZWNvZGVDYWNoZVBhdGgpOgorICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxl LnhjY29uZmlnOgorCiAyMDE5LTA1LTI1ICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUu Y29tPgogCiAgICAgICAgIEpJVE9wZXJhdGlvbnMgZ2V0QnlWYWwgc2hvdWxkIG1hcmsgbmVnYXRp dmUgYXJyYXkgaW5kaWNlcyBhcyBvdXQtb2YtYm91bmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQVBJL0pTU2NyaXB0Lm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U1NjcmlwdC5tbQppbmRleCBiM2FkMDM3ZDY4NmE5ZTRhNWNhYjA1YTk5ODRlODdjNDVmYmE3Mjc2 Li45M2Y3YjU2M2JmOTdiZGViY2FiYmRiOGRiNGM1MWYwNmY5ZTY0NWZjIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTU2NyaXB0Lm1tCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvSlNTY3JpcHQubW0KQEAgLTc3LDI1ICs3NywyNSBAQCBzdGF0aWMgYm9vbCB2 YWxpZGF0ZUJ5dGVjb2RlQ2FjaGVQYXRoKE5TVVJMKiBjYWNoZVBhdGgsIE5TRXJyb3IqKiBlcnJv cikKIAogICAgIGlmIChhdXRvIG1ldGFkYXRhID0gRmlsZVN5c3RlbTo6ZmlsZU1ldGFkYXRhKHN5 c3RlbVBhdGgpKSB7CiAgICAgICAgIGlmIChtZXRhZGF0YS0+dHlwZSAhPSBGaWxlTWV0YWRhdGE6 OlR5cGU6OkZpbGUpIHsKLSAgICAgICAgICAgIGNyZWF0ZUVycm9yKFtOU1N0cmluZyBzdHJpbmdX aXRoRm9ybWF0OkAiQ2FjaGUgcGF0aCBgJXNgIGFscmVhZHkgZXhpc3RzIGFuZCBpcyBub3QgYSBm aWxlIiwgc3lzdGVtUGF0aC51dGY4KCkuZGF0YSgpXSwgZXJyb3IpOworICAgICAgICAgICAgY3Jl YXRlRXJyb3IoW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJDYWNoZSBwYXRoIGAlQGAgYWxy ZWFkeSBleGlzdHMgYW5kIGlzIG5vdCBhIGZpbGUiLCBzdGF0aWNfY2FzdDxOU1N0cmluZyo+KHN5 c3RlbVBhdGgpXSwgZXJyb3IpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9 CiAgICAgfQogCiAgICAgU3RyaW5nIGRpcmVjdG9yeSA9IEZpbGVTeXN0ZW06OmRpcmVjdG9yeU5h bWUoc3lzdGVtUGF0aCk7CiAgICAgaWYgKGRpcmVjdG9yeS5pc051bGwoKSkgewotICAgICAgICBj cmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIHBhdGggYCVzYCBk b2VzIG5vdCBjb250YWluIGluIGEgdmFsaWQgZGlyZWN0b3J5Iiwgc3lzdGVtUGF0aC51dGY4KCku ZGF0YSgpXSwgZXJyb3IpOworICAgICAgICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0 aEZvcm1hdDpAIkNhY2hlIHBhdGggYCVAYCBkb2VzIG5vdCBjb250YWluIGluIGEgdmFsaWQgZGly ZWN0b3J5Iiwgc3RhdGljX2Nhc3Q8TlNTdHJpbmcqPihzeXN0ZW1QYXRoKV0sIGVycm9yKTsKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAogICAgIGlmICghRmlsZVN5c3RlbTo6ZmlsZUlz RGlyZWN0b3J5KGRpcmVjdG9yeSwgRmlsZVN5c3RlbTo6U2hvdWxkRm9sbG93U3ltYm9saWNMaW5r czo6Tm8pKSB7Ci0gICAgICAgIGNyZWF0ZUVycm9yKFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0 OkAiQ2FjaGUgZGlyZWN0b3J5IGAlc2AgaXMgbm90IGEgZGlyZWN0b3J5IG9yIGRvZXMgbm90IGV4 aXN0IiwgZGlyZWN0b3J5LnV0ZjgoKS5kYXRhKCldLCBlcnJvcik7CisgICAgICAgIGNyZWF0ZUVy cm9yKFtOU1N0cmluZyBzdHJpbmdXaXRoRm9ybWF0OkAiQ2FjaGUgZGlyZWN0b3J5IGAlQGAgaXMg bm90IGEgZGlyZWN0b3J5IG9yIGRvZXMgbm90IGV4aXN0Iiwgc3RhdGljX2Nhc3Q8TlNTdHJpbmcq PihkaXJlY3RvcnkpXSwgZXJyb3IpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCiAj aWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKICAgICBpZiAocm9vdGxlc3NfY2hlY2tfZGF0YXZh dWx0X2ZsYWcoRmlsZVN5c3RlbTo6ZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGRpcmVjdG9yeSku ZGF0YSgpLCBudWxscHRyKSkgewotICAgICAgICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5n V2l0aEZvcm1hdDpAIkNhY2hlIGRpcmVjdG9yeSBgJXNgIGlzIG5vdCBhIGRhdGEgdmF1bHQiLCBk aXJlY3RvcnkudXRmOCgpLmRhdGEoKV0sIGVycm9yKTsKKyAgICAgICAgY3JlYXRlRXJyb3IoW05T U3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJDYWNoZSBkaXJlY3RvcnkgYCVAYCBpcyBub3QgYSBk YXRhIHZhdWx0Iiwgc3RhdGljX2Nhc3Q8TlNTdHJpbmcqPihkaXJlY3RvcnkpXSwgZXJyb3IpOwog ICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNjb25maWcgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNjb25m aWcKaW5kZXggMjYzOTQyZDIyNTMxNTRhMDg5ZjJjOGViNzdkMjE2MzAwMmI3ZDIxYy4uYjhhOWIy OGYxMTA2N2U1NmY1ZTAyMzhhYTk0OTk4YWI2NGYyNTFiMyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxlLnhjY29uZmlnCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2Nv bmZpZwpAQCAtNDMsOCArNDMsOCBAQCBDT0RFX1NJR05fSURFTlRJVFlfID0gJChDT0RFX1NJR05f SURFTlRJVFlfTk8pOwogQ09ERV9TSUdOX0lERU5USVRZX05PID0gLTsKIENPREVfU0lHTl9JREVO VElUWV9ZRVMgPSAkKFdLX0VOR0lORUVSSU5HX0NPREVfU0lHTl9JREVOVElUWSk7CiAKLUNPREVf U0lHTl9FTlRJVExFTUVOVFNbc2RrPW1hY29zeCpdID0gJChDT0RFX1NJR05fRU5USVRMRU1FTlRT X21hY29zeF8kKFRBUkdFVF9OQU1FKSk7Ci1DT0RFX1NJR05fRU5USVRMRU1FTlRTX21hY29zeF90 ZXN0YXBpID0gdGVzdGFwaS5lbnRpdGxlbWVudHM7CitDT0RFX1NJR05fRU5USVRMRU1FTlRTW3Nk az1tYWNvc3gqXSA9ICQoQ09ERV9TSUdOX0VOVElUTEVNRU5UU19tYWNvc3hfJChUQVJHRVRfTkFN RSlfJChVU0VfSU5URVJOQUxfU0RLKSk7CitDT0RFX1NJR05fRU5USVRMRU1FTlRTX21hY29zeF90 ZXN0YXBpX1lFUyA9IHRlc3RhcGkuZW50aXRsZW1lbnRzOwogCiBDT0RFX1NJR05fRU5USVRMRU1F TlRTW3Nkaz1pcGhvbmUqXSA9ICQoQ09ERV9TSUdOX0VOVElUTEVNRU5UU19pb3NfJChUQVJHRVRf TkFNRSkpOwogQ09ERV9TSUdOX0VOVElUTEVNRU5UU19pb3NfbWluaWRvbSA9IGVudGl0bGVtZW50 cy5wbGlzdDsK 370708 2019-05-27 14:22:08 -0700 2019-05-27 14:51:46 -0700 Patch for landing bug-198256-20190527232207.patch text/plain 4236 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZjVhZGM0Y2M3MjVmYTQ2MWIyYWM4OTc0Zjc3MjU1OGYxMWE1NDU1Li40NWEwMzAwNzQ1MDI1Y2Ew ZjVlOTg5MzJlNmRlODQxMjQ2NTI5ZTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wNS0yNiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggb3BlbnNvdXJjZSBidWlsZCBvZiB0ZXN0YXBpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgyNTYKKworICAgICAgICBS ZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisgICAgICAgIEluIHIyNDU1NjQsIHdl IGFkZGVkIGN1c3RvbSBlbnRpdGxlbWVudHMgdG8gdGVzdGFwaSB0byBhbGxvdyBjYWNoaW5nCisg ICAgICAgIGJ5dGVjb2RlIGluIGRhdGEgdmF1bHRzLCBidXQgd2Ugc2hvdWxkIG9ubHkgdXNlIHRo ZSBlbnRpdGxlbWVudHMgZm9yCisgICAgICAgIGludGVybmFsIGJ1aWxkcy4gT3RoZXJ3aXNlcywg dGVzdGFwaSBnZXRzIGtpbGxlZCBvbiBsYXVuY2guIEFsc28gZml4IHRoZQorICAgICAgICBmb3Jt YXR0aW5nIGZvciB0aGUgZXJyb3JzIGFkZGVkIGluIHRoZSBzYW1lIHBhdGNoLCBhY2NvcmRpbmcg dG8gY29tbWVudHMKKyAgICAgICAgaW4gdGhlIGJ1ZyBhZnRlciB0aGUgcGF0Y2ggaGFkIGFscmVh ZHkgbGFuZGVkLgorCisgICAgICAgICogQVBJL0pTU2NyaXB0Lm1tOgorICAgICAgICAodmFsaWRh dGVCeXRlY29kZUNhY2hlUGF0aCk6CisgICAgICAgICogQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1 dGFibGUueGNjb25maWc6CisKIDIwMTktMDUtMjUgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgSklUT3BlcmF0aW9ucyBnZXRCeVZhbCBzaG91bGQgbWFyayBu ZWdhdGl2ZSBhcnJheSBpbmRpY2VzIGFzIG91dC1vZi1ib3VuZHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTY3JpcHQubW0gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTU2NyaXB0Lm1tCmluZGV4IGIzYWQwMzdkNjg2YTllNGE1Y2FiMDVhOTk4NGU4N2M0NWZi YTcyNzYuLjQxMWRkY2Q0NjdkMmJlNWVkZGJjMzJkNGE2NTZmZmY4NWFmMmNhNmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNTY3JpcHQubW0KKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS9KU1NjcmlwdC5tbQpAQCAtNzcsMjUgKzc3LDI1IEBAIHN0YXRpYyBi b29sIHZhbGlkYXRlQnl0ZWNvZGVDYWNoZVBhdGgoTlNVUkwqIGNhY2hlUGF0aCwgTlNFcnJvcioq IGVycm9yKQogCiAgICAgaWYgKGF1dG8gbWV0YWRhdGEgPSBGaWxlU3lzdGVtOjpmaWxlTWV0YWRh dGEoc3lzdGVtUGF0aCkpIHsKICAgICAgICAgaWYgKG1ldGFkYXRhLT50eXBlICE9IEZpbGVNZXRh ZGF0YTo6VHlwZTo6RmlsZSkgewotICAgICAgICAgICAgY3JlYXRlRXJyb3IoW05TU3RyaW5nIHN0 cmluZ1dpdGhGb3JtYXQ6QCJDYWNoZSBwYXRoIGAlc2AgYWxyZWFkeSBleGlzdHMgYW5kIGlzIG5v dCBhIGZpbGUiLCBzeXN0ZW1QYXRoLnV0ZjgoKS5kYXRhKCldLCBlcnJvcik7CisgICAgICAgICAg ICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIHBhdGggYCVA YCBhbHJlYWR5IGV4aXN0cyBhbmQgaXMgbm90IGEgZmlsZSIsIHN0YXRpY19jYXN0PE5TU3RyaW5n ICo+KHN5c3RlbVBhdGgpXSwgZXJyb3IpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg ICAgICB9CiAgICAgfQogCiAgICAgU3RyaW5nIGRpcmVjdG9yeSA9IEZpbGVTeXN0ZW06OmRpcmVj dG9yeU5hbWUoc3lzdGVtUGF0aCk7CiAgICAgaWYgKGRpcmVjdG9yeS5pc051bGwoKSkgewotICAg ICAgICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIHBhdGgg YCVzYCBkb2VzIG5vdCBjb250YWluIGluIGEgdmFsaWQgZGlyZWN0b3J5Iiwgc3lzdGVtUGF0aC51 dGY4KCkuZGF0YSgpXSwgZXJyb3IpOworICAgICAgICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3Ry aW5nV2l0aEZvcm1hdDpAIkNhY2hlIHBhdGggYCVAYCBkb2VzIG5vdCBjb250YWluIGluIGEgdmFs aWQgZGlyZWN0b3J5Iiwgc3RhdGljX2Nhc3Q8TlNTdHJpbmcgKj4oc3lzdGVtUGF0aCldLCBlcnJv cik7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKICAgICBpZiAoIUZpbGVTeXN0ZW06 OmZpbGVJc0RpcmVjdG9yeShkaXJlY3RvcnksIEZpbGVTeXN0ZW06OlNob3VsZEZvbGxvd1N5bWJv bGljTGlua3M6Ok5vKSkgewotICAgICAgICBjcmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0 aEZvcm1hdDpAIkNhY2hlIGRpcmVjdG9yeSBgJXNgIGlzIG5vdCBhIGRpcmVjdG9yeSBvciBkb2Vz IG5vdCBleGlzdCIsIGRpcmVjdG9yeS51dGY4KCkuZGF0YSgpXSwgZXJyb3IpOworICAgICAgICBj cmVhdGVFcnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIGRpcmVjdG9yeSBg JUBgIGlzIG5vdCBhIGRpcmVjdG9yeSBvciBkb2VzIG5vdCBleGlzdCIsIHN0YXRpY19jYXN0PE5T U3RyaW5nICo+KGRpcmVjdG9yeSldLCBlcnJvcik7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAg ICB9CiAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogICAgIGlmIChyb290bGVzc19jaGVj a19kYXRhdmF1bHRfZmxhZyhGaWxlU3lzdGVtOjpmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24oZGly ZWN0b3J5KS5kYXRhKCksIG51bGxwdHIpKSB7Ci0gICAgICAgIGNyZWF0ZUVycm9yKFtOU1N0cmlu ZyBzdHJpbmdXaXRoRm9ybWF0OkAiQ2FjaGUgZGlyZWN0b3J5IGAlc2AgaXMgbm90IGEgZGF0YSB2 YXVsdCIsIGRpcmVjdG9yeS51dGY4KCkuZGF0YSgpXSwgZXJyb3IpOworICAgICAgICBjcmVhdGVF cnJvcihbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpAIkNhY2hlIGRpcmVjdG9yeSBgJUBgIGlz IG5vdCBhIGRhdGEgdmF1bHQiLCBzdGF0aWNfY2FzdDxOU1N0cmluZyAqPihkaXJlY3RvcnkpXSwg ZXJyb3IpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogI2VuZGlmCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNj b25maWcgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFi bGUueGNjb25maWcKaW5kZXggMjYzOTQyZDIyNTMxNTRhMDg5ZjJjOGViNzdkMjE2MzAwMmI3ZDIx Yy4uYjhhOWIyOGYxMTA2N2U1NmY1ZTAyMzhhYTk0OTk4YWI2NGYyNTFiMyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxlLnhjY29u ZmlnCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0 YWJsZS54Y2NvbmZpZwpAQCAtNDMsOCArNDMsOCBAQCBDT0RFX1NJR05fSURFTlRJVFlfID0gJChD T0RFX1NJR05fSURFTlRJVFlfTk8pOwogQ09ERV9TSUdOX0lERU5USVRZX05PID0gLTsKIENPREVf U0lHTl9JREVOVElUWV9ZRVMgPSAkKFdLX0VOR0lORUVSSU5HX0NPREVfU0lHTl9JREVOVElUWSk7 CiAKLUNPREVfU0lHTl9FTlRJVExFTUVOVFNbc2RrPW1hY29zeCpdID0gJChDT0RFX1NJR05fRU5U SVRMRU1FTlRTX21hY29zeF8kKFRBUkdFVF9OQU1FKSk7Ci1DT0RFX1NJR05fRU5USVRMRU1FTlRT X21hY29zeF90ZXN0YXBpID0gdGVzdGFwaS5lbnRpdGxlbWVudHM7CitDT0RFX1NJR05fRU5USVRM RU1FTlRTW3Nkaz1tYWNvc3gqXSA9ICQoQ09ERV9TSUdOX0VOVElUTEVNRU5UU19tYWNvc3hfJChU QVJHRVRfTkFNRSlfJChVU0VfSU5URVJOQUxfU0RLKSk7CitDT0RFX1NJR05fRU5USVRMRU1FTlRT X21hY29zeF90ZXN0YXBpX1lFUyA9IHRlc3RhcGkuZW50aXRsZW1lbnRzOwogCiBDT0RFX1NJR05f RU5USVRMRU1FTlRTW3Nkaz1pcGhvbmUqXSA9ICQoQ09ERV9TSUdOX0VOVElUTEVNRU5UU19pb3Nf JChUQVJHRVRfTkFNRSkpOwogQ09ERV9TSUdOX0VOVElUTEVNRU5UU19pb3NfbWluaWRvbSA9IGVu dGl0bGVtZW50cy5wbGlzdDsK