198236 2019-05-24 15:30:20 -0700 Update sandbox rules for more News use cases 2019-05-28 10:34:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham ap bfulgham pvollan thorton oldest_to_newest 1539089 0 bfulgham 2019-05-24 15:30:20 -0700 Update the WebContent and Network process sandboxes so that News has the same set of allowed service access as regular WebKit views. 1539090 1 bfulgham 2019-05-24 15:30:53 -0700 <rdar://problem/50054027> 1539091 2 370597 bfulgham 2019-05-24 15:33:27 -0700 Created attachment 370597 Patch 1539118 3 370597 ap 2019-05-24 16:58:38 -0700 Comment on attachment 370597 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370597&action=review > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC) Please remove most of these #ifs. 10.13 is the minimum. 1539635 4 bfulgham 2019-05-28 10:32:54 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 370597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370597&action=review > > > Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:46 > > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300 || PLATFORM(IOSMAC) > > Please remove most of these #ifs. 10.13 is the minimum. I don't think that's true until we ship in the fall? 10.14 is current shipping, and we support current and two back. 1539637 5 bfulgham 2019-05-28 10:34:05 -0700 Committed r245817: <https://trac.webkit.org/changeset/245817> 370597 2019-05-24 15:33:27 -0700 2019-05-24 16:58:38 -0700 Patch bug-198236-20190524153327.patch text/plain 4247 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI2NDc2NDY3NjllNTM2N2Mw YjQxMGU5NTA5ZjQ0ODViYjI3MzFlYWMuLmRkM2U2ODhkYTc1YjNhZDBiYjdjYzlhMjVlZjBhM2Nm ZTlhNjc5OTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDUtMjQgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIHNhbmRib3ggcnVs ZXMgZm9yIG1vcmUgTmV3cyB1c2UgY2FzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5ODIzNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTAwNTQw Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBk YXRlIHRoZSBXZWJDb250ZW50IGFuZCBOZXR3b3JrIHByb2Nlc3Mgc2FuZGJveGVzIHNvIHRoYXQg TmV3cyBoYXMgdGhlIHNhbWUgc2V0IG9mIGFsbG93ZWQKKyAgICAgICAgc2VydmljZSBhY2Nlc3Mg YXMgcmVndWxhciBXZWJLaXQgdmlld3MuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9tYWMv Y29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbjoKKyAgICAgICAgKiBXZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDE5LTA1LTI0ICBEYXZpZCBRdWVz YWRhICA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggdW5kZXIgV2Vi Q29yZTo6VGltZXJCYXNlOjp+VGltZXJCYXNlIGFmdGVyIGEgZG93bmxvYWQgaXMgY2FuY2VsZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5X ZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L21hYy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQcm9jZXNzLnNiLmluCmluZGV4IDA2YTEzZDRh M2YyYjU4YTU1ZjVmMjcyZWZiNGQ4ZjM0ZDg4NmRjNTAuLjRhODgzZDQzY2QwNzQxYmRmYjA1OWM1 NDYwMmFjMmE4ZTk5NmFjZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4KKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vz cy5zYi5pbgpAQCAtMSw0ICsxLDQgQEAKLTsgQ29weXJpZ2h0IChDKSAyMDEzLTIwMTcgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorOyBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxOSBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiA7CiA7IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogOyBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK QEAgLTQzLDcgKzQzLDcgQEAKIAogKGRlbnkgaW9raXQtZ2V0LXByb3BlcnRpZXMpCiAKLSNpZiBf X01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMAorI2lmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAwIHx8IFBMQVRGT1JNKElPU01BQykKIChkZW55 IG1hY2gtbG9va3VwICh4cGMtc2VydmljZS1uYW1lLXByZWZpeCAiIikpCiAjZW5kaWYKIApAQCAt NTcsNyArNTcsNyBAQAogKGRlZmluZSAoaG9tZS1saXRlcmFsIGhvbWUtcmVsYXRpdmUtbGl0ZXJh bCkKICAgICAobGl0ZXJhbCAoc3RyaW5nLWFwcGVuZCAocGFyYW0gIkhPTUVfRElSIikgaG9tZS1y ZWxhdGl2ZS1saXRlcmFsKSkpCiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEwMTMwMAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAw IHx8IFBMQVRGT1JNKElPU01BQykKIDs7IENGTmV0d29yawogKGFsbG93IGZpbGUtcmVhZC1kYXRh IChwYXRoICIvcHJpdmF0ZS92YXIvZGIvbnN1cmxzdG9yYWdlZC9kYWZzYURhdGEuYmluIikpCiAj ZW5kaWYKQEAgLTE1Miw3ICsxNTIsNyBAQAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkZp bGVDb29yZGluYXRpb24iKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLlBvd2VyTWFuYWdl bWVudC5jb250cm9sIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5TeXN0ZW1Db25maWd1 cmF0aW9uLmNvbmZpZ2QiKQotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0g MTAxMzAwCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAgfHwg UExBVEZPUk0oSU9TTUFDKQogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmFuYWx5dGljc2Qi KQogI2VuZGlmCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY29va2llZCIpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4g Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KaW5k ZXggMDdjYWQ2NTA0NjY0NjNiNDdlN2Q2MjA4ZTgwYTg5OWE4NWM5NTNmMi4uNTAwMTZjN2VkZjMx ODM2ZDNlNmMyNmM2ZmEwYzI3NDczZjJjMTM4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgpAQCAtMSw0ICsxLDQgQEAKLTsg Q29weXJpZ2h0IChDKSAyMDEwLTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor OyBDb3B5cmlnaHQgKEMpIDIwMTAtMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiA7CiA7IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAogOyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTExNCw3ICsxMTQsNyBAQAogICAgIDs7 IENWTVMKICAgICAoYWxsb3cgbWFjaC1sb29rdXAKICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuY3Ztc1NlcnYiKSkKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwMTQwMAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNDAwIHx8 IFBMQVRGT1JNKElPU01BQykKICAgICAoYWxsb3cgZmlsZS1yZWFkKgogICAgICAgICAocHJlZml4 ICIvcHJpdmF0ZS92YXIvZGIvQ1ZNUy9jdm1zQ29kZVNpZ25PYmoiKSkKICNlbmRpZgpAQCAtNjM2 LDcgKzYzNiw3IEBACiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUudGNjZCIpCiAgICAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUudGNjZC5zeXN0ZW0iKQogICAgICAgIChnbG9iYWwt bmFtZSAiY29tLmFwcGxlLnRydXN0ZC5hZ2VudCIpCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMDE0MDAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDEwMTQwMCB8fCBQTEFURk9STShJT1NNQUMpCiAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuQ0FSZW5kZXJTZXJ2ZXIiKSA7IE5lZWRlZCBmb3IgW0NBQ29udGV4dCByZW1vdGVDb250 ZXh0V2l0aE9wdGlvbnNdCiAjZWxzZQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLndp bmRvd3NlcnZlci5hY3RpdmUiKQpAQCAtNjQ4LDcgKzY0OCw3IEBACiAoYWxsb3cgbWFjaC1sb29r dXAgKHhwYy1zZXJ2aWNlLW5hbWUgImNvbS5hcHBsZS5NVExDb21waWxlclNlcnZpY2UiKSkKICNl bmRpZgogCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKKyNp ZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQwMCB8fCBQTEFURk9STShJ T1NNQUMpCiAoZGVueSBtYWNoLWxvb2t1cCAod2l0aCBuby1sb2cpCiAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuVmlld0JyaWRnZUF1eGlsaWFyeSIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUud2luZG93c2VydmVyLmFjdGl2ZSIpKQo=