198231 2019-05-24 14:00:53 -0700 Remove unused member in WebsiteDataRecord 2019-05-24 15:48:34 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue webkit-bug-importer wilander oldest_to_newest 1539054 0 pvollan 2019-05-24 14:00:53 -0700 The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins with credentials are now stored in the 'origins' member. 1539056 1 370588 pvollan 2019-05-24 14:03:22 -0700 Created attachment 370588 Patch 1539074 2 webkit-bug-importer 2019-05-24 14:49:42 -0700 <rdar://problem/51122257> 1539076 3 370588 bfulgham 2019-05-24 15:08:57 -0700 Comment on attachment 370588 Patch I love deleting code. 1539081 4 pvollan 2019-05-24 15:21:44 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 370588 [details] > Patch > > I love deleting code. Yes, that is nice :) Thanks for reviewing! 1539097 5 370588 commit-queue 2019-05-24 15:48:32 -0700 Comment on attachment 370588 Patch Clearing flags on attachment: 370588 Committed r245757: <https://trac.webkit.org/changeset/245757> 1539098 6 commit-queue 2019-05-24 15:48:34 -0700 All reviewed patches have been landed. Closing bug. 370588 2019-05-24 14:03:22 -0700 2019-05-24 15:48:32 -0700 Patch bug-198231-20190524140321.patch text/plain 3482 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDU3NTEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTI0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIG1lbWJl ciBpbiBXZWJzaXRlRGF0YVJlY29yZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk4MjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIGRhdGEgbWVtYmVyICdvcmlnaW5zV2l0aENyZWRlbnRpYWxzJyBp biBXZWJzaXRlRGF0YVJlY29yZCBpcyBubyBsb25nZXIgbmVlZGVkIHNpbmNlIG9yaWdpbnMKKyAg ICAgICAgd2l0aCBjcmVkZW50aWFscyBhcmUgbm93IHN0b3JlZCBpbiB0aGUgJ29yaWdpbnMnIG1l bWJlci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVJlY29y ZC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhUmVjb3JkOjphZGRPcmlnaW5XaXRo Q3JlZGVudGlhbCk6IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dl YnNpdGVEYXRhUmVjb3JkLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNp dGVEYXRhU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpmZXRj aERhdGFBbmRBcHBseSk6CisKIDIwMTktMDUtMjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBtZXNzYWdlc191bml0dGVzdC5weSBhZnRlciByMjQ1 NzE1CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0 YVJlY29yZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0 ZURhdGEvV2Vic2l0ZURhdGFSZWNvcmQuY3BwCShyZXZpc2lvbiAyNDU3NTEpCisrKyBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVJlY29yZC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE1MywxMCArMTUzLDQgQEAgU3RyaW5nIFdlYnNpdGVEYXRhUmVjb3JkOjp0 b3BQcml2YXRlbHlDbwogICAgIHJldHVybiBlbXB0eVN0cmluZygpOwogfQogCi12b2lkIFdlYnNp dGVEYXRhUmVjb3JkOjphZGRPcmlnaW5XaXRoQ3JlZGVudGlhbChjb25zdCBTdHJpbmcmIG9yaWdp bikKLXsKLSAgICB0eXBlcy5hZGQoV2Vic2l0ZURhdGFUeXBlOjpDcmVkZW50aWFscyk7Ci0gICAg b3JpZ2luc1dpdGhDcmVkZW50aWFscy5hZGQob3JpZ2luKTsKLX0KLQogfQpJbmRleDogU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFSZWNvcmQuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVJl Y29yZC5oCShyZXZpc2lvbiAyNDU3NTEpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJz aXRlRGF0YS9XZWJzaXRlRGF0YVJlY29yZC5oCSh3b3JraW5nIGNvcHkpCkBAIC01Myw3ICs1Myw2 IEBAIHN0cnVjdCBXZWJzaXRlRGF0YVJlY29yZCB7CiAjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJ Tl9BUEkpCiAgICAgdm9pZCBhZGRQbHVnaW5EYXRhSG9zdE5hbWUoY29uc3QgU3RyaW5nJiBob3N0 TmFtZSk7CiAjZW5kaWYKLSAgICB2b2lkIGFkZE9yaWdpbldpdGhDcmVkZW50aWFsKGNvbnN0IFN0 cmluZyYpOwogICAgIHZvaWQgYWRkSFNUU0NhY2hlSG9zdG5hbWUoY29uc3QgU3RyaW5nJiBob3N0 TmFtZSk7CiAKICAgICBTdHJpbmcgZGlzcGxheU5hbWU7CkBAIC03MCw3ICs2OSw2IEBAIHN0cnVj dCBXZWJzaXRlRGF0YVJlY29yZCB7CiAjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAg ICAgSGFzaFNldDxTdHJpbmc+IHBsdWdpbkRhdGFIb3N0TmFtZXM7CiAjZW5kaWYKLSAgICBIYXNo U2V0PFN0cmluZz4gb3JpZ2luc1dpdGhDcmVkZW50aWFsczsKICAgICBIYXNoU2V0PFN0cmluZz4g SFNUU0NhY2hlSG9zdE5hbWVzOwogCiAgICAgYm9vbCBtYXRjaGVzKGNvbnN0IFdlYkNvcmU6OlJl Z2lzdHJhYmxlRG9tYWluJikgY29uc3Q7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAkocmV2aXNpb24g MjQ1NzUxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURh dGFTdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxOSwxNyArMzE5LDYgQEAgdm9pZCBXZWJz aXRlRGF0YVN0b3JlOjpmZXRjaERhdGFBbmRBcHBseQogICAgICAgICAgICAgfQogI2VuZGlmCiAK LSAgICAgICAgICAgIGZvciAoYXV0byYgb3JpZ2luIDogd2Vic2l0ZURhdGEub3JpZ2luc1dpdGhD cmVkZW50aWFscykgewotICAgICAgICAgICAgICAgIGF1dG8gZGlzcGxheU5hbWUgPSBXZWJzaXRl RGF0YVJlY29yZDo6ZGlzcGxheU5hbWVGb3JPcmlnaW4oV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW5E YXRhOjpmcm9tVVJMKFVSTChVUkwoKSwgb3JpZ2luKSkpOwotICAgICAgICAgICAgICAgIEFTU0VS VCghZGlzcGxheU5hbWUuaXNFbXB0eSgpKTsKLQotICAgICAgICAgICAgICAgIGF1dG8mIHJlY29y ZCA9IG1fd2Vic2l0ZURhdGFSZWNvcmRzLmFkZChkaXNwbGF5TmFtZSwgV2Vic2l0ZURhdGFSZWNv cmQgeyB9KS5pdGVyYXRvci0+dmFsdWU7Ci0gICAgICAgICAgICAgICAgaWYgKCFyZWNvcmQuZGlz cGxheU5hbWUpCi0gICAgICAgICAgICAgICAgICAgIHJlY29yZC5kaXNwbGF5TmFtZSA9IFdURk1v dmUoZGlzcGxheU5hbWUpOwotCi0gICAgICAgICAgICAgICAgcmVjb3JkLmFkZE9yaWdpbldpdGhD cmVkZW50aWFsKG9yaWdpbik7Ci0gICAgICAgICAgICB9Ci0KICAgICAgICAgICAgIGZvciAoYXV0 byYgaG9zdE5hbWUgOiB3ZWJzaXRlRGF0YS5ob3N0TmFtZXNXaXRoSFNUU0NhY2hlKSB7CiAgICAg ICAgICAgICAgICAgYXV0byBkaXNwbGF5TmFtZSA9IFdlYnNpdGVEYXRhUmVjb3JkOjpkaXNwbGF5 TmFtZUZvckhvc3ROYW1lKGhvc3ROYW1lKTsKICAgICAgICAgICAgICAgICBpZiAoIWRpc3BsYXlO YW1lKQo=