198229 2019-05-24 13:39:37 -0700 JITOperations getByVal should mark negative array indices as out-of-bounds 2019-05-25 20:47:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer ysuzuki oldest_to_newest 1539050 0 tzagallo 2019-05-24 13:39:37 -0700 ... 1539053 1 370586 tzagallo 2019-05-24 13:59:44 -0700 Created attachment 370586 Patch 1539092 2 370586 saam 2019-05-24 15:35:51 -0700 Comment on attachment 370586 Patch Nice. r=me 1539093 3 370586 saam 2019-05-24 15:36:22 -0700 Comment on attachment 370586 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370586&action=review > Source/JavaScriptCore/ChangeLog:10 > + but baseline doesn't mark it as out-of-bounds, since it only considers positive indices. This > + leads to discarding DFG code, recompiling it and exiting at the same bytecode. Can you quote where in JS2 you found this w/ the expected speedup? 1539177 4 370630 tzagallo 2019-05-25 00:55:56 -0700 Created attachment 370630 Patch for landing 1539178 5 tzagallo 2019-05-25 01:01:05 -0700 I think I might have messed up the measurements, let me double-check it before landing. 1539186 6 370630 commit-queue 2019-05-25 02:25:31 -0700 Comment on attachment 370630 Patch for landing Clearing flags on attachment: 370630 Committed r245769: <https://trac.webkit.org/changeset/245769> 1539187 7 commit-queue 2019-05-25 02:25:33 -0700 All reviewed patches have been landed. Closing bug. 1539188 8 webkit-bug-importer 2019-05-25 02:26:18 -0700 <rdar://problem/51134153> 1539199 9 saam 2019-05-25 07:50:47 -0700 (In reply to Tadeu Zagallo from comment #5) > I think I might have messed up the measurements, let me double-check it > before landing. I was interested in how much faster the individual test gets. IIRC, on IRC, you said something like 5%-10%. I wouldn’t expect 5% on an individual test to show up as a measurable overall progression. When I make changes like this, I like to quote the impact on both the individual JS2 test and on the microbenchmark 1539208 10 tzagallo 2019-05-25 09:28:06 -0700 (In reply to Saam Barati from comment #9) > (In reply to Tadeu Zagallo from comment #5) > > I think I might have messed up the measurements, let me double-check it > > before landing. > > I was interested in how much faster the individual test gets. IIRC, on IRC, > you said something like 5%-10%. I wouldn’t expect 5% on an individual test > to show up as a measurable overall progression. When I make changes like > this, I like to quote the impact on both the individual JS2 test and on the > microbenchmark Oops, my bad, will keep that in mind going forward. FWIW, it looks like a ~10% progression in prepack-wtb (which I'm a bit skeptical of, since the function wasn't that hot) and the microbenchmark is ~4% faster, but is within the noise (maybe it wasn't a great microbenchmark after all...) 1539245 11 ysuzuki 2019-05-25 20:47:49 -0700 Nice! Seems that on iOS devices it gets 1-3% improvement in JetStream2/uglify-js-wtb 370586 2019-05-24 13:59:44 -0700 2019-05-25 00:55:52 -0700 Patch bug-198229-20190524225943.patch text/plain 4212 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OWQzNGI4YmFmZDE0YzFhNjZhYWI2YzY2ZjhkNjAzZmUxN2MxMjhkLi4yN2Y2MmIzYjgwZTIyYjA2 Zjk0MTFhZGEyMDM0NzAwZDIwMDYyNmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNS0yNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBKSVRPcGVyYXRpb25zIGdldEJ5VmFsIHNob3VsZCBtYXJrIG5lZ2F0aXZl IGFycmF5IGluZGljZXMgYXMgb3V0LW9mLWJvdW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgZ2V0X2J5X3ZhbCB3aXRoIGFuIGFycmF5IG9yIHN0cmlu ZyBhcyBiYXNlIHZhbHVlIGFuZCBhIG5lZ2F0aXZlIGluZGV4IGNhdXNlcyBERkcgdG8gT1NSIGV4 aXQsCisgICAgICAgIGJ1dCBiYXNlbGluZSBkb2Vzbid0IG1hcmsgaXQgYXMgb3V0LW9mLWJvdW5k cywgc2luY2UgaXQgb25seSBjb25zaWRlcnMgcG9zaXRpdmUgaW5kaWNlcy4gVGhpcworICAgICAg ICBsZWFkcyB0byBkaXNjYXJkaW5nIERGRyBjb2RlLCByZWNvbXBpbGluZyBpdCBhbmQgZXhpdGlu ZyBhdCB0aGUgc2FtZSBieXRlY29kZS4KKworICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNw cDoKKyAgICAgICAgKEpTQzo6Z2V0QnlWYWwpOgorCiAyMDE5LTA1LTIzICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBPdmVybGF5OiBy dWxlcnMvZ3VpZGVzIHNob3VsZCBiZSBzaG93biB3aGVuZXZlciBlbGVtZW50IHNlbGVjdGlvbiBp cyBlbmFibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJh dGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcApp bmRleCAxMmI3OGFhZGY0NTg5ZGQ0ODNjYzg3OTJkMmQ2Mzg2MzUxOTkwZWY0Li5iNWM1NDViOGMw Y2JmOTViMjVlMWM1YjY3NmU2MjE0YTU3NDQxMGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTE4NTAsMTMgKzE4NTAsMTMgQEAgc3RhdGljIEpT VmFsdWUgZ2V0QnlWYWwoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIGJhc2VWYWx1ZSwgSlNWYWx1 ZSBzdWJzY3JpcHQsIEIKICAgICAgICAgfQogICAgIH0KIAotICAgIGlmIChzdWJzY3JpcHQuaXNV SW50MzIoKSkgeworICAgIGlmIChzdWJzY3JpcHQuaXNJbnQzMigpKSB7CiAgICAgICAgIEFTU0VS VChleGVjLT5ieXRlY29kZU9mZnNldCgpKTsKICAgICAgICAgYnlWYWxJbmZvLT50b29rU2xvd1Bh dGggPSB0cnVlOwogCi0gICAgICAgIHVpbnQzMl90IGkgPSBzdWJzY3JpcHQuYXNVSW50MzIoKTsK KyAgICAgICAgaW50MzJfdCBpID0gc3Vic2NyaXB0LmFzSW50MzIoKTsKICAgICAgICAgaWYgKGlz SlNTdHJpbmcoYmFzZVZhbHVlKSkgewotICAgICAgICAgICAgaWYgKGFzU3RyaW5nKGJhc2VWYWx1 ZSktPmNhbkdldEluZGV4KGkpKSB7CisgICAgICAgICAgICBpZiAoaSA+PSAwICYmIGFzU3RyaW5n KGJhc2VWYWx1ZSktPmNhbkdldEluZGV4KGkpKSB7CiAgICAgICAgICAgICAgICAgY3RpUGF0Y2hD YWxsQnlSZXR1cm5BZGRyZXNzKHJldHVybkFkZHJlc3MsIG9wZXJhdGlvbkdldEJ5VmFsU3RyaW5n KTsKICAgICAgICAgICAgICAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUsIGFzU3RyaW5nKGJh c2VWYWx1ZSktPmdldEluZGV4KGV4ZWMsIGkpKTsKICAgICAgICAgICAgIH0KQEAgLTE4NjgsNyAr MTg2OCw3IEBAIHN0YXRpYyBKU1ZhbHVlIGdldEJ5VmFsKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1 ZSBiYXNlVmFsdWUsIEpTVmFsdWUgc3Vic2NyaXB0LCBCCiAKICAgICAgICAgICAgIGJvb2wgc2tp cE1hcmtpbmdPdXRPZkJvdW5kcyA9IGZhbHNlOwogCi0gICAgICAgICAgICBpZiAob2JqZWN0LT5p bmRleGluZ1R5cGUoKSA9PSBBcnJheVdpdGhDb250aWd1b3VzICYmIGkgPCBvYmplY3QtPmJ1dHRl cmZseSgpLT5wdWJsaWNMZW5ndGgoKSkgeworICAgICAgICAgICAgaWYgKG9iamVjdC0+aW5kZXhp bmdUeXBlKCkgPT0gQXJyYXlXaXRoQ29udGlndW91cyAmJiBpID49IDAgJiYgc3RhdGljX2Nhc3Q8 dWludDMyX3Q+KGkpIDwgb2JqZWN0LT5idXR0ZXJmbHkoKS0+cHVibGljTGVuZ3RoKCkpIHsKICAg ICAgICAgICAgICAgICAvLyBGSVhNRTogZXhwYW5kIHRoaXMgdG8gQXJyYXlTdG9yYWdlLCBJbnQz MiwgYW5kIG1heWJlIERvdWJsZToKICAgICAgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgyOTQwCiAgICAgICAgICAgICAgICAgYXV0byogZ2xv YmFsT2JqZWN0ID0gb2JqZWN0LT5nbG9iYWxPYmplY3Qodm0pOwpAQCAtMTg4Myw3ICsxODgzLDgg QEAgc3RhdGljIEpTVmFsdWUgZ2V0QnlWYWwoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIGJhc2VW YWx1ZSwgSlNWYWx1ZSBzdWJzY3JpcHQsIEIKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0g ICAgICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29wZSwgYmFzZVZhbHVlLmdldChleGVjLCBpKSk7 CisgICAgICAgIGlmIChpID49IDApCisgICAgICAgICAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2Nv cGUsIGJhc2VWYWx1ZS5nZXQoZXhlYywgc3RhdGljX2Nhc3Q8dWludDMyX3Q+KGkpKSk7CiAgICAg fQogCiAgICAgYmFzZVZhbHVlLnJlcXVpcmVPYmplY3RDb2VyY2libGUoZXhlYyk7CmRpZmYgLS1n aXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDY4ZGUzNmI5 MzYxMjJmNzgxYmFjMDAzZGE4NzdhYzgyMDkwNDFkZmEuLjBlZjA2YjA4OTU4Yjg0N2Y5YTRhZWY4 ZjhiOTkyOTcwYmY3OWY4NmEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pT VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDUtMjQgIFRhZGV1IFphZ2Fs bG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CisKKyAgICAgICAgSklUT3BlcmF0aW9ucyBnZXRCeVZh bCBzaG91bGQgbWFyayBuZWdhdGl2ZSBhcnJheSBpbmRpY2VzIGFzIG91dC1vZi1ib3VuZHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODIyOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWljcm9iZW5j aG1hcmtzL2dldC1ieS12YWwtbmVnYXRpdmUtYXJyYXktaW5kZXguanM6IEFkZGVkLgorICAgICAg ICAoZm9vKToKKwogMjAxOS0wNS0yMyAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KIAogICAgICAgICBERkc6Ok9TUkVudHJ5IHNob3VsZCBub3QgcGVyZm9ybSBhcml0eSBjaGVj awpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWJ5LXZhbC1uZWdhdGl2 ZS1hcnJheS1pbmRleC5qcyBiL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2dldC1ieS12YWwtbmVn YXRpdmUtYXJyYXktaW5kZXguanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWE4NjkxNWY1OWM0N2U4NzkzYTNkZGFj ODdhMWFlNmVhMTE4MTlmZQotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvbWljcm9iZW5jaG1h cmtzL2dldC1ieS12YWwtbmVnYXRpdmUtYXJyYXktaW5kZXguanMKQEAgLTAsMCArMSwxMSBAQAor ZnVuY3Rpb24gZm9vKGFyciwgaW5kZXgpIHsKKyAgICByZXR1cm4gYXJyW2luZGV4XTsKK30KK25v SW5saW5lKGZvbyk7CisKK2NvbnN0IGFyciA9IG5ldyBBcnJheSgxMDAwKS5maWxsKHt9KTsKK2Zv ciAobGV0IGkgPSAwOyBpIDwgMWU3OyBpKyspIHsKKyAgICBmb28oYXJyLCBpICUgYXJyLmxlbmd0 aCk7CisgICAgaWYgKCEoaSAlIDFlMykpCisgICAgICAgIGZvbyhhcnIsIC0xKTsKK30K 370630 2019-05-25 00:55:56 -0700 2019-05-25 02:25:31 -0700 Patch for landing bug-198229-20190525095554.patch text/plain 4535 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OWQzNGI4YmFmZDE0YzFhNjZhYWI2YzY2ZjhkNjAzZmUxN2MxMjhkLi4yNGQ0ZGI2MjZmMzIyOTQx MjJhZTJhNTViZjdjMTZmZTExY2Y1NmRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0wNS0yNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBKSVRPcGVyYXRpb25zIGdldEJ5VmFsIHNob3VsZCBtYXJrIG5lZ2F0aXZl IGFycmF5IGluZGljZXMgYXMgb3V0LW9mLWJvdW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2Fh bSBCYXJhdGkuCisKKyAgICAgICAgZ2V0X2J5X3ZhbCB3aXRoIGFuIGFycmF5IG9yIHN0cmluZyBh cyBiYXNlIHZhbHVlIGFuZCBhIG5lZ2F0aXZlIGluZGV4IGNhdXNlcyBERkcgdG8gT1NSIGV4aXQs CisgICAgICAgIGJ1dCBiYXNlbGluZSBkb2Vzbid0IG1hcmsgaXQgYXMgb3V0LW9mLWJvdW5kcywg c2luY2UgaXQgb25seSBjb25zaWRlcnMgcG9zaXRpdmUgaW5kaWNlcy4gVGhpcworICAgICAgICBs ZWFkcyB0byBkaXNjYXJkaW5nIERGRyBjb2RlLCByZWNvbXBpbGluZyBpdCBhbmQgZXhpdGluZyBh dCB0aGUgc2FtZSBieXRlY29kZS4KKworICAgICAgICBUaGlzIGlzIG9ic2VydmVkIGluIHRoZSBw cmVwYWNrLXd0YiBzdWJ0ZXN0IG9mIEpldFN0cmVhbTIuIEluIHBvcENvbnRleHQjQ2RPaEZKLCB0 aGUgbGFzdCBpdGVtCisgICAgICAgIG9mIHRoZSBhcnJheSBwb3BwZWQgYW5kIHRoZSBuZXcgbGFz dCB2YWx1ZSBpcyBhY2Nlc3NlZCB1c2luZyBgYXJyYXlbYXJyYXkubGVuZ3RoIC0gMV1gLCB3aGlj aAorICAgICAgICBpcyAtMSB3aGVuIHRoZSBhcnJheSBpcyBlbXB0eS4gSXQgc2hvd3MgYSB+MC41 JSBwcm9ncmVzc2lvbiBpbiBKZXRTdHJlYW0yLCBidXQgaXQncyB3aXRoaW4gdGhlCisgICAgICAg IG5vaXNlLgorCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuY3BwOgorICAgICAgICAoSlND OjpnZXRCeVZhbCk6CisKIDIwMTktMDUtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE92ZXJsYXk6IHJ1bGVycy9ndWlkZXMgc2hv dWxkIGJlIHNob3duIHdoZW5ldmVyIGVsZW1lbnQgc2VsZWN0aW9uIGlzIGVuYWJsZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCmluZGV4IDEyYjc4YWFkZjQ1 ODlkZDQ4M2NjODc5MmQyZDYzODYzNTE5OTBlZjQuLmI1YzU0NWI4YzBjYmY5NWIyNWUxYzViNjc2 ZTYyMTRhNTc0NDEwYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3BlcmF0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRp b25zLmNwcApAQCAtMTg1MCwxMyArMTg1MCwxMyBAQCBzdGF0aWMgSlNWYWx1ZSBnZXRCeVZhbChF eGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgYmFzZVZhbHVlLCBKU1ZhbHVlIHN1YnNjcmlwdCwgQgog ICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKHN1YnNjcmlwdC5pc1VJbnQzMigpKSB7CisgICAg aWYgKHN1YnNjcmlwdC5pc0ludDMyKCkpIHsKICAgICAgICAgQVNTRVJUKGV4ZWMtPmJ5dGVjb2Rl T2Zmc2V0KCkpOwogICAgICAgICBieVZhbEluZm8tPnRvb2tTbG93UGF0aCA9IHRydWU7CiAKLSAg ICAgICAgdWludDMyX3QgaSA9IHN1YnNjcmlwdC5hc1VJbnQzMigpOworICAgICAgICBpbnQzMl90 IGkgPSBzdWJzY3JpcHQuYXNJbnQzMigpOwogICAgICAgICBpZiAoaXNKU1N0cmluZyhiYXNlVmFs dWUpKSB7Ci0gICAgICAgICAgICBpZiAoYXNTdHJpbmcoYmFzZVZhbHVlKS0+Y2FuR2V0SW5kZXgo aSkpIHsKKyAgICAgICAgICAgIGlmIChpID49IDAgJiYgYXNTdHJpbmcoYmFzZVZhbHVlKS0+Y2Fu R2V0SW5kZXgoaSkpIHsKICAgICAgICAgICAgICAgICBjdGlQYXRjaENhbGxCeVJldHVybkFkZHJl c3MocmV0dXJuQWRkcmVzcywgb3BlcmF0aW9uR2V0QnlWYWxTdHJpbmcpOwogICAgICAgICAgICAg ICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29wZSwgYXNTdHJpbmcoYmFzZVZhbHVlKS0+Z2V0SW5k ZXgoZXhlYywgaSkpOwogICAgICAgICAgICAgfQpAQCAtMTg2OCw3ICsxODY4LDcgQEAgc3RhdGlj IEpTVmFsdWUgZ2V0QnlWYWwoRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIGJhc2VWYWx1ZSwgSlNW YWx1ZSBzdWJzY3JpcHQsIEIKIAogICAgICAgICAgICAgYm9vbCBza2lwTWFya2luZ091dE9mQm91 bmRzID0gZmFsc2U7CiAKLSAgICAgICAgICAgIGlmIChvYmplY3QtPmluZGV4aW5nVHlwZSgpID09 IEFycmF5V2l0aENvbnRpZ3VvdXMgJiYgaSA8IG9iamVjdC0+YnV0dGVyZmx5KCktPnB1YmxpY0xl bmd0aCgpKSB7CisgICAgICAgICAgICBpZiAob2JqZWN0LT5pbmRleGluZ1R5cGUoKSA9PSBBcnJh eVdpdGhDb250aWd1b3VzICYmIGkgPj0gMCAmJiBzdGF0aWNfY2FzdDx1aW50MzJfdD4oaSkgPCBv YmplY3QtPmJ1dHRlcmZseSgpLT5wdWJsaWNMZW5ndGgoKSkgewogICAgICAgICAgICAgICAgIC8v IEZJWE1FOiBleHBhbmQgdGhpcyB0byBBcnJheVN0b3JhZ2UsIEludDMyLCBhbmQgbWF5YmUgRG91 YmxlOgogICAgICAgICAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODI5NDAKICAgICAgICAgICAgICAgICBhdXRvKiBnbG9iYWxPYmplY3QgPSBvYmpl Y3QtPmdsb2JhbE9iamVjdCh2bSk7CkBAIC0xODgzLDcgKzE4ODMsOCBAQCBzdGF0aWMgSlNWYWx1 ZSBnZXRCeVZhbChFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgYmFzZVZhbHVlLCBKU1ZhbHVlIHN1 YnNjcmlwdCwgQgogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgUkVMRUFTRV9B TkRfUkVUVVJOKHNjb3BlLCBiYXNlVmFsdWUuZ2V0KGV4ZWMsIGkpKTsKKyAgICAgICAgaWYgKGkg Pj0gMCkKKyAgICAgICAgICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29wZSwgYmFzZVZhbHVlLmdl dChleGVjLCBzdGF0aWNfY2FzdDx1aW50MzJfdD4oaSkpKTsKICAgICB9CiAKICAgICBiYXNlVmFs dWUucmVxdWlyZU9iamVjdENvZXJjaWJsZShleGVjKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hh bmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjhkZTM2YjkzNjEyMmY3ODFiYWMwMDNk YTg3N2FjODIwOTA0MWRmYS4uYTE4MWI5ZWVjYzAxNWIxMGZlZmNjNTdkZDM0NmU0ZDE0N2Y5NDUx NiAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMyBAQAorMjAxOS0wNS0yNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFw cGxlLmNvbT4KKworICAgICAgICBKSVRPcGVyYXRpb25zIGdldEJ5VmFsIHNob3VsZCBtYXJrIG5l Z2F0aXZlIGFycmF5IGluZGljZXMgYXMgb3V0LW9mLWJvdW5kcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MjI5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgU2FhbSBCYXJhdGkuCisKKyAgICAgICAgKiBtaWNyb2JlbmNobWFya3MvZ2V0LWJ5LXZhbC1u ZWdhdGl2ZS1hcnJheS1pbmRleC5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorCiAyMDE5LTA1 LTIzICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUuY29tPgogCiAgICAgICAgIERGRzo6 T1NSRW50cnkgc2hvdWxkIG5vdCBwZXJmb3JtIGFyaXR5IGNoZWNrCmRpZmYgLS1naXQgYS9KU1Rl c3RzL21pY3JvYmVuY2htYXJrcy9nZXQtYnktdmFsLW5lZ2F0aXZlLWFycmF5LWluZGV4LmpzIGIv SlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWJ5LXZhbC1uZWdhdGl2ZS1hcnJheS1pbmRleC5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4xYTg2OTE1ZjU5YzQ3ZTg3OTNhM2RkYWM4N2ExYWU2ZWExMTgxOWZlCi0t LSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvZ2V0LWJ5LXZhbC1uZWdh dGl2ZS1hcnJheS1pbmRleC5qcwpAQCAtMCwwICsxLDExIEBACitmdW5jdGlvbiBmb28oYXJyLCBp bmRleCkgeworICAgIHJldHVybiBhcnJbaW5kZXhdOworfQorbm9JbmxpbmUoZm9vKTsKKworY29u c3QgYXJyID0gbmV3IEFycmF5KDEwMDApLmZpbGwoe30pOworZm9yIChsZXQgaSA9IDA7IGkgPCAx ZTc7IGkrKykgeworICAgIGZvbyhhcnIsIGkgJSBhcnIubGVuZ3RoKTsKKyAgICBpZiAoIShpICUg MWUzKSkKKyAgICAgICAgZm9vKGFyciwgLTEpOworfQo=