198225 2019-05-24 12:36:58 -0700 Refactor how showLetterpressedGlyphsWithAdvances gets the graphics context 2019-05-24 14:42:45 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue dino mmaxfield thorton webkit-bug-importer oldest_to_newest 1539032 0 timothy 2019-05-24 12:36:58 -0700 We should pass in the GraphicsContext& and not the CGContextRef for ease of use. 1539033 1 370580 timothy 2019-05-24 12:39:18 -0700 Created attachment 370580 Patch 1539034 2 webkit-bug-importer 2019-05-24 12:40:43 -0700 <rdar://problem/51116951> 1539072 3 thorton 2019-05-24 14:42:15 -0700 r245753 370580 2019-05-24 12:39:18 -0700 2019-05-24 14:42:45 -0700 Patch bug-198225-20190524123917.patch text/plain 3479 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzkwOThhZTQ4N2Q5ZTY4 N2E3ZmRjMzE4ZTE2NjA3MGIyN2ViZGQ2Ny4uMzA4Yzc4Mjc0OTU5YzNiZDBkZmI5Zjk2NDMyZGM5 ODQ2MjljNGU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA1LTI0ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBSZWZhY3RvciBob3cg c2hvd0xldHRlcnByZXNzZWRHbHlwaHNXaXRoQWR2YW5jZXMgZ2V0cyB0aGUgZ3JhcGhpY3MgY29u dGV4dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODIyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhc2NhZGVDb2NvYS5tbToKKyAgICAgICAgKFdl YkNvcmU6OnNob3dMZXR0ZXJwcmVzc2VkR2x5cGhzV2l0aEFkdmFuY2VzKToKKyAgICAgICAgKFdl YkNvcmU6OkZvbnRDYXNjYWRlOjpkcmF3R2x5cGhzKToKKwogMjAxOS0wNS0yNCAgU2FhbSBiYXJh dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIFJlYWRNb2RpZnlXcml0 ZUV4cHJlc3Npb24gYWx3YXlzIGhhcyBhIHJlc3VsdCBhbmQgbmV3IHZhbHVlIGV4cHJlc3Npb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRD YXNjYWRlQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9G b250Q2FzY2FkZUNvY29hLm1tCmluZGV4IGY1OTliNGU2YmQwY2E3NjdmNTAyZjIxYmY2OGY1MTQ2 ZTBjOWExMDMuLjNiMmYxNDFjZDRiYmY5ZmVlM2Y0YzJhMzk3YWZhY2MzODY1OTE0YWIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYXNjYWRl Q29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9u dENhc2NhZGVDb2NvYS5tbQpAQCAtOTgsNyArOTgsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgc2hv dWxkVXNlTGV0dGVycHJlc3NFZmZlY3QoY29uc3QgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0KQog I2VuZGlmCiB9CiAKLXN0YXRpYyB2b2lkIHNob3dMZXR0ZXJwcmVzc2VkR2x5cGhzV2l0aEFkdmFu Y2VzKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBjb25zdCBGb250JiBmb250LCBDR0NvbnRleHRS ZWYgY29udGV4dCwgY29uc3QgQ0dHbHlwaCogZ2x5cGhzLCBjb25zdCBDR1NpemUqIGFkdmFuY2Vz LCB1bnNpZ25lZCBjb3VudCkKK3N0YXRpYyB2b2lkIHNob3dMZXR0ZXJwcmVzc2VkR2x5cGhzV2l0 aEFkdmFuY2VzKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBjb25zdCBGb250JiBmb250LCBHcmFw aGljc0NvbnRleHQmIGNvcmVDb250ZXh0LCBjb25zdCBDR0dseXBoKiBnbHlwaHMsIGNvbnN0IENH U2l6ZSogYWR2YW5jZXMsIHVuc2lnbmVkIGNvdW50KQogewogI2lmIEVOQUJMRShMRVRURVJQUkVT UykKICAgICBpZiAoIWNvdW50KQpAQCAtMTEwLDYgKzExMCw4IEBAIHN0YXRpYyB2b2lkIHNob3dM ZXR0ZXJwcmVzc2VkR2x5cGhzV2l0aEFkdmFuY2VzKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBj b25zdCBGCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBDR0NvbnRleHRSZWYgY29udGV4 dCA9IGNvcmVDb250ZXh0LnBsYXRmb3JtQ29udGV4dCgpOworCiAgICAgQ0dDb250ZXh0U2V0VGV4 dFBvc2l0aW9uKGNvbnRleHQsIHBvaW50LngoKSwgcG9pbnQueSgpKTsKICAgICBWZWN0b3I8Q0dQ b2ludCwgMjU2PiBwb3NpdGlvbnMoY291bnQpOwogICAgIGZpbGxWZWN0b3JXaXRoSG9yaXpvbnRh bEdseXBoUG9zaXRpb25zKHBvc2l0aW9ucywgY29udGV4dCwgYWR2YW5jZXMsIGNvdW50KTsKQEAg LTEyNyw2ICsxMjksMTAgQEAgc3RhdGljIHZvaWQgc2hvd0xldHRlcnByZXNzZWRHbHlwaHNXaXRo QWR2YW5jZXMoY29uc3QgRmxvYXRQb2ludCYgcG9pbnQsIGNvbnN0IEYKICAgICAgICAgc3R5bGVD b25maWd1cmF0aW9uLnVzZVNpbXBsaWZpZWRFZmZlY3QgPSBZRVM7CiAgICAgfQogCisjaWYgVVNF KEFQUExFX0lOVEVSTkFMX1NESykgJiYgX19oYXNfaW5jbHVkZSg8V2ViS2l0QWRkaXRpb25zL0Zv bnRDYXNjYWRlQ29jb2FBZGRpdGlvbnMubW0+KQorI2luY2x1ZGUgPFdlYktpdEFkZGl0aW9ucy9G b250Q2FzY2FkZUNvY29hQWRkaXRpb25zLm1tPgorI2VuZGlmCisKICAgICBDR0NvbnRleHRTZXRG b250KGNvbnRleHQsIGFkb3B0Q0YoQ1RGb250Q29weUdyYXBoaWNzRm9udChjdEZvbnQsIG51bGxw dHIpKS5nZXQoKSk7CiAgICAgQ0dDb250ZXh0U2V0Rm9udFNpemUoY29udGV4dCwgcGxhdGZvcm1E YXRhLnNpemUoKSk7CiAKQEAgLTEzNyw3ICsxNDMsNyBAQCBzdGF0aWMgdm9pZCBzaG93TGV0dGVy cHJlc3NlZEdseXBoc1dpdGhBZHZhbmNlcyhjb25zdCBGbG9hdFBvaW50JiBwb2ludCwgY29uc3Qg RgogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0ocG9pbnQpOwogICAgIFVOVVNFRF9QQVJBTShmb250 KTsKLSAgICBVTlVTRURfUEFSQU0oY29udGV4dCk7CisgICAgVU5VU0VEX1BBUkFNKGNvcmVDb250 ZXh0KTsKICAgICBVTlVTRURfUEFSQU0oZ2x5cGhzKTsKICAgICBVTlVTRURfUEFSQU0oYWR2YW5j ZXMpOwogICAgIFVOVVNFRF9QQVJBTShjb3VudCk7CkBAIC0yOTksNyArMzA1LDcgQEAgdm9pZCBG b250Q2FzY2FkZTo6ZHJhd0dseXBocyhHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IEZv bnQmIGZvbnQsIGNvbnN0IEcKICAgICB9CiAKICAgICBpZiAodXNlTGV0dGVycHJlc3NFZmZlY3Qp Ci0gICAgICAgIHNob3dMZXR0ZXJwcmVzc2VkR2x5cGhzV2l0aEFkdmFuY2VzKHBvaW50LCBmb250 LCBjZ0NvbnRleHQsIGdseXBoQnVmZmVyLmdseXBocyhmcm9tKSwgc3RhdGljX2Nhc3Q8Y29uc3Qg Q0dTaXplKj4oZ2x5cGhCdWZmZXIuYWR2YW5jZXMoZnJvbSkpLCBudW1HbHlwaHMpOworICAgICAg ICBzaG93TGV0dGVycHJlc3NlZEdseXBoc1dpdGhBZHZhbmNlcyhwb2ludCwgZm9udCwgY29udGV4 dCwgZ2x5cGhCdWZmZXIuZ2x5cGhzKGZyb20pLCBzdGF0aWNfY2FzdDxjb25zdCBDR1NpemUqPihn bHlwaEJ1ZmZlci5hZHZhbmNlcyhmcm9tKSksIG51bUdseXBocyk7CiAgICAgZWxzZQogICAgICAg ICBzaG93R2x5cGhzV2l0aEFkdmFuY2VzKHBvaW50LCBmb250LCBjZ0NvbnRleHQsIGdseXBoQnVm ZmVyLmdseXBocyhmcm9tKSwgc3RhdGljX2Nhc3Q8Y29uc3QgQ0dTaXplKj4oZ2x5cGhCdWZmZXIu YWR2YW5jZXMoZnJvbSkpLCBudW1HbHlwaHMpOwogICAgIGlmIChzeW50aGV0aWNCb2xkT2Zmc2V0 KQo=