<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>198221</bug_id>
          
          <creation_ts>2019-05-24 11:16:08 -0700</creation_ts>
          <short_desc>Web Inspector: Overlay: don&apos;t show setting for showing rulers/guides during element selection if it&apos;s not supported</short_desc>
          <delta_ts>2019-05-24 12:02:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Devin Rousso">hi</reporter>
          <assigned_to name="Devin Rousso">hi</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>hi</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1539008</commentid>
    <comment_count>0</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2019-05-24 11:16:08 -0700</bug_when>
    <thetext>Oops.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539010</commentid>
    <comment_count>1</comment_count>
      <attachid>370578</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2019-05-24 11:17:29 -0700</bug_when>
    <thetext>Created attachment 370578
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539012</commentid>
    <comment_count>2</comment_count>
      <attachid>370578</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2019-05-24 11:19:34 -0700</bug_when>
    <thetext>Comment on attachment 370578
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539026</commentid>
    <comment_count>3</comment_count>
      <attachid>370578</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-24 12:01:54 -0700</bug_when>
    <thetext>Comment on attachment 370578
Patch

Clearing flags on attachment: 370578

Committed r245750: &lt;https://trac.webkit.org/changeset/245750&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539027</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-24 12:01:56 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>370578</attachid>
            <date>2019-05-24 11:17:29 -0700</date>
            <delta_ts>2019-05-24 12:01:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-198221-20190524111728.patch</filename>
            <type>text/plain</type>
            <size>2188</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYWE4NWIwMjIyYzY5NWE4N2ExYzQ4ZmM4YzU2
NTNkODE1OTA2YTYuLmViNWIzNWYyMzNhZjJmMmQyYzQ0MmFjZjU3YzAyNDU2MTM1ZGMyN2YgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA1LTI0ICBEZXZp
biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBP
dmVybGF5OiBkb24ndCBzaG93IHNldHRpbmcgZm9yIHNob3dpbmcgcnVsZXJzL2d1aWRlcyBkdXJp
bmcgZWxlbWVudCBzZWxlY3Rpb24gaWYgaXQncyBub3Qgc3VwcG9ydGVkCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgyMjEKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv
U2V0dGluZ3NUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLlNldHRpbmdzVGFiQ29udGVu
dFZpZXcucHJvdG90eXBlLl9jcmVhdGVHZW5lcmFsU2V0dGluZ3NWaWV3KToKKwogMjAxOS0wNS0y
MyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl
Y3RvcjogT3ZlcmxheTogcnVsZXJzL2d1aWRlcyBzaG91bGQgYmUgc2hvd24gd2hlbmV2ZXIgZWxl
bWVudCBzZWxlY3Rpb24gaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv
clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJj
ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZp
ZXcuanMKaW5kZXggM2VjOTU2MzNjMTI0MjFlODFlZGQ2ZjBkNTBjZWFhNGFmYzg3MDFhOS4uZDFi
MDYyMTM5NDkxOTMxODk2M2NmYTZiYjkyMmU5MWM3MjFlNjY5OCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmll
dy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0
aW5nc1RhYkNvbnRlbnRWaWV3LmpzCkBAIC0yMjIsOSArMjIyLDExIEBAIFdJLlNldHRpbmdzVGFi
Q29udGVudFZpZXcgPSBjbGFzcyBTZXR0aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuVGFi
Q29udGVudFZpCiAKICAgICAgICAgZ2VuZXJhbFNldHRpbmdzVmlldy5hZGRTZXBhcmF0b3IoKTsK
IAotICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNldHRpbmcoV0kuVUlTdHJpbmcoIkVs
ZW1lbnQgU2VsZWN0aW9uOiIpLCBXSS5zZXR0aW5ncy5zaG93UnVsZXJzRHVyaW5nRWxlbWVudFNl
bGVjdGlvbiwgV0kuVUlTdHJpbmcoIlNob3cgcGFnZSBydWxlcnMgYW5kIG5vZGUgYm9yZGVyIGxp
bmVzIikpOworICAgICAgICBpZiAoSW5zcGVjdG9yQmFja2VuZC5kb21haW5zLkRPTSAmJiBJbnNw
ZWN0b3JCYWNrZW5kLmRvbWFpbnMuRE9NLnNldEluc3BlY3RNb2RlRW5hYmxlZCAmJiBJbnNwZWN0
b3JCYWNrZW5kLmRvbWFpbnMuRE9NLnNldEluc3BlY3RNb2RlRW5hYmxlZC5zdXBwb3J0cygic2hv
d1J1bGVycyIpKSB7CisgICAgICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNldHRpbmco
V0kuVUlTdHJpbmcoIkVsZW1lbnQgU2VsZWN0aW9uOiIpLCBXSS5zZXR0aW5ncy5zaG93UnVsZXJz
RHVyaW5nRWxlbWVudFNlbGVjdGlvbiwgV0kuVUlTdHJpbmcoIlNob3cgcGFnZSBydWxlcnMgYW5k
IG5vZGUgYm9yZGVyIGxpbmVzIikpOwogCi0gICAgICAgIGdlbmVyYWxTZXR0aW5nc1ZpZXcuYWRk
U2VwYXJhdG9yKCk7CisgICAgICAgICAgICBnZW5lcmFsU2V0dGluZ3NWaWV3LmFkZFNlcGFyYXRv
cigpOworICAgICAgICB9CiAKICAgICAgICAgY29uc3Qgem9vbUxldmVscyA9IFswLjYsIDAuOCwg
MSwgMS4yLCAxLjQsIDEuNiwgMS44LCAyLCAyLjIsIDIuNF07CiAgICAgICAgIGNvbnN0IHpvb21W
YWx1ZXMgPSB6b29tTGV2ZWxzLm1hcCgobGV2ZWwpID0+IFtsZXZlbCwgTnVtYmVyLnBlcmNlbnRh
Z2VTdHJpbmcobGV2ZWwsIDApXSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>