198216 2019-05-23 23:05:22 -0700 Asssertion failure in dispatchSubtreeModifiedEvent due to TextFieldInputType updating UA shadow tree inside Element::removedFromAncestor 2019-05-24 14:25:11 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa bfulgham cdumez commit-queue koivisto webkit-bug-importer oldest_to_newest 1538945 0 rniwa 2019-05-23 23:05:22 -0700 We hit the assertion in Node::dispatchSubtreeModifiedEvent when a datalist element is removed right after the input element's type is changed. <rdar://problem/50021640> 1538946 1 370565 rniwa 2019-05-23 23:13:46 -0700 Created attachment 370565 Fixes the bug 1538980 2 370565 bfulgham 2019-05-24 09:03:55 -0700 Comment on attachment 370565 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=370565&action=review r=me > Source/WebCore/html/shadow/DataListButtonElement.cpp:-52 > - setPseudo(AtomicString("-webkit-list-button", AtomicString::ConstructFromLiteral)); Why do we prefer to call 'setPseudo' on the result of this constructed object, rather than during construction here? It seems like it would be easy to forget to do this work, wouldn't it? 1538985 3 370565 commit-queue 2019-05-24 09:34:04 -0700 Comment on attachment 370565 Fixes the bug Clearing flags on attachment: 370565 Committed r245746: <https://trac.webkit.org/changeset/245746> 1538986 4 commit-queue 2019-05-24 09:34:05 -0700 All reviewed patches have been landed. Closing bug. 1538987 5 webkit-bug-importer 2019-05-24 09:35:18 -0700 <rdar://problem/51109894> 1539065 6 rniwa 2019-05-24 14:25:11 -0700 (In reply to Brent Fulgham from comment #2) > Comment on attachment 370565 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370565&action=review > > r=me > > > Source/WebCore/html/shadow/DataListButtonElement.cpp:-52 > > - setPseudo(AtomicString("-webkit-list-button", AtomicString::ConstructFromLiteral)); > > Why do we prefer to call 'setPseudo' on the result of this constructed > object, rather than during construction here? It seems like it would be easy > to forget to do this work, wouldn't it? In general, it's a bad practice to add an attribute in an element constructor. A content attribute should be something the users of an element should be specifying, not the element itself. In this particular case, setting the content attribute triggers DOMSubtreeModifiedEvent and which ends up hitting the same assertion because the disabling of the assertion will only take effect after this element had been inserted into the shadow tree. 370565 2019-05-23 23:13:46 -0700 2019-05-24 09:34:04 -0700 Fixes the bug bug-198216-20190523231345.patch text/plain 6562 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTc0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE5LTA1LTIzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFzc3NlcnRpb24gZmFpbHVyZSBp biBkaXNwYXRjaFN1YnRyZWVNb2RpZmllZEV2ZW50IGR1ZSB0byBUZXh0RmllbGRJbnB1dFR5cGUg dXBkYXRpbmcgVUEgc2hhZG93IHRyZWUgaW5zaWRlIEVsZW1lbnQ6OnJlbW92ZWRGcm9tQW5jZXN0 b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODIx NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBi dWcgd2FzIGNhdXNlZCBieSBMaXN0QXR0cmlidXRlVGFyZ2V0T2JzZXJ2ZXI6OmlkVGFyZ2V0Q2hh bmdlZCgpIHVwZGF0aW5nIHRoZSBzaGFkb3cgdHJlZSBvZiBhbiBpbnB1dCBlbGVtZW50CisgICAg ICAgIHdpdGhpbiBFbGVtZW50OjpyZW1vdmVkRnJvbUFuY2VzdG9yIHZpYSBUZXh0RmllbGRJbnB1 dFR5cGU6OmNyZWF0ZURhdGFMaXN0RHJvcGRvd25JbmRpY2F0b3IoKS4gRml4ZWQgaXQgYnkKKyAg ICAgICAgc3VwcmVzc2luZyB0aGUgYXNzZXJ0aW9ucyB3aXRoIFNjcmlwdERpc2FsbG93ZWRTY29w ZTo6RXZlbnRBbGxvd2VkU2NvcGUgc2luY2UgaXQncyBhbHdheXMgc2FmZSB0byB1cGRhdGUKKyAg ICAgICAgVUEgc2hhZG93IHRyZWVzIG9mIGlucHV0IGVsZW1lbnRzIGFzIGl0J3Mgbm90IGV4cG9z ZWQgdG8gYXV0aG9yIHNjcmlwdHMuCisKKyAgICAgICAgQXZvaWRpbmcgdGhlIGNyZWF0aW9uIG9m IGRyb3Bkb3duIGluZGljYXRvciBpbiB0aGlzIHBhcnRpY3VsYXIgc2NlbmFyaW8gaXMgYSBsb3Qg bW9yZSBpbnZvbHZlZCBhbmQgaXQncyBub3QKKyAgICAgICAgcGFydGljdWxhcmx5IGNvcnJlY3Qg YmVjYXVzZSB0aGVyZSBjb3VsZCBiZSBhbm90aGVyIGRhdGFsaXN0IGVsZW1lbnQgd2hpY2ggbWF0 Y2hlcyB0aGUgSUQgc3BlY2lmaWVkIGluIGxpc3QKKyAgICAgICAgY29udGVudCBhdHRyaWJ1dGUg YWZ0ZXIgdGhlIHJlbW92YWwgb2YgdGhlIG9sZCBkYXRhbGlzdCBlbGVtZW50LgorCisgICAgICAg IFRlc3Q6IGZhc3QvZm9ybXMvZGF0YWxpc3QvZGF0YWxpc3QtcmVtb3ZhbC1hc3NlcnRpb24uaHRt bAorCisgICAgICAgICogaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjpjcmVhdGVEYXRhTGlzdERyb3Bkb3duSW5kaWNhdG9y KToKKyAgICAgICAgKFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6Y3JlYXRlQ29udGFpbmVy KToKKyAgICAgICAgKiBodG1sL3NoYWRvdy9EYXRhTGlzdEJ1dHRvbkVsZW1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RGF0YUxpc3RCdXR0b25FbGVtZW50OjpEYXRhTGlzdEJ1dHRvbkVsZW1l bnQpOgorCiAyMDE5LTA1LTIzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFdpdGggYXN5bmMgb3ZlcmZsb3cgc2Nyb2xsaW5nLCBwcm9ncmFtbWF0aWMg c2Nyb2xsIHRvIGEgbmVnYXRpdmUgb2Zmc2V0IGZhaWxzIHRvIGNsYW1wIHRoZSBzY3JvbGwgb2Zm c2V0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCShy ZXZpc2lvbiAyNDU3MjEpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlw ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUyLDYgKzUyLDcgQEAKICNpbmNsdWRlICJSZW5kZXJU ZXh0Q29udHJvbFNpbmdsZUxpbmUuaCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZS5oIgogI2luY2x1 ZGUgIlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMuaCIKKyNpbmNsdWRlICJTY3JpcHREaXNhbGxvd2Vk U2NvcGUuaCIKICNpbmNsdWRlICJTaGFkb3dSb290LmgiCiAjaW5jbHVkZSAiVGV4dENvbnRyb2xJ bm5lckVsZW1lbnRzLmgiCiAjaW5jbHVkZSAiVGV4dEV2ZW50LmgiCkBAIC00NTIsOSArNDUzLDEz IEBAIHZvaWQgVGV4dEZpZWxkSW5wdXRUeXBlOjpjcmVhdGVEYXRhTGlzdEQKICAgICBBU1NFUlQo IW1fZGF0YUxpc3REcm9wZG93bkluZGljYXRvcik7CiAgICAgaWYgKCFtX2NvbnRhaW5lcikKICAg ICAgICAgY3JlYXRlQ29udGFpbmVyKCk7CisKKyAgICBTY3JpcHREaXNhbGxvd2VkU2NvcGU6OkV2 ZW50QWxsb3dlZFNjb3BlIGFsbG93ZWRTY29wZSgqbV9jb250YWluZXIpOwogICAgIG1fZGF0YUxp c3REcm9wZG93bkluZGljYXRvciA9IERhdGFMaXN0QnV0dG9uRWxlbWVudDo6Y3JlYXRlKGVsZW1l bnQoKS0+ZG9jdW1lbnQoKSwgKnRoaXMpOwotICAgIG1fZGF0YUxpc3REcm9wZG93bkluZGljYXRv ci0+c2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eURpc3BsYXksIENTU1ZhbHVlTm9u ZSwgdHJ1ZSk7CiAgICAgbV9jb250YWluZXItPmFwcGVuZENoaWxkKCptX2RhdGFMaXN0RHJvcGRv d25JbmRpY2F0b3IpOworICAgIG1fZGF0YUxpc3REcm9wZG93bkluZGljYXRvci0+c2V0UHNldWRv KEF0b21pY1N0cmluZygiLXdlYmtpdC1saXN0LWJ1dHRvbiIsIEF0b21pY1N0cmluZzo6Q29uc3Ry dWN0RnJvbUxpdGVyYWwpKTsKKyAgICBtX2RhdGFMaXN0RHJvcGRvd25JbmRpY2F0b3ItPnNldElu bGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlEaXNwbGF5LCBDU1NWYWx1ZU5vbmUsIHRydWUp OworCiB9CiAjZW5kaWYKIApAQCAtNzczLDE0ICs3NzgsMTUgQEAgdm9pZCBUZXh0RmllbGRJbnB1 dFR5cGU6OmNyZWF0ZUNvbnRhaW5lcgogICAgIEFTU0VSVCghbV9jb250YWluZXIpOwogICAgIEFT U0VSVChlbGVtZW50KCkpOwogCisgICAgU2NyaXB0RGlzYWxsb3dlZFNjb3BlOjpFdmVudEFsbG93 ZWRTY29wZSBhbGxvd2VkU2NvcGUoKmVsZW1lbnQoKS0+dXNlckFnZW50U2hhZG93Um9vdCgpKTsK KwogICAgIG1fY29udGFpbmVyID0gVGV4dENvbnRyb2xJbm5lckNvbnRhaW5lcjo6Y3JlYXRlKGVs ZW1lbnQoKS0+ZG9jdW1lbnQoKSk7CisgICAgZWxlbWVudCgpLT51c2VyQWdlbnRTaGFkb3dSb290 KCktPmFwcGVuZENoaWxkKCptX2NvbnRhaW5lcik7CiAgICAgbV9jb250YWluZXItPnNldFBzZXVk byhBdG9taWNTdHJpbmcoIi13ZWJraXQtdGV4dGZpZWxkLWRlY29yYXRpb24tY29udGFpbmVyIiwg QXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwogCiAgICAgbV9pbm5lckJsb2Nr ID0gVGV4dENvbnRyb2xJbm5lckVsZW1lbnQ6OmNyZWF0ZShlbGVtZW50KCktPmRvY3VtZW50KCkp OwotICAgIG1faW5uZXJCbG9jay0+YXBwZW5kQ2hpbGQoKm1faW5uZXJUZXh0KTsKICAgICBtX2Nv bnRhaW5lci0+YXBwZW5kQ2hpbGQoKm1faW5uZXJCbG9jayk7Ci0KLSAgICBlbGVtZW50KCktPnVz ZXJBZ2VudFNoYWRvd1Jvb3QoKS0+YXBwZW5kQ2hpbGQoKm1fY29udGFpbmVyKTsKKyAgICBtX2lu bmVyQmxvY2stPmFwcGVuZENoaWxkKCptX2lubmVyVGV4dCk7CiB9CiAKIHZvaWQgVGV4dEZpZWxk SW5wdXRUeXBlOjpjcmVhdGVBdXRvRmlsbEJ1dHRvbihBdXRvRmlsbEJ1dHRvblR5cGUgYXV0b0Zp bGxCdXR0b25UeXBlKQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvRGF0YUxpc3RC dXR0b25FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRv dy9EYXRhTGlzdEJ1dHRvbkVsZW1lbnQuY3BwCShyZXZpc2lvbiAyNDU3MjEpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9EYXRhTGlzdEJ1dHRvbkVsZW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00OSw3ICs0OSw2IEBAIERhdGFMaXN0QnV0dG9uRWxlbWVudDo6RGF0YUxpc3RCdXR0 b25FbGUKICAgICA6IEhUTUxEaXZFbGVtZW50KGRpdlRhZywgZG9jdW1lbnQpCiAgICAgLCBtX293 bmVyKG93bmVyKQogewotICAgIHNldFBzZXVkbyhBdG9taWNTdHJpbmcoIi13ZWJraXQtbGlzdC1i dXR0b24iLCBBdG9taWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSk7CiB9CiAKIERhdGFM aXN0QnV0dG9uRWxlbWVudDo6fkRhdGFMaXN0QnV0dG9uRWxlbWVudCgpIHsgfQpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gMjQ1NzIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDUtMjMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CisKKyAgICAgICAgQXNzc2VydGlvbiBmYWlsdXJlIGluIGRpc3BhdGNoU3VidHJlZU1v ZGlmaWVkRXZlbnQgZHVlIHRvIFRleHRGaWVsZElucHV0VHlwZSB1cGRhdGluZyBVQSBzaGFkb3cg dHJlZSBpbnNpZGUgRWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3RvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MjE2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3Qu CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2RhdGFsaXN0L2RhdGFsaXN0LXJlbW92YWwtYXNzZXJ0 aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9kYXRhbGlzdC9k YXRhbGlzdC1yZW1vdmFsLWFzc2VydGlvbi5odG1sOiBBZGRlZC4KKwogMjAxOS0wNS0yMyAgU2Fh bSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIFByb3BlcnR5 IHJlc29sdmVyIG5lZWRzIHRvIHJlY3Vyc2UgdG8gaGFuZGxlIHRoZSBiYXNlIHdoZW4gc2ltcGxp ZnlpbmcgcnZhbHVlcwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC9kYXRh bGlzdC1yZW1vdmFsLWFzc2VydGlvbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC9kYXRhbGlzdC1yZW1vdmFsLWFzc2VydGlvbi1leHBl Y3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlz dC9kYXRhbGlzdC1yZW1vdmFsLWFzc2VydGlvbi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3RzIHJlbW92aW5nIHRoZSBkYXRhbGlzdCBlbGVtZW50 IGltbWVkaWF0ZWx5IGFmdGVyIGNoYW5naW5nIHRoZSB0eXBlIG9mIHRoZSBpbnB1dCBlbGVtZW50 J3MgdHlwZS4KK1dlYktpdCBzaG91bGQgbm90IGhpdCBhIGRlYnVnIGFzc2VydGlvbi4KKworUEFT UwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9kYXRhbGlzdC9kYXRhbGlzdC1yZW1vdmFs LWFzc2VydGlvbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvZGF0 YWxpc3QvZGF0YWxpc3QtcmVtb3ZhbC1hc3NlcnRpb24uaHRtbAkobm9uZXhpc3RlbnQpCisrKyBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RhdGFsaXN0L2RhdGFsaXN0LXJlbW92YWwtYXNzZXJ0aW9u Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyByZW1vdmluZyB0aGUgZGF0YWxpc3QgZWxlbWVu dCBpbW1lZGlhdGVseSBhZnRlciBjaGFuZ2luZyB0aGUgdHlwZSBvZiB0aGUgaW5wdXQgZWxlbWVu dCdzIHR5cGUuPGJyPgorV2ViS2l0IHNob3VsZCBub3QgaGl0IGEgZGVidWcgYXNzZXJ0aW9uLjwv cD4KKzxpbnB1dCBpZD0iaW5wdXQiIGxpc3Q9ImZydWl0cyIgdHlwZT0iY2hlY2tib3giPgorPGRh dGFsaXN0IGlkPSJmcnVpdHMiPgorICAgIDxvcHRpb24+T3JhbmdlPC9vcHRpb24+CisgICAgPG9w dGlvbj5QZWFyPC9vcHRpb24+CisgICAgPG9wdGlvbj5BcHBsZTwvb3B0aW9uPgorPC9kYXRhbGlz dD4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1w QXNUZXh0KCk7CitpbnB1dC50eXBlID0gJ3RleHQnOworZnJ1aXRzLnJlbW92ZSgpOworaW5wdXQu cmVtb3ZlKCk7Citkb2N1bWVudC53cml0ZSgnUEFTUycpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8 L2h0bWw+Cg==