198180 2019-05-23 06:48:37 -0700 Fix a few missing header inclusions often masked by by unified sources 2021-04-04 13:36:57 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia commit-queue eric.carlson lantw44 pnormand raj.khem saam webkit-bug-importer wenson_hsieh youennf zalan zan oldest_to_newest 1538650 0 aperez 2019-05-23 06:48:37 -0700 The following are build errors caused by missing includes which would have been caught much earlier if unified sources weren't used: ../Source/JavaScriptCore/wasm/WasmBinding.cpp:48:22: error: use of undeclared identifier 'wasmCallingConventionAir' GPRReg scratch = wasmCallingConventionAir().prologueScratch(0); ^ ../Source/JavaScriptCore/assembler/PerfLog.cpp:147:32: error: implicit instantiation of undefined template 'std::__1::array<char, 1024>' std::array<char, 1024> filename; ^ ../Source/WebCore/html/FeaturePolicy.cpp:53:58: error: use of undeclared identifier 'isHTMLSpace' item = item.stripLeadingAndTrailingMatchedCharacters(isHTMLSpace<UChar>); ^ ../Source/WebCore/platform/text/TextCodec.cpp:43:16: error: use of undeclared identifier 'snprintf'; did you mean 'vswprintf'? return snprintf(replacement.data(), sizeof(UnencodableReplacementArray), "&#%u;", codePoint); ^~~~~~~~ vswprintf 1538652 1 370505 aperez 2019-05-23 07:34:43 -0700 Created attachment 370505 Patch 1538657 2 370505 commit-queue 2019-05-23 08:47:16 -0700 Comment on attachment 370505 Patch Clearing flags on attachment: 370505 Committed r245681: <https://trac.webkit.org/changeset/245681> 1538658 3 commit-queue 2019-05-23 08:47:18 -0700 All reviewed patches have been landed. Closing bug. 1538659 4 webkit-bug-importer 2019-05-23 08:48:18 -0700 <rdar://problem/51069221> 1746869 5 raj.khem 2021-04-04 13:36:57 -0700 *** Bug 197085 has been marked as a duplicate of this bug. *** 370505 2019-05-23 07:34:43 -0700 2019-05-23 08:47:16 -0700 Patch bug-198180-20190523173441.patch text/plain 3790 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NGQ4Yzg4ZDA0MTc3OWVkZWYzOGZmZDhhNThmODgwY2YzZTQxMTRhLi4xYjZiMzkxOWQ0ZTRlNzYw YmJjM2I0OGQ3Y2M0MTc4MzdmYjYwY2VmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOS0wNS0yMyAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgorCisgICAgICAgIEZpeCBhIGZldyBtaXNzaW5nIGhlYWRlciBpbmNsdXNpb25z IG9mdGVuIG1hc2tlZCBieSBieSB1bmlmaWVkIHNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODE4MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL1BlcmZMb2cuY3BwOiBBZGQg bWlzc2luZyA8YXJyYXk+IGhlYWRlciBpbmNsdXNpb24uCisgICAgICAgICogd2FzbS9XYXNtQmlu ZGluZy5jcHA6IEFkZCBtaXNzaW5nICJXYXNtQ2FsbGluZ0NvbnZlbnRpb24uaCIgaW5jbHVzaW9u LgorCiAyMDE5LTA1LTIzICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUuY29tPgogCiAg ICAgICAgIGNyZWF0ZUxpc3RGcm9tQXJyYXlMaWtlIHNob3VsZCB0aHJvdyBpZiB2YWx1ZSBpcyBu b3QgYW4gb2JqZWN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE4YjYyNDFhOTBkNmQyYjE5YzhlZTNkZmE5ODlk OWQzYjc5NjNhYy4uYTAxYzg0OWMxZDFmZjNiZDRiOGQ4YTI4YzVjMjA4OGQxNjY0NmIzZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA1LTIzICBBZHJpYW4gUGVyZXogZGUgQ2Fz dHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGEgZmV3IG1pc3NpbmcgaGVh ZGVyIGluY2x1c2lvbnMgb2Z0ZW4gbWFza2VkIGJ5IGJ5IHVuaWZpZWQgc291cmNlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MTgwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBlZGl0aW5nL21hcmt1 cC5oOiBBZGQgbWlzc2luZyAiRmxvYXRTaXplLmgiIGluY2x1c2lvbi4KKyAgICAgICAgKiBodG1s L0ZlYXR1cmVQb2xpY3kuY3BwOiBBZGQgbWlzc2luZyAiSFRNTFBhcnNlcklkaW9tcy5oIiBpbmNs dXNpb24uCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9UZXh0Q29kZWMuY3BwOiBBZGQgbWlzc2lu ZyA8Y3N0ZGlvPiBpbmNsdXNpb24uCisKIDIwMTktMDUtMjMgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIEltcGxlbWVudCBwcm9wZXJ0 eSByZXNvbHZlcgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9Q ZXJmTG9nLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvUGVyZkxvZy5jcHAK aW5kZXggMTQzYzQ2ZDgzMjM1MDBmN2EyY2M3ZGE4N2JmMmI5OWIxODdkN2U2Zi4uZjcwNzEyZmMy NmIxN2RhYTU3NmQ5ODY3OTdjYWRkYmM3MWI1NThiMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9QZXJmTG9nLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL1BlcmZMb2cuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpZiBFTkFCTEUo QVNTRU1CTEVSKSAmJiBPUyhMSU5VWCkKIAorI2luY2x1ZGUgPGFycmF5PgogI2luY2x1ZGUgPGVs Zi5oPgogI2luY2x1ZGUgPGZjbnRsLmg+CiAjaW5jbHVkZSA8bXV0ZXg+CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQmluZGluZy5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd2FzbS9XYXNtQmluZGluZy5jcHAKaW5kZXggMGM1M2NiNjZmZDBkYjMyZDg4MzRi ZmU2YTIzYzRiMDY3ZjZlZDI4MS4uZmVkNDViMTA2M2M5YTM2YmY2NTFjZjgwM2VlMTBmMWM1YmU3 YzY1NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUJpbmRpbmcu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CaW5kaW5nLmNwcApAQCAt MzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkNDYWxsSGVscGVycy5oIgogI2luY2x1ZGUgIkpTQ0lu bGluZXMuaCIKICNpbmNsdWRlICJMaW5rQnVmZmVyLmgiCisjaW5jbHVkZSAiV2FzbUNhbGxpbmdD b252ZW50aW9uLmgiCiAjaW5jbHVkZSAiV2FzbUluc3RhbmNlLmgiCiAKIG5hbWVzcGFjZSBKU0Mg eyBuYW1lc3BhY2UgV2FzbSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21h cmt1cC5oIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYXJrdXAuaAppbmRleCA3OTIyYTc4Yjgw NTViYWIyZjIzZmIxOGI1OWZjNjg4NzE3YTlkMGE3Li5lODY5NmJiMTQyYjUzMDZjMjQ1YWYyYTkw ZTVkZTBkMzQ0NTM4NDI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hcmt1 cC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFya3VwLmgKQEAgLTI2LDYgKzI2LDcg QEAKICNwcmFnbWEgb25jZQogCiAjaW5jbHVkZSAiRXhjZXB0aW9uT3IuaCIKKyNpbmNsdWRlICJG bG9hdFNpemUuaCIKICNpbmNsdWRlICJGcmFnbWVudFNjcmlwdGluZ1Blcm1pc3Npb24uaCIKICNp bmNsdWRlICJIVE1MSW50ZXJjaGFuZ2UuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9GZWF0dXJlUG9saWN5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvRmVhdHVyZVBvbGljeS5jcHAKaW5kZXggYjkxODdmMWEyYWM2ODU2NWE2YTU3 YzQ5MzE5YjhkNThkOTBjNzAyNi4uM2RhODc0MjI2MmYzNjUyOWY4Y2MwOGNmMzFjNmFjODFiY2M5 NGJhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9GZWF0dXJlUG9saWN5LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0ZlYXR1cmVQb2xpY3kuY3BwCkBAIC0yNyw2ICsyNyw3 IEBACiAjaW5jbHVkZSAiRmVhdHVyZVBvbGljeS5oIgogCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIK KyNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4u aCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9UZXh0Q29kZWMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9U ZXh0Q29kZWMuY3BwCmluZGV4IDg2Yjg5Y2ZjNDc2ZjAzYjZkYjRmNzhmYjQyYzE4M2Y0ODk3ZGFk ODQuLjQ4MWRkMjg5YTYyMTkyYjlhY2I0Yzg4NDgwZGI5MTg5OWU0NzA1OGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dENvZGVjLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRDb2RlYy5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlICJUZXh0Q29kZWMuaCIKIAogI2luY2x1ZGUgPGFycmF5PgorI2luY2x1ZGUgPGNzdGRp bz4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg==