<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>198142</bug_id>
          
          <creation_ts>2019-05-22 15:04:48 -0700</creation_ts>
          <short_desc>webkitpy: Using sudo on iOS device during timeout spindumps</short_desc>
          <delta_ts>2019-05-28 12:07:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="hysu">hysu</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>hysu</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1538398</commentid>
    <comment_count>0</comment_count>
    <who name="hysu">hysu</who>
    <bug_when>2019-05-22 15:04:48 -0700</bug_when>
    <thetext>sample_process checks the source host instead of the target host when deciding whether or not to run sudo for spindumps.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1538412</commentid>
    <comment_count>1</comment_count>
      <attachid>370451</attachid>
    <who name="hysu">hysu</who>
    <bug_when>2019-05-22 15:24:23 -0700</bug_when>
    <thetext>Created attachment 370451
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539678</commentid>
    <comment_count>2</comment_count>
      <attachid>370451</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-28 12:06:24 -0700</bug_when>
    <thetext>Comment on attachment 370451
Patch

Clearing flags on attachment: 370451

Committed r245819: &lt;https://trac.webkit.org/changeset/245819&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539679</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-05-28 12:06:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1539680</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-05-28 12:07:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/51188689&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>370451</attachid>
            <date>2019-05-22 15:24:23 -0700</date>
            <delta_ts>2019-05-28 12:06:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-198142-20190522152422.patch</filename>
            <type>text/plain</type>
            <size>1390</size>
            <attacher name="hysu">hysu</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODFlYWJjNzVlMjgyNzE1ZGZkOGM0ZWU5MzUzMzkwMzA2
NjI4M2E3Zi4uZWIxZDRjNTE5YzNkMmJiMjQwOTJmODA5MDZiMDkyN2IzZWVhZjA3OSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz
IEBACisyMDE5LTA1LTIyICBEYXZpZCBYaW9uZyAgPHdfeGlvbmdAYXBwbGUuY29tPgorCisgICAg
ICAgIHdlYmtpdHB5OiBVc2luZyBzdWRvIG9uIGlPUyBkZXZpY2UgZHVyaW5nIHRpbWVvdXQgc3Bp
bmR1bXBzIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTk4MTQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
KiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZGFyd2luLnB5OgorICAgICAgICAoRGFyd2luUG9ydC5z
YW1wbGVfcHJvY2Vzcyk6IENoZWNrIHRhcmdldCBob3N0IGluc3RlYWQgb2Ygc291cmNlIGhvc3Qg
Zm9yIHN1ZG8gY29tbWFuZC4KKwogMjAxOS0wNS0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj
Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IHRoZSBidWlsZCB3
aXRoIEhBVkUoQUNDRVNTSUJJTElUWSkgZGlzYWJsZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw
dHMvd2Via2l0cHkvcG9ydC9kYXJ3aW4ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv
ZGFyd2luLnB5CmluZGV4IDMzYTRiYzk3YjhmMDViMzFmOWZlZjM5OGI2MWMzOTEzNTA3MTMyMjAu
LmE5Njg2ODBiNmQyNWI0NzgwMGRkZDFlNWRkYzNiMGZhMGQ2ZjFmZDUgMTAwNjQ0Ci0tLSBhL1Rv
b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kYXJ3aW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93
ZWJraXRweS9wb3J0L2Rhcndpbi5weQpAQCAtMTY4LDcgKzE2OCw3IEBAIGNsYXNzIERhcndpblBv
cnQoQXBwbGVQb3J0KToKICAgICAgICAgICAgICctZmlsZScsCiAgICAgICAgICAgICBEYXJ3aW5Q
b3J0LnNwaW5kdW1wX2ZpbGVfcGF0aChob3N0LCBuYW1lLCBwaWQsIHN0cih0ZW1wZGlyKSksCiAg
ICAgICAgIF0KLSAgICAgICAgaWYgc2VsZi5ob3N0LnBsYXRmb3JtLmlzX21hYygpOgorICAgICAg
ICBpZiBob3N0LnBsYXRmb3JtLmlzX21hYygpOgogICAgICAgICAgICAgY29tbWFuZCA9IFsnL3Vz
ci9iaW4vc3VkbycsICctbiddICsgY29tbWFuZAogICAgICAgICBleGl0X3N0YXR1cyA9IGhvc3Qu
ZXhlY3V0aXZlLnJ1bl9jb21tYW5kKGNvbW1hbmQsIHJldHVybl9leGl0X2NvZGU9VHJ1ZSkKICAg
ICAgICAgaWYgZXhpdF9zdGF0dXM6Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>