198120 2019-05-22 08:24:39 -0700 llint_slow_path_get_by_id needs to hold the CodeBlock's lock to update the metadata's mode 2019-05-22 15:19:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist fpizlo keith_miller mark.lam msaboff rmorisset saam webkit-bug-importer ysuzuki oldest_to_newest 1538192 0 tzagallo 2019-05-22 08:24:39 -0700 <rdar://problem/49668795> 1538193 1 370398 tzagallo 2019-05-22 08:35:46 -0700 Created attachment 370398 Patch 1538386 2 370398 msaboff 2019-05-22 14:51:37 -0700 Comment on attachment 370398 Patch r=me 1538408 3 370398 commit-queue 2019-05-22 15:19:44 -0700 Comment on attachment 370398 Patch Clearing flags on attachment: 370398 Committed r245652: <https://trac.webkit.org/changeset/245652> 1538409 4 commit-queue 2019-05-22 15:19:45 -0700 All reviewed patches have been landed. Closing bug. 370398 2019-05-22 08:35:46 -0700 2019-05-22 15:19:44 -0700 Patch bug-198120-20190522173545.patch text/plain 4422 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YTc3MDg0ZTY0ZTU1NmY1M2E0MDEzMGRmMGE4MjdlMGMyMjg3NmJmLi4zZDlhMjI1MGI4M2VmZjI5 NzFhODJlMWM0MjY2ZTExNTg2YzEzODQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wNS0yMiAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBsbGludF9zbG93X3BhdGhfZ2V0X2J5X2lkIG5lZWRzIHRvIGhvbGQgdGhl IENvZGVCbG9jaydzIGxvY2sgdG8gdXBkYXRlIHRoZSBtZXRhZGF0YSdzIG1vZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODEyMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNDk2Njg3OTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHR3byBwbGFjZXMgaW4gbGxpbnRfc2xvd19wYXRo X2dldF9ieV9pZCB3aGVyZSB3ZSBjaGFuZ2UgdGhlCisgICAgICAgIG1ldGFkYXRhJ3MgbW9kZSB3 aXRob3V0IGhvbGRpbmcgdGhlIENvZGVCbG9jaydzIGxvY2suIFRoaXMgaXMgYW4gaXNzdWUKKyAg ICAgICAgd2hlbiBzd2l0Y2hpbmcgdG8gYW5kIGZyb20gQXJyYXlMZW5ndGggbW9kZSwgc2luY2Ug b3RoZXIgcGxhY2VzIGNhbgorICAgICAgICBlaXRoZXIgZ2V0IGEgcG9pbnRlciB0byBhbiBhcnJh eSBwcm9maWxlIHRoYXQgd2lsbCBiZSBvdmVyd3JpdHRlbiBvcgorICAgICAgICBhbiBhcnJheSBw cm9maWxlIHRoYXQgaGFzbid0IHlldCBiZWVuIGluaXRpYWxpemVkLgorCisgICAgICAgICogbGxp bnQvTExJbnRTbG93UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6TExJTlRfU0xPV19Q QVRIX0RFQ0wpOgorCiAyMDE5LTA1LTIxICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bz b255LmNvbT4KIAogICAgICAgICBbUGxheVN0YXRpb25dIERvbid0IGNhbGwgZmNudGwuCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAppbmRleCAyZTkw YzcwMWRhMWVjNzViMTgyMmFhNmQ3YjNiZTdjNzQyNmYyNWI3Li41MDNlNjBlMmM2M2NkMzZlM2Uy ZjA1ZDIzNzVlOWU3NGM1YWNhMmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGlu dC9MTEludFNsb3dQYXRocy5jcHAKQEAgLTgwMyw2ICs4MDMsOCBAQCBMTElOVF9TTE9XX1BBVEhf REVDTChzbG93X3BhdGhfZ2V0X2J5X2lkKQogICAgICAgICBKU0NlbGwqIGJhc2VDZWxsID0gYmFz ZVZhbHVlLmFzQ2VsbCgpOwogICAgICAgICBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IGJhc2VDZWxs LT5zdHJ1Y3R1cmUodm0pOwogICAgICAgICBpZiAoc2xvdC5pc1ZhbHVlKCkgJiYgc2xvdC5zbG90 QmFzZSgpID09IGJhc2VWYWx1ZSkgeworICAgICAgICAgICAgQ29uY3VycmVudEpTTG9ja2VyIGxv Y2tlcihjb2RlQmxvY2stPm1fbG9jayk7CisKICAgICAgICAgICAgIC8vIFN0YXJ0IG91dCBieSBj bGVhcmluZyBvdXQgdGhlIG9sZCBjYWNoZS4KICAgICAgICAgICAgIG1ldGFkYXRhLm1fbW9kZSA9 IEdldEJ5SWRNb2RlOjpEZWZhdWx0OwogICAgICAgICAgICAgbWV0YWRhdGEubV9tb2RlTWV0YWRh dGEuZGVmYXVsdE1vZGUuc3RydWN0dXJlSUQgPSAwOwpAQCAtODE0LDggKzgxNiw2IEBAIExMSU5U X1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9nZXRfYnlfaWQpCiAgICAgICAgICAgICBpZiAoc3Ry dWN0dXJlLT5wcm9wZXJ0eUFjY2Vzc2VzQXJlQ2FjaGVhYmxlKCkKICAgICAgICAgICAgICAgICAm JiAhc3RydWN0dXJlLT5uZWVkSW1wdXJlUHJvcGVydHlXYXRjaHBvaW50KCkpIHsKICAgICAgICAg ICAgICAgICB2bS5oZWFwLndyaXRlQmFycmllcihjb2RlQmxvY2spOwotICAgICAgICAgICAgICAg IAotICAgICAgICAgICAgICAgIENvbmN1cnJlbnRKU0xvY2tlciBsb2NrZXIoY29kZUJsb2NrLT5t X2xvY2spOwogCiAgICAgICAgICAgICAgICAgbWV0YWRhdGEubV9tb2RlTWV0YWRhdGEuZGVmYXVs dE1vZGUuc3RydWN0dXJlSUQgPSBzdHJ1Y3R1cmUtPmlkKCk7CiAgICAgICAgICAgICAgICAgbWV0 YWRhdGEubV9tb2RlTWV0YWRhdGEuZGVmYXVsdE1vZGUuY2FjaGVkT2Zmc2V0ID0gc2xvdC5jYWNo ZWRPZmZzZXQoKTsKQEAgLTgyOSw2ICs4MjksNyBAQCBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93 X3BhdGhfZ2V0X2J5X2lkKQogICAgIH0gZWxzZSBpZiAoIUxMSU5UX0FMV0FZU19BQ0NFU1NfU0xP VwogICAgICAgICAmJiBpc0pTQXJyYXkoYmFzZVZhbHVlKQogICAgICAgICAmJiBpZGVudCA9PSB2 bS5wcm9wZXJ0eU5hbWVzLT5sZW5ndGgpIHsKKyAgICAgICAgQ29uY3VycmVudEpTTG9ja2VyIGxv Y2tlcihjb2RlQmxvY2stPm1fbG9jayk7CiAgICAgICAgIG1ldGFkYXRhLm1fbW9kZSA9IEdldEJ5 SWRNb2RlOjpBcnJheUxlbmd0aDsKICAgICAgICAgbmV3ICgmbWV0YWRhdGEubV9tb2RlTWV0YWRh dGEuYXJyYXlMZW5ndGhNb2RlLmFycmF5UHJvZmlsZSkgQXJyYXlQcm9maWxlKGNvZGVCbG9jay0+ Ynl0ZWNvZGVPZmZzZXQocGMpKTsKICAgICAgICAgbWV0YWRhdGEubV9tb2RlTWV0YWRhdGEuYXJy YXlMZW5ndGhNb2RlLmFycmF5UHJvZmlsZS5vYnNlcnZlU3RydWN0dXJlKGJhc2VWYWx1ZS5hc0Nl bGwoKS0+c3RydWN0dXJlKHZtKSk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pT VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRlNGY4ODY1NmFjODRhM2JjMGJmNzI2ZWJmMzU0MzlkOTFl MzA1YWQuLjdmYWYyMjFjZWQzOWIwOTIwZGQxY2UzY2EwN2M1ZDc4OWYyZjY2NDUgMTAwNjQ0Ci0t LSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTktMDUtMjIgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CisK KyAgICAgICAgbGxpbnRfc2xvd19wYXRoX2dldF9ieV9pZCBuZWVkcyB0byBob2xkIHRoZSBDb2Rl QmxvY2sncyB0byB1cGRhdGUgdGhlIG1ldGFkYXRhJ3MgbW9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MTIwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80OTY2ODc5NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHN0cmVzcy9nZXQtYXJyYXktbGVuZ3RoLWNvbmN1cnJlbnRseS1jaGFuZ2UtbW9k ZS5qczogQWRkZWQuCisgICAgICAgIChtYWluKToKKwogMjAxOS0wNS0yMCAgS2VpdGggTWlsbGVy ICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbnVwIFlhcnIgcmVnZXhw IGNvZGUgYXJvdW5kIHBhcmVuIGNvbnRleHRzLgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3Mv Z2V0LWFycmF5LWxlbmd0aC1jb25jdXJyZW50bHktY2hhbmdlLW1vZGUuanMgYi9KU1Rlc3RzL3N0 cmVzcy9nZXQtYXJyYXktbGVuZ3RoLWNvbmN1cnJlbnRseS1jaGFuZ2UtbW9kZS5qcwpuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi4wNmY0NzgzODI2ZGFhZmQ2NzE4YzNmN2E5YzFhZWNkYTY3ZTllNzQyCi0tLSAvZGV2L251 bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvZ2V0LWFycmF5LWxlbmd0aC1jb25jdXJyZW50bHktY2hh bmdlLW1vZGUuanMKQEAgLTAsMCArMSwxOSBAQAorLy9AIHJlcXVpcmVPcHRpb25zKCItLXdhdGNo ZG9nPTEwMDAwIiwgIi0td2F0Y2hkb2ctZXhjZXB0aW9uLW9rIikKK2Z1bmN0aW9uIG1haW4oKSB7 CisgICAgcnVuU3RyaW5nKGAKKyAgICAgICAgZnVuY3Rpb24gYmFyKF9hKSB7CisgICAgICAgICAg ZXZhbChfYSk7CisgICAgICAgICAgYXJndW1lbnRzLmxlbmd0aCA9IDA7CisgICAgICAgICAgdmFy IGFycmF5ID0gWworICAgICAgICAgICAgYXJndW1lbnRzLAorICAgICAgICAgICAgWzBdCisgICAg ICAgICAgXTsKKyAgICAgICAgICB2YXIgcmVzdWx0ID0gMDsKKyAgICAgICAgICBmb3IgKHZhciBp ID0gMDsgaSA8IDEwMDAwMDA7ICsraSkKKyAgICAgICAgICAgIHJlc3VsdCArPSBhcnJheVtpICUg YXJyYXkubGVuZ3RoXS5sZW5ndGg7CisgICAgICAgIH0KKyAgICAgICAgYmFyKCdiYXIoKScpOwor ICAgIGApOworICAgIG1haW4oKTsKK30KK21haW4oKTsK