197971 2019-05-16 16:38:12 -0700 GLContextEGL should check the supported EGL version at compile time 2019-06-08 11:05:04 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 madhurkiran.h webkit-unassigned aperez bugs-noreply madhurkiran.h magomez mcatanzaro oldest_to_newest 1536970 0 370090 madhurkiran.h 2019-05-16 16:38:12 -0700 Created attachment 370090 Fix-patch Webkitgtk should check the supported version at compile time. The macro definitions for 1.5 may not be defined if the EGL only supports for 1.4 1537002 1 mcatanzaro 2019-05-16 19:55:55 -0700 The #endif is misplaced! - Be sure to add a ChangeLog entry using Tools/Scripts/prepare-ChangeLog - Be sure to flag it as a patch, to enable review - Then set the r? and cq? Bugzilla flags to request review and commit 1537003 2 mcatanzaro 2019-05-16 19:57:13 -0700 See also: https://webkit.org/contributing-code/ 1537020 3 madhurkiran.h 2019-05-16 21:06:00 -0700 Can you please explain why you think its misplaced. I am expecting the platform to support at least EGL 1.4 as default. I will add the changelog. -Mads 1537127 4 mcatanzaro 2019-05-17 09:42:03 -0700 It clearly won't compile: @@ -384,7 +384,11 @@ EGLContext GLContextEGL::createContextForEGLVersion(PlatformDisplay& platformDis // Try to create a context with this configuration. context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes); - } else if (platformDisplay.eglCheckVersion(1, 4)) { + } else if +#else + if +#endif + (platformDisplay.eglCheckVersion(1, 4)) { const char* extensions = eglQueryString(platformDisplay.eglDisplay(), EGL_EXTENSIONS); if (GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context")) { contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR; -- 2.7.4 1537167 5 madhurkiran.h 2019-05-17 11:06:57 -0700 Sorry, but there is the ifdef in the patch, I think you missed that. --- a/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp +++ b/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp @@ -372,7 +372,7 @@ EGLContext GLContextEGL::createContextForEGLVersion(PlatformDisplay& platformDis // we'll use whatever is available. In order to request a concrete version of OpenGL we need EGL version // 1.5 or EGL version 1.4 with the extension EGL_KHR_create_context. EGLContext context = EGL_NO_CONTEXT; - +#ifdef EGL_VERSION_1_5 if (platformDisplay.eglCheckVersion(1, 5)) { contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION; contextAttributes[1] = 3; @@ -384,7 +384,11 @@ EGLContext GLContextEGL::createContextForEGLVersion(PlatformDisplay& platformDis // Try to create a context with this configuration. context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes); - } else if (platformDisplay.eglCheckVersion(1, 4)) { + } else if +#else + if +#endif + (platformDisplay.eglCheckVersion(1, 4)) { const char* extensions = eglQueryString(platformDisplay.eglDisplay(), EGL_EXTENSIONS); if (GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context")) { contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR; -- 2.7.4 1537192 6 mcatanzaro 2019-05-17 12:04:04 -0700 Oh, you've *intentionally* left the final case as just #else if #endif Don't do that, please, it's not readable. 1537288 7 madhurkiran.h 2019-05-17 15:24:01 -0700 Ok. Fixed it. 1537291 8 370161 madhurkiran.h 2019-05-17 15:27:21 -0700 Created attachment 370161 Fix to check the EGL version at compile time 1537410 9 370161 mcatanzaro 2019-05-18 08:04:17 -0700 Comment on attachment 370161 Fix to check the EGL version at compile time View in context: https://bugs.webkit.org/attachment.cgi?id=370161&action=review OK this looks better, thanks! > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:419 > } else if (platformDisplay.eglCheckVersion(1, 4)) { > +#else > + if (platformDisplay.eglCheckVersion(1, 4)) { > +#endif How about: } else #endif if (platformDisplay.eglCheckVersion(1, 4)) { That way we don't need to repeat the condition at all. 1537411 10 370161 aperez 2019-05-18 08:13:12 -0700 Comment on attachment 370161 Fix to check the EGL version at compile time I don't understand why it is needed to have guards for EGL version 1.5: The call to “.eglCheckVersion()” can be done regardless of the version, and if at runtime the check fails then we are already falling back to check for 1.4 anyway. I am failing to see how this can be useful and/or needed. I can make a case for having *only* checks at runtime being better. Imagine the case in which a distributor packages WebKit using for building headers from a version of Mesa which does NOT define EGL_VERSION_1_5; then Mesa is updated to a new release that happens to support EGL version 1.5 and new packages available. With a build-time check, the WebKit package would need to be rebuilt to take advantage of new features, with a runtime check things will just start working automatically. (Not to mention that usual “modus operandi” of OpenGL, EGL, and related APIs is to provide a common base guaranteed to work, and have applications check at run time by querying extensions, versions, and so on.) 1537414 11 mcatanzaro 2019-05-18 10:08:05 -0700 Mads, can you copy/paste the build error you are seeing please? 1537561 12 aperez 2019-05-20 05:17:24 -0700 (In reply to Michael Catanzaro from comment #11) > Mads, can you copy/paste the build error you are seeing please? OK, I have been investigating a bit about this: in EGL version 1.5 the extension EGL_KHR_create_context is built-in, but headers for *older* versions of EGL will not have defined the constants which were added in 1.5 and that is likely the cause for the compilation failure, checking the EGL 1.4 spec [1]: - EGL_CONTEXT_MAJOR_VERSION was EGL_CONTEXT_CLIENT_VERSION in EGL <1.5 - EGL_CONTEXT_MINOR_VERSION was not defined prior to EGL 1.5 I would do something like the following instead, because the constant values for the macros above are set on stone in the spec and official headers: // The EGL headers being used may not include version 1.5 symbols, // so we define here the ones we need, which will be used *only* // if the EGL version detected at runtime is 1.5 or newer. Values // taken from the official headers as published by Khronos, see: // // https://www.khronos.org/registry/EGL/api/EGL/egl.h #ifndef EGL_CONTEXT_MAJOR_VERSION #define EGL_CONTEXT_MAJOR_VERSION 0x3098 #endif #ifndef EGL_CONTEXT_MINOR_VERSION #define EGL_CONTEXT_MINOR_VERSION 0x30FB #endif // ... if (platformDisplay.eglCheckVersion(1, 5) { contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION; contextAttributes[1] = 3; contextAttributes[2] = EGL_CONTEXT_MINOR_VERSION; // ...and so on, no #ifdefs needed here. } --- [1] https://www.khronos.org/registry/EGL/specs/eglspec.1.5.withchanges.pdf 1537828 13 370304 madhurkiran.h 2019-05-21 01:18:08 -0700 Created attachment 370304 Error_log 1537990 14 370343 madhurkiran.h 2019-05-21 14:39:59 -0700 Created attachment 370343 Use a generic macro for EGL context version 1539456 15 370343 aperez 2019-05-27 16:12:43 -0700 Comment on attachment 370343 Use a generic macro for EGL context version View in context: https://bugs.webkit.org/attachment.cgi?id=370343&action=review I think this is looking pretty good for landing now. Could a reviewer please take a look? (Thanks!) > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:407 > + || (platformDisplay.eglCheckVersion(1, 4) && GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context"))) { I quite like unifying the two if-branches into a single one, good thinking! Probably we still want to do the #ifndef-#define dance for the macros, because EGL 1.5 headers might provide EGL_CONTEXT_MAJOR_VERSION, but not EGL_CONTEXT_MAJOR_VERSION_KHR as an extension — though it is very likely that the _KHR symbols are provided also on EGL 1.5 headers, so it is probably fine to merge this patch as-is, and add the #ifdef-#define bits if needed in the future... What do reviewers think about this? 1539457 16 370343 mcatanzaro 2019-05-27 16:45:25 -0700 Comment on attachment 370343 Use a generic macro for EGL context version View in context: https://bugs.webkit.org/attachment.cgi?id=370343&action=review > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:-430 > } > - } This indentation can't be right. 1540090 17 370881 madhurkiran.h 2019-05-29 13:40:16 -0700 Created attachment 370881 Use a generic macro for EGL context version v2 1540102 18 370881 mcatanzaro 2019-05-29 14:05:09 -0700 Comment on attachment 370881 Use a generic macro for EGL context version v2 View in context: https://bugs.webkit.org/attachment.cgi?id=370881&action=review > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:418 > context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes); > - } > } Again, this is eight-space indentation when it should be four-space. 1540145 19 madhurkiran.h 2019-05-29 15:41:36 -0700 I think this looks fine. 1540305 20 mcatanzaro 2019-05-30 08:23:46 -0700 Well it's not, because we require four-space indentation.... 1542932 21 madhurkiran.h 2019-06-07 13:52:25 -0700 If the "if" condition started at 8 space indentation why would it need 4 space to end? 1542947 22 mcatanzaro 2019-06-07 14:30:14 -0700 It's not allowed to use eight-space indentation in WebKit. We use four-space indentation everywhere. Your patch changes this code from four-space to eight-space; that's why you have cq-. 1542960 23 madhurkiran.h 2019-06-07 15:02:25 -0700 Why not , as this conditional statement is within another conditional statement? 1543097 24 mcatanzaro 2019-06-08 11:05:04 -0700 Maybe we have a misunderstanding. Your code starts like this: if (platformDisplay.eglCheckVersion(1, 5) || (platformDisplay.eglCheckVersion(1, 4) && GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context"))) { contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR; contextAttributes[1] = 3; contextAttributes[2] = EGL_CONTEXT_MINOR_VERSION_KHR; with eight spaces of indentation between the if and the code within the condition. But to be accepted into WebKit, it needs to look like this: if (platformDisplay.eglCheckVersion(1, 5) || (platformDisplay.eglCheckVersion(1, 4) && GLContext::isExtensionSupported(extensions, "EGL_KHR_create_context"))) { contextAttributes[0] = EGL_CONTEXT_MAJOR_VERSION_KHR; contextAttributes[1] = 3; contextAttributes[2] = EGL_CONTEXT_MINOR_VERSION_KHR; with four spaces. Similarly, your code ends like this: // Try to create a context with this configuration. context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes); } again, with eight spaces there. But it needs to use four spaces: // Try to create a context with this configuration. context = eglCreateContext(platformDisplay.eglDisplay(), config, sharingContext, contextAttributes); } 370090 2019-05-16 16:38:12 -0700 2019-05-17 15:27:21 -0700 Fix-patch 0001-egl-GLContextEGL.cpp-Check-the-spported-EGL-version-.patch application/mbox 2099 madhurkiran.h RnJvbSA0NjM5NGY0YzkwNmY4NzU5NDQ1YjE5YWM1YjliNjZkZmRkYWQzZTRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYWRodXJraXJhbiBIYXJpa3Jpc2huYW4gPG1hZGh1cmtpcmFu LmhhcmlrcmlzaG5hbkB4aWxpbnguY29tPgpEYXRlOiBUaHUsIDE2IE1heSAyMDE5IDE1OjI3OjE2 IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gZWdsOiBHTENvbnRleHRFR0wuY3BwOiBDaGVjayB0aGUg c3Bwb3J0ZWQgRUdMIHZlcnNpb24gYXQKIGNvbXBpbGUgdGltZQoKRUdMIHByb3ZpZGVycy9oZWFk ZXJzIHdpbGwgbm90IHByb3ZpZGUgbWFjcm8gZGVmaW5pdGlvbnMgZm9yIGhpZ2hlcgpFR0wgdmVy c2lvbi4gSGVuY2UsIGNoZWNrIHRoZSBzdXBwb3J0ZWQgRUdMIHZlcnNpb24gYXQgY29tcGlsZSB0 aW1lLgoKU2lnbmVkLW9mZi1ieTogTWFkaHVya2lyYW4gSGFyaWtyaXNobmFuIDxtYWRodXJraXJh bi5oYXJpa3Jpc2huYW5AeGlsaW54LmNvbT4KLS0tCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcCB8IDggKysrKysrLS0KIDEgZmlsZSBjaGFuZ2Vk LCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcAppbmRleCAyNGQwNmJh Li4xZjA0YjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9l Z2wvR0xDb250ZXh0RUdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9lZ2wvR0xDb250ZXh0RUdMLmNwcApAQCAtMzcyLDcgKzM3Miw3IEBAIEVHTENvbnRleHQgR0xD b250ZXh0RUdMOjpjcmVhdGVDb250ZXh0Rm9yRUdMVmVyc2lvbihQbGF0Zm9ybURpc3BsYXkmIHBs YXRmb3JtRGlzCiAgICAgICAgIC8vIHdlJ2xsIHVzZSB3aGF0ZXZlciBpcyBhdmFpbGFibGUuIElu IG9yZGVyIHRvIHJlcXVlc3QgYSBjb25jcmV0ZSB2ZXJzaW9uIG9mIE9wZW5HTCB3ZSBuZWVkIEVH TCB2ZXJzaW9uCiAgICAgICAgIC8vIDEuNSBvciBFR0wgdmVyc2lvbiAxLjQgd2l0aCB0aGUgZXh0 ZW5zaW9uIEVHTF9LSFJfY3JlYXRlX2NvbnRleHQuCiAgICAgICAgIEVHTENvbnRleHQgY29udGV4 dCA9IEVHTF9OT19DT05URVhUOwotCisjaWZkZWYgRUdMX1ZFUlNJT05fMV81CiAgICAgICAgIGlm IChwbGF0Zm9ybURpc3BsYXkuZWdsQ2hlY2tWZXJzaW9uKDEsIDUpKSB7CiAgICAgICAgICAgICBj b250ZXh0QXR0cmlidXRlc1swXSA9IEVHTF9DT05URVhUX01BSk9SX1ZFUlNJT047CiAgICAgICAg ICAgICBjb250ZXh0QXR0cmlidXRlc1sxXSA9IDM7CkBAIC0zODQsNyArMzg0LDExIEBAIEVHTENv bnRleHQgR0xDb250ZXh0RUdMOjpjcmVhdGVDb250ZXh0Rm9yRUdMVmVyc2lvbihQbGF0Zm9ybURp c3BsYXkmIHBsYXRmb3JtRGlzCiAKICAgICAgICAgICAgIC8vIFRyeSB0byBjcmVhdGUgYSBjb250 ZXh0IHdpdGggdGhpcyBjb25maWd1cmF0aW9uLgogICAgICAgICAgICAgY29udGV4dCA9IGVnbENy ZWF0ZUNvbnRleHQocGxhdGZvcm1EaXNwbGF5LmVnbERpc3BsYXkoKSwgY29uZmlnLCBzaGFyaW5n Q29udGV4dCwgY29udGV4dEF0dHJpYnV0ZXMpOwotICAgICAgICB9IGVsc2UgaWYgKHBsYXRmb3Jt RGlzcGxheS5lZ2xDaGVja1ZlcnNpb24oMSwgNCkpIHsKKyAgICAgICAgfSBlbHNlIGlmCisjZWxz ZQorCWlmCisjZW5kaWYKKwkJKHBsYXRmb3JtRGlzcGxheS5lZ2xDaGVja1ZlcnNpb24oMSwgNCkp IHsKICAgICAgICAgICAgIGNvbnN0IGNoYXIqIGV4dGVuc2lvbnMgPSBlZ2xRdWVyeVN0cmluZyhw bGF0Zm9ybURpc3BsYXkuZWdsRGlzcGxheSgpLCBFR0xfRVhURU5TSU9OUyk7CiAgICAgICAgICAg ICBpZiAoR0xDb250ZXh0Ojppc0V4dGVuc2lvblN1cHBvcnRlZChleHRlbnNpb25zLCAiRUdMX0tI Ul9jcmVhdGVfY29udGV4dCIpKSB7CiAgICAgICAgICAgICAgICAgY29udGV4dEF0dHJpYnV0ZXNb MF0gPSBFR0xfQ09OVEVYVF9NQUpPUl9WRVJTSU9OX0tIUjsKLS0gCjIuNy40Cgo= 370161 2019-05-17 15:27:21 -0700 2019-05-21 14:39:59 -0700 Fix to check the EGL version at compile time 0001-PATCH-v2-egl-GLContextEGL.cpp-Check-the-spported-EGL-version-.patch text/plain 2269 madhurkiran.h SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTQ4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTE3ICBNYWRodXJr aXJhbiBIYXJpa3Jpc2huYW4gIDxtYWRodXJraXJhbi5oYXJpa3Jpc2huYW5AeGlsaW54LmNvbT4K KworICAgICAgICBlZ2w6IEdMQ29udGV4dEVHTC5jcHA6IENoZWNrIHRoZSBzcHBvcnRlZCBFR0wg dmVyc2lvbiBhdCBjb21waWxlIHRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Nzk3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEVHTCBwcm92aWRlcnMvaGVhZGVycyB3aWxsIG5vdCBwcm92aWRlIG1h Y3JvIGRlZmluaXRpb25zIGZvciBoaWdoZXIgRUdMCisgICAgICAgIHZlcnNpb24uIEhlbmNlLCBj aGVjayB0aGUgc3VwcG9ydGVkIEVHTCB2ZXJzaW9uIGF0IGNvbXBpbGUgdGltZS4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6R0xDb250ZXh0RUdMOjpjcmVhdGVDb250ZXh0Rm9yRUdMVmVyc2lvbik6CisKIDIwMTkt MDUtMTcgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg YSB3ZWJzaXRlIHBvbGljeSB0byBkaXNhYmxlIHRoZSBsZWdhY3kgLXdlYmtpdC1vdmVyZmxvdy1z Y3JvbGxpbmc6dG91Y2ggYmVoYXZpb3IKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCShyZXZpc2lvbiAyNDU0ODMp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDAxLDcgKzQwMSw3IEBAIEVHTENvbnRleHQgR0xDb250ZXh0 RUdMOjpjcmVhdGVDb250ZXh0Rm8KICAgICAgICAgLy8gd2UnbGwgdXNlIHdoYXRldmVyIGlzIGF2 YWlsYWJsZS4gSW4gb3JkZXIgdG8gcmVxdWVzdCBhIGNvbmNyZXRlIHZlcnNpb24gb2YgT3BlbkdM IHdlIG5lZWQgRUdMIHZlcnNpb24KICAgICAgICAgLy8gMS41IG9yIEVHTCB2ZXJzaW9uIDEuNCB3 aXRoIHRoZSBleHRlbnNpb24gRUdMX0tIUl9jcmVhdGVfY29udGV4dC4KICAgICAgICAgRUdMQ29u dGV4dCBjb250ZXh0ID0gRUdMX05PX0NPTlRFWFQ7Ci0KKyNpZmRlZiBFR0xfVkVSU0lPTl8xXzUK ICAgICAgICAgaWYgKHBsYXRmb3JtRGlzcGxheS5lZ2xDaGVja1ZlcnNpb24oMSwgNSkpIHsKICAg ICAgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzBdID0gRUdMX0NPTlRFWFRfTUFKT1JfVkVSU0lP TjsKICAgICAgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzFdID0gMzsKQEAgLTQxNCw2ICs0MTQs OSBAQCBFR0xDb250ZXh0IEdMQ29udGV4dEVHTDo6Y3JlYXRlQ29udGV4dEZvCiAgICAgICAgICAg ICAvLyBUcnkgdG8gY3JlYXRlIGEgY29udGV4dCB3aXRoIHRoaXMgY29uZmlndXJhdGlvbi4KICAg ICAgICAgICAgIGNvbnRleHQgPSBlZ2xDcmVhdGVDb250ZXh0KHBsYXRmb3JtRGlzcGxheS5lZ2xE aXNwbGF5KCksIGNvbmZpZywgc2hhcmluZ0NvbnRleHQsIGNvbnRleHRBdHRyaWJ1dGVzKTsKICAg ICAgICAgfSBlbHNlIGlmIChwbGF0Zm9ybURpc3BsYXkuZWdsQ2hlY2tWZXJzaW9uKDEsIDQpKSB7 CisjZWxzZQorICAgICAgICBpZiAocGxhdGZvcm1EaXNwbGF5LmVnbENoZWNrVmVyc2lvbigxLCA0 KSkgeworI2VuZGlmCiAgICAgICAgICAgICBjb25zdCBjaGFyKiBleHRlbnNpb25zID0gZWdsUXVl cnlTdHJpbmcocGxhdGZvcm1EaXNwbGF5LmVnbERpc3BsYXkoKSwgRUdMX0VYVEVOU0lPTlMpOwog ICAgICAgICAgICAgaWYgKEdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoZXh0ZW5zaW9u cywgIkVHTF9LSFJfY3JlYXRlX2NvbnRleHQiKSkgewogICAgICAgICAgICAgICAgIGNvbnRleHRB dHRyaWJ1dGVzWzBdID0gRUdMX0NPTlRFWFRfTUFKT1JfVkVSU0lPTl9LSFI7Cg== 370304 2019-05-21 01:18:08 -0700 2019-05-21 01:18:08 -0700 Error_log error_log_egl.txt text/plain 5254 madhurkiran.h SW4gZmlsZSBpbmNsdWRlZCBmcm9tIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvdW5pZmllZC1zb3Vy Y2VzL1VuaWZpZWRTb3VyY2UzMjAuY3BwOjI6ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIA0KL3NjcmF0Y2gveW9jdG8vbWFzdGVybWVyZ2UvYnVpbGRzL3pj dTEwMi90bXAvd29yay9hYXJjaDY0LXhpbGlueC1saW51eC93ZWJraXRndGsvMi4yMi43LXIwL3dl YmtpdGd0ay0yLjIyLjcvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29u dGV4dEVHTC5jcHA6IEluIHN0YXRpYyBtZW1iZXIgZnVuY3Rpb24gXA0KJ3N0YXRpYyB2b2lkKiBX ZWJDb3JlOjpHTENvbnRleHRFR0w6OmNyZWF0ZUNvbnRleHRGb3JFR0xWZXJzaW9uKFdlYkNvcmU6 OlBsYXRmb3JtRGlzcGxheSYsIEVHTENvbmZpZywgRUdMQ29udGV4dCknOiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIA0KL3NjcmF0Y2gveW9jdG8vbWFzdGVybWVyZ2UvYnVpbGRzL3pjdTEwMi90bXAvd29yay9h YXJjaDY0LXhpbGlueC1saW51eC93ZWJraXRndGsvMi4yMi43LXIwL3dlYmtpdGd0ay0yLjIyLjcv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHA6Mzc3 OjM2OiBlcnJvcjogJ0VHTF9DT05URVhUXA0KX01BSk9SX1ZFUlNJT04nIHdhcyBub3QgZGVjbGFy ZWQgaW4gdGhpcyBzY29wZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAg ICAgIGNvbnRleHRBdHRyaWJ1dGVzWzBdID0gRUdMX0NPTlRFWFRfTUFKT1JfVkVSU0lPTjsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KL3NjcmF0Y2gveW9jdG8vbWFzdGVybWVy Z2UvYnVpbGRzL3pjdTEwMi90bXAvd29yay9hYXJjaDY0LXhpbGlueC1saW51eC93ZWJraXRndGsv Mi4yMi43LXIwL3dlYmtpdGd0ay0yLjIyLjcvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZWdsL0dMQ29udGV4dEVHTC5jcHA6Mzc3OjM2OiBub3RlOiBzdWdnZXN0ZWQgYWx0XA0KZXJu YXRpdmU6ICdFR0xfQ09OVEVYVF9NQUpPUl9WRVJTSU9OX0tIUicgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzBdID0gRUdM X0NPTlRFWFRfTUFKT1JfVkVSU0lPTjsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRUdMX0NPTlRFWFRfTUFKT1Jf VkVSU0lPTl9LSFIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIA0KL3NjcmF0Y2gveW9jdG8vbWFzdGVybWVyZ2UvYnVpbGRz L3pjdTEwMi90bXAvd29yay9hYXJjaDY0LXhpbGlueC1saW51eC93ZWJraXRndGsvMi4yMi43LXIw L3dlYmtpdGd0ay0yLjIyLjcvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dM Q29udGV4dEVHTC5jcHA6Mzc5OjM2OiBlcnJvcjogJ0VHTF9DT05URVhUXA0KX01JTk9SX1ZFUlNJ T04nIHdhcyBub3QgZGVjbGFyZWQgaW4gdGhpcyBzY29wZSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIA0KICAgICAgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzJdID0gRUdMX0NPTlRFWFRf TUlOT1JfVkVSU0lPTjsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KL3NjcmF0 Y2gveW9jdG8vbWFzdGVybWVyZ2UvYnVpbGRzL3pjdTEwMi90bXAvd29yay9hYXJjaDY0LXhpbGlu eC1saW51eC93ZWJraXRndGsvMi4yMi43LXIwL3dlYmtpdGd0ay0yLjIyLjcvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHA6Mzc5OjM2OiBub3RlOiBz dWdnZXN0ZWQgYWx0XA0KZXJuYXRpdmU6ICdFR0xfQ09OVEVYVF9NSU5PUl9WRVJTSU9OX0tIUicg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgIGNvbnRleHRB dHRyaWJ1dGVzWzJdID0gRUdMX0NPTlRFWFRfTUlOT1JfVkVSU0lPTjsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0K ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg RUdMX0NPTlRFWFRfTUlOT1JfVkVSU0lPTl9LSFIgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KL3NjcmF0Y2gveW9jdG8v bWFzdGVybWVyZ2UvYnVpbGRzL3pjdTEwMi90bXAvd29yay9hYXJjaDY0LXhpbGlueC1saW51eC93 ZWJraXRndGsvMi4yMi43LXIwL3dlYmtpdGd0ay0yLjIyLjcvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHA6MzgxOjM2OiBlcnJvcjogJ0VHTF9DT05U RVhUXA0KX09QRU5HTF9QUk9GSUxFX01BU0snIHdhcyBub3QgZGVjbGFyZWQgaW4gdGhpcyBzY29w ZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVz WzRdID0gRUdMX0NPTlRFWFRfT1BFTkdMX1BST0ZJTEVfTUFTSzsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIA0KL3NjcmF0Y2gveW9jdG8vbWFzdGVybWVyZ2UvYnVpbGRzL3pjdTEwMi90bXAv d29yay9hYXJjaDY0LXhpbGlueC1saW51eC93ZWJraXRndGsvMi4yMi43LXIwL3dlYmtpdGd0ay0y LjIyLjcvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5j cHA6MzgxOjM2OiBub3RlOiBzdWdnZXN0ZWQgYWx0XA0KZXJuYXRpdmU6ICdFR0xfQ09OVEVYVF9P UEVOR0xfUFJPRklMRV9NQVNLX0tIUicgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAg ICAgICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzRdID0gRUdMX0NPTlRFWFRfT1BFTkdMX1BST0ZJ TEVfTUFTSzsNCg== 370343 2019-05-21 14:39:59 -0700 2019-05-29 13:40:16 -0700 Use a generic macro for EGL context version fix_v3.patch text/plain 3273 madhurkiran.h SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTU5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA1LTIxICBNYWRodXJr aXJhbiBIYXJpa3Jpc2huYW4gIDxtYWRodXJraXJhbi5oYXJpa3Jpc2huYW5AeGlsaW54LmNvbT4K KworICAgICAgICBVc2UgYSBnZW5lcmljIG1hY3JvIGZvciBFR0wgY29udGV4dCB2ZXJzaW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5NzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBu byBuZWVkIHRvIGhhdmUgYSBzZXBhcmF0ZSBtYWNyb3MgZm9yIGVnbCBjb250ZXh0IHZlcnNpb24s CisgICAgICAgIG9wZW5nbCBwcm9maWxlIG1hc2sgZXRjLiBmb3IgRUdMIDEuNSBhbmQgRUdMIDEu NCwgYXMgdGhleSBhcmUgZXNzZW50aWFsbHkKKyAgICAgICAgc2FtZS4gVGhpcyB3aWxsIGhlbHAg Zml4IHRoZSBjb21waWxhdGlvbiBlcnJvciBmb3IgdGFyZ2V0cyB3aGljaCBvbmx5CisgICAgICAg IHN1cHBvcnRzIEVHTCAxLjQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xD b250ZXh0RUdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdMQ29udGV4dEVHTDo6Y3JlYXRlQ29u dGV4dEZvckVHTFZlcnNpb24pOgorCiAyMDE5LTA1LTIxICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0 c0BhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBDb21wYXRpYmlsaXR5IG1vdXNlIGV2ZW50 cyBhcmVuJ3QgcHJldmVudGVkIGJ5IGNhbGxpbmcgcHJldmVudERlZmF1bHQoKSBvbiBwb2ludGVy ZG93bgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4 dEVHTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWdsL0dMQ29udGV4dEVHTC5jcHAJKHJldmlzaW9uIDI0NTU5NCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00MDEsMjEgKzQwMSwxMCBAQCBFR0xDb250ZXh0IEdMQ29udGV4dEVHTDo6Y3JlYXRlQ29udGV4 dEZvCiAgICAgICAgIC8vIHdlJ2xsIHVzZSB3aGF0ZXZlciBpcyBhdmFpbGFibGUuIEluIG9yZGVy IHRvIHJlcXVlc3QgYSBjb25jcmV0ZSB2ZXJzaW9uIG9mIE9wZW5HTCB3ZSBuZWVkIEVHTCB2ZXJz aW9uCiAgICAgICAgIC8vIDEuNSBvciBFR0wgdmVyc2lvbiAxLjQgd2l0aCB0aGUgZXh0ZW5zaW9u IEVHTF9LSFJfY3JlYXRlX2NvbnRleHQuCiAgICAgICAgIEVHTENvbnRleHQgY29udGV4dCA9IEVH TF9OT19DT05URVhUOworICAgICAgICBjb25zdCBjaGFyKiBleHRlbnNpb25zID0gZWdsUXVlcnlT dHJpbmcocGxhdGZvcm1EaXNwbGF5LmVnbERpc3BsYXkoKSwgRUdMX0VYVEVOU0lPTlMpOwogCi0g ICAgICAgIGlmIChwbGF0Zm9ybURpc3BsYXkuZWdsQ2hlY2tWZXJzaW9uKDEsIDUpKSB7Ci0gICAg ICAgICAgICBjb250ZXh0QXR0cmlidXRlc1swXSA9IEVHTF9DT05URVhUX01BSk9SX1ZFUlNJT047 Ci0gICAgICAgICAgICBjb250ZXh0QXR0cmlidXRlc1sxXSA9IDM7Ci0gICAgICAgICAgICBjb250 ZXh0QXR0cmlidXRlc1syXSA9IEVHTF9DT05URVhUX01JTk9SX1ZFUlNJT047Ci0gICAgICAgICAg ICBjb250ZXh0QXR0cmlidXRlc1szXSA9IDI7Ci0gICAgICAgICAgICBjb250ZXh0QXR0cmlidXRl c1s0XSA9IEVHTF9DT05URVhUX09QRU5HTF9QUk9GSUxFX01BU0s7Ci0gICAgICAgICAgICBjb250 ZXh0QXR0cmlidXRlc1s1XSA9IEVHTF9DT05URVhUX09QRU5HTF9DT1JFX1BST0ZJTEVfQklUOwot ICAgICAgICAgICAgY29udGV4dEF0dHJpYnV0ZXNbNl0gPSBFR0xfTk9ORTsKLQotICAgICAgICAg ICAgLy8gVHJ5IHRvIGNyZWF0ZSBhIGNvbnRleHQgd2l0aCB0aGlzIGNvbmZpZ3VyYXRpb24uCi0g ICAgICAgICAgICBjb250ZXh0ID0gZWdsQ3JlYXRlQ29udGV4dChwbGF0Zm9ybURpc3BsYXkuZWds RGlzcGxheSgpLCBjb25maWcsIHNoYXJpbmdDb250ZXh0LCBjb250ZXh0QXR0cmlidXRlcyk7Ci0g ICAgICAgIH0gZWxzZSBpZiAocGxhdGZvcm1EaXNwbGF5LmVnbENoZWNrVmVyc2lvbigxLCA0KSkg ewotICAgICAgICAgICAgY29uc3QgY2hhciogZXh0ZW5zaW9ucyA9IGVnbFF1ZXJ5U3RyaW5nKHBs YXRmb3JtRGlzcGxheS5lZ2xEaXNwbGF5KCksIEVHTF9FWFRFTlNJT05TKTsKLSAgICAgICAgICAg IGlmIChHTENvbnRleHQ6OmlzRXh0ZW5zaW9uU3VwcG9ydGVkKGV4dGVuc2lvbnMsICJFR0xfS0hS X2NyZWF0ZV9jb250ZXh0IikpIHsKKyAgICAgICAgaWYgKHBsYXRmb3JtRGlzcGxheS5lZ2xDaGVj a1ZlcnNpb24oMSwgNSkKKyAgICAgICAgICAgIHx8IChwbGF0Zm9ybURpc3BsYXkuZWdsQ2hlY2tW ZXJzaW9uKDEsIDQpICYmIEdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoZXh0ZW5zaW9u cywgIkVHTF9LSFJfY3JlYXRlX2NvbnRleHQiKSkpIHsKICAgICAgICAgICAgICAgICBjb250ZXh0 QXR0cmlidXRlc1swXSA9IEVHTF9DT05URVhUX01BSk9SX1ZFUlNJT05fS0hSOwogICAgICAgICAg ICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzFdID0gMzsKICAgICAgICAgICAgICAgICBjb250ZXh0 QXR0cmlidXRlc1syXSA9IEVHTF9DT05URVhUX01JTk9SX1ZFUlNJT05fS0hSOwpAQCAtNDI3LDcg KzQxNiw2IEBAIEVHTENvbnRleHQgR0xDb250ZXh0RUdMOjpjcmVhdGVDb250ZXh0Rm8KICAgICAg ICAgICAgICAgICAvLyBUcnkgdG8gY3JlYXRlIGEgY29udGV4dCB3aXRoIHRoaXMgY29uZmlndXJh dGlvbi4KICAgICAgICAgICAgICAgICBjb250ZXh0ID0gZWdsQ3JlYXRlQ29udGV4dChwbGF0Zm9y bURpc3BsYXkuZWdsRGlzcGxheSgpLCBjb25maWcsIHNoYXJpbmdDb250ZXh0LCBjb250ZXh0QXR0 cmlidXRlcyk7CiAgICAgICAgICAgICB9Ci0gICAgICAgIH0KIAogICAgICAgICAvLyBJZiB0aGUg Y29udGV4dCBjcmVhdGlvbiB3b3JrZWQsIGp1c3QgcmV0dXJuIGl0LgogICAgICAgICBpZiAoY29u dGV4dCAhPSBFR0xfTk9fQ09OVEVYVCkK 370881 2019-05-29 13:40:16 -0700 2019-05-29 14:05:09 -0700 Use a generic macro for EGL context version v2 patch_v3.patch text/plain 3235 madhurkiran.h SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTU5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA1LTIxICBNYWRodXJr aXJhbiBIYXJpa3Jpc2huYW4gIDxtYWRodXJraXJhbi5oYXJpa3Jpc2huYW5AeGlsaW54LmNvbT4K KworICAgICAgICBVc2UgYSBnZW5lcmljIG1hY3JvIGZvciBFR0wgY29udGV4dCB2ZXJzaW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTc5NzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBu byBuZWVkIHRvIGhhdmUgYSBzZXBhcmF0ZSBtYWNyb3MgZm9yIGVnbCBjb250ZXh0IHZlcnNpb24s CisgICAgICAgIG9wZW5nbCBwcm9maWxlIG1hc2sgZXRjLiBmb3IgRUdMIDEuNSBhbmQgRUdMIDEu NCwgYXMgdGhleSBhcmUgZXNzZW50aWFsbHkKKyAgICAgICAgc2FtZS4gVGhpcyB3aWxsIGhlbHAg Zml4IHRoZSBjb21waWxhdGlvbiBlcnJvciBmb3IgdGFyZ2V0cyB3aGljaCBvbmx5CisgICAgICAg IHN1cHBvcnRzIEVHTCAxLjQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xD b250ZXh0RUdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdMQ29udGV4dEVHTDo6Y3JlYXRlQ29u dGV4dEZvckVHTFZlcnNpb24pOgorCiAyMDE5LTA1LTIxICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0 c0BhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBDb21wYXRpYmlsaXR5IG1vdXNlIGV2ZW50 cyBhcmVuJ3QgcHJldmVudGVkIGJ5IGNhbGxpbmcgcHJldmVudERlZmF1bHQoKSBvbiBwb2ludGVy ZG93bgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4 dEVHTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWdsL0dMQ29udGV4dEVHTC5jcHAJKHJldmlzaW9uIDI0NTU5NCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00MDEsMjEgKzQwMSwxMCBAQCBFR0xDb250ZXh0IEdMQ29udGV4dEVHTDo6Y3JlYXRlQ29udGV4 dEZvCiAgICAgICAgIC8vIHdlJ2xsIHVzZSB3aGF0ZXZlciBpcyBhdmFpbGFibGUuIEluIG9yZGVy IHRvIHJlcXVlc3QgYSBjb25jcmV0ZSB2ZXJzaW9uIG9mIE9wZW5HTCB3ZSBuZWVkIEVHTCB2ZXJz aW9uCiAgICAgICAgIC8vIDEuNSBvciBFR0wgdmVyc2lvbiAxLjQgd2l0aCB0aGUgZXh0ZW5zaW9u IEVHTF9LSFJfY3JlYXRlX2NvbnRleHQuCiAgICAgICAgIEVHTENvbnRleHQgY29udGV4dCA9IEVH TF9OT19DT05URVhUOworICAgICAgICBjb25zdCBjaGFyKiBleHRlbnNpb25zID0gZWdsUXVlcnlT dHJpbmcocGxhdGZvcm1EaXNwbGF5LmVnbERpc3BsYXkoKSwgRUdMX0VYVEVOU0lPTlMpOwogCi0g ICAgICAgIGlmIChwbGF0Zm9ybURpc3BsYXkuZWdsQ2hlY2tWZXJzaW9uKDEsIDUpKSB7Ci0gICAg ICAgICAgICBjb250ZXh0QXR0cmlidXRlc1swXSA9IEVHTF9DT05URVhUX01BSk9SX1ZFUlNJT047 Ci0gICAgICAgICAgICBjb250ZXh0QXR0cmlidXRlc1sxXSA9IDM7Ci0gICAgICAgICAgICBjb250 ZXh0QXR0cmlidXRlc1syXSA9IEVHTF9DT05URVhUX01JTk9SX1ZFUlNJT047Ci0gICAgICAgICAg ICBjb250ZXh0QXR0cmlidXRlc1szXSA9IDI7Ci0gICAgICAgICAgICBjb250ZXh0QXR0cmlidXRl c1s0XSA9IEVHTF9DT05URVhUX09QRU5HTF9QUk9GSUxFX01BU0s7Ci0gICAgICAgICAgICBjb250 ZXh0QXR0cmlidXRlc1s1XSA9IEVHTF9DT05URVhUX09QRU5HTF9DT1JFX1BST0ZJTEVfQklUOwot ICAgICAgICAgICAgY29udGV4dEF0dHJpYnV0ZXNbNl0gPSBFR0xfTk9ORTsKLQotICAgICAgICAg ICAgLy8gVHJ5IHRvIGNyZWF0ZSBhIGNvbnRleHQgd2l0aCB0aGlzIGNvbmZpZ3VyYXRpb24uCi0g ICAgICAgICAgICBjb250ZXh0ID0gZWdsQ3JlYXRlQ29udGV4dChwbGF0Zm9ybURpc3BsYXkuZWds RGlzcGxheSgpLCBjb25maWcsIHNoYXJpbmdDb250ZXh0LCBjb250ZXh0QXR0cmlidXRlcyk7Ci0g ICAgICAgIH0gZWxzZSBpZiAocGxhdGZvcm1EaXNwbGF5LmVnbENoZWNrVmVyc2lvbigxLCA0KSkg ewotICAgICAgICAgICAgY29uc3QgY2hhciogZXh0ZW5zaW9ucyA9IGVnbFF1ZXJ5U3RyaW5nKHBs YXRmb3JtRGlzcGxheS5lZ2xEaXNwbGF5KCksIEVHTF9FWFRFTlNJT05TKTsKLSAgICAgICAgICAg IGlmIChHTENvbnRleHQ6OmlzRXh0ZW5zaW9uU3VwcG9ydGVkKGV4dGVuc2lvbnMsICJFR0xfS0hS X2NyZWF0ZV9jb250ZXh0IikpIHsKKyAgICAgICAgaWYgKHBsYXRmb3JtRGlzcGxheS5lZ2xDaGVj a1ZlcnNpb24oMSwgNSkKKyAgICAgICAgICAgIHx8IChwbGF0Zm9ybURpc3BsYXkuZWdsQ2hlY2tW ZXJzaW9uKDEsIDQpICYmIEdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoZXh0ZW5zaW9u cywgIkVHTF9LSFJfY3JlYXRlX2NvbnRleHQiKSkpIHsKICAgICAgICAgICAgICAgICBjb250ZXh0 QXR0cmlidXRlc1swXSA9IEVHTF9DT05URVhUX01BSk9SX1ZFUlNJT05fS0hSOwogICAgICAgICAg ICAgICAgIGNvbnRleHRBdHRyaWJ1dGVzWzFdID0gMzsKICAgICAgICAgICAgICAgICBjb250ZXh0 QXR0cmlidXRlc1syXSA9IEVHTF9DT05URVhUX01JTk9SX1ZFUlNJT05fS0hSOwpAQCAtNDI2LDcg KzQxNSw2IEBAIEVHTENvbnRleHQgR0xDb250ZXh0RUdMOjpjcmVhdGVDb250ZXh0Rm8KIAogICAg ICAgICAgICAgICAgIC8vIFRyeSB0byBjcmVhdGUgYSBjb250ZXh0IHdpdGggdGhpcyBjb25maWd1 cmF0aW9uLgogICAgICAgICAgICAgICAgIGNvbnRleHQgPSBlZ2xDcmVhdGVDb250ZXh0KHBsYXRm b3JtRGlzcGxheS5lZ2xEaXNwbGF5KCksIGNvbmZpZywgc2hhcmluZ0NvbnRleHQsIGNvbnRleHRB dHRyaWJ1dGVzKTsKLSAgICAgICAgICAgIH0KICAgICAgICAgfQogCiAgICAgICAgIC8vIElmIHRo ZSBjb250ZXh0IGNyZWF0aW9uIHdvcmtlZCwganVzdCByZXR1cm4gaXQuCg==